)]}'
{"bin/glance":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7ae93086e6efe176e4a20ef43bcd4bd7014a55ed","unresolved":false,"context_lines":[{"line_number":777,"context_line":"                           \"(http/https) of the glance server, for example \""},{"line_number":778,"context_line":"                           \"-U https://localhost:\" + str(DEFAULT_PORT) +"},{"line_number":779,"context_line":"                           \"/v1 Default: None\")"},{"line_number":780,"context_line":"    parser.add_option(\u0027-k\u0027, \u0027--insecure\u0027, dest\u003d\"insecure\", metavar\u003d\"INSECURE\","},{"line_number":781,"context_line":"                      default\u003dFalse, action\u003d\"store_true\","},{"line_number":782,"context_line":"                      help\u003d\"Explicitly allow glance to perform \\\"insecure\\\" \""},{"line_number":783,"context_line":"                      \"SSL (https) requests. The server\u0027s certificate will \""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F7qI%3D","line":780,"updated":"2012-02-12 15:03:30.000000000","message":"Small nit: on boolean (action\u003dstore_true) options, there\u0027s no need to specify a metavar, since actually if you specify one would be an error:\n\n jpipes@uberbox:~/repos/glance$ ./bin/glance --verbose\u003dtrue\n \u003csnip\u003e\n glance: error: --verbose option does not take a value","commit_id":"6376c18ef7ef53374ccb6dbe5e2788180a21ed30"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"b976fce465cc4fdcfb762f7164129d84604f4bf5","unresolved":false,"context_lines":[{"line_number":777,"context_line":"                           \"(http/https) of the glance server, for example \""},{"line_number":778,"context_line":"                           \"-U https://localhost:\" + str(DEFAULT_PORT) +"},{"line_number":779,"context_line":"                           \"/v1 Default: None\")"},{"line_number":780,"context_line":"    parser.add_option(\u0027-k\u0027, \u0027--insecure\u0027, dest\u003d\"insecure\", metavar\u003d\"INSECURE\","},{"line_number":781,"context_line":"                      default\u003dFalse, action\u003d\"store_true\","},{"line_number":782,"context_line":"                      help\u003d\"Explicitly allow glance to perform \\\"insecure\\\" \""},{"line_number":783,"context_line":"                      \"SSL (https) requests. The server\u0027s certificate will \""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAEn%2F%2F7j4%3D","line":780,"in_reply_to":"AAAAEn%2F%2F7qI%3D","updated":"2012-02-13 13:34:31.000000000","message":"Ok, makes sense. (I\u0027ll take out the metavar for --force aswell.)","commit_id":"6376c18ef7ef53374ccb6dbe5e2788180a21ed30"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"86aa46f2edc1e127618f1db2f635efa19988300f","unresolved":false,"context_lines":[{"line_number":781,"context_line":"                           \"(http/https) of the glance server, for example \""},{"line_number":782,"context_line":"                           \"-U https://localhost:\" + str(DEFAULT_PORT) +"},{"line_number":783,"context_line":"                           \"/v1 Default: None\")"},{"line_number":784,"context_line":"    parser.add_option(\u0027-k\u0027, \u0027--insecure\u0027, dest\u003d\"insecure\","},{"line_number":785,"context_line":"                      default\u003dFalse, action\u003d\"store_true\","},{"line_number":786,"context_line":"                      help\u003d\"Explicitly allow glance to perform \\\"insecure\\\" \""},{"line_number":787,"context_line":"                      \"SSL (https) requests. The server\u0027s certificate will \""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAEn%2F%2F7CQ%3D","line":784,"updated":"2012-02-14 12:20:17.000000000","message":"Using the same short-form option letter (differing only in case) as an existing option (-K/--password) might cause confusion. Not a big deal, but would it be possible to choose a different letter here?\n\nAlso I\u0027m wondering about the \"insecure\" description, as its not fully insecure as would be the case if the HTTP request were sent in the clear. In a sense, its more like \"partial security\" (if that makes any sense as a concept), as at least we get confidentiality from HTTPS, if not verification of the server\u0027s cert. \n\nThe wget utility uses the  --no-check-certificate option for the same sort of behaviour, which seems to to capture the intent a bit better (even its clumsy and long-winded to type out).","commit_id":"0f0fe2ba1b772e6964241c0631683b306fff23c0"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"2158325d13e3b392873691b6ad7a65b3ff284b15","unresolved":false,"context_lines":[{"line_number":781,"context_line":"                           \"(http/https) of the glance server, for example \""},{"line_number":782,"context_line":"                           \"-U https://localhost:\" + str(DEFAULT_PORT) +"},{"line_number":783,"context_line":"                           \"/v1 Default: None\")"},{"line_number":784,"context_line":"    parser.add_option(\u0027-k\u0027, \u0027--insecure\u0027, dest\u003d\"insecure\","},{"line_number":785,"context_line":"                      default\u003dFalse, action\u003d\"store_true\","},{"line_number":786,"context_line":"                      help\u003d\"Explicitly allow glance to perform \\\"insecure\\\" \""},{"line_number":787,"context_line":"                      \"SSL (https) requests. The server\u0027s certificate will \""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAEn%2F%2F7A0%3D","line":784,"in_reply_to":"AAAAEn%2F%2F7BQ%3D","updated":"2012-02-14 14:53:04.000000000","message":"Given that curl is comparably well-known, I guess the --insecure naming is just as likely to be familiar to users as wget\u0027s --no-certificate-check style.\n\nAnd you\u0027re right, it does have a clearer connotation of there being some risk involved.\n\nSo feel free to stick with \"insecure\".","commit_id":"0f0fe2ba1b772e6964241c0631683b306fff23c0"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"02a9067b7c626a5a3bba665f1bafb0382efa9ee8","unresolved":false,"context_lines":[{"line_number":781,"context_line":"                           \"(http/https) of the glance server, for example \""},{"line_number":782,"context_line":"                           \"-U https://localhost:\" + str(DEFAULT_PORT) +"},{"line_number":783,"context_line":"                           \"/v1 Default: None\")"},{"line_number":784,"context_line":"    parser.add_option(\u0027-k\u0027, \u0027--insecure\u0027, dest\u003d\"insecure\","},{"line_number":785,"context_line":"                      default\u003dFalse, action\u003d\"store_true\","},{"line_number":786,"context_line":"                      help\u003d\"Explicitly allow glance to perform \\\"insecure\\\" \""},{"line_number":787,"context_line":"                      \"SSL (https) requests. The server\u0027s certificate will \""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAEn%2F%2F7BQ%3D","line":784,"in_reply_to":"AAAAEn%2F%2F7CQ%3D","updated":"2012-02-14 14:16:53.000000000","message":"Hi Eoghan, thanks for your feedback. I chose to copy curl\u0027s \"-k/--insecure\" option flags (rather than wget). I felt that \u0027--insecure\u0027 made it clear that this was a potential security risk to someone who may not know what a certificate is.\n\nRe partial security: yeah I see what you\u0027re saying ... but isn\u0027t there a risk that you could be sending your credentials to a \u0027bad\u0027 host (in which case SSL encryption isn\u0027t that big a win)?\n\nI wonder if anyone else has a preference for the flag name? Its easy to change if there\u0027s a critical mass.","commit_id":"0f0fe2ba1b772e6964241c0631683b306fff23c0"}],"glance/common/client.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"86aa46f2edc1e127618f1db2f635efa19988300f","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            self.sock \u003d sock"},{"line_number":173,"context_line":"            self._tunnel()"},{"line_number":174,"context_line":"        # Check CA file unless \u0027insecure\u0027 is specificed"},{"line_number":175,"context_line":"        if self.insecure is True:"},{"line_number":176,"context_line":"            self.sock \u003d ssl.wrap_socket(sock, self.key_file, self.cert_file,"},{"line_number":177,"context_line":"                                        cert_reqs\u003dssl.CERT_NONE)"},{"line_number":178,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F7CM%3D","line":175,"updated":"2012-02-14 12:20:17.000000000","message":"No need for the explicitl \u0027is True\u0027, reads more clearly as just a simple:\n\n  if self.insecure:\n     ...","commit_id":"0f0fe2ba1b772e6964241c0631683b306fff23c0"},{"author":{"_account_id":455,"name":"Stuart McLaren","email":"stuart.mclaren@hpe.com","username":"stuart-mclaren"},"change_message_id":"02a9067b7c626a5a3bba665f1bafb0382efa9ee8","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            self.sock \u003d sock"},{"line_number":173,"context_line":"            self._tunnel()"},{"line_number":174,"context_line":"        # Check CA file unless \u0027insecure\u0027 is specificed"},{"line_number":175,"context_line":"        if self.insecure is True:"},{"line_number":176,"context_line":"            self.sock \u003d ssl.wrap_socket(sock, self.key_file, self.cert_file,"},{"line_number":177,"context_line":"                                        cert_reqs\u003dssl.CERT_NONE)"},{"line_number":178,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAEn%2F%2F7BM%3D","line":175,"in_reply_to":"AAAAEn%2F%2F7CM%3D","updated":"2012-02-14 14:16:53.000000000","message":"Yes, makes sense. Thanks.","commit_id":"0f0fe2ba1b772e6964241c0631683b306fff23c0"}],"glance/tests/functional/test_ssl.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"7ae93086e6efe176e4a20ef43bcd4bd7014a55ed","unresolved":false,"context_lines":[{"line_number":45,"context_line":"from glance.store.location import get_location_from_uri"},{"line_number":46,"context_line":"from glance.tests import functional"},{"line_number":47,"context_line":"from glance.tests.utils import execute, skip_if_disabled"},{"line_number":48,"context_line":"from glance import client as glance_client"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"FIVE_KB \u003d 5 * 1024"},{"line_number":51,"context_line":"FIVE_GB \u003d 5 * 1024 * 1024 * 1024"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F7qE%3D","line":48,"updated":"2012-02-12 15:03:30.000000000","message":"femto-nit: this import line should be at the top of the glance imports...","commit_id":"6376c18ef7ef53374ccb6dbe5e2788180a21ed30"}]}