)]}'
{"glance/tests/functional/test_reload.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"6d61df23c10e7110795f4d55f4efd94be2174f63","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        pid \u003d None"},{"line_number":77,"context_line":"        pid \u003d self._get_parent(server)"},{"line_number":78,"context_line":"        process \u003d psutil.Process(pid)"},{"line_number":79,"context_line":"        if hasattr(process, \u0027get_children\u0027):"},{"line_number":80,"context_line":"            children \u003d process.get_children()"},{"line_number":81,"context_line":"        else:"},{"line_number":82,"context_line":"            children \u003d process.children()"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_462acf2d","line":79,"updated":"2017-01-15 07:39:59.000000000","message":"prefer try/except or getattr with a sentinal default to hasattr because hasattr does not behave the same in py2 vs py3 and can mask other errors in py2.\n\nexample:\n  try:\n    # psutil 1\n    children \u003d process.get_children()\n  except AttributeError:\n    # psutil 2\n    children \u003d process.children()","commit_id":"c7c6def90fdeab238d44dcbbfa950db676bebe84"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"671ab42ad1fb8990a1a8052727d1a48eef271f73","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        pid \u003d None"},{"line_number":77,"context_line":"        pid \u003d self._get_parent(server)"},{"line_number":78,"context_line":"        process \u003d psutil.Process(pid)"},{"line_number":79,"context_line":"        if hasattr(process, \u0027get_children\u0027):"},{"line_number":80,"context_line":"            children \u003d process.get_children()"},{"line_number":81,"context_line":"        else:"},{"line_number":82,"context_line":"            children \u003d process.children()"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_f7a1a7aa","line":79,"in_reply_to":"7a3c09a3_462acf2d","updated":"2017-01-15 14:09:06.000000000","message":"Fine with that, I just swapped the order because I would like to have psutils \u003e\u003d 2 required to cleanup the mess soonish.","commit_id":"c7c6def90fdeab238d44dcbbfa950db676bebe84"}],"glance/tests/functional/v1/test_multiprocessing.py":[{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"6d61df23c10e7110795f4d55f4efd94be2174f63","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        api_pid \u003d self.api_server.process_pid"},{"line_number":49,"context_line":"        process \u003d psutil.Process(api_pid)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        if hasattr(process, \u0027get_children\u0027):"},{"line_number":52,"context_line":"            children \u003d process.get_children()"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            children \u003d process.children()"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a3c09a3_861cb714","line":51,"updated":"2017-01-15 07:39:59.000000000","message":"same as other inline comment","commit_id":"c7c6def90fdeab238d44dcbbfa950db676bebe84"}]}
