)]}'
{"glance/tests/unit/v1/test_api.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"bdc957341889a143b750d19f1cfeffb81f254205","unresolved":false,"context_lines":[{"line_number":53,"context_line":"UUID1 \u003d _gen_uuid()"},{"line_number":54,"context_line":"UUID2 \u003d _gen_uuid()"},{"line_number":55,"context_line":"UUID3 \u003d _gen_uuid()"},{"line_number":56,"context_line":"QUOTA \u003d 500"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class TestGlanceAPI(base.IsolatedUnitTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_32db4b1d","line":56,"updated":"2016-12-19 19:25:11.000000000","message":"Is this really required for tests to pass on Python 3.5? This seems superfluous and like a random refactoring being snuck in with legitimate test fixes.","commit_id":"ca803fe30376d883b55804da37ccb3ec54e419cc"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"9583e8e07dacc4b5b248ecd720a4ca2aa6981556","unresolved":false,"context_lines":[{"line_number":53,"context_line":"UUID1 \u003d _gen_uuid()"},{"line_number":54,"context_line":"UUID2 \u003d _gen_uuid()"},{"line_number":55,"context_line":"UUID3 \u003d _gen_uuid()"},{"line_number":56,"context_line":"QUOTA \u003d 500"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class TestGlanceAPI(base.IsolatedUnitTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_17ba8623","line":56,"updated":"2016-12-20 19:02:12.000000000","message":"No. Refactoring a module to use a global is not appropriate for this patch. Fixing the failing bug itself would be appropriate.\n\nKeeping patches narrowly constrained to do exactly what\u0027s on the packaging (i.e., commit) is absolutely necessary. Refactoring this to use a module global is not enabling Python 3.5. A separate, follow-on, patch to do this would be perfectly acceptable. The change isn\u0027t undesirable, it just doesn\u0027t belong in this patch.","commit_id":"ca803fe30376d883b55804da37ccb3ec54e419cc"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"2c60fc289c6dd12c0d94dc27cb00b70faaa2bf03","unresolved":false,"context_lines":[{"line_number":53,"context_line":"UUID1 \u003d _gen_uuid()"},{"line_number":54,"context_line":"UUID2 \u003d _gen_uuid()"},{"line_number":55,"context_line":"UUID3 \u003d _gen_uuid()"},{"line_number":56,"context_line":"QUOTA \u003d 500"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"class TestGlanceAPI(base.IsolatedUnitTest):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_97b93bce","line":56,"in_reply_to":"1a6eadb0_32db4b1d","updated":"2016-12-20 17:17:40.000000000","message":"The original code on line 836 was using http_client.INTERNAL_SERVER_ERROR to set the quota value to 500. This was causing the test to fail in py35 because it is not treated as an integer. So I changed it to a hard-coded value of 500. I then saw that 500 was also being used in two other tests to set the quota, so I got rid of that magic number by defining a global QUOTA constant. I don\u0027t think that\u0027s at all superfluous and is perfectly appropriate for this patch.","commit_id":"ca803fe30376d883b55804da37ccb3ec54e419cc"}],"tox.ini":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"9583e8e07dacc4b5b248ecd720a4ca2aa6981556","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 1.6"},{"line_number":3,"context_line":"envlist \u003d py35,py34,py27,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1a6eadb0_f7aa6ad1","line":3,"updated":"2016-12-20 19:02:12.000000000","message":"I agree, Eric.","commit_id":"ca803fe30376d883b55804da37ccb3ec54e419cc"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"40a8ac5ff25a19390021902a210f0328ba0262de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 1.6"},{"line_number":3,"context_line":"envlist \u003d py35,py34,py27,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1a6eadb0_14fd243a","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":19},"updated":"2016-12-20 18:51:15.000000000","message":"I don\u0027t think it makes much sense to have both py35 and py34.  Most local environments (remember this defines the default env list for running tox without parameters), will have either py35 OR py34.  Unlikely to have both.","commit_id":"ca803fe30376d883b55804da37ccb3ec54e419cc"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"64c82dfaf5c234e9526b29e94b300d97455172f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 1.6"},{"line_number":3,"context_line":"envlist \u003d py35,py34,py27,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1a6eadb0_268f52cd","line":3,"in_reply_to":"1a6eadb0_669eaab9","updated":"2016-12-20 21:56:50.000000000","message":"I\u0027m happy to remove py34 completely. I\u0027ll wait until Ia44a37177d57b972c4c9d0f179291b0c8316dd95 merges with a more streamlined tox.ini and integrate my change into that.","commit_id":"ca803fe30376d883b55804da37ccb3ec54e419cc"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d5528fec249d1fd2255ea19e37384ef84dc9a708","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 1.6"},{"line_number":3,"context_line":"envlist \u003d py35,py34,py27,pep8"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":2,"id":"1a6eadb0_669eaab9","line":3,"in_reply_to":"1a6eadb0_f7aa6ad1","updated":"2016-12-20 21:28:55.000000000","message":"Just as a point of information:\nThis aligns with what Erno suggested in his comment on I98ac5543d995dca021fc3aff3993dc07fb2c4b7a but I know in the past we supported multiple minors for Python 2 in the past, specifically 2.6 and 2.7.\n\nThis seems like a good topic for the -dev mailing list.","commit_id":"ca803fe30376d883b55804da37ccb3ec54e419cc"}]}