)]}'
{"id":"openstack%2Fglance~419074","triplet_id":"openstack%2Fglance~master~I4de03e2a1ca493cd49a474a67cbbdec24d61b98f","project":"openstack/glance","branch":"master","topic":"bug/1655727","hashtags":[],"change_id":"I4de03e2a1ca493cd49a474a67cbbdec24d61b98f","subject":"Invoke monkey_patching early enough for eventlet 0.20.1","status":"MERGED","created":"2017-01-11 18:04:49.000000000","updated":"2017-03-17 15:49:56.000000000","submitted":"2017-03-17 15:49:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6bcb58159d42148f631f7a9710c7a0c8fe28b93c","_number":419074,"virtual_id_number":419074,"owner":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":0,"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":16034,"name":"soumiyajit","email":"somya.rock@gmail.com","username":"soumiyajit"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":2,"date":"2017-03-17 15:49:56.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"recommended":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"all":[{"value":1,"date":"2017-03-16 18:11:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":2,"date":"2017-03-17 14:30:57.000000000","_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":1,"date":"2017-03-16 19:56:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},{"value":1,"date":"2017-03-17 01:47:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":1,"date":"2017-03-16 18:01:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":1,"date":"2017-03-16 17:53:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":1,"date":"2017-03-17 07:15:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16034,"name":"soumiyajit","email":"somya.rock@gmail.com","username":"soumiyajit"},{"value":2,"date":"2017-03-16 21:02:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"all":[{"value":0,"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":1,"date":"2017-03-17 14:30:57.000000000","_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":16034,"name":"soumiyajit","email":"somya.rock@gmail.com","username":"soumiyajit"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":0,"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},{"value":0,"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"value":0,"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},{"value":0,"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"value":0,"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},{"value":0,"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"value":0,"_account_id":16034,"name":"soumiyajit","email":"somya.rock@gmail.com","username":"soumiyajit"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"_account_id":16034,"name":"soumiyajit","email":"somya.rock@gmail.com","username":"soumiyajit"},{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-03-13 17:05:14.000000000","updated_by":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"reviewer":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"state":"REVIEWER"},{"updated":"2017-03-16 17:53:01.000000000","updated_by":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"reviewer":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"state":"REVIEWER"},{"updated":"2017-03-16 18:01:29.000000000","updated_by":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"reviewer":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"state":"REVIEWER"},{"updated":"2017-03-16 18:11:01.000000000","updated_by":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"reviewer":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"state":"REVIEWER"},{"updated":"2017-03-16 19:56:28.000000000","updated_by":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"reviewer":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"state":"REVIEWER"},{"updated":"2017-03-16 21:02:46.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2017-03-17 01:47:21.000000000","updated_by":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"reviewer":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"state":"REVIEWER"},{"updated":"2017-03-17 07:15:25.000000000","updated_by":{"_account_id":16034,"name":"soumiyajit","email":"somya.rock@gmail.com","username":"soumiyajit"},"reviewer":{"_account_id":16034,"name":"soumiyajit","email":"somya.rock@gmail.com","username":"soumiyajit"},"state":"REVIEWER"},{"updated":"2017-03-17 14:30:57.000000000","updated_by":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"reviewer":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"state":"REVIEWER"},{"updated":"2017-03-17 15:49:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6eea3d1c60fab8c6eaf0a11aa109b723c1e5d083","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2017-01-11 18:04:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"11f31a6912a0379f29e8b74e9182b39b6e7a661a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-11 20:00:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-glance-python35-db-nv http://logs.openstack.org/74/419074/1/check/gate-glance-python35-db-nv/11a3fac/ : FAILURE in 4m 53s (non-voting)\n- gate-glance-docs-ubuntu-xenial http://docs-draft.openstack.org/74/419074/1/check/gate-glance-docs-ubuntu-xenial/badca39//doc/build/html/ : SUCCESS in 8m 46s\n- gate-glance-pep8-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-glance-pep8-ubuntu-xenial/8303433/ : SUCCESS in 5m 22s\n- gate-glance-python27-db-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-glance-python27-db-ubuntu-xenial/4be26f4/ : SUCCESS in 11m 53s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/64400ac/ : SUCCESS in 1h 52m 26s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/45bad79/ : SUCCESS in 55m 43s\n- gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/284b998/ : SUCCESS in 1h 26m 31s\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/74/419074/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/a0fb10a/ : SUCCESS in 1h 28m 38s (non-voting)\n- gate-rally-dsvm-glance-ubuntu-xenial-nv http://logs.openstack.org/74/419074/1/check/gate-rally-dsvm-glance-ubuntu-xenial-nv/837644f/ : SUCCESS in 29m 33s (non-voting)\n- gate-rally-dsvm-py35-glance-nv http://logs.openstack.org/74/419074/1/check/gate-rally-dsvm-py35-glance-nv/075435f/ : SUCCESS in 32m 50s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"905765a418c9a7de54079ee674705692314638f3","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2017-01-11 20:51:51.000000000","message":"Patch Set 1: Workflow-1\n\nNot enough.. https://review.openstack.org/417590","accounts_in_message":[],"_revision_number":1},{"id":"34d77859d6c1af4a6a02269ec9535e96e1e986a2","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2017-01-17 09:21:51.000000000","message":"Patch Set 1:\n\nI think this one is needed too: https://review.openstack.org/#/c/421162/","accounts_in_message":[],"_revision_number":1},{"id":"b671634d5f696b608a03b448536d4fad27a2b03b","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2017-01-17 09:29:12.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"af1ca3c21c4bd0de9c206d713514b3d51a3faf49","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-01-17 10:57:57.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- gate-glance-python35-db-nv http://logs.openstack.org/74/419074/1/check/gate-glance-python35-db-nv/12b9d13/ : FAILURE in 2m 43s (non-voting)\n- gate-glance-docs-ubuntu-xenial http://docs-draft.openstack.org/74/419074/1/check/gate-glance-docs-ubuntu-xenial/7d098da//doc/build/html/ : SUCCESS in 5m 06s\n- gate-glance-pep8-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-glance-pep8-ubuntu-xenial/51d5784/ : SUCCESS in 3m 51s\n- gate-glance-python27-db-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-glance-python27-db-ubuntu-xenial/67a73da/ : SUCCESS in 8m 46s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/b0f601c/ : SUCCESS in 55m 46s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/82adf8c/ : SUCCESS in 49m 23s\n- gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/31b9267/ : FAILURE in 53m 02s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/74/419074/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/98b3661/ : SUCCESS in 1h 27m 05s (non-voting)\n- gate-rally-dsvm-glance-ubuntu-xenial-nv http://logs.openstack.org/74/419074/1/check/gate-rally-dsvm-glance-ubuntu-xenial-nv/4df3dc8/ : SUCCESS in 20m 22s (non-voting)\n- gate-rally-dsvm-py35-glance-nv http://logs.openstack.org/74/419074/1/check/gate-rally-dsvm-py35-glance-nv/612f063/ : SUCCESS in 25m 01s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"06fc035304e7ca7b924d9793172ca048d9e63535","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2017-01-20 06:40:56.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"b1e68734da4a904fe44e1e8fe47a7d8872116690","author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"date":"2017-02-20 01:44:36.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"043ade40296d7c18d190a2c23d684ae524ffc2d3","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2017-02-25 18:20:02.000000000","message":"Patch Set 1: Code-Review+1\n\nLet\u0027s please get this in.","accounts_in_message":[],"_revision_number":1},{"id":"087796f5cf5d56bc3bf7d3a2f3d2d92cbade59bd","author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"date":"2017-02-27 20:56:22.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nPlease see comment inline","accounts_in_message":[],"_revision_number":1},{"id":"312c543a21741d649e1a4d0262eb7e20f7501748","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2017-03-09 11:06:26.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"800bc3084164bd2d954665255661fe129e22fe2e","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2017-03-09 11:07:12.000000000","message":"Patch Set 1:\n\nAll tests looks passing with everything patched.","accounts_in_message":[],"_revision_number":1},{"id":"8cfc319bdfa4ed0700d9b3c589c134a9958e5ae3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-09 12:34:47.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- gate-glance-python35 http://logs.openstack.org/74/419074/1/check/gate-glance-python35/79e2414/ : SUCCESS in 19m 52s\n- gate-glance-docs-ubuntu-xenial http://docs-draft.openstack.org/74/419074/1/check/gate-glance-docs-ubuntu-xenial/dc6e4ec//doc/build/html/ : SUCCESS in 3m 35s\n- gate-glance-pep8-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-glance-pep8-ubuntu-xenial/330aaa7/ : SUCCESS in 5m 54s\n- gate-glance-python27-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-glance-python27-ubuntu-xenial/3d11301/ : SUCCESS in 7m 47s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/c630580/ : SUCCESS in 1h 18m 59s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/e2dbec7/ : SUCCESS in 49m 55s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-tempest-dsvm-py35-ubuntu-xenial/fb81855/ : SUCCESS in 1h 02m 03s\n- gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial http://logs.openstack.org/74/419074/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/8c513ee/ : SUCCESS in 1h 06m 17s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/74/419074/1/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/7d623c2/ : SUCCESS in 1h 26m 32s (non-voting)\n- gate-rally-dsvm-glance-ubuntu-xenial-nv http://logs.openstack.org/74/419074/1/check/gate-rally-dsvm-glance-ubuntu-xenial-nv/52456ff/ : SUCCESS in 22m 23s (non-voting)\n- gate-rally-dsvm-py35-glance-nv http://logs.openstack.org/74/419074/1/check/gate-rally-dsvm-py35-glance-nv/acf5b32/ : FAILURE in 25m 49s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5906f2c33dd2db5e10867c8a85b6fa2075eed23a","author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"date":"2017-03-09 16:34:46.000000000","message":"Patch Set 1:\n\nNot all tests are enabled yet. There are patches in flight to do so:\nhttps://review.openstack.org/#/q/status:open+project:openstack/glance+branch:master+topic:goal-python35/glance","accounts_in_message":[],"_revision_number":1},{"id":"e8e8a907e94bd56c58078bbaba037ce9e59a2bf6","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2017-03-09 19:11:04.000000000","message":"Patch Set 1:\n\nWell, I hope, we will not wait that all glance py35 tests pass to merge this. Not be able to bump eventlet blocks other projects to merge changes.","accounts_in_message":[],"_revision_number":1},{"id":"b1d94a602366c2b22de640572c9f5bfffbd1fa04","author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"date":"2017-03-09 19:29:26.000000000","message":"Patch Set 1:\n\nWe don\u0027t need to wait for py35, but there is no reason to intentionally break changes we know are coming down the pipe, since the fix is as simple as selectively patching only the modules that are needed, instead of all of them.","accounts_in_message":[],"_revision_number":1},{"id":"ef8e8d9deb69993f55bd794e256dd7d81719aa97","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2017-03-10 06:39:19.000000000","message":"Patch Set 1:\n\nThis what glance does in api/scruber/...:\n\n  eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue, time\u003dTrue,\n                                select\u003dTrue, thread\u003dTrue, os\u003dTrue)\n\n\nIf you put a different monkey pacthing in your functional tests, you will not really test the same code path than the real glance software run. Making many assumption wrong.\n\nIf test doesn\u0027t pass after this change, we have a good chance the tests is doing wrong thing.","accounts_in_message":[],"_revision_number":1},{"id":"36eb580739a935183e3616509e11c0d9ec20a706","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2017-03-13 13:40:06.000000000","message":"Patch Set 1: Code-Review-1\n\n\u003e This what glance does in api/scruber/...:\n \u003e \n \u003e eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue, time\u003dTrue,\n \u003e select\u003dTrue, thread\u003dTrue, os\u003dTrue)\n \u003e \n \u003e \n \u003e If you put a different monkey pacthing in your functional tests,\n \u003e you will not really test the same code path than the real glance\n \u003e software run. Making many assumption wrong.\n \u003e \n \u003e If test doesn\u0027t pass after this change, we have a good chance the\n \u003e tests is doing wrong thing.\n\nRight, so if Glance is patching only the ones above specifically, why patch everything? Doesn\u0027t this mean that we patch modules other than those specified above?","accounts_in_message":[],"_revision_number":1},{"id":"10026f4b101ceed5934a68aea99d85ee43d674db","author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"date":"2017-03-13 15:50:09.000000000","message":"Patch Set 1: Code-Review+1\n\n\u003e \u003e This what glance does in api/scruber/...:\n \u003e \u003e\n \u003e \u003e eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue, time\u003dTrue,\n \u003e \u003e select\u003dTrue, thread\u003dTrue, os\u003dTrue)\n \u003e \u003e\n \u003e \u003e\n \u003e \u003e If you put a different monkey pacthing in your functional tests,\n \u003e \u003e you will not really test the same code path than the real glance\n \u003e \u003e software run. Making many assumption wrong.\n \u003e \u003e\n \u003e \u003e If test doesn\u0027t pass after this change, we have a good chance the\n \u003e \u003e tests is doing wrong thing.\n \u003e \n \u003e Right, so if Glance is patching only the ones above specifically,\n \u003e why patch everything? Doesn\u0027t this mean that we patch modules other\n \u003e than those specified above?\n\nHemanth, I think both api and scrubber now are mokeypatching all the modules. So is the current patch. Cos, all the 5 parameters that eventlet\u0027s monkey_patch() takes have been enabled there. [1] I think it is okay to be implicitly state the same here.\nRegistry on the other hand has enabled only socket, time and thread.\n\n\nhttp://eventlet.net/doc/basic_usage.html#eventlet.monkey_patch","accounts_in_message":[],"_revision_number":1},{"id":"88642d77ae794b4b7fb1e59c48ace2e9ab9abac8","author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"date":"2017-03-13 17:05:14.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nAlex\n\n \u003e (1 comment)\n \u003e \n \u003e Please see comment inline\n\n \u003e (1 comment)\n \u003e \n \u003e Please see comment inline\n\nAlex, I\u0027ve commented inline. I think we need to unblock the release team on priority. If we can get this in which will not break you in future, will the proposed solution inline work?\n\n\nOverall, I\u0027m -1 to a change that will potentially break glance on a community goal priority --\u003e http://specs.openstack.org/openstack/glance-specs/specs/pike/approved/glance/lite-specs.html#community-goal-support-python-3-5","accounts_in_message":[],"_revision_number":1},{"id":"685b71c6cd29c4e6daf451f7444cfb3e939b73c0","author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"date":"2017-03-13 17:10:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ecda74d1476486040b855be36bd47c335e488101","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2017-03-14 15:10:34.000000000","message":"Patch Set 1:\n\n\u003e \n \u003e Hemanth, I think both api and scrubber now are mokeypatching all\n \u003e the modules. So is the current patch. Cos, all the 5 parameters\n \u003e that eventlet\u0027s monkey_patch() takes have been enabled there. [1] I\n \u003e think it is okay to be implicitly state the same here.\n \u003e Registry on the other hand has enabled only socket, time and\n \u003e thread.\n \u003e \n \u003e \n \u003e http://eventlet.net/doc/basic_usage.html#eventlet.monkey_patch\n\nIt may be the same. Or not? http://eventlet.net/doc/patching.html#eventlet.patcher.monkey_patch\n\nLooks like now psycopg can be monkey patched as well. Now, we don\u0027t use postgres, so it is probably not an issue. But, can you see what I\u0027m concerned about? Monkey patching ``all`` is very implicit. If eventlet adds support for something else tomorrow, then that would get monkey patched by default too irrespective of our intention. We\u0027ll then be looking at a nasty debugging scenario.\n\nCall me paranoid but explicit is better than implicit. \nMoreover, what is ``all`` buying us that explicit monkey patching doesn\u0027t? Help me understand.","accounts_in_message":[],"_revision_number":1},{"id":"40c32dda9b7b20a5a62681fc801e73d4fc94a97c","author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"date":"2017-03-14 17:00:11.000000000","message":"Patch Set 1: -Code-Review\n\n\u003e \u003e\n \u003e \u003e Hemanth, I think both api and scrubber now are mokeypatching all\n \u003e \u003e the modules. So is the current patch. Cos, all the 5 parameters\n \u003e \u003e that eventlet\u0027s monkey_patch() takes have been enabled there. [1]\n \u003e I\n \u003e \u003e think it is okay to be implicitly state the same here.\n \u003e \u003e Registry on the other hand has enabled only socket, time and\n \u003e \u003e thread.\n \u003e \u003e\n \u003e \u003e\n \u003e \u003e http://eventlet.net/doc/basic_usage.html#eventlet.monkey_patch\n \u003e \n \u003e It may be the same. Or not? http://eventlet.net/doc/patching.html#eventlet.patcher.monkey_patch\n \u003e \n \u003e Looks like now psycopg can be monkey patched as well. Now, we don\u0027t\n \u003e use postgres, so it is probably not an issue. But, can you see what\n \u003e I\u0027m concerned about? Monkey patching ``all`` is very implicit. If\n \u003e eventlet adds support for something else tomorrow, then that would\n \u003e get monkey patched by default too irrespective of our intention.\n \u003e We\u0027ll then be looking at a nasty debugging scenario.\n \u003e \n \u003e Call me paranoid but explicit is better than implicit.\n \u003e Moreover, what is ``all`` buying us that explicit monkey patching\n \u003e doesn\u0027t? Help me understand.\n\nHi Hemanth,\nI understand your concern and I agree with you that explicitly monkey patching is better for us here. I was just trying to tell that right now with this PS, no harm.\n\n@Mehdi, can we please monkey patch only the required params explicitly as Hemanth says as this will prevent issues in the future?","accounts_in_message":[],"_revision_number":1},{"id":"ad9a447f3e87645067fc9e3689b0579723b9d646","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2017-03-15 14:53:26.000000000","message":"Patch Set 1:\n\nFYI, I\u0027m going to take this over due to lack of activity.","accounts_in_message":[],"_revision_number":1},{"id":"595e21007f9a389b3850147845725b4bd0e162e6","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2017-03-15 17:49:51.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ec53e3a3160b8bdcd301f18f66608c5466d9b00c","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2017-03-15 17:50:52.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"49507d7361a9bf0674105a739df32c2801827183","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2017-03-15 18:45:50.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"c59de06fbc52adbf1586725b0f4f7299500f46bc","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2017-03-15 18:55:28.000000000","message":"Patch Set 3:\n\nFrom what I understand, eventlet 0.20.x removed ``poll``. So, if we patch select it\u0027s not going to have ``poll``, which is used by subprocess to communicate. Unless we patch  subprocess too, patching select alone will break subprocess usage.\n\nI\u0027m not entirely sure myself but that\u0027s what I got so far.","accounts_in_message":[],"_revision_number":3},{"id":"c34f95a1fa53a0ddb97e54ff53b006856ab7e6bf","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2017-03-15 19:01:54.000000000","message":"Patch Set 3:\n\nGreat, let\u0027s keep poking at it looking for a solution, disqualifying alternatives as we go.\n\nSomeday we will take eventlet, install it onto a Laserjet, and take them both to a deserted patch of grass with some baseball bats.","accounts_in_message":[],"_revision_number":3},{"id":"b550da2ed3a590f8043b2071f91ae4b8ad2f9239","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-15 19:35:41.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-glance-python35 http://logs.openstack.org/74/419074/3/check/gate-glance-python35/adf2e37/ : FAILURE in 4m 57s\n- gate-glance-docs-ubuntu-xenial http://docs-draft.openstack.org/74/419074/3/check/gate-glance-docs-ubuntu-xenial/aa838b7//doc/build/html/ : SUCCESS in 4m 59s\n- gate-glance-pep8-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-glance-pep8-ubuntu-xenial/bc1a2a3/ : SUCCESS in 3m 33s\n- gate-glance-python27-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-glance-python27-ubuntu-xenial/4b215c1/ : SUCCESS in 7m 16s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/08d87b9/ : SUCCESS in 1h 13m 21s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-grenade-dsvm-neutron-ubuntu-xenial/7789f9d/ : SUCCESS in 36m 04s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-tempest-dsvm-py35-ubuntu-xenial/6b6c497/ : SUCCESS in 1h 09m 14s\n- gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/2e9a5aa/ : SUCCESS in 1h 06m 29s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/74/419074/3/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/0fc2026/ : SUCCESS in 1h 41m 09s (non-voting)\n- gate-rally-dsvm-glance-ubuntu-xenial-nv http://logs.openstack.org/74/419074/3/check/gate-rally-dsvm-glance-ubuntu-xenial-nv/694bf52/ : SUCCESS in 21m 53s (non-voting)\n- gate-rally-dsvm-py35-glance-nv http://logs.openstack.org/74/419074/3/check/gate-rally-dsvm-py35-glance-nv/8d25d43/ : FAILURE in 25m 34s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"f4d177899de9000255682ebc453d606ea6a014e3","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2017-03-16 16:20:50.000000000","message":"Patch Set 3:\n\nrecheck - the gate-glance-python35 failure should be cleaned up by an unrelated change","accounts_in_message":[],"_revision_number":3},{"id":"04ca5745719e66abf6d510158c16c006193bf65d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-16 17:38:24.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-glance-python35 http://logs.openstack.org/74/419074/3/check/gate-glance-python35/f3d23b1/ : SUCCESS in 14m 25s\n- gate-glance-docs-ubuntu-xenial http://docs-draft.openstack.org/74/419074/3/check/gate-glance-docs-ubuntu-xenial/ad7f34b//doc/build/html/ : SUCCESS in 4m 50s\n- gate-glance-pep8-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-glance-pep8-ubuntu-xenial/26b0ce9/ : SUCCESS in 3m 21s\n- gate-glance-python27-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-glance-python27-ubuntu-xenial/238f4d2/ : SUCCESS in 9m 47s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/5387263/ : SUCCESS in 1h 14m 48s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-grenade-dsvm-neutron-ubuntu-xenial/536ff39/ : SUCCESS in 48m 34s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-tempest-dsvm-py35-ubuntu-xenial/fe4704b/ : SUCCESS in 1h 08m 41s\n- gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial http://logs.openstack.org/74/419074/3/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/1657549/ : SUCCESS in 1h 05m 23s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/74/419074/3/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/47249cd/ : SUCCESS in 1h 12m 56s (non-voting)\n- gate-rally-dsvm-glance-ubuntu-xenial-nv http://logs.openstack.org/74/419074/3/check/gate-rally-dsvm-glance-ubuntu-xenial-nv/4bb759a/ : SUCCESS in 31m 10s (non-voting)\n- gate-rally-dsvm-py35-glance-nv http://logs.openstack.org/74/419074/3/check/gate-rally-dsvm-py35-glance-nv/11cabee/ : FAILURE in 26m 22s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"7f0a9180dd47a0aff8527f251323f7421871d57a","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2017-03-16 17:43:12.000000000","message":"Patch Set 3:\n\nBecause this has been blocking others too long and we are getting no closer to an alternate fix, Alex and I are dropping our resistance to the original patch set.","accounts_in_message":[],"_revision_number":3},{"id":"eda380963b7749f176a565b7079e6cb68ee0977e","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2017-03-16 17:48:32.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"34676c40fbb34ead4baf99a4da533d9ae29978ef","author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"date":"2017-03-16 17:53:01.000000000","message":"Patch Set 4: Code-Review+1\n\nI\u0027m OK with making this change to unblock bumping the eventlet version. The fallout with python3.5 should be manageable given that other projects have managed it.","accounts_in_message":[],"_revision_number":4},{"id":"370b84291388584272f1ed6a7c39581b4b683aef","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2017-03-16 18:01:29.000000000","message":"Patch Set 4: Code-Review+1\n\nRestricting myself to +1 because I changed the import line from the original patch.\n\nI\u0027m + on this merging.","accounts_in_message":[],"_revision_number":4},{"id":"9ecd8b46812ae73c23398b155a3b8ffdd01774da","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2017-03-16 18:11:01.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"557b099d8d63182dd40c034dcfb7e3668ad4472c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-16 19:27:13.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-glance-python35 http://logs.openstack.org/74/419074/4/check/gate-glance-python35/9646e2b/ : SUCCESS in 16m 13s\n- gate-glance-docs-ubuntu-xenial http://docs-draft.openstack.org/74/419074/4/check/gate-glance-docs-ubuntu-xenial/4fa7b01//doc/build/html/ : SUCCESS in 6m 10s\n- gate-glance-pep8-ubuntu-xenial http://logs.openstack.org/74/419074/4/check/gate-glance-pep8-ubuntu-xenial/9ccce21/ : SUCCESS in 6m 21s\n- gate-glance-python27-ubuntu-xenial http://logs.openstack.org/74/419074/4/check/gate-glance-python27-ubuntu-xenial/72d94f8/ : SUCCESS in 11m 10s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/74/419074/4/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/db06273/ : SUCCESS in 1h 30m 16s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/74/419074/4/check/gate-grenade-dsvm-neutron-ubuntu-xenial/70debec/ : SUCCESS in 1h 35m 26s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/74/419074/4/check/gate-tempest-dsvm-py35-ubuntu-xenial/6d3a639/ : SUCCESS in 1h 03m 59s\n- gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial http://logs.openstack.org/74/419074/4/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/2d1b1ad/ : SUCCESS in 1h 05m 29s (non-voting)\n- gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv http://logs.openstack.org/74/419074/4/check/gate-tempest-dsvm-neutron-identity-v3-only-full-ubuntu-xenial-nv/0a284a4/ : SUCCESS in 1h 13m 30s (non-voting)\n- gate-rally-dsvm-glance-ubuntu-xenial-nv http://logs.openstack.org/74/419074/4/check/gate-rally-dsvm-glance-ubuntu-xenial-nv/4fbec16/ : SUCCESS in 28m 21s (non-voting)\n- gate-rally-dsvm-py35-glance-nv http://logs.openstack.org/74/419074/4/check/gate-rally-dsvm-py35-glance-nv/85fa0fc/ : FAILURE in 34m 05s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"d22d6dfd7e14baae95dad80863d0426820122467","author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"date":"2017-03-16 19:56:28.000000000","message":"Patch Set 4: Code-Review+1\n\nI am not sure that this patching of all modules will not cause issues in the future to crop up.\nBut now, i do not see any issues. I did not earlier during my +1 too. Hence, due to limited knowledge with this, I am +1\u0027ing.","accounts_in_message":[],"_revision_number":4},{"id":"4cb26d6d08dc22382624a33ae805ef3c6af6f92e","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2017-03-16 21:02:46.000000000","message":"Patch Set 4: Code-Review+2\n\nThis will cause some additional work for Alex with the Python 3.5 community goal.  But since all the current tests pass with this patch, it looks like the change doesn\u0027t actually break Glance.  So in the interest of unblocking requirements, I\u0027m OK with this patch.","accounts_in_message":[],"_revision_number":4},{"id":"008de78b982b629027c645341154cba190fc3678","author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"date":"2017-03-17 01:47:21.000000000","message":"Patch Set 4: Code-Review+1\n\nLet\u0027s please get this in and then iterate if needed.","accounts_in_message":[],"_revision_number":4},{"id":"88336a1ac18a01f5dc1681533dbe5c23d38b06e7","author":{"_account_id":16034,"name":"soumiyajit","email":"somya.rock@gmail.com","username":"soumiyajit"},"date":"2017-03-17 07:15:25.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"d3e1055ab69ca79d8fb0aee87c696c479b31f436","author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"date":"2017-03-17 14:30:57.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1\n\nI have my reservations against this one. Patching select without patching subprocess I think is a bomb waiting to go off. I tried looking at all the places where we use subprocess and thus need select.poll. It looks like Glance directly uses this primarily for bringing up servers for functional tests. Apart from that I couldn\u0027t find a direct use of it anywhere else. But, I\u0027m not 100% sure that we won\u0027t break Glance going forward with direct or indirect usage of subprocess that requires select.poll. \n\nKeeping the above in mind and given that this is blocking the entire community from moving to eventlet 0.20.x, I\u0027m willing to merge this with reservations.","accounts_in_message":[],"_revision_number":4},{"id":"4916de7f5898fd38f2f010f8b9d9878d28b9db25","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-17 14:31:08.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"9fe18028611291e1e6e2b17101d4f38c80b6886c","date":"2017-03-17 15:49:56.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":4},{"id":"f7bc798961d621566acb0e02e0fd85e490553396","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-03-17 15:49:56.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-glance-python35 http://logs.openstack.org/74/419074/4/gate/gate-glance-python35/4619783/ : SUCCESS in 13m 34s\n- gate-glance-docs-ubuntu-xenial http://docs-draft.openstack.org/74/419074/4/gate/gate-glance-docs-ubuntu-xenial/cfbaeea//doc/build/html/ : SUCCESS in 4m 09s\n- gate-glance-pep8-ubuntu-xenial http://logs.openstack.org/74/419074/4/gate/gate-glance-pep8-ubuntu-xenial/996b4d7/ : SUCCESS in 3m 44s\n- gate-glance-python27-ubuntu-xenial http://logs.openstack.org/74/419074/4/gate/gate-glance-python27-ubuntu-xenial/05c7a66/ : SUCCESS in 10m 09s\n- gate-tempest-dsvm-neutron-full-ubuntu-xenial http://logs.openstack.org/74/419074/4/gate/gate-tempest-dsvm-neutron-full-ubuntu-xenial/fee76e7/ : SUCCESS in 1h 11m 27s\n- gate-grenade-dsvm-neutron-ubuntu-xenial http://logs.openstack.org/74/419074/4/gate/gate-grenade-dsvm-neutron-ubuntu-xenial/fd7836e/ : SUCCESS in 37m 39s\n- gate-tempest-dsvm-py35-ubuntu-xenial http://logs.openstack.org/74/419074/4/gate/gate-tempest-dsvm-py35-ubuntu-xenial/32c5238/ : SUCCESS in 1h 04m 00s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"f07c7cff61a3a6a326fde699af3a800d1ac7d571","revisions":{"e0dcfeb84468e9f134a469d702347b13b1c2846f":{"kind":"REWORK","_number":1,"created":"2017-01-11 18:04:49.000000000","uploader":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"ref":"refs/changes/74/419074/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/74/419074/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/74/419074/1"}}},"commit":{"parents":[{"commit":"03567be314d0929122f40600649ed3d0bc6568f4","subject":"Remove obsolete swift links","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/03567be314d0929122f40600649ed3d0bc6568f4"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2017-01-11 18:02:52.000000000","tz":60},"committer":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2017-01-11 18:04:38.000000000","tz":60},"subject":"Invoke monkey_patching early enough for eventlet 0.20.1","message":"Invoke monkey_patching early enough for eventlet 0.20.1\n\neventlet 0.20.x is monkey patching also subprocess, so we need\nto establish patching early enough for functional tests\n\nCloses-Bug: #1655727\nChange-Id: I4de03e2a1ca493cd49a474a67cbbdec24d61b98f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/e0dcfeb84468e9f134a469d702347b13b1c2846f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/e0dcfeb84468e9f134a469d702347b13b1c2846f"}]},"branch":"refs/heads/master"},"7d3210069f6ac7f40bcdf5e054621145f7038d6d":{"kind":"REWORK","_number":2,"created":"2017-03-15 17:49:51.000000000","uploader":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"ref":"refs/changes/74/419074/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/74/419074/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/74/419074/2"}}},"commit":{"parents":[{"commit":"03567be314d0929122f40600649ed3d0bc6568f4","subject":"Remove obsolete swift links","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/03567be314d0929122f40600649ed3d0bc6568f4"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2017-01-11 18:02:52.000000000","tz":60},"committer":{"name":"Steve Lewis","email":"stevelle@gmail.com","date":"2017-03-15 17:49:02.000000000","tz":-420},"subject":"Invoke monkey_patching early enough for eventlet 0.20.1","message":"Invoke monkey_patching early enough for eventlet 0.20.1\n\neventlet 0.20.x is monkey patching also subprocess, so we need\nto establish patching early enough for functional tests\n\nCloses-Bug: #1655727\nChange-Id: I4de03e2a1ca493cd49a474a67cbbdec24d61b98f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/7d3210069f6ac7f40bcdf5e054621145f7038d6d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/7d3210069f6ac7f40bcdf5e054621145f7038d6d"}]},"branch":"refs/heads/master"},"b3e07ff5c48d635d4483b18dd3438dc86bd86fab":{"kind":"REWORK","_number":3,"created":"2017-03-15 17:50:52.000000000","uploader":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"ref":"refs/changes/74/419074/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/74/419074/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/74/419074/3"}}},"commit":{"parents":[{"commit":"03567be314d0929122f40600649ed3d0bc6568f4","subject":"Remove obsolete swift links","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/03567be314d0929122f40600649ed3d0bc6568f4"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2017-01-11 18:02:52.000000000","tz":60},"committer":{"name":"Steve Lewis","email":"stevelle@gmail.com","date":"2017-03-15 17:50:43.000000000","tz":-420},"subject":"Invoke monkey_patching early enough for eventlet 0.20.1","message":"Invoke monkey_patching early enough for eventlet 0.20.1\n\neventlet 0.20.x is monkey patching also subprocess, so we need\nto establish patching early enough for functional tests\n\nCloses-Bug: #1655727\nChange-Id: I4de03e2a1ca493cd49a474a67cbbdec24d61b98f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b3e07ff5c48d635d4483b18dd3438dc86bd86fab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b3e07ff5c48d635d4483b18dd3438dc86bd86fab"}]},"branch":"refs/heads/master"},"f07c7cff61a3a6a326fde699af3a800d1ac7d571":{"kind":"REWORK","_number":4,"created":"2017-03-16 17:48:32.000000000","uploader":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"ref":"refs/changes/74/419074/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/74/419074/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/74/419074/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/74/419074/4"}}},"commit":{"parents":[{"commit":"7580d817dab87d2b1ef16d2780237ecc4f658699","subject":"Merge \"Use HostAddressOpt for opts that accept IP and hostnames\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/7580d817dab87d2b1ef16d2780237ecc4f658699"}]}],"author":{"name":"Dirk Mueller","email":"dirk@dmllr.de","date":"2017-01-11 18:02:52.000000000","tz":60},"committer":{"name":"Steve Lewis","email":"stevelle@gmail.com","date":"2017-03-16 17:48:10.000000000","tz":-420},"subject":"Invoke monkey_patching early enough for eventlet 0.20.1","message":"Invoke monkey_patching early enough for eventlet 0.20.1\n\neventlet 0.20.x is monkey patching also subprocess, so we need\nto establish patching early enough for functional tests\n\nCloses-Bug: #1655727\nChange-Id: I4de03e2a1ca493cd49a474a67cbbdec24d61b98f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/f07c7cff61a3a6a326fde699af3a800d1ac7d571"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/f07c7cff61a3a6a326fde699af3a800d1ac7d571"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}