)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"447b836eaaf2571b7bdfca69049136de56a02fa4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ian Cordasco \u003cgraffatcolmingov@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-13 09:47:16 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Satisfy API Reference documentation deletiing tags"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The API Reference documentation for Glance v2 documents the response"},{"line_number":10,"context_line":"status code as 204 but instead returns a 200 status code. This fixes the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_283770b1","line":7,"updated":"2017-01-13 16:45:36.000000000","message":"Done","commit_id":"1c95a4b26bb8ca060e0aae97baa97defcab6f47b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d86688585f05f3896d36acb0327f41fd8ecbb3bb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ian Cordasco \u003cgraffatcolmingov@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-13 09:47:16 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Satisfy API Reference documentation deletiing tags"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The API Reference documentation for Glance v2 documents the response"},{"line_number":10,"context_line":"status code as 204 but instead returns a 200 status code. This fixes the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_6f1422f5","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":43},"updated":"2017-01-13 15:56:42.000000000","message":"s/ii/i/","commit_id":"1c95a4b26bb8ca060e0aae97baa97defcab6f47b"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7864705c7c50333d6604044862db08b69982b906","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The API Reference documentation for Glance v2 documents the response"},{"line_number":10,"context_line":"status code as 204 but instead returns a 200 status code. This fixes the"},{"line_number":11,"context_line":"disparity and adds the ability to start testing our response serializer."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1656183"},{"line_number":14,"context_line":"Depends-On: I5e4c0e300dd47e8c69bf826e6eb8f725b190f7a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_edf7af56","line":11,"updated":"2017-02-14 18:37:49.000000000","message":"It seems like we should include a better reason why this change makes sense.\n\nMy initial take is, the code is the API not the docs:\nhttps://governance.openstack.org/tc/reference/principles.html#openstack-primarily-produces-software\nNova in particular wrote this down when this came up before:\nhttp://docs.openstack.org/developer/nova/policies.html#rest-apis\n\nNow, if the correct response is 204, rather than 200, because that aligns with the API-WG spec, regardless of what is in the docs, thats all good reason to consider this change.\n\nIt has been said that most clients only check for 2xx, so most folks will not be broken by changing 200 -\u003e 204. But it could (so probably will) break some users.\n\nYou could also argue, if most clients only check for 2xx, there is no real reason to change this, as changing it risks breaking some clients, but the people who are doing things correctly should be checking only for 2xx for success.\n\nIf its really important, you could implement microversions, so clients can opt-in to the \"more correct\" behaviour at their own pace. But that feels like over kill here for something like this.","commit_id":"d67d2efab5edb0e0ad9aa7ebaeab77270711fed3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5295cbcbe5ca36c7c8da0393712763e4014a5623","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The API Reference documentation for Glance v2 documents the response"},{"line_number":10,"context_line":"status code as 204 but instead returns a 200 status code. This fixes the"},{"line_number":11,"context_line":"disparity and adds the ability to start testing our response serializer."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1656183"},{"line_number":14,"context_line":"Depends-On: I5e4c0e300dd47e8c69bf826e6eb8f725b190f7a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa31d9ce_a1bcdb06","line":11,"in_reply_to":"fa31d9ce_edf7af56","updated":"2017-02-14 21:44:51.000000000","message":"Hi John,\n\nKen pointed out the Nova policy to me on another review, but I think this situation is a bit different.  I responded here: https://review.openstack.org/#/c/421846/1/guidelines/api_compatibility.rst@84\n\nDon\u0027t know if you\u0027ll buy this, but I made an argument on one of my comments on this patch that *not* changing to a 204 will break all those users who followed the api-ref but haven\u0027t had to delete any metadefs tags yet ... when they do go to delete a tag and can\u0027t handle a 200, they\u0027re broken because we didn\u0027t fix the code to return the correct response!","commit_id":"d67d2efab5edb0e0ad9aa7ebaeab77270711fed3"}],"glance/tests/unit/v2/test_metadef_resources.py":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"62e038a24bfc8df07f0ca972710a9d18734100be","unresolved":false,"context_lines":[{"line_number":2022,"context_line":"class TestMetadefNamespaceResponseSerializers(base.IsolatedUnitTest):"},{"line_number":2023,"context_line":""},{"line_number":2024,"context_line":"    def setUp(self):"},{"line_number":2025,"context_line":"        self.serializer \u003d namespaces.ResponseSerializer(schema\u003d{})"},{"line_number":2026,"context_line":"        self.response \u003d mock.Mock()"},{"line_number":2027,"context_line":"        self.result \u003d mock.Mock()"},{"line_number":2028,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_0d4c86c6","line":2025,"updated":"2017-01-13 16:35:25.000000000","message":"Shouldn\u0027t we be calling the super class\u0027 SetUp()?","commit_id":"1c95a4b26bb8ca060e0aae97baa97defcab6f47b"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"447b836eaaf2571b7bdfca69049136de56a02fa4","unresolved":false,"context_lines":[{"line_number":2022,"context_line":"class TestMetadefNamespaceResponseSerializers(base.IsolatedUnitTest):"},{"line_number":2023,"context_line":""},{"line_number":2024,"context_line":"    def setUp(self):"},{"line_number":2025,"context_line":"        self.serializer \u003d namespaces.ResponseSerializer(schema\u003d{})"},{"line_number":2026,"context_line":"        self.response \u003d mock.Mock()"},{"line_number":2027,"context_line":"        self.result \u003d mock.Mock()"},{"line_number":2028,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a3c09a3_483cbc93","line":2025,"updated":"2017-01-13 16:45:36.000000000","message":"Thanks for catching that. I always forget it. \u003d/","commit_id":"1c95a4b26bb8ca060e0aae97baa97defcab6f47b"}]}