)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"e7276a47a2bed376075524433142c96ba0208498","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Steve Lewis \u003cstevelle@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-21 15:58:04 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Eliminate use of incorrect term in replication"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The replicator replicates from a source to a target. There is no"},{"line_number":10,"context_line":"other relationship or responsibilities between the source and target"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da36d5c6_1c062986","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":46},"updated":"2017-02-22 19:17:08.000000000","message":"Please indicate what we are actually changing. No need to use clickbaiting in the subject line.","commit_id":"c1301a1b3a9b6ecae452d1e5c4a799484dc02142"}],"glance/cmd/replicator.py":[{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"1894e96b457d671b53de6bf5dbee9631f4924880","unresolved":false,"context_lines":[{"line_number":66,"context_line":"               help\u003d(\"Pass in your authentication token if you have \""},{"line_number":67,"context_line":"                     \"one. This is the token used for the master.\")),"},{"line_number":68,"context_line":"    cfg.StrOpt(\u0027replicatoken\u0027,"},{"line_number":69,"context_line":"               short\u003d\u0027S\u0027,"},{"line_number":70,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":71,"context_line":"               deprecated_name\u003d\u0027slavetoken\u0027,"},{"line_number":72,"context_line":"               deprecated_since\u003d\u0027Ocata\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_fcf6e7f7","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":23},"updated":"2017-01-26 21:23:20.000000000","message":"we need to consider this as well if we wanna change the opt name.","commit_id":"f27e1a7e0df6fdc8297affccd18e69ebcc4faa53"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"19600e108e9109a7ce07f496bf1aeb35a8bdacd0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               help\u003d\"Amount of data to transfer per HTTP write.\"),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027dontreplicate\u0027,"},{"line_number":50,"context_line":"               short\u003d\u0027D\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027created_at date deleted_at location updated_at\u0027,"},{"line_number":52,"context_line":"               help\u003d\"List of fields to not replicate.\"),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027metaonly\u0027,"},{"line_number":54,"context_line":"                short\u003d\u0027m\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_65da214e","line":51,"updated":"2017-02-22 21:14:55.000000000","message":"looks like this change isn\u0027t related to this change, I\u0027d prefer a separate commit for this line to avoid confusing history.","commit_id":"7d661d3e0a8df5485dda27577d7320e5c7ee5261"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"1168c7e92dae39997175459841b5fbfb785c33c0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               help\u003d\"Amount of data to transfer per HTTP write.\"),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027dontreplicate\u0027,"},{"line_number":50,"context_line":"               short\u003d\u0027D\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027created_at date deleted_at location updated_at\u0027,"},{"line_number":52,"context_line":"               help\u003d\"List of fields to not replicate.\"),"},{"line_number":53,"context_line":"    cfg.BoolOpt(\u0027metaonly\u0027,"},{"line_number":54,"context_line":"                short\u003d\u0027m\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_43bb750e","line":51,"in_reply_to":"da36d5c6_65da214e","updated":"2017-03-08 23:55:05.000000000","message":"Done","commit_id":"7d661d3e0a8df5485dda27577d7320e5c7ee5261"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"19600e108e9109a7ce07f496bf1aeb35a8bdacd0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":65,"context_line":"               help\u003d(\"Pass in your authentication token if you have \""},{"line_number":66,"context_line":"                     \"one. This is the token used for the source.\")),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027mastertoken\u0027,"},{"line_number":68,"context_line":"               short\u003d\u0027M\u0027,"},{"line_number":69,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":70,"context_line":"               deprecated_since\u003d\u0027Pike\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_05ac058b","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":27},"updated":"2017-02-22 21:14:55.000000000","message":"can you use an alias for this config option to alias it to sourcetoken and not worry about the short?","commit_id":"7d661d3e0a8df5485dda27577d7320e5c7ee5261"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"a8635d72bb04769fbd2b04d6be739a12839732e4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":65,"context_line":"               help\u003d(\"Pass in your authentication token if you have \""},{"line_number":66,"context_line":"                     \"one. This is the token used for the source.\")),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027mastertoken\u0027,"},{"line_number":68,"context_line":"               short\u003d\u0027M\u0027,"},{"line_number":69,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":70,"context_line":"               deprecated_since\u003d\u0027Pike\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_43f9b54c","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":27},"in_reply_to":"9a30ddce_431d35bc","updated":"2017-03-09 00:04:02.000000000","message":"good to know, hadn\u0027t seen that one when hunting for a solution. New patch coming shortly.","commit_id":"7d661d3e0a8df5485dda27577d7320e5c7ee5261"},{"author":{"_account_id":21722,"name":"Dharini Chandrasekar","email":"dharini.chandrasekar@intel.com","username":"dharinic"},"change_message_id":"3b654804053d51a2827f4180d4b15ebde3a23938","unresolved":false,"context_lines":[{"line_number":64,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":65,"context_line":"               help\u003d(\"Pass in your authentication token if you have \""},{"line_number":66,"context_line":"                     \"one. This is the token used for the source.\")),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027mastertoken\u0027,"},{"line_number":68,"context_line":"               short\u003d\u0027M\u0027,"},{"line_number":69,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":70,"context_line":"               deprecated_since\u003d\u0027Pike\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_431d35bc","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":27},"in_reply_to":"9a30ddce_8309eddf","updated":"2017-03-09 00:01:51.000000000","message":"Steve, there is option type: \"DeprecatedOpt\". [1]\n\n[1] https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1085","commit_id":"7d661d3e0a8df5485dda27577d7320e5c7ee5261"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"1168c7e92dae39997175459841b5fbfb785c33c0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":65,"context_line":"               help\u003d(\"Pass in your authentication token if you have \""},{"line_number":66,"context_line":"                     \"one. This is the token used for the source.\")),"},{"line_number":67,"context_line":"    cfg.StrOpt(\u0027mastertoken\u0027,"},{"line_number":68,"context_line":"               short\u003d\u0027M\u0027,"},{"line_number":69,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":70,"context_line":"               deprecated_since\u003d\u0027Pike\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_8309eddf","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":27},"in_reply_to":"da36d5c6_05ac058b","updated":"2017-03-08 23:55:05.000000000","message":"Perhaps I misunderstand\n\nSee the comments in patch set 1 where leaving the short unchanged was rejected.\n\na StrOpt requires a name [1], so I can\u0027t just add another deprecated StrOpt for the short which omits the name.\n\n[1] https://docs.openstack.org/developer/oslo.config/opts.html","commit_id":"7d661d3e0a8df5485dda27577d7320e5c7ee5261"}],"glance/tests/unit/test_glance_replicator.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"19600e108e9109a7ce07f496bf1aeb35a8bdacd0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"IMG_RESPONSE_QUEUED \u003d copy.copy(IMG_RESPONSE_ACTIVE)"},{"line_number":63,"context_line":"IMG_RESPONSE_QUEUED[\u0027status\u0027] \u003d \u0027queued\u0027"},{"line_number":64,"context_line":"IMG_RESPONSE_QUEUED[\u0027id\u0027] \u003d \u002749b2c782-ee10-4692-84f8-3942e9432c4b\u0027"},{"line_number":65,"context_line":"IMG_RESPONSE_QUEUED[\u0027location\u0027] \u003d (\u0027http://127.0.0.1:9292/v1/images/\u0027 +"},{"line_number":66,"context_line":"                                   IMG_RESPONSE_QUEUED[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da36d5c6_0576c505","line":65,"updated":"2017-02-22 21:14:55.000000000","message":"not needed for this commit, please use a different commit","commit_id":"7d661d3e0a8df5485dda27577d7320e5c7ee5261"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"1168c7e92dae39997175459841b5fbfb785c33c0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"IMG_RESPONSE_QUEUED \u003d copy.copy(IMG_RESPONSE_ACTIVE)"},{"line_number":63,"context_line":"IMG_RESPONSE_QUEUED[\u0027status\u0027] \u003d \u0027queued\u0027"},{"line_number":64,"context_line":"IMG_RESPONSE_QUEUED[\u0027id\u0027] \u003d \u002749b2c782-ee10-4692-84f8-3942e9432c4b\u0027"},{"line_number":65,"context_line":"IMG_RESPONSE_QUEUED[\u0027location\u0027] \u003d (\u0027http://127.0.0.1:9292/v1/images/\u0027 +"},{"line_number":66,"context_line":"                                   IMG_RESPONSE_QUEUED[\u0027id\u0027])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a30ddce_e3cb8951","line":65,"in_reply_to":"da36d5c6_0576c505","updated":"2017-03-08 23:55:05.000000000","message":"Done","commit_id":"7d661d3e0a8df5485dda27577d7320e5c7ee5261"}]}