)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"c115f64fa2ceeced4e2ecc68bd056cb2dfe6735a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"running successfully. This patch fixes that."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch also fixes the ocata contract DB migration to"},{"line_number":14,"context_line":"depend on the correct expansion branch (ocata_expand01)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I40ffaaa3fa2bae7a555a86d9f31422d79fb9bb19"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba2be162_e8adb6e9","line":14,"range":{"start_line":14,"start_character":32,"end_line":14,"end_character":38},"updated":"2017-03-05 13:59:34.000000000","message":"revision","commit_id":"842d9ca2f507731217b433222ef3a625e76300d1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b5c27bd9af73b049de5c2d1a4452c68b0c956a8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix experimental E-M-C migrations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Two code issues were discovered in the code which prevent the"},{"line_number":10,"context_line":"experiment E-M-C (rolling upgrade) migration feature introduced"},{"line_number":11,"context_line":"in Ocata from working: a malformed select statement in the data"},{"line_number":12,"context_line":"migration [1], and a incorrect revision dependency in the DB"},{"line_number":13,"context_line":"migration [2]. This patch fixes both issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba2be162_8e2a5f2e","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":10},"updated":"2017-03-06 16:49:06.000000000","message":"nit: should be \u0027experimental\u0027.  If you fix, you might want to change the sentence to begin \"Two closely related code issues\" (and then maybe no one will object to both fixes in the same patch).","commit_id":"81ace89fd4ebb2a182c999c53d60589c04f0753e"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"22bc844ed571b4ccda7c91f724f74576ac4c6f45","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix experimental E-M-C migrations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Two code issues were discovered in the code which prevent the"},{"line_number":10,"context_line":"experiment E-M-C (rolling upgrade) migration feature introduced"},{"line_number":11,"context_line":"in Ocata from working: a malformed select statement in the data"},{"line_number":12,"context_line":"migration [1], and a incorrect revision dependency in the DB"},{"line_number":13,"context_line":"migration [2]. This patch fixes both issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba2be162_d79dc60b","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":10},"in_reply_to":"ba2be162_8e2a5f2e","updated":"2017-03-06 17:47:20.000000000","message":"Done","commit_id":"81ace89fd4ebb2a182c999c53d60589c04f0753e"}],"glance/tests/functional/db/migrations/test_ocata_migrate01.py":[{"author":{"_account_id":8158,"name":"Hemanth Makkapati","email":"makstacker+osgerrit@gmail.com","username":"hemanth.makkapati"},"change_message_id":"efe2f73a9a693d347e6d9bc74febf7bf41e23824","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    pass"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class TestOcataMigrate01_2Mixin(test_migrations.AlembicMigrationsMixin):"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _get_revisions(self, config):"},{"line_number":153,"context_line":"        return test_migrations.AlembicMigrationsMixin._get_revisions("}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_a793ca4e","line":150,"range":{"start_line":150,"start_character":6,"end_line":150,"end_character":31},"updated":"2017-03-06 21:36:22.000000000","message":"I was lazy enough to not give this a decent name. How about we give this a self-explanatory name or even better include a doc string to explain what this is doing differently when compared to the test above?","commit_id":"d8b90b4941010ec2001950c0b8ffc46e970f5a06"},{"author":{"_account_id":22448,"name":"Alexander Bashmakov","email":"abashmak@yahoo.com","username":"abashmak"},"change_message_id":"2dc7b0c00bc6eec885ef33967546b5eb3803d884","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    pass"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class TestOcataMigrate01_2Mixin(test_migrations.AlembicMigrationsMixin):"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _get_revisions(self, config):"},{"line_number":153,"context_line":"        return test_migrations.AlembicMigrationsMixin._get_revisions("}],"source_content_type":"text/x-python","patch_set":9,"id":"9a30ddce_47e5aea6","line":150,"range":{"start_line":150,"start_character":6,"end_line":150,"end_character":31},"in_reply_to":"9a30ddce_a793ca4e","updated":"2017-03-06 21:39:37.000000000","message":"Haha, I figured the comment on line 157 takes care of that. I guess not. Will change the name and add a doc string.","commit_id":"d8b90b4941010ec2001950c0b8ffc46e970f5a06"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"d75449a2ed98c9744596c231cea412fa4452eb8d","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    pass"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"class TestOcataMigrate01_EmptyDBMixin(test_migrations.AlembicMigrationsMixin):"},{"line_number":151,"context_line":"    \"\"\"This mixin is used to create an initial glance database and upgrade it"},{"line_number":152,"context_line":"    up to the ocata_expand01 revision."},{"line_number":153,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a1ced50_1f2cb249","line":150,"updated":"2017-03-17 17:24:20.000000000","message":"we need to come up with a different factoring for the initial DB that makes more sense to the reader.\n\nThis is probably going to be confusing because it is tagged with ocata_expand01 as the head, and the _pre_upgrade_ocata_expand01 and _check_ocata_expand01 methods have names that don\u0027t communicate what is going on well. The latter method tests that the data migration is a no-op before it tries to actually perform the migration, but this probably belongs in the TestOcataMigrate01_EmptyDBMySQL class, technically. Not the mixin.\n\nThe pattern can be fixed in Pike rather than here, but maybe a little tweaking can be done now.","commit_id":"15817166ab35212069517ba0002d8098988fd3bd"}]}