)]}'
{"glance/api/v2/images.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"944c2f7ebcb64247504432f286af00a74883c1a2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        executor_factory \u003d self.gateway.get_task_executor_factory(req.context)"},{"line_number":95,"context_line":"        task_repo \u003d self.gateway.get_task_repo(req.context)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        task_input \u003d {}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        try:"},{"line_number":100,"context_line":"            import_task \u003d task_factory.new_task(task_type\u003d\u0027api_image_import\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_615e98e7","line":97,"range":{"start_line":97,"start_character":8,"end_line":97,"end_character":23},"updated":"2017-05-29 11:22:12.000000000","message":"Instead of passing empty dictionary from here can we take care of this in unpack_task_input method?","commit_id":"ae405690c7480c3b13382366f541a3d3c83b7f81"}],"glance/common/scripts/api_image_import/main.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"944c2f7ebcb64247504432f286af00a74883c1a2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # necessary"},{"line_number":66,"context_line":"        err_msg \u003d (\"Error: \" + six.text_type(type(e)) + \u0027: \u0027 +"},{"line_number":67,"context_line":"                   encodeutils.exception_to_unicode(e))"},{"line_number":68,"context_line":"        log_msg \u003d _LE(err_msg + (\"Task ID %s\" % task.task_id))  # noqa"},{"line_number":69,"context_line":"        LOG.exception(log_msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        task.fail(_LE(err_msg))  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_3688e8c4","line":68,"range":{"start_line":68,"start_character":18,"end_line":68,"end_character":21},"updated":"2017-05-29 11:22:12.000000000","message":"Somewhere I heard that there is no need to translate messages now, should we follow the same in glance?\n\nReference:\nhttps://bugs.launchpad.net/glance/+bug/1674546\nhttps://review.openstack.org/#/c/446762/","commit_id":"ae405690c7480c3b13382366f541a3d3c83b7f81"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4c8d84f321be3db166aa4adb750c07679f2aec96","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # necessary"},{"line_number":66,"context_line":"        err_msg \u003d (\"Error: \" + six.text_type(type(e)) + \u0027: \u0027 +"},{"line_number":67,"context_line":"                   encodeutils.exception_to_unicode(e))"},{"line_number":68,"context_line":"        log_msg \u003d _LE(err_msg + (\"Task ID %s\" % task.task_id))  # noqa"},{"line_number":69,"context_line":"        LOG.exception(log_msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        task.fail(_LE(err_msg))  # noqa"}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_9c511312","line":68,"range":{"start_line":68,"start_character":18,"end_line":68,"end_character":21},"in_reply_to":"df140735_3688e8c4","updated":"2017-05-29 11:54:17.000000000","message":"we probably shouldn\u0027t indeed add new ones","commit_id":"ae405690c7480c3b13382366f541a3d3c83b7f81"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"944c2f7ebcb64247504432f286af00a74883c1a2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        log_msg \u003d _LE(err_msg + (\"Task ID %s\" % task.task_id))  # noqa"},{"line_number":69,"context_line":"        LOG.exception(log_msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        task.fail(_LE(err_msg))  # noqa"},{"line_number":72,"context_line":"    finally:"},{"line_number":73,"context_line":"        task_repo.save(task)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_d68e4ccf","line":71,"range":{"start_line":71,"start_character":18,"end_line":71,"end_character":21},"updated":"2017-05-29 11:22:12.000000000","message":"it is already translated at line #68","commit_id":"ae405690c7480c3b13382366f541a3d3c83b7f81"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4c8d84f321be3db166aa4adb750c07679f2aec96","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        log_msg \u003d _LE(err_msg + (\"Task ID %s\" % task.task_id))  # noqa"},{"line_number":69,"context_line":"        LOG.exception(log_msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        task.fail(_LE(err_msg))  # noqa"},{"line_number":72,"context_line":"    finally:"},{"line_number":73,"context_line":"        task_repo.save(task)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_fc348fe0","line":71,"range":{"start_line":71,"start_character":18,"end_line":71,"end_character":21},"in_reply_to":"df140735_d68e4ccf","updated":"2017-05-29 11:54:17.000000000","message":"Actually it\u0027s not. Different string.","commit_id":"ae405690c7480c3b13382366f541a3d3c83b7f81"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"fb73cf2c6507bf16c813e6c59f8d023131e2b900","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        log_msg \u003d _LE(err_msg + (\"Task ID %s\" % task.task_id))  # noqa"},{"line_number":69,"context_line":"        LOG.exception(log_msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        task.fail(_LE(err_msg))  # noqa"},{"line_number":72,"context_line":"    finally:"},{"line_number":73,"context_line":"        task_repo.save(task)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"df140735_9cd6b34f","line":71,"range":{"start_line":71,"start_character":18,"end_line":71,"end_character":21},"in_reply_to":"df140735_fc348fe0","updated":"2017-05-29 12:07:30.000000000","message":"yes, my bad","commit_id":"ae405690c7480c3b13382366f541a3d3c83b7f81"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"b29b92ebfeaec589f23040b3bd83bf934c360c1a","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if image.status \u003d\u003d \u0027saving\u0027:"},{"line_number":100,"context_line":"            image_repo.save(new_image)"},{"line_number":101,"context_line":"            return image_id"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            msg \u003d _(\"The Image %(image_id)s object being created by this task \""},{"line_number":104,"context_line":"                    \"%(task_id)s, is no longer in valid status for further \""},{"line_number":105,"context_line":"                    \"processing.\") % {\"image_id\": image_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_77ce4784","line":102,"updated":"2017-06-07 17:04:19.000000000","message":"else is not necessary","commit_id":"09312ab2c723d2cfb233ea0e417a297f38b67f40"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"ba71d1f8c8d6a35ed3976adfad556fce129e0905","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if image.status \u003d\u003d \u0027saving\u0027:"},{"line_number":100,"context_line":"            image_repo.save(new_image)"},{"line_number":101,"context_line":"            return image_id"},{"line_number":102,"context_line":"        else:"},{"line_number":103,"context_line":"            msg \u003d _(\"The Image %(image_id)s object being created by this task \""},{"line_number":104,"context_line":"                    \"%(task_id)s, is no longer in valid status for further \""},{"line_number":105,"context_line":"                    \"processing.\") % {\"image_id\": image_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf091321_4d6f59c5","line":102,"in_reply_to":"df140735_77ce4784","updated":"2017-06-07 22:48:14.000000000","message":"Tru, makes it more readable \u0027though.","commit_id":"09312ab2c723d2cfb233ea0e417a297f38b67f40"}],"glance/common/scripts/utils.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"b29b92ebfeaec589f23040b3bd83bf934c360c1a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        if \u0027import_method\u0027 not in task_input:"},{"line_number":60,"context_line":"            msg \u003d _(\"Input does not contain \u0027import_method\u0027\")"},{"line_number":61,"context_line":"            raise exception.Invalid(msg)"},{"line_number":62,"context_line":"    else:"},{"line_number":63,"context_line":"        for key in [\"import_from\", \"import_from_format\", \"image_properties\"]:"},{"line_number":64,"context_line":"            if key not in task_input:"},{"line_number":65,"context_line":"                msg \u003d (_(\"Input does not contain \u0027%(key)s\u0027 field\") %"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_9712fb08","line":62,"updated":"2017-06-07 17:04:19.000000000","message":"Generally I understand that there are only two possible values for task_type: api_image_import and import, but I wonder whether we should use \u0027else\u0027 here. Maybe \"elif task_type \u003d\u003d \u0027import\u0027:\" is more appropriate.","commit_id":"09312ab2c723d2cfb233ea0e417a297f38b67f40"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"ba71d1f8c8d6a35ed3976adfad556fce129e0905","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        if \u0027import_method\u0027 not in task_input:"},{"line_number":60,"context_line":"            msg \u003d _(\"Input does not contain \u0027import_method\u0027\")"},{"line_number":61,"context_line":"            raise exception.Invalid(msg)"},{"line_number":62,"context_line":"    else:"},{"line_number":63,"context_line":"        for key in [\"import_from\", \"import_from_format\", \"image_properties\"]:"},{"line_number":64,"context_line":"            if key not in task_input:"},{"line_number":65,"context_line":"                msg \u003d (_(\"Input does not contain \u0027%(key)s\u0027 field\") %"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf091321_2da9c5de","line":62,"in_reply_to":"df140735_9712fb08","updated":"2017-06-07 22:48:14.000000000","message":"I was cursing the decision someone had made to hardcode these in at this level when I first stumbled upon it and I was told for the sake of getting it done to keep doing that for now and we can get back to do it right some later time if deemed necessary ;)","commit_id":"09312ab2c723d2cfb233ea0e417a297f38b67f40"}]}