)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a32512424e0c1b8ec1d4bb37d2467c47850b0ef5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"13820e9c_25cf91f6","updated":"2022-07-01 06:32:55.000000000","message":"I think we can go ahead and remove this option now.\nBut IMO you also need to generate sample configs with this patch to reflect our sample configurations.\n\ntox -e genconfig\n\nlike,https://review.opendev.org/c/openstack/glance/+/842336","commit_id":"5406c81a45e0c87a333df4e23161c5af68e84e37"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"aac800393765092b41eab3e9f9f86004be05d3e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6f1aad98_6e94832f","updated":"2022-06-24 16:35:47.000000000","message":"Note to reviewers: I\u0027m just digging this up because it feels like something we should have done a while ago. If we do not want to merge this right now, we should decide in which release the deprecated option should be removed, and maybe discuss it in a next meeting.","commit_id":"5406c81a45e0c87a333df4e23161c5af68e84e37"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"96e4f81d5847efe56b073dece5e50bd674ae94ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d49f9517_ad4fd189","updated":"2022-07-13 05:20:15.000000000","message":"Thank you, looks good to me now!","commit_id":"d137a21cd8e5ff242c49c7c2becdff3a87eef41f"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"96e42530a9df4192af6058e74e2ebb1827f11a26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"86e377d3_9266d8c4","updated":"2022-07-14 05:41:32.000000000","message":"All concerns addressed and the zuul also obliged, no regression spotted, ninja approving the change, thank you!","commit_id":"8140abe6390818cea2419db31568b51177f44946"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2917fbdac8bf2334f3a85d54bf452169cb7e8f11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7c03c115_663c0094","updated":"2022-07-14 11:01:15.000000000","message":"recheck","commit_id":"8140abe6390818cea2419db31568b51177f44946"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4989cd0a7b9bd2f0bb8227efec3aac5eaaa08ef2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0d129f1e_5c79018d","updated":"2022-07-14 09:27:15.000000000","message":"recheck functional timeout","commit_id":"8140abe6390818cea2419db31568b51177f44946"}],"releasenotes/notes/remove_secure_proxy_ssl_header-2a95ad48ffa471ad.yaml":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a32512424e0c1b8ec1d4bb37d2467c47850b0ef5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Removed the deprecated \u0027secure_proxy_ssl_header\u0027 config option. Image import"},{"line_number":4,"context_line":"    will be always enabled from this release onwards as designed."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    As Glance relies on oslo.middleware for this feature, care needs to be taken"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"16c07159_b18da4a0","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":65},"updated":"2022-07-01 06:32:55.000000000","message":"I think prelude section should be added in last milestone otherwise it gives rendering issue.\n\nYou can use deprecations section to mention this.","commit_id":"5406c81a45e0c87a333df4e23161c5af68e84e37"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"96e42530a9df4192af6058e74e2ebb1827f11a26","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Removed the deprecated \u0027secure_proxy_ssl_header\u0027 config option. Image import"},{"line_number":4,"context_line":"    will be always enabled from this release onwards as designed."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    As Glance relies on oslo.middleware for this feature, care needs to be taken"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"36528470_7751cb79","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":65},"in_reply_to":"16c07159_b18da4a0","updated":"2022-07-14 05:41:32.000000000","message":"Done","commit_id":"5406c81a45e0c87a333df4e23161c5af68e84e37"},{"author":{"_account_id":19138,"name":"Pranali Deore","email":"pdeore@redhat.com","username":"PranaliD"},"change_message_id":"71b5541fd9e0146002fa1744fc9ef934483766f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Removed the deprecated \u0027secure_proxy_ssl_header\u0027 config option. Image import"},{"line_number":4,"context_line":"    will be always enabled from this release onwards as designed."},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    As Glance relies on oslo.middleware for this feature, care needs to be taken"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"eb02a673_853874e6","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":65},"in_reply_to":"16c07159_b18da4a0","updated":"2022-07-14 05:40:57.000000000","message":"Done","commit_id":"5406c81a45e0c87a333df4e23161c5af68e84e37"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b86d77761c21056a35eb406eb13c6dce88c9d2b3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the deprecated \u0027secure_proxy_ssl_header\u0027 config option. Image import"},{"line_number":5,"context_line":"    will be always enabled from this release onwards as designed."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    As Glance relies on oslo.middleware for this feature, care needs to be taken"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"16f4ed2d_7df6cc62","line":5,"range":{"start_line":4,"start_character":68,"end_line":5,"end_character":65},"updated":"2022-09-07 14:52:36.000000000","message":"(I just found this in release note and I know it\u0027s too late to comment this but ...)\n\nHow is the image import feature involved ? The change removes the logic to replace wsgi.url_scheme based on header but I could not find anything related to image import feature.","commit_id":"8140abe6390818cea2419db31568b51177f44946"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"0ce5fdddf359569bfd7d4fc8c8cb5124da02a935","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed the deprecated \u0027secure_proxy_ssl_header\u0027 config option. Image import"},{"line_number":5,"context_line":"    will be always enabled from this release onwards as designed."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    As Glance relies on oslo.middleware for this feature, care needs to be taken"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"049b9bae_97e60e14","line":5,"range":{"start_line":4,"start_character":68,"end_line":5,"end_character":65},"in_reply_to":"16f4ed2d_7df6cc62","updated":"2022-09-14 16:44:45.000000000","message":"Oops, I think I failed at copy/pasting here. I\u0027m not sure if I can modify the release note now.","commit_id":"8140abe6390818cea2419db31568b51177f44946"}]}