)]}'
{"glance/db/simple/api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ec6af8cecc65688f85cb3b3f1bbd065b912a9278","unresolved":false,"context_lines":[{"line_number":670,"context_line":"                                  delete_time\u003ddelete_time)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    for i, loc in enumerate(DATA[\u0027locations\u0027]):"},{"line_number":673,"context_line":"        if image_id \u003d\u003d loc[\u0027image_id\u0027] and loc[\u0027deleted\u0027] is False:"},{"line_number":674,"context_line":"            del DATA[\u0027locations\u0027][i]"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_1bbd7501","line":673,"range":{"start_line":673,"start_character":58,"end_line":673,"end_character":66},"updated":"2017-06-15 19:28:00.000000000","message":"[here and below]\n\nUnrelated changes.  But I like \u0027em.  But makes me want to change it to \"not loc[\u0027deleted\u0027]\".  But that makes me want to look around and make sure loc[\u0027deleted\u0027] can\u0027t legitimately be 0 or \u0027\u0027 or {} or []...","commit_id":"19f9e5b867385b53f5a98c9bfe2cf3ef91f80943"}],"glance/db/sqlalchemy/migrate_repo/versions/033_add_location_status.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"baa05e69fad85b35709f30f5e74c81421fb10b2b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # Set \u0027status\u0027 column initial value for image_locations table"},{"line_number":34,"context_line":"    mapping \u003d {\u0027active\u0027: \u0027active\u0027, \u0027pending_delete\u0027: \u0027pending_delete\u0027,"},{"line_number":35,"context_line":"               \u0027deleted\u0027: \u0027deleted\u0027, \u0027killed\u0027: \u0027deleted\u0027}"},{"line_number":36,"context_line":"    for src, dst in mapping.items():"},{"line_number":37,"context_line":"        subq \u003d sqlalchemy.sql.select([images_table.c.id]).where("},{"line_number":38,"context_line":"            images_table.c.status \u003d\u003d src)"},{"line_number":39,"context_line":"        image_locations_table.update(values\u003d{\u0027status\u0027: dst}).where("}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_81a2b999","line":36,"updated":"2017-05-30 09:30:02.000000000","message":"We had a discussion in community about not changing migration code due to refactoring reasons because it demonstrates updates or bugs  im migrartions to  users","commit_id":"126c27725f4c220c5072491ac9a1d2bcaf5727e1"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"f1d87e2272d2b96503db380201e1acedc9febabd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # Set \u0027status\u0027 column initial value for image_locations table"},{"line_number":34,"context_line":"    mapping \u003d {\u0027active\u0027: \u0027active\u0027, \u0027pending_delete\u0027: \u0027pending_delete\u0027,"},{"line_number":35,"context_line":"               \u0027deleted\u0027: \u0027deleted\u0027, \u0027killed\u0027: \u0027deleted\u0027}"},{"line_number":36,"context_line":"    for src, dst in mapping.items():"},{"line_number":37,"context_line":"        subq \u003d sqlalchemy.sql.select([images_table.c.id]).where("},{"line_number":38,"context_line":"            images_table.c.status \u003d\u003d src)"},{"line_number":39,"context_line":"        image_locations_table.update(values\u003d{\u0027status\u0027: dst}).where("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_3e681fb7","line":36,"updated":"2017-06-15 19:48:18.000000000","message":"I suppose you shouldn\u0027t change this file at all, because there was an agreement that we never change db migrations code (except of critical and security bugs). This is not the case.","commit_id":"19f9e5b867385b53f5a98c9bfe2cf3ef91f80943"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b56e1e34a4936459c3dc0700292c501f9a6a8f48","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # Set \u0027status\u0027 column initial value for image_locations table"},{"line_number":34,"context_line":"    mapping \u003d {\u0027active\u0027: \u0027active\u0027, \u0027pending_delete\u0027: \u0027pending_delete\u0027,"},{"line_number":35,"context_line":"               \u0027deleted\u0027: \u0027deleted\u0027, \u0027killed\u0027: \u0027deleted\u0027}"},{"line_number":36,"context_line":"    for src, dst in mapping.items():"},{"line_number":37,"context_line":"        subq \u003d sqlalchemy.sql.select([images_table.c.id]).where("},{"line_number":38,"context_line":"            images_table.c.status \u003d\u003d src)"},{"line_number":39,"context_line":"        image_locations_table.update(values\u003d{\u0027status\u0027: dst}).where("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_9e6a93ea","line":36,"in_reply_to":"7f231b9d_3e681fb7","updated":"2017-06-15 20:13:06.000000000","message":"Mike, is this because of the migration to alembic? Just trying to learn the current situation.","commit_id":"19f9e5b867385b53f5a98c9bfe2cf3ef91f80943"},{"author":{"_account_id":20401,"name":"M V P Nitesh","email":"parimalanitesh@gmail.com","username":"mvpnitesh"},"change_message_id":"9fb955ebde0c10e54492eb3210018362fd1aee60","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    # Set \u0027status\u0027 column initial value for image_locations table"},{"line_number":34,"context_line":"    mapping \u003d {\u0027active\u0027: \u0027active\u0027, \u0027pending_delete\u0027: \u0027pending_delete\u0027,"},{"line_number":35,"context_line":"               \u0027deleted\u0027: \u0027deleted\u0027, \u0027killed\u0027: \u0027deleted\u0027}"},{"line_number":36,"context_line":"    for src, dst in mapping.items():"},{"line_number":37,"context_line":"        subq \u003d sqlalchemy.sql.select([images_table.c.id]).where("},{"line_number":38,"context_line":"            images_table.c.status \u003d\u003d src)"},{"line_number":39,"context_line":"        image_locations_table.update(values\u003d{\u0027status\u0027: dst}).where("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f231b9d_64af197d","line":36,"in_reply_to":"7f231b9d_9e6a93ea","updated":"2017-06-16 06:59:05.000000000","message":"Hey Mike and Sean thanks for the review. Please let me know if i\u0027ve to  revert this change or not?","commit_id":"19f9e5b867385b53f5a98c9bfe2cf3ef91f80943"}],"glance/tests/functional/v2/test_images.py":[{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"841726eaf31e3f168e61a7039bc5029269699975","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_serialization import jsonutils"},{"line_number":21,"context_line":"import requests"},{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":"from six.moves import http_client as http"},{"line_number":24,"context_line":"# NOTE(jokke): simplified transition to py3, behaves like py2 xrange"},{"line_number":25,"context_line":"from six.moves import range"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_2a534e41","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":10},"updated":"2017-06-15 09:15:27.000000000","message":"F401 \u0027six\u0027 imported but unused","commit_id":"05bd0c868a076877f1817fc188686d86e8ddfdd8"}]}
