)]}'
{"glance/api/v1/upload_utils.py":[{"author":{"_account_id":9520,"name":"David Koo (koofoss)","email":"david.koo@huawei.com","username":"koofoss"},"change_message_id":"a59beddddcf46bb0dbba5570605559172de563b2","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        msg \u003d _(\"Attempt to upload duplicate image: %s\") % e"},{"line_number":168,"context_line":"        LOG.debug(msg)"},{"line_number":169,"context_line":"        safe_kill(req, image_id)"},{"line_number":170,"context_line":"        notifier.error(\u0027image.upload\u0027, {\"message\": msg})"},{"line_number":171,"context_line":"        raise webob.exc.HTTPConflict(explanation\u003dmsg,"},{"line_number":172,"context_line":"                                     request\u003dreq,"},{"line_number":173,"context_line":"                                     content_type\u003d\"text/plain\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9kj4%3D","line":170,"updated":"2013-12-10 04:25:17.000000000","message":"Why not define a private method to call the notifier since all the calls to notifier_error are practically identical?\n\ndef _ntf_error(self, msg_str):\n    self.notifier.error(\u0027image.upload\u0027, {\"message\": msg_str})","commit_id":"c2c69197730b01c797f1b886425a8c6d1e6b9d99"}],"glance/notifier.py":[{"author":{"_account_id":9520,"name":"David Koo (koofoss)","email":"david.koo@huawei.com","username":"koofoss"},"change_message_id":"a59beddddcf46bb0dbba5570605559172de563b2","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            self.image.set_data(data, size)"},{"line_number":223,"context_line":"        except exception.StorageFull as e:"},{"line_number":224,"context_line":"            msg \u003d (_(\"Image storage media is full: %s\") % e)"},{"line_number":225,"context_line":"            self.notifier.error(\u0027image.upload\u0027, {\"message\": msg})"},{"line_number":226,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003dmsg)"},{"line_number":227,"context_line":"        except exception.StorageWriteDenied as e:"},{"line_number":228,"context_line":"            msg \u003d (_(\"Insufficient permissions on image storage media: %s\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9kkE%3D","line":225,"updated":"2013-12-10 04:25:17.000000000","message":"Same as comment for glance/api/v1/upload_utils.py","commit_id":"c2c69197730b01c797f1b886425a8c6d1e6b9d99"}],"glance/notifier/__init__.py":[{"author":{"_account_id":7884,"name":"Noboru Arai","email":"arai@mxa.nes.nec.co.jp","username":"NoboruArai"},"change_message_id":"71dd241935cd0d54316ab45ae17d58596a885b4b","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    @staticmethod"},{"line_number":77,"context_line":"    def generate_message(event_type, priority, payload):"},{"line_number":78,"context_line":"        if not isinstance(payload, dict):"},{"line_number":79,"context_line":"            msg \u003d _(\"payload should be type: dict, found type: %s\")"},{"line_number":80,"context_line":"            raise TypeError(msg % type(payload))"},{"line_number":81,"context_line":"        return {"},{"line_number":82,"context_line":"            \"message_id\": str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2B9hg%3D","line":79,"updated":"2013-11-18 03:06:41.000000000","message":"little thing,\n\"type\" function output  \"\u003ctype XXX\u003e\" string.\nbecause \"type\" is duplicated in message, \"type:\" string my be unnecessary in this line.","commit_id":"fcd292ea24e396bdab9393a0fe6039eb906daba3"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"1db6eccdfa24311eb0fc9cc84c3f81f2190b8f00","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    @staticmethod"},{"line_number":77,"context_line":"    def generate_message(event_type, priority, payload):"},{"line_number":78,"context_line":"        if not isinstance(payload, dict):"},{"line_number":79,"context_line":"            msg \u003d _(\"payload should be type: dict, found type: %s\")"},{"line_number":80,"context_line":"            raise TypeError(msg % type(payload))"},{"line_number":81,"context_line":"        return {"},{"line_number":82,"context_line":"            \"message_id\": str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F94uE%3D","line":79,"in_reply_to":"AAAATn%2F%2B9hg%3D","updated":"2013-12-04 21:27:42.000000000","message":"It may be neater to do type(payload).__name__","commit_id":"fcd292ea24e396bdab9393a0fe6039eb906daba3"}]}