)]}'
{"glance/tests/functional/test_bin_glance.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"110778711293e08b86df4b493faeb5223c8779eb","unresolved":false,"context_lines":[{"line_number":488,"context_line":"        self.assertTrue(image_lines[1].startswith(\u0027Id: 3\u0027))"},{"line_number":489,"context_line":"        self.assertTrue(image_lines[11].startswith(\u0027Id: 1\u0027))"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        self.stop_servers()"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_results_sorting(self):"},{"line_number":494,"context_line":"        self.cleanup()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2F5A%3D","line":491,"updated":"2011-09-16 14:51:03.000000000","message":"Was the lack of this causing issues? I feel like it would be better to put this in tearDown() if it\u0027s going to be in every test, that way it can\u0027t be forgotten again.","commit_id":"d73be7be2591265891a8387d815a75b08df4123c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cb514561e5a3a856bac311e97ad402b1c1b8d6c0","unresolved":false,"context_lines":[{"line_number":488,"context_line":"        self.assertTrue(image_lines[1].startswith(\u0027Id: 3\u0027))"},{"line_number":489,"context_line":"        self.assertTrue(image_lines[11].startswith(\u0027Id: 1\u0027))"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        self.stop_servers()"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_results_sorting(self):"},{"line_number":494,"context_line":"        self.cleanup()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2F4w%3D","line":491,"in_reply_to":"AAAACX%2F%2F%2F5A%3D","updated":"2011-09-16 15:13:51.000000000","message":"Well, it\u0027d be more fair to say that the lack of this was causing distraction—it caused some test directories to be left around and made it more difficult to figure out which ones corresponded to my failing tests.  I agree that having it in setUp()/tearDown() would make more sense.  For that matter, I\u0027ve been working on a decorator-based system for test fixtures that would also make sense here...","commit_id":"d73be7be2591265891a8387d815a75b08df4123c"}],"glance/tests/functional/test_protected_properties.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"110778711293e08b86df4b493faeb5223c8779eb","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        manipulated by users."},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        self.cleanup()"},{"line_number":73,"context_line":"        self.start_servers()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # First, push an image up as non-admin"},{"line_number":76,"context_line":"        data1 \u003d self._push_image(keystone_utils.pattieblack_token,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2F48%3D","line":73,"updated":"2011-09-16 14:51:03.000000000","message":"Would it make sense to put cleanup() and start_servers in the setUp() and stop_servers() in tearDown? Also maybe the inserting of the first image could be setUp?","commit_id":"d73be7be2591265891a8387d815a75b08df4123c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cb514561e5a3a856bac311e97ad402b1c1b8d6c0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        manipulated by users."},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":"        self.cleanup()"},{"line_number":73,"context_line":"        self.start_servers()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        # First, push an image up as non-admin"},{"line_number":76,"context_line":"        data1 \u003d self._push_image(keystone_utils.pattieblack_token,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2F4s%3D","line":73,"in_reply_to":"AAAACX%2F%2F%2F48%3D","updated":"2011-09-16 15:13:51.000000000","message":"I don\u0027t think the inserting of the first image makes sense in setUp() for these tests.  For other tests of this type, perhaps, but it still feels wrong.  The start_servers()/stop_servers() being in setUp()/tearDown() maybe makes more sense...","commit_id":"d73be7be2591265891a8387d815a75b08df4123c"}]}