)]}'
{"glance/registry/api/v2/rpc.py":[{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"f044be515fccfa041cc6ecfb800dcc228734fc4f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        db_api.setup_db_env()"},{"line_number":51,"context_line":"        db_api_to_register \u003d db_api"},{"line_number":52,"context_line":"        if CONF.use_tpool:"},{"line_number":53,"context_line":"            db_api_to_register \u003d db_api.wrapped"},{"line_number":54,"context_line":"        self.register(db_api_to_register)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FxuQ%3D","line":53,"updated":"2013-09-19 14:43:43.000000000","message":"why not we wrap this whole logic into a method like unwrap() on db_api and just say self.register(db_api.unwrap()). In that way we can avoid rpc.py exposing impl details of db_api. Thoughts?","commit_id":"51ba6766478fdbc2ddb2b0abac4f1c275a082a4c"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2d90405ea6eb4efba947220b533418e4deff3f84","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        db_api.setup_db_env()"},{"line_number":51,"context_line":"        db_api_to_register \u003d db_api"},{"line_number":52,"context_line":"        if CONF.use_tpool:"},{"line_number":53,"context_line":"            db_api_to_register \u003d db_api.get_wrapped()"},{"line_number":54,"context_line":"        self.register(db_api_to_register)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2Fkak%3D","line":53,"updated":"2013-09-24 15:32:19.000000000","message":"Just had a discussion with Venkatesh and this nomenclature is quite confusing. To someone who is not aware of this story, it seems like we\u0027r getting the method wrapped from the perspective of ThreadPoolWrapper. It would really be great, if you could please move the method to db api.","commit_id":"3d5a30199919a87d1190d60036e7969691916e39"}]}