)]}'
{"glance/hacking/checks.py":[{"author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"change_message_id":"eacce60fd1c951eec3a07ec08a60f0f7b5673e03","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    register(assert_equal_none)"},{"line_number":190,"context_line":"    register(no_translate_debug_logs)"},{"line_number":191,"context_line":"    register(no_direct_use_of_unicode_function)"},{"line_number":192,"context_line":"    # register(validate_log_translations)"},{"line_number":193,"context_line":"    register(check_no_contextlib_nested)"},{"line_number":194,"context_line":"    register(dict_constructor_with_list_copy)"},{"line_number":195,"context_line":"    register(check_python3_xrange)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_b66ce708","line":192,"range":{"start_line":192,"start_character":41,"end_line":192,"end_character":41},"updated":"2017-05-15 09:05:34.000000000","message":"shouldn\u0027t the check be removed instead?","commit_id":"48300e8a773f577e44b4b5db2998c16354f2bed7"},{"author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"change_message_id":"b9a1aac3b29a49e844ef17081c5bf222fde8afee","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    register(assert_equal_none)"},{"line_number":190,"context_line":"    register(no_translate_debug_logs)"},{"line_number":191,"context_line":"    register(no_direct_use_of_unicode_function)"},{"line_number":192,"context_line":"    # register(validate_log_translations)"},{"line_number":193,"context_line":"    register(check_no_contextlib_nested)"},{"line_number":194,"context_line":"    register(dict_constructor_with_list_copy)"},{"line_number":195,"context_line":"    register(check_python3_xrange)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_99823c4f","line":192,"range":{"start_line":192,"start_character":41,"end_line":192,"end_character":41},"in_reply_to":"1f013ff3_793bf0d0","updated":"2017-05-15 09:14:15.000000000","message":"Sorry, did not see that. Lgtm then. :)","commit_id":"48300e8a773f577e44b4b5db2998c16354f2bed7"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"2b7ed16ecc478bfab28e7d7300085a8fa8a5e844","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    register(assert_equal_none)"},{"line_number":190,"context_line":"    register(no_translate_debug_logs)"},{"line_number":191,"context_line":"    register(no_direct_use_of_unicode_function)"},{"line_number":192,"context_line":"    # register(validate_log_translations)"},{"line_number":193,"context_line":"    register(check_no_contextlib_nested)"},{"line_number":194,"context_line":"    register(dict_constructor_with_list_copy)"},{"line_number":195,"context_line":"    register(check_python3_xrange)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f013ff3_793bf0d0","line":192,"range":{"start_line":192,"start_character":41,"end_line":192,"end_character":41},"in_reply_to":"1f013ff3_b66ce708","updated":"2017-05-15 09:12:08.000000000","message":"Remove at 2nd commit: https://review.openstack.org/#/c/464536/","commit_id":"48300e8a773f577e44b4b5db2998c16354f2bed7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a4e07ebdda616ee1c64bfb8746d0449a3d1e94a7","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               \"sentences not allowed\")"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def no_translate_debug_logs(logical_line, filename):"},{"line_number":78,"context_line":"    dirs \u003d ["},{"line_number":79,"context_line":"        \"glance/api\","},{"line_number":80,"context_line":"        \"glance/cmd\","}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_e412adb4","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":27},"updated":"2017-06-20 12:12:37.000000000","message":"shall we change this hacking rule to prevent translating other levels as well?","commit_id":"372af03e06e428e5921c1435c2f2c17ea3b43be2"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"14b907d112cee283394beaa50d5196a806bbd746","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               \"sentences not allowed\")"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def no_translate_debug_logs(logical_line, filename):"},{"line_number":78,"context_line":"    dirs \u003d ["},{"line_number":79,"context_line":"        \"glance/api\","},{"line_number":80,"context_line":"        \"glance/cmd\","}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_97d6964f","line":77,"range":{"start_line":77,"start_character":4,"end_line":77,"end_character":27},"in_reply_to":"7f231b9d_e412adb4","updated":"2017-06-21 01:17:51.000000000","message":"We can not add rules for other log levels because we just make log functions as no-op but still keep its invocations.","commit_id":"372af03e06e428e5921c1435c2f2c17ea3b43be2"}],"glance/i18n.py":[{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"df1682347e587765575c1da3eeba6d12d6e23c52","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# The primary translation function using the well-known name \"_\""},{"line_number":21,"context_line":"_ \u003d _translators.primary"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def _LI(msg):"},{"line_number":25,"context_line":"    return msg"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_604a0928","line":23,"updated":"2017-06-21 08:28:20.000000000","message":"It will be great if you leave a comment here for convenience of future developers, why these functions look like that. I think copy-paste from commit message is okay.","commit_id":"372af03e06e428e5921c1435c2f2c17ea3b43be2"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"502b11e154a1ebae0114552bd610db7943a96b29","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# The primary translation function using the well-known name \"_\""},{"line_number":21,"context_line":"_ \u003d _translators.primary"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"def _LI(msg):"},{"line_number":25,"context_line":"    return msg"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_fb724c11","line":23,"in_reply_to":"5f201791_604a0928","updated":"2017-06-21 09:17:49.000000000","message":"Done","commit_id":"372af03e06e428e5921c1435c2f2c17ea3b43be2"}]}