)]}'
{"glance/api/middleware/context.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"811c7b717dc6225bf19ac6b54359233c6c8dbd0a","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        ctxt.roles \u003d [r.lower() for r in ctxt.roles]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if CONF.admin_role.strip().lower() in ctxt.roles:"},{"line_number":196,"context_line":"            ctxt.is_admin \u003d True"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        return ctxt"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_a25aa27f","side":"PARENT","line":196,"updated":"2017-05-24 21:27:27.000000000","message":"context.is_admin is checked throughout the glance code. You can\u0027t stop setting that until/unless all of those places are updated to no longer need it.","commit_id":"cfc2f92780b902aac3c5e33603a703f5ca656f71"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"aa23b46409da239b7d6292f3efda1662a76e6d30","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        ctxt.roles \u003d [r.lower() for r in ctxt.roles]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        if CONF.admin_role.strip().lower() in ctxt.roles:"},{"line_number":196,"context_line":"            ctxt.is_admin \u003d True"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        return ctxt"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_487be726","side":"PARENT","line":196,"in_reply_to":"ff0f0b1f_a25aa27f","updated":"2017-05-24 22:26:19.000000000","message":"This line only overrides the setting in [0].  Removing this line does not mean ctxt.is_admin is not unset and should not cause failures in other places that reference it.\n\n[0] https://github.com/openstack/glance/blob/master/glance/context.py#L35-L36","commit_id":"cfc2f92780b902aac3c5e33603a703f5ca656f71"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"811c7b717dc6225bf19ac6b54359233c6c8dbd0a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt("},{"line_number":49,"context_line":"        \u0027admin_role\u0027, default\u003d\u0027admin\u0027,"},{"line_number":50,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":51,"context_line":"        deprecated_reason\u003d_(\u0027Use policy instead to define admin access \u0027"},{"line_number":52,"context_line":"                            \u0027rather than redefining this via config.\u0027),"},{"line_number":53,"context_line":"        deprecated_since\u003d\u0027Pike\u0027,"},{"line_number":54,"context_line":"        help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_a2e8627b","line":51,"updated":"2017-05-24 21:27:27.000000000","message":"this isn\u0027t about using policy or not using policy. It\u0027s about whether the name of your admin role has to be \"admin\". This config option gives you the ability to call your admin role something else if you so choose (e.g. \"Administrator\"). Removing that is a take-away for operators. Have we done any polling to see if they will care?","commit_id":"670b94131c4a3da9d99a90f5fecf91705d6da378"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"aa23b46409da239b7d6292f3efda1662a76e6d30","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.StrOpt("},{"line_number":49,"context_line":"        \u0027admin_role\u0027, default\u003d\u0027admin\u0027,"},{"line_number":50,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":51,"context_line":"        deprecated_reason\u003d_(\u0027Use policy instead to define admin access \u0027"},{"line_number":52,"context_line":"                            \u0027rather than redefining this via config.\u0027),"},{"line_number":53,"context_line":"        deprecated_since\u003d\u0027Pike\u0027,"},{"line_number":54,"context_line":"        help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_6876ab72","line":51,"in_reply_to":"ff0f0b1f_a2e8627b","updated":"2017-05-24 22:26:19.000000000","message":"This msg will be revised in future patch set","commit_id":"670b94131c4a3da9d99a90f5fecf91705d6da378"}],"glance/scrubber.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"811c7b717dc6225bf19ac6b54359233c6c8dbd0a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    cfg.StrOpt("},{"line_number":113,"context_line":"        \u0027admin_role\u0027, default\u003d\u0027admin\u0027,"},{"line_number":114,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":115,"context_line":"        deprecated_reason\u003d_(\u0027Use policy instead to define admin access \u0027"},{"line_number":116,"context_line":"                            \u0027rather than redefining this via config.\u0027),"},{"line_number":117,"context_line":"        deprecated_since\u003d\u0027Pike\u0027,"},{"line_number":118,"context_line":"        help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_6206ca54","line":115,"updated":"2017-05-24 21:27:27.000000000","message":"same comment here as in the middleware","commit_id":"670b94131c4a3da9d99a90f5fecf91705d6da378"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"aa23b46409da239b7d6292f3efda1662a76e6d30","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    cfg.StrOpt("},{"line_number":113,"context_line":"        \u0027admin_role\u0027, default\u003d\u0027admin\u0027,"},{"line_number":114,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":115,"context_line":"        deprecated_reason\u003d_(\u0027Use policy instead to define admin access \u0027"},{"line_number":116,"context_line":"                            \u0027rather than redefining this via config.\u0027),"},{"line_number":117,"context_line":"        deprecated_since\u003d\u0027Pike\u0027,"},{"line_number":118,"context_line":"        help\u003d_(\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_8810df01","line":115,"in_reply_to":"ff0f0b1f_6206ca54","updated":"2017-05-24 22:26:19.000000000","message":"This will be reworded in future patchset.","commit_id":"670b94131c4a3da9d99a90f5fecf91705d6da378"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"811c7b717dc6225bf19ac6b54359233c6c8dbd0a","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            self.admin_context \u003d context.RequestContext(user\u003dadmin_user,"},{"line_number":237,"context_line":"                                                        tenant\u003dadmin_tenant,"},{"line_number":238,"context_line":"                                                        auth_token\u003dNone,"},{"line_number":239,"context_line":"                                                        roles\u003d[\u0027admin\u0027])"},{"line_number":240,"context_line":"            self.registry \u003d registry.get_registry_client(self.admin_context)"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            ctxt \u003d context.RequestContext()"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_22aa1218","line":239,"updated":"2017-05-24 21:27:27.000000000","message":"why do we need to hardcode the name of the admin role? What harm is the current config option causing?","commit_id":"670b94131c4a3da9d99a90f5fecf91705d6da378"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"a9ecb5b81ed6a51874933aa90d565b18ecb7b5c6","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            self.admin_context \u003d context.RequestContext(user\u003dadmin_user,"},{"line_number":237,"context_line":"                                                        tenant\u003dadmin_tenant,"},{"line_number":238,"context_line":"                                                        auth_token\u003dNone,"},{"line_number":239,"context_line":"                                                        roles\u003d[\u0027admin\u0027])"},{"line_number":240,"context_line":"            self.registry \u003d registry.get_registry_client(self.admin_context)"},{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            ctxt \u003d context.RequestContext()"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_a05c854b","line":239,"in_reply_to":"ff0f0b1f_22aa1218","updated":"2017-05-30 20:25:37.000000000","message":"This config option is kinda weird, does each service do this or is this something exclusive to glance?","commit_id":"670b94131c4a3da9d99a90f5fecf91705d6da378"}]}