)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0f1a1117f6d6f82438baa43b6463f2a24d89e2d0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     DamonLi \u003cdamonl@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-20 13:59:13 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add linked clone option in glance metadata"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The glance must upload the VMDK file from Glance to ESXi datastore when the"},{"line_number":10,"context_line":"image does not exist in VMware environment. To optimize this process, the VMDK"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_8389aa75","line":7,"updated":"2017-11-29 22:24:36.000000000","message":"This would be more accurate: Add img_linked_clone to compute vmware metadefs","commit_id":"984036bc4edf873d302eae593d1ed4b442548db4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0f1a1117f6d6f82438baa43b6463f2a24d89e2d0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"However, if we create VMs on another datastore, the cached VMDK file must be"},{"line_number":13,"context_line":"copied from the cache location to the target datastore. In order to avoid"},{"line_number":14,"context_line":"this, we add linked clone option in glance metedata. If set this option to"},{"line_number":15,"context_line":"true, we can avoid this copy operation."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I27cd33b9b9593de61a6558879d337685ebd6f734"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_633906a2","line":15,"updated":"2017-11-29 22:24:36.000000000","message":"Instead of repeating the docstring for the property here, it would be good to document that this image property is in fact used by nova, so it\u0027s clear to readers why you\u0027re adding it.  So something like:\n\nThe nova vmware compute driver checks images for the \u0027img_linked_clone\u0027 property at boot time, but that property is missing from the OS::Compute::VMware metadefs.  This patch adds the property.","commit_id":"984036bc4edf873d302eae593d1ed4b442548db4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0f1a1117f6d6f82438baa43b6463f2a24d89e2d0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"copied from the cache location to the target datastore. In order to avoid"},{"line_number":14,"context_line":"this, we add linked clone option in glance metedata. If set this option to"},{"line_number":15,"context_line":"true, we can avoid this copy operation."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I27cd33b9b9593de61a6558879d337685ebd6f734"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_e34c3643","line":16,"updated":"2017-11-29 22:24:36.000000000","message":"Also add a line here:\n\nDocImpact: add to metadefs release note","commit_id":"984036bc4edf873d302eae593d1ed4b442548db4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9ee8e541eb3270f780dd91452e7ee606a26a3b86","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nova vmware driver checks images for the \u0027img_linked_clone\u0027"},{"line_number":10,"context_line":"property at boot time, but that property is missing in"},{"line_number":11,"context_line":"OS::Compute::VMware metadefs. This patch adds \u0027img_linked_clone\u0027 property."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact: add to metadefs release note"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f93b717_8857cdca","line":11,"updated":"2018-01-31 14:57:23.000000000","message":"I think it\u0027s worth adding a paragraph here saying why there\u0027s no default value specified, something like:\n\nNo default value is specified for this property because the default behavior in a particular cloud depends on the nova configuration setting \u0027vmware.use_linked_clone\u0027.","commit_id":"eda73e539b1e2ff6ec424d1f36278357c14946ca"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"2fdd5b75a5e2a95d7d2368bd6aa334d5594040c0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The nova vmware driver checks images for the \u0027img_linked_clone\u0027"},{"line_number":10,"context_line":"property at boot time, but that property is missing in"},{"line_number":11,"context_line":"OS::Compute::VMware metadefs. This patch adds \u0027img_linked_clone\u0027 property."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact: add to metadefs release note"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f93b717_9915d342","line":11,"in_reply_to":"5f93b717_8857cdca","updated":"2018-02-01 02:31:54.000000000","message":"Thanks Brian. I will do it right now.","commit_id":"eda73e539b1e2ff6ec424d1f36278357c14946ca"}],"etc/metadefs/compute-vmware.json":[{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"2027287f9318aa6aa54239d491f04be895f3bb5a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"properties\": {"},{"line_number":13,"context_line":"        \"img_linked_clone\":{"},{"line_number":14,"context_line":"            \"title\": \"Linked Clone\","},{"line_number":15,"context_line":"            \"description\": \"The glance must upload the VMDK file from Glance to ESXi datastore when the image does not exist in VMware environment. To optimize this process, the VMDK file is cached on a datastore when the file is used for the first time. However, if we create VMs on another datastore, the cached VMDK file must be copied from the cache location to the target datastore. If set this option to true, we can avoid this copy operation.\","},{"line_number":16,"context_line":"            \"type\": \"boolean\","},{"line_number":17,"context_line":"            \"default\": true"},{"line_number":18,"context_line":"        },"}],"source_content_type":"application/json","patch_set":2,"id":"7f231b9d_a5ab73d4","line":15,"range":{"start_line":15,"start_character":28,"end_line":15,"end_character":38},"updated":"2017-06-12 17:55:59.000000000","message":"Don\u0027t need \u0027The\u0027. Just \"Glance must upload...\"","commit_id":"2d71446637569d74df96ffc537b28a2914d1b098"},{"author":{"_account_id":23140,"name":"Jess Egler","email":"jess.egler@gmail.com","username":"jessegler"},"change_message_id":"2027287f9318aa6aa54239d491f04be895f3bb5a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"properties\": {"},{"line_number":13,"context_line":"        \"img_linked_clone\":{"},{"line_number":14,"context_line":"            \"title\": \"Linked Clone\","},{"line_number":15,"context_line":"            \"description\": \"The glance must upload the VMDK file from Glance to ESXi datastore when the image does not exist in VMware environment. To optimize this process, the VMDK file is cached on a datastore when the file is used for the first time. However, if we create VMs on another datastore, the cached VMDK file must be copied from the cache location to the target datastore. If set this option to true, we can avoid this copy operation.\","},{"line_number":16,"context_line":"            \"type\": \"boolean\","},{"line_number":17,"context_line":"            \"default\": true"},{"line_number":18,"context_line":"        },"}],"source_content_type":"application/json","patch_set":2,"id":"7f231b9d_25a083f4","line":15,"range":{"start_line":15,"start_character":391,"end_line":15,"end_character":406},"updated":"2017-06-12 17:55:59.000000000","message":"this option is set","commit_id":"2d71446637569d74df96ffc537b28a2914d1b098"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"9a36732c7e7c93036ce3960c655052f7a1fda83f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"properties\": {"},{"line_number":13,"context_line":"        \"img_linked_clone\":{"},{"line_number":14,"context_line":"            \"title\": \"Linked Clone\","},{"line_number":15,"context_line":"            \"description\": \"The glance must upload the VMDK file from Glance to ESXi datastore when the image does not exist in VMware environment. To optimize this process, the VMDK file is cached on a datastore when the file is used for the first time. However, if we create VMs on another datastore, the cached VMDK file must be copied from the cache location to the target datastore. If set this option to true, we can avoid this copy operation.\","},{"line_number":16,"context_line":"            \"type\": \"boolean\","},{"line_number":17,"context_line":"            \"default\": true"},{"line_number":18,"context_line":"        },"}],"source_content_type":"application/json","patch_set":2,"id":"7f231b9d_f8458944","line":15,"range":{"start_line":15,"start_character":391,"end_line":15,"end_character":406},"in_reply_to":"7f231b9d_25a083f4","updated":"2017-11-30 07:08:29.000000000","message":"Done","commit_id":"2d71446637569d74df96ffc537b28a2914d1b098"},{"author":{"_account_id":22078,"name":"Damon Li","email":"likailichee@gmail.com","username":"likai"},"change_message_id":"9a36732c7e7c93036ce3960c655052f7a1fda83f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"properties\": {"},{"line_number":13,"context_line":"        \"img_linked_clone\":{"},{"line_number":14,"context_line":"            \"title\": \"Linked Clone\","},{"line_number":15,"context_line":"            \"description\": \"The glance must upload the VMDK file from Glance to ESXi datastore when the image does not exist in VMware environment. To optimize this process, the VMDK file is cached on a datastore when the file is used for the first time. However, if we create VMs on another datastore, the cached VMDK file must be copied from the cache location to the target datastore. If set this option to true, we can avoid this copy operation.\","},{"line_number":16,"context_line":"            \"type\": \"boolean\","},{"line_number":17,"context_line":"            \"default\": true"},{"line_number":18,"context_line":"        },"}],"source_content_type":"application/json","patch_set":2,"id":"7f231b9d_9870d5a7","line":15,"range":{"start_line":15,"start_character":28,"end_line":15,"end_character":38},"in_reply_to":"7f231b9d_a5ab73d4","updated":"2017-11-30 07:08:29.000000000","message":"Done","commit_id":"2d71446637569d74df96ffc537b28a2914d1b098"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0f1a1117f6d6f82438baa43b6463f2a24d89e2d0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"properties\": {"},{"line_number":13,"context_line":"        \"img_linked_clone\":{"},{"line_number":14,"context_line":"            \"title\": \"Linked Clone\","},{"line_number":15,"context_line":"            \"description\": \"The glance must upload the VMDK file from Glance to ESXi datastore when the image does not exist in VMware environment. To optimize this process, the VMDK file is cached on a datastore when the file is used for the first time. However, if we create VMs on another datastore, the cached VMDK file must be copied from the cache location to the target datastore. If set this option to true, we can avoid this copy operation.\","},{"line_number":16,"context_line":"            \"type\": \"boolean\","},{"line_number":17,"context_line":"            \"default\": true"},{"line_number":18,"context_line":"        },"}],"source_content_type":"application/json","patch_set":4,"id":"ff82abbf_c8003105","line":15,"updated":"2017-11-29 22:24:36.000000000","message":"This doesn\u0027t seem to be an accurate description of what this property does.  Looking at [0] and [1], this would be more accurate:\n\n\"description\": \"By default, the VMware compute driver creates linked clones when possible (though this can be turned off by the operator). You can use this image property on a per-image basis to control whether virtual machines booted from the image are treated as full clones (value: false) or linked clones (value: true). Please refer to VMware documentation for information about full vs. linked clones.\"\n\n[0] https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-vmware.html#image-handling\n\n[1] https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-vmware.html#configuration-reference","commit_id":"984036bc4edf873d302eae593d1ed4b442548db4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0f1a1117f6d6f82438baa43b6463f2a24d89e2d0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"            \"title\": \"Linked Clone\","},{"line_number":15,"context_line":"            \"description\": \"The glance must upload the VMDK file from Glance to ESXi datastore when the image does not exist in VMware environment. To optimize this process, the VMDK file is cached on a datastore when the file is used for the first time. However, if we create VMs on another datastore, the cached VMDK file must be copied from the cache location to the target datastore. If set this option to true, we can avoid this copy operation.\","},{"line_number":16,"context_line":"            \"type\": \"boolean\","},{"line_number":17,"context_line":"            \"default\": true"},{"line_number":18,"context_line":"        },"},{"line_number":19,"context_line":"        \"vmware_adaptertype\": {"},{"line_number":20,"context_line":"            \"title\": \"Disk Adapter Type\","}],"source_content_type":"application/json","patch_set":4,"id":"ff82abbf_e36bd6b3","line":17,"updated":"2017-11-29 22:24:36.000000000","message":"Is this correct? What happens when the property is missing depends on how nova has been configured.  See https://github.com/openstack/nova/blob/7e2d8cb89b68d136c7bc3dd2eae18b5269fcefbd/nova/virt/vmwareapi/images.py#L130","commit_id":"984036bc4edf873d302eae593d1ed4b442548db4"}]}