)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d6915ca9bcc83866c471a98209564fe68ab556f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces uuid.uuid4 with uuidutils.generate_uuid()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack common has a wrapper for generating uuids.We should"},{"line_number":10,"context_line":"use that function when generating uuids for consistency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0ecab42cd0dec472792b2f6a2e1e178cfb5f9be6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f1d235d_22ff6bab","line":9,"range":{"start_line":9,"start_character":52,"end_line":9,"end_character":54},"updated":"2017-06-30 06:08:15.000000000","message":"add a space before","commit_id":"5571f985432790c7dc5d222d7e788e88fbf6b651"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d6915ca9bcc83866c471a98209564fe68ab556f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces uuid.uuid4 with uuidutils.generate_uuid()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack common has a wrapper for generating uuids.We should"},{"line_number":10,"context_line":"use that function when generating uuids for consistency."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I0ecab42cd0dec472792b2f6a2e1e178cfb5f9be6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f1d235d_62f563cb","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":17},"updated":"2017-06-30 06:08:15.000000000","message":"library, oslo_utils","commit_id":"5571f985432790c7dc5d222d7e788e88fbf6b651"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"513b60fd6ad9622861c731154cb08fae64a34d46","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replaces uuid.uuid4 with uuidutils.generate_uuid()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack oslo_utils has a generate_uuid function for generating"},{"line_number":10,"context_line":"uuids. We should use that function when generating uuids for"},{"line_number":11,"context_line":"consistency."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0ecab42cd0dec472792b2f6a2e1e178cfb5f9be6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1f1a1f67_3aff7035","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":12},"updated":"2017-07-13 22:30:14.000000000","message":"Python stdlib has also these really handy uuid functions we\u0027re using very consistently across our code base. I do not see value of using oslo lib just for the sake of using oslo lib.","commit_id":"81fc22523c51c9c71070b22afc10c0f67559dc23"}],"glance/db/sqlalchemy/migrate_repo/versions/012_id_to_uuid.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d6915ca9bcc83866c471a98209564fe68ab556f6","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import migrate"},{"line_number":26,"context_line":"import sqlalchemy"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"and_ \u003d sqlalchemy.and_"},{"line_number":30,"context_line":"or_ \u003d sqlalchemy.or_"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_82e63f16","side":"PARENT","line":27,"updated":"2017-06-30 06:08:15.000000000","message":"this change is unrelated","commit_id":"ffc84dec67e9e629cd3b351f365d7b7c8694f721"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff188e61972608f3977f4b83c492e0cc0dae2a8e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import migrate"},{"line_number":25,"context_line":"import sqlalchemy"},{"line_number":26,"context_line":"from oslo_utils import uuidutils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"and_ \u003d sqlalchemy.and_"},{"line_number":29,"context_line":"or_ \u003d sqlalchemy.or_"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_5428d384","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":32},"updated":"2017-06-30 14:28:18.000000000","message":"this should be imported before line #25 to avoid pep8 error","commit_id":"d97cba12490f1c363a8946f0bd142ff6f09f0ec7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff188e61972608f3977f4b83c492e0cc0dae2a8e","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        t_images.update().where("},{"line_number":311,"context_line":"            t_images.c.id \u003d\u003d old_id).values(id\u003dnew_id).execute()"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        t_image_members.update().where(t_image_members.c.image_id \u003d\u003d old_id)."},{"line_number":314,"context_line":"        values(image_id\u003dnew_id).execute()"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        t_image_properties.update().where(t_image_properties.c."},{"line_number":317,"context_line":"                                          image_id \u003d\u003d old_id).values("},{"line_number":318,"context_line":"            image_id\u003dnew_id).execute()"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        t_image_properties.update().where("}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_b43de7bc","line":317,"range":{"start_line":313,"start_character":8,"end_line":317,"end_character":69},"updated":"2017-06-30 14:28:18.000000000","message":"revert these unrelated changes","commit_id":"d97cba12490f1c363a8946f0bd142ff6f09f0ec7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff188e61972608f3977f4b83c492e0cc0dae2a8e","unresolved":false,"context_lines":[{"line_number":321,"context_line":"            and_(or_(t_image_properties.c.name \u003d\u003d \u0027kernel_id\u0027,"},{"line_number":322,"context_line":"                     t_image_properties.c.name \u003d\u003d \u0027ramdisk_id\u0027),"},{"line_number":323,"context_line":"                 t_image_properties.c.value \u003d\u003d old_id)).values("},{"line_number":324,"context_line":"            value\u003dnew_id).execute()"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"def _update_all_uuids_to_ids(t_images, t_image_members, t_image_properties):"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_f4747f9b","line":324,"range":{"start_line":324,"start_character":12,"end_line":324,"end_character":35},"updated":"2017-06-30 14:28:18.000000000","message":"revert this change as well","commit_id":"d97cba12490f1c363a8946f0bd142ff6f09f0ec7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff188e61972608f3977f4b83c492e0cc0dae2a8e","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            id\u003dstr(new_id)).execute()"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        t_image_members.update().where(t_image_members.c.image_id \u003d\u003d old_id)."},{"line_number":339,"context_line":"        values(image_id\u003dstr(new_id)).execute()"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        t_image_properties.update().where(t_image_properties.c."},{"line_number":342,"context_line":"                                          image_id \u003d\u003d old_id).values("},{"line_number":343,"context_line":"            image_id\u003dstr(new_id)).execute()"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        t_image_properties.update().where("},{"line_number":346,"context_line":"            and_(or_(t_image_properties.c.name \u003d\u003d \u0027kernel_id\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_549b33c8","line":343,"range":{"start_line":339,"start_character":8,"end_line":343,"end_character":43},"updated":"2017-06-30 14:28:18.000000000","message":"revert these unrelated changes","commit_id":"d97cba12490f1c363a8946f0bd142ff6f09f0ec7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff188e61972608f3977f4b83c492e0cc0dae2a8e","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            and_(or_(t_image_properties.c.name \u003d\u003d \u0027kernel_id\u0027,"},{"line_number":347,"context_line":"                     t_image_properties.c.name \u003d\u003d \u0027ramdisk_id\u0027),"},{"line_number":348,"context_line":"                 t_image_properties.c.value \u003d\u003d old_id)).values("},{"line_number":349,"context_line":"            value\u003dstr(new_id)).execute()"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        new_id +\u003d 1"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_5484535e","line":349,"range":{"start_line":349,"start_character":12,"end_line":349,"end_character":40},"updated":"2017-06-30 14:28:18.000000000","message":"revert this change as well","commit_id":"d97cba12490f1c363a8946f0bd142ff6f09f0ec7"}],"glance/tests/functional/db/base.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d6915ca9bcc83866c471a98209564fe68ab556f6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.assertEqual(create_time, image[\u0027updated_at\u0027])"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # Image IDs aren\u0027t predictable, but they should be populated"},{"line_number":180,"context_line":"        self.assertTrue(uuid.UUID(image[\u0027id\u0027]))"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # NOTE(bcwaldon): the tags attribute should not be returned as a part"},{"line_number":183,"context_line":"        # of a core image entity"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_a2b6dbd8","line":180,"range":{"start_line":180,"start_character":24,"end_line":180,"end_character":33},"updated":"2017-06-30 06:08:15.000000000","message":"instead of this can we use is_uuid_like method of uuidutils?","commit_id":"5571f985432790c7dc5d222d7e788e88fbf6b651"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b3c05582d686f0414a192f8cfea824ff20cd10af","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from oslo_db import exception as db_exception"},{"line_number":23,"context_line":"from oslo_db.sqlalchemy import utils as sqlalchemyutils"},{"line_number":24,"context_line":"from oslo_utils import uuidutils"},{"line_number":25,"context_line":"import uuid"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# NOTE(jokke): simplified transition to py3, behaves like py2 xrange"},{"line_number":28,"context_line":"from six.moves import range"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_d8ed4626","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":11},"updated":"2017-06-30 07:09:25.000000000","message":"as per my comment on previous patch line #180 can we use is_uuid_like method of uuidutils to get rid of uuid module, else uuid is a inbuilt module and should be imported after line #19\n\nMy take is we should use is_uuid_like method.","commit_id":"f80e419cf573032cc3250bb0a248fc18b9c91c1e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff188e61972608f3977f4b83c492e0cc0dae2a8e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        self.assertEqual(create_time, image[\u0027updated_at\u0027])"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # Image IDs aren\u0027t predictable, but they should be populated"},{"line_number":178,"context_line":"        self.assertTrue(uuid.UUID(image[\u0027id\u0027]))"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # NOTE(bcwaldon): the tags attribute should not be returned as a part"},{"line_number":181,"context_line":"        # of a core image entity"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_b4f5e7cd","line":178,"range":{"start_line":178,"start_character":24,"end_line":178,"end_character":46},"updated":"2017-06-30 14:28:18.000000000","message":"change it to uuidutils.is_uuid_like(image[\u0027id\u0027]) which will fix failing tests for python2 and 3","commit_id":"d97cba12490f1c363a8946f0bd142ff6f09f0ec7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff188e61972608f3977f4b83c492e0cc0dae2a8e","unresolved":false,"context_lines":[{"line_number":2012,"context_line":"            engine, \"image_tags\")"},{"line_number":2013,"context_line":""},{"line_number":2014,"context_line":"        # Add a 4th row in images table and set it deleted 15 days ago"},{"line_number":2015,"context_line":"        uuidstr \u003d uuidutils.generate_uuid().hex"},{"line_number":2016,"context_line":"        created_time \u003d timeutils.utcnow() - datetime.timedelta(days\u003d20)"},{"line_number":2017,"context_line":"        deleted_time \u003d created_time + datetime.timedelta(days\u003d5)"},{"line_number":2018,"context_line":"        images_row_fixture \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_94c9cb79","line":2015,"range":{"start_line":2015,"start_character":18,"end_line":2015,"end_character":47},"updated":"2017-06-30 14:28:18.000000000","message":"no need to call .hex property here as uuidutils.generate_uuid() method returns uuid in hex format.\n\nhttps://github.com/openstack/oslo.utils/blob/master/oslo_utils/uuidutils.py#L34","commit_id":"d97cba12490f1c363a8946f0bd142ff6f09f0ec7"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"887ca8b293134353e121d2350b678c546801617f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        self.assertEqual(create_time, image[\u0027updated_at\u0027])"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        # Image IDs aren\u0027t predictable, but they should be populated"},{"line_number":178,"context_line":"        self.assertTrue(uuidutils.is_uuid_like(image[\u0027id\u0027]))"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        # NOTE(bcwaldon): the tags attribute should not be returned as a part"},{"line_number":181,"context_line":"        # of a core image entity"}],"source_content_type":"text/x-python","patch_set":16,"id":"1f1a1f67_75ed008a","line":178,"updated":"2017-07-13 20:02:48.000000000","message":"Previous code was strange :) Because if image[\u0027id\u0027] is not uuid, then it will raise ValueError, or return UUID object otherwise. In other words self.assertTrue was not required there at all!\n\nThank you for fixing this.","commit_id":"81fc22523c51c9c71070b22afc10c0f67559dc23"}],"glance/tests/unit/async/flows/test_convert.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff188e61972608f3977f4b83c492e0cc0dae2a8e","unresolved":false,"context_lines":[{"line_number":159,"context_line":"                    \"format-specific\": {"},{"line_number":160,"context_line":"                        \"type\": \"qcow2\","},{"line_number":161,"context_line":"                        \"data\": {"},{"line_number":162,"context_line":"                                 \"compat\": \"0.10\""},{"line_number":163,"context_line":"                                }"},{"line_number":164,"context_line":"                                       },"},{"line_number":165,"context_line":"                    \"dirty-flag\": False"},{"line_number":166,"context_line":"                                  }), None)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"            open(\"%s.converted\" % image_path, \u0027a\u0027).close()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_74bcef04","line":165,"range":{"start_line":162,"start_character":28,"end_line":165,"end_character":35},"updated":"2017-06-30 14:28:18.000000000","message":"revert this unrelated change","commit_id":"d97cba12490f1c363a8946f0bd142ff6f09f0ec7"}],"glance/tests/unit/test_domain.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff188e61972608f3977f4b83c492e0cc0dae2a8e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_utils import uuidutils"},{"line_number":22,"context_line":"import oslo_utils.importutils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import glance.async"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_14cc9bba","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":31},"updated":"2017-06-30 14:28:18.000000000","message":"this should be imported after line #22 to avoid pep8 error\n\nrefer import standards, https://docs.openstack.org/developer/hacking/#imports","commit_id":"d97cba12490f1c363a8946f0bd142ff6f09f0ec7"}],"glance/tests/unit/test_glance_replicator.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d6915ca9bcc83866c471a98209564fe68ab556f6","unresolved":false,"context_lines":[{"line_number":593,"context_line":"            exception.UploadException,"},{"line_number":594,"context_line":"            glance_replicator._check_upload_response_headers, {}, None)"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def test_image_present(self):"},{"line_number":598,"context_line":"        client \u003d FakeImageService(None, \u0027noauth\u0027)"},{"line_number":599,"context_line":"        self.assertTrue(glance_replicator._image_present("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_42da6717","line":596,"updated":"2017-06-30 06:08:15.000000000","message":"unrelated change, remove this new line","commit_id":"5571f985432790c7dc5d222d7e788e88fbf6b651"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d6915ca9bcc83866c471a98209564fe68ab556f6","unresolved":false,"context_lines":[{"line_number":603,"context_line":""},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"    def test_dict_diff(self):"},{"line_number":606,"context_line":"        a\u003d{\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3}"},{"line_number":607,"context_line":"        b\u003d{\u0027a\u0027: 1, \u0027b\u0027: 2}"},{"line_number":608,"context_line":"        c\u003d{\u0027a\u0027: 1, \u0027b\u0027: 1, \u0027c\u0027: 3}"},{"line_number":609,"context_line":"        d\u003d{\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3, \u0027d\u0027: 4}"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        # Only things that the first dict has which the second dict doesn\u0027t"},{"line_number":612,"context_line":"        # matter here."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_62f68392","line":609,"range":{"start_line":606,"start_character":8,"end_line":609,"end_character":42},"updated":"2017-06-30 06:08:15.000000000","message":"revert these changes as well","commit_id":"5571f985432790c7dc5d222d7e788e88fbf6b651"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b4e0b4cce1977f64db7a5a098e1b429b28f606e","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        self.assertTrue(glance_replicator._image_present("},{"line_number":599,"context_line":"            client, \u00275dcddce0-cba5-4f18-9cf4-9853c7b207a6\u0027))"},{"line_number":600,"context_line":"        self.assertFalse(glance_replicator._image_present("},{"line_number":601,"context_line":"            client, uuidutils.generate_uuid())"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    def test_dict_diff(self):"},{"line_number":604,"context_line":"        a\u003d{\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_cad9e983","line":601,"range":{"start_line":601,"start_character":43,"end_line":601,"end_character":46},"updated":"2017-06-30 09:48:25.000000000","message":"these are unrelated changes, jenkins is failing because you have removed extra closing bracket here. this should be like,\n\nuuidutils.generate_uuid()))","commit_id":"371e97692bce6eca6d31c25323e2e9a86ed365ec"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"9b4e0b4cce1977f64db7a5a098e1b429b28f606e","unresolved":false,"context_lines":[{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        # Only things that the first dict has which the second dict doesn\u0027t"},{"line_number":610,"context_line":"        # matter here."},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        self.assertFalse(glance_replicator._dict_diff(a, a))"},{"line_number":613,"context_line":"        self.assertTrue(glance_replicator._dict_diff(a, b))"},{"line_number":614,"context_line":"        self.assertTrue(glance_replicator._dict_diff(a, c))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f1d235d_6a3775b2","line":611,"updated":"2017-06-30 09:48:25.000000000","message":"remove this line as well, I am pretty sure it will pass now once you fix line #601","commit_id":"371e97692bce6eca6d31c25323e2e9a86ed365ec"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1922316a5b5d311f0c9b8954a01136e6711f5aa1","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        self.assertTrue(glance_replicator._image_present("},{"line_number":599,"context_line":"            client, \u00275dcddce0-cba5-4f18-9cf4-9853c7b207a6\u0027))"},{"line_number":600,"context_line":"        self.assertFalse(glance_replicator._image_present("},{"line_number":601,"context_line":"            client, uuidutils.generate_uuid())"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    def test_dict_diff(self):"},{"line_number":604,"context_line":"        a\u003d{\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3}"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f1d235d_937d68b3","line":601,"range":{"start_line":601,"start_character":20,"end_line":601,"end_character":46},"updated":"2017-06-30 11:31:23.000000000","message":"You have not fixed my earlier comment, as mentioned\n\nthese are unrelated changes, jenkins is failing because you have removed extra closing bracket here. This should be like,\nuuidutils.generate_uuid()))","commit_id":"361f791d694e14801a1c6def610b55ab9b86303a"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d5eadb6634aff6379bd8a1c4cb146a6a3b493eb6","unresolved":false,"context_lines":[{"line_number":601,"context_line":"            client, uuidutils.generate_uuid()))"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    def test_dict_diff(self):"},{"line_number":604,"context_line":"        a\u003d{\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3}"},{"line_number":605,"context_line":"        b\u003d{\u0027a\u0027: 1, \u0027b\u0027: 2}"},{"line_number":606,"context_line":"        c\u003d{\u0027a\u0027: 1, \u0027b\u0027: 1, \u0027c\u0027: 3}"},{"line_number":607,"context_line":"        d\u003d{\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3, \u0027d\u0027: 4}"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        # Only things that the first dict has which the second dict doesn\u0027t"},{"line_number":610,"context_line":"        # matter here."}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_9e91ef9c","line":607,"range":{"start_line":604,"start_character":8,"end_line":607,"end_character":42},"updated":"2017-06-30 11:45:19.000000000","message":"this is unrelated change, revert these changes as you fixed line #601 pep8 will not fail.","commit_id":"097306bd8c4f35a0f44af1633576e8ab39d785d6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d5eadb6634aff6379bd8a1c4cb146a6a3b493eb6","unresolved":false,"context_lines":[{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        # Only things that the first dict has which the second dict doesn\u0027t"},{"line_number":610,"context_line":"        # matter here."},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        self.assertFalse(glance_replicator._dict_diff(a, a))"},{"line_number":613,"context_line":"        self.assertTrue(glance_replicator._dict_diff(a, b))"},{"line_number":614,"context_line":"        self.assertTrue(glance_replicator._dict_diff(a, c))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f1d235d_3eee5b22","line":611,"updated":"2017-06-30 11:45:19.000000000","message":"ditto, remove this new line as well","commit_id":"097306bd8c4f35a0f44af1633576e8ab39d785d6"},{"author":{"_account_id":11391,"name":"Mikhail Fedosin","email":"mfedosin@redhat.com","username":"fedosinme"},"change_message_id":"887ca8b293134353e121d2350b678c546801617f","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        self.assertTrue(glance_replicator._image_present("},{"line_number":599,"context_line":"            client, \u00275dcddce0-cba5-4f18-9cf4-9853c7b207a6\u0027))"},{"line_number":600,"context_line":"        self.assertFalse(glance_replicator._image_present("},{"line_number":601,"context_line":"            client, uuidutils.generate_uuid()))"},{"line_number":602,"context_line":""},{"line_number":603,"context_line":"    def test_dict_diff(self):"},{"line_number":604,"context_line":"        a \u003d {\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3}"}],"source_content_type":"text/x-python","patch_set":16,"id":"1f1a1f67_7512a00b","line":601,"updated":"2017-07-13 20:02:48.000000000","message":"uuid.uuid4() returns UUID object, uuidutils.generate_uuid() returns string:\n\u003e\u003e\u003e uuid.uuid4()\nUUID(\u0027bc8061cf-f025-4996-b6f1-7593dd395cb3\u0027)\n\u003e\u003e\u003e uuidutils.generate_uuid()\n\u0027f3d75b42-eb60-446e-a44a-56b2197b09e0\u0027\n\nBut I think that it was a bug in the test, because in fact _image_present requires an uuid string, not object.","commit_id":"81fc22523c51c9c71070b22afc10c0f67559dc23"}],"glance/tests/unit/v2/test_image_data_resource.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ff188e61972608f3977f4b83c492e0cc0dae2a8e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from cursive import exception as cursive_exception"},{"line_number":17,"context_line":"from oslo_utils import uuidutils"},{"line_number":18,"context_line":"import glance_store"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_74518fd8","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":32},"updated":"2017-06-30 14:28:18.000000000","message":"this should be imported after line #19 to avoid pep8 error","commit_id":"d97cba12490f1c363a8946f0bd142ff6f09f0ec7"}],"glance/tests/unit/v2/test_registry_api.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d6915ca9bcc83866c471a98209564fe68ab556f6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from glance.registry.api import v2 as rserver"},{"line_number":33,"context_line":"from glance.tests.unit import base"},{"line_number":34,"context_line":"from glance.tests import utils as test_utils"},{"line_number":35,"context_line":"from oslo_utils import uuidutils"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"_gen_uuid \u003d lambda: uuidutils.generate_uuid()"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_424827cb","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":32},"updated":"2017-06-30 06:08:15.000000000","message":"this should be imported after line #20","commit_id":"5571f985432790c7dc5d222d7e788e88fbf6b651"}],"glance/tests/unit/v2/test_registry_client.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d6915ca9bcc83866c471a98209564fe68ab556f6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from glance.registry.client.v2.api import client as rclient"},{"line_number":38,"context_line":"from glance.tests.unit import base"},{"line_number":39,"context_line":"from glance.tests import utils as test_utils"},{"line_number":40,"context_line":"from oslo_utils import uuidutils"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"_gen_uuid \u003d lambda: uuidutils.generate_uuid()"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f1d235d_02146f9f","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":32},"updated":"2017-06-30 06:08:15.000000000","message":"this should be imported after line #26","commit_id":"5571f985432790c7dc5d222d7e788e88fbf6b651"}]}