)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6e5988a9c6f855fd614539492a6f99a14ef67ff4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cadd6c37_b79b6983","updated":"2022-07-07 22:33:47.000000000","message":"A few things noted inline.\n\nAlso, this is for a follow up ... I\u0027m pretty sure the output from the glanceclient is different from what\u0027s displayed throughout this doc (which was the osc output).","commit_id":"b8903cc6f846f6b8c774a38b4c50c2a297c21182"}],"doc/source/install/verify.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d718d21113bff7904105786b6ae387b33e744639","unresolved":false,"context_lines":[{"line_number":105,"context_line":"   .. code-block:: console"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      $ openstack image save --file cirros_down.img cirros"},{"line_number":108,"context_line":"      $ diff cirros_down.img cirros-0.3.5-x86_64-disk.img"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"   There should be no output to either command, which will indicate the"},{"line_number":111,"context_line":"   downloaded image matches exactly what was uploaded. If the diff returns"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff346bd7_f0b8002b","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":12},"updated":"2017-07-25 01:57:51.000000000","message":"Would it make more sense to do md5sum?","commit_id":"a84b01fd96b5932c26ae749ec9a8f95d7ebc705d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"a80e070dc483f7735f25a45ac64d48c5459df1a6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"   .. code-block:: console"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      $ openstack image save --file cirros_down.img cirros"},{"line_number":108,"context_line":"      $ diff cirros_down.img cirros-0.3.5-x86_64-disk.img"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"   There should be no output to either command, which will indicate the"},{"line_number":111,"context_line":"   downloaded image matches exactly what was uploaded. If the diff returns"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df3967d1_87e81ae2","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":12},"in_reply_to":"df3967d1_873dbac5","updated":"2017-08-02 19:03:01.000000000","message":"Do you want me to just add a comment to the previous step about running md5sum on the image file and comparing it to the api response? Just trying to figure out the best flow for adding that and the download diff.","commit_id":"a84b01fd96b5932c26ae749ec9a8f95d7ebc705d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b6a2ed1634b70bbad2fc07eb08fce7169998a787","unresolved":false,"context_lines":[{"line_number":105,"context_line":"   .. code-block:: console"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      $ openstack image save --file cirros_down.img cirros"},{"line_number":108,"context_line":"      $ diff cirros_down.img cirros-0.3.5-x86_64-disk.img"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"   There should be no output to either command, which will indicate the"},{"line_number":111,"context_line":"   downloaded image matches exactly what was uploaded. If the diff returns"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df3967d1_6cbaa0c1","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":12},"in_reply_to":"df3967d1_87e81ae2","updated":"2017-08-03 11:58:30.000000000","message":"I\u0027d suggest adding a note or another paragraph after line 114, something like:\n\nIf the diff returns an error, take an md5 of the original image and compare it to the \u0027checksum\u0027 property of the get-image response.  If those differ, then the problem occurred during upload, and the data Glance stored is not correct.  In that case, you\u0027ll have to delete the image and create a new one.  If the value of the \u0027checksum\u0027 property is correct, then the data was somehow corrupted during the download.  Try downloading the image data again.","commit_id":"a84b01fd96b5932c26ae749ec9a8f95d7ebc705d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"90facbcee5bc5a5b0c32a0d7e70c83d7aa3da92c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"   .. code-block:: console"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      $ openstack image save --file cirros_down.img cirros"},{"line_number":108,"context_line":"      $ diff cirros_down.img cirros-0.3.5-x86_64-disk.img"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"   There should be no output to either command, which will indicate the"},{"line_number":111,"context_line":"   downloaded image matches exactly what was uploaded. If the diff returns"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df3967d1_873dbac5","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":12},"in_reply_to":"ff346bd7_13ddb56f","updated":"2017-08-02 18:55:32.000000000","message":"It may be worth mentioning the md5sum as well, because other image consumers (who don\u0027t have access to the original image) will have to rely on the \u0027checksum\u0027 property of the image record in order to verify downloads, so if the value of \u0027checksum\u0027 differs from the actual md5 of the image, then there\u0027s going to be trouble.","commit_id":"a84b01fd96b5932c26ae749ec9a8f95d7ebc705d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b2cf5edd8b99bae872b1dc839497925f44189107","unresolved":false,"context_lines":[{"line_number":105,"context_line":"   .. code-block:: console"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      $ openstack image save --file cirros_down.img cirros"},{"line_number":108,"context_line":"      $ diff cirros_down.img cirros-0.3.5-x86_64-disk.img"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"   There should be no output to either command, which will indicate the"},{"line_number":111,"context_line":"   downloaded image matches exactly what was uploaded. If the diff returns"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff346bd7_13ddb56f","line":108,"range":{"start_line":108,"start_character":8,"end_line":108,"end_character":12},"in_reply_to":"ff346bd7_f0b8002b","updated":"2017-07-25 15:40:12.000000000","message":"I thought about doing a checksum here, but decided it was more foolproof to just do the complete diff. If you did a checksum command instead of diff you\u0027d have to manually compare the strings to make sure they\u0027re not the same. Sometimes that\u0027s easy, sometimes it\u0027s not. The advantage of diff here is that it will return 1 and explicitly say A is not B when they are different.","commit_id":"a84b01fd96b5932c26ae749ec9a8f95d7ebc705d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6e5988a9c6f855fd614539492a6f99a14ef67ff4","unresolved":true,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"   .. code-block:: console"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      $ glance image-download --file cirros_down.img cirros"},{"line_number":108,"context_line":"      $ diff cirros_down.img cirros-0.3.5-x86_64-disk.img"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"   There should be no output to either command, which will indicate the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"755dd09a_07ff64ff","line":107,"range":{"start_line":107,"start_character":53,"end_line":107,"end_character":59},"updated":"2022-07-07 22:33:47.000000000","message":"for the glanceclient, you have to use the image ID here","commit_id":"b8903cc6f846f6b8c774a38b4c50c2a297c21182"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6e5988a9c6f855fd614539492a6f99a14ef67ff4","unresolved":true,"context_lines":[{"line_number":105,"context_line":"   .. code-block:: console"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      $ glance image-download --file cirros_down.img cirros"},{"line_number":108,"context_line":"      $ diff cirros_down.img cirros-0.3.5-x86_64-disk.img"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"   There should be no output to either command, which will indicate the"},{"line_number":111,"context_line":"   downloaded image matches exactly what was uploaded. If the diff returns"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e8837142_b7c32f48","line":108,"range":{"start_line":108,"start_character":29,"end_line":108,"end_character":57},"updated":"2022-07-07 22:33:47.000000000","message":"After your rebase, I think this should be:\n\ncirros-0.4.0-x86_64-disk.img","commit_id":"b8903cc6f846f6b8c774a38b4c50c2a297c21182"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6e5988a9c6f855fd614539492a6f99a14ef67ff4","unresolved":true,"context_lines":[{"line_number":114,"context_line":"   from Glance does not match the uploaded image."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"   If the diff returns an error, take an md5 of the original image and compare"},{"line_number":117,"context_line":"   it to the \u0027checksum\u0027 property of the get-image response.  If those differ,"},{"line_number":118,"context_line":"   then the problem occurred during upload, and the data Glance stored is not"},{"line_number":119,"context_line":"   correct.  In that case, you\u0027ll have to delete the image and create a new"},{"line_number":120,"context_line":"   one.  If the value of the \u0027checksum\u0027 property is correct, then the data was"}],"source_content_type":"text/x-rst","patch_set":2,"id":"626f44dd_b928c3a6","line":117,"range":{"start_line":117,"start_character":13,"end_line":117,"end_character":23},"updated":"2022-07-07 22:33:47.000000000","message":"In the time since I made this suggestion in 2017, I believe that the \u0027checksum\u0027 property is no longer populated, and will only be present on legacy images.  You\u0027ll have to explain how to use the \u0027os_hash_algo\u0027 and \u0027os_hash_value\u0027 image properties.  Probably just say something like:\n\nIf the diff returns an error, take a sha512sum of the original image and compare it to the \u0027os_hash_value\u0027 property displayed in the image-show response.  (If the \u0027os_hash_algo\u0027 property is something other than \u0027sha512\u0027, then you\u0027ll need to use the appropriate command to generate the value locally.)  If those differ, then the problem occurred during upload, and the data Glance stored is not correct.  In that case, you\u0027ll have to delete the image and create a new one.\n\n(The glancelient, unlike osc, does download validation, so it shouldn\u0027t be possible for the download to succeed with an incorrect checksum.)","commit_id":"b8903cc6f846f6b8c774a38b4c50c2a297c21182"}]}