)]}'
{"glance/api/v2/images.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"1e22e08ebd951aee4b6bedca6132bcfe373976a8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        executor_factory \u003d self.gateway.get_task_executor_factory(req.context)"},{"line_number":95,"context_line":"        task_repo \u003d self.gateway.get_task_repo(req.context)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        task_input \u003d {\u0027image_id\u0027: image_id}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        try:"},{"line_number":100,"context_line":"            import_task \u003d task_factory.new_task(task_type\u003d\u0027api_image_import\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_9e5b1e2d","line":97,"range":{"start_line":97,"start_character":34,"end_line":97,"end_character":42},"updated":"2017-08-23 15:14:35.000000000","message":"image_id was added in patch [1] which is decided to revert, so should we revert that patch before and keep this patch depend on that patch?\n\n[1] https://review.openstack.org/#/c/491249/\n\nIMO to be consistent with client we should have image_id and body or else we need to make change in client as well.","commit_id":"be76b448d2fc19adf402ea25d325823072f74f4d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"72b7e8d219dd8b89ffa160c7d29ba3d736d9c509","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        executor_factory \u003d self.gateway.get_task_executor_factory(req.context)"},{"line_number":95,"context_line":"        task_repo \u003d self.gateway.get_task_repo(req.context)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        task_input \u003d {\u0027image_id\u0027: image_id}"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        try:"},{"line_number":100,"context_line":"            import_task \u003d task_factory.new_task(task_type\u003d\u0027api_image_import\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_638fb623","line":97,"range":{"start_line":97,"start_character":34,"end_line":97,"end_character":42},"in_reply_to":"7f287b81_9e5b1e2d","updated":"2017-08-23 16:16:01.000000000","message":"You are right, this patch has [1] as a dependency.  I think that we can view them as two separate fixes: [1] handles the 500s we were getting, and this patch fixes getting taskflow running and passing the image_id into the flow.  The task_input does *not* come from what the client passes, it\u0027s created internally on the server by the controller right at this line.\n\nSo I think these are separate fixes and we can keep them separate and merge them separately into the code base.  I\u0027ll put a comment on https://review.openstack.org/#/c/495789 saying that.","commit_id":"be76b448d2fc19adf402ea25d325823072f74f4d"}],"glance/common/scripts/utils.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"f724e5c8c749318b1555b5ad2746d5c722356cb1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    task_input \u003d task.task_input"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    if task_type \u003d\u003d \u0027api_image_import\u0027:"},{"line_number":59,"context_line":"        if not task_input:"},{"line_number":60,"context_line":"            msg \u003d _(\"Input to api_image_import task is empty.\")"},{"line_number":61,"context_line":"            raise exception.Invalid(msg)"},{"line_number":62,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_14b6eafb","line":59,"updated":"2017-08-23 17:44:23.000000000","message":"Why removing the input validation here? If someone invokes the api_image_import via tasks api without correct imput we won\u0027t be failing clean.","commit_id":"be76b448d2fc19adf402ea25d325823072f74f4d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"43efcfafa8274d0cc6fc04edfa9f990b1a35d083","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    task_input \u003d task.task_input"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    if task_type \u003d\u003d \u0027api_image_import\u0027:"},{"line_number":59,"context_line":"        if not task_input:"},{"line_number":60,"context_line":"            msg \u003d _(\"Input to api_image_import task is empty.\")"},{"line_number":61,"context_line":"            raise exception.Invalid(msg)"},{"line_number":62,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_14838ace","line":59,"in_reply_to":"7f287b81_14b6eafb","updated":"2017-08-23 17:54:13.000000000","message":"I was counting on the import call\u0027s request deserializer to handle this, but you\u0027re right, someone could try to create one of these and submit it via the Tasks API, so we should be ready.","commit_id":"be76b448d2fc19adf402ea25d325823072f74f4d"}]}