)]}'
{"glance/api/policy.py":[{"author":{"_account_id":26734,"name":"Scott McClymont","email":"scott.mcclymont@verizonwireless.com","username":"smcclymont"},"change_message_id":"8d927aaf3515d83e11b4b91e3b7a5205dab84bd2","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            yield key"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    # FIXME(cyril): Move the content of this function to __init__?"},{"line_number":429,"context_line":"    def _get_target_keys(self):"},{"line_number":430,"context_line":"        \"\"\"Return the keys defined by self.target.\"\"\""},{"line_number":431,"context_line":"        return [k for k in dir(ImageProxy)"},{"line_number":432,"context_line":"                if not k.startswith(\u0027__\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_0e2e41fa","line":429,"updated":"2017-10-17 13:32:59.000000000","message":"I agree with your comment, move this to init.","commit_id":"e2af0127f3df4851d30efac04724778f039e6295"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"538bde6279a101672856dbf28a29033d08c9af3b","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    def get(self, key, default\u003dNone):"},{"line_number":415,"context_line":"        try:"},{"line_number":416,"context_line":"            return self.__getitem__(key)"},{"line_number":417,"context_line":"        except IndexError:"},{"line_number":418,"context_line":"            return default"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def __len__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_68c80073","line":417,"updated":"2017-10-17 18:46:25.000000000","message":"Why would getitem raise an IndexError? Should this be KeyError? Both?","commit_id":"a737ec87bde30b8c5c16e3e333c8fef7fbf46947"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"bd0fc1bfb01f7b3ddca17a12b2bc2a639ee47423","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    def get(self, key, default\u003dNone):"},{"line_number":415,"context_line":"        try:"},{"line_number":416,"context_line":"            return self.__getitem__(key)"},{"line_number":417,"context_line":"        except IndexError:"},{"line_number":418,"context_line":"            return default"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def __len__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_71baedde","line":417,"in_reply_to":"5f4e5783_68c80073","updated":"2017-10-19 18:04:28.000000000","message":"Done","commit_id":"a737ec87bde30b8c5c16e3e333c8fef7fbf46947"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"bd0fc1bfb01f7b3ddca17a12b2bc2a639ee47423","unresolved":false,"context_lines":[{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def __len__(self):"},{"line_number":421,"context_line":"        length \u003d len(self._target_keys)"},{"line_number":422,"context_line":"        length +\u003d len(getattr(self.target, \u0027extra_properties\u0027, []))"},{"line_number":423,"context_line":"        return length"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"    def __iter__(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_2e8f5d2b","line":422,"range":{"start_line":422,"start_character":44,"end_line":422,"end_character":60},"updated":"2017-10-19 18:04:28.000000000","message":"Same here, btw.","commit_id":"094840f8b3be764de4485920655af60b8dd29b96"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"ba5424655903d110a7a44e2f2f7ef986685a3be5","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    def __iter__(self):"},{"line_number":426,"context_line":"        for key in self._target_keys:"},{"line_number":427,"context_line":"            yield key"},{"line_number":428,"context_line":"        for key in getattr(self.target, \u0027extra_properties\u0027, []).keys():"},{"line_number":429,"context_line":"            yield key"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def key_transforms(self, key):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_740d293d","line":428,"range":{"start_line":428,"start_character":27,"end_line":428,"end_character":71},"updated":"2017-10-19 15:00:24.000000000","message":"will this fail if target doesn\u0027t contains extra_properties then it will return list and then call keys on it?\nIMO this should be {} instead of list","commit_id":"094840f8b3be764de4485920655af60b8dd29b96"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"bd0fc1bfb01f7b3ddca17a12b2bc2a639ee47423","unresolved":false,"context_lines":[{"line_number":425,"context_line":"    def __iter__(self):"},{"line_number":426,"context_line":"        for key in self._target_keys:"},{"line_number":427,"context_line":"            yield key"},{"line_number":428,"context_line":"        for key in getattr(self.target, \u0027extra_properties\u0027, []).keys():"},{"line_number":429,"context_line":"            yield key"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def key_transforms(self, key):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_4e8a991b","line":428,"range":{"start_line":428,"start_character":27,"end_line":428,"end_character":71},"in_reply_to":"3f4b6375_740d293d","updated":"2017-10-19 18:04:28.000000000","message":"Obviously, what was I thinking. Thanks.","commit_id":"094840f8b3be764de4485920655af60b8dd29b96"}]}
