)]}'
{"glance/api/v2/images.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"bb7888a5a36e9e7c2e3685ede8495f82fa25999b","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if (import_method \u003d\u003d \u0027web-download\u0027 and"},{"line_number":150,"context_line":"           not utils.validate_import_uri(uri)):"},{"line_number":151,"context_line":"            LOG.debug(\"URI for web-download does not pass filtering: %s\", uri)"},{"line_number":152,"context_line":"            msg \u003d (_(\"URI for web-download does not pass filtering: %s\") % uri)"},{"line_number":153,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        try:"},{"line_number":156,"context_line":"            import_task \u003d task_factory.new_task(task_type\u003d\u0027api_image_import\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_211a2e17","line":153,"range":{"start_line":151,"start_character":0,"end_line":153,"end_character":59},"updated":"2020-01-10 12:31:12.000000000","message":"I\u0027m not convinced this improves readability and thus might be rule we don\u0027t want to exercise. Specially as this is against pep8 [0]\n\n[0]https://www.python.org/dev/peps/pep-0008/#indentation","commit_id":"e7e72e9c2ab907b00f669e50fcafbee4c5fbbfaf"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"505662dc9017863d200abeb79240f97ba331a961","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        if (import_method \u003d\u003d \u0027web-download\u0027 and"},{"line_number":150,"context_line":"           not utils.validate_import_uri(uri)):"},{"line_number":151,"context_line":"            LOG.debug(\"URI for web-download does not pass filtering: %s\", uri)"},{"line_number":152,"context_line":"            msg \u003d (_(\"URI for web-download does not pass filtering: %s\") % uri)"},{"line_number":153,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        try:"},{"line_number":156,"context_line":"            import_task \u003d task_factory.new_task(task_type\u003d\u0027api_image_import\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a7794efb","line":153,"range":{"start_line":151,"start_character":0,"end_line":153,"end_character":59},"in_reply_to":"3fa7e38b_211a2e17","updated":"2020-01-10 14:56:01.000000000","message":"That link suggests extra indenting for function arguments. I\u0027m not sure if that will work in this case with it just being conditional values. Either way, the extra indentation of the block body is not correct.","commit_id":"e7e72e9c2ab907b00f669e50fcafbee4c5fbbfaf"}],"glance/common/wsgi.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"bb7888a5a36e9e7c2e3685ede8495f82fa25999b","unresolved":false,"context_lines":[{"line_number":970,"context_line":"    \"\"\""},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    def routematch(self, url\u003dNone, environ\u003dNone):"},{"line_number":973,"context_line":"        if url \u003d\u003d \"\":"},{"line_number":974,"context_line":"            result \u003d self._match(\"\", environ)"},{"line_number":975,"context_line":"            return result[0], result[1]"},{"line_number":976,"context_line":"        return routes.Mapper.routematch(self, url, environ)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_41216a4e","line":973,"range":{"start_line":973,"start_character":8,"end_line":973,"end_character":21},"updated":"2020-01-10 12:31:12.000000000","message":"why this change? Not part of pep8 nor hacking documentation.","commit_id":"e7e72e9c2ab907b00f669e50fcafbee4c5fbbfaf"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"505662dc9017863d200abeb79240f97ba331a961","unresolved":false,"context_lines":[{"line_number":970,"context_line":"    \"\"\""},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    def routematch(self, url\u003dNone, environ\u003dNone):"},{"line_number":973,"context_line":"        if url \u003d\u003d \"\":"},{"line_number":974,"context_line":"            result \u003d self._match(\"\", environ)"},{"line_number":975,"context_line":"            return result[0], result[1]"},{"line_number":976,"context_line":"        return routes.Mapper.routematch(self, url, environ)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8711b2b1","line":973,"range":{"start_line":973,"start_character":8,"end_line":973,"end_character":21},"in_reply_to":"3fa7e38b_41216a4e","updated":"2020-01-10 14:56:01.000000000","message":"\"is\" is not the correct way to check if a variable contains a string value. It\u0027s identity (is) versus equality (\u003d\u003d).","commit_id":"e7e72e9c2ab907b00f669e50fcafbee4c5fbbfaf"}],"glance/db/sqlalchemy/migrate_repo/versions/003_add_disk_format.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"bb7888a5a36e9e7c2e3685ede8495f82fa25999b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from sqlalchemy import Column, MetaData, Table, and_, select"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from glance.db.sqlalchemy.migrate_repo.schema import ("},{"line_number":19,"context_line":"    Boolean, DateTime, Integer, String, Text, from_migration_import)  # noqa"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_c1979a45","line":16,"updated":"2020-01-10 12:31:12.000000000","message":"I don\u0027t think this is exactly a strong enough case to touch already published migration script [0]. Also applies to all the following cases.\n\n[0] https://docs.openstack.org/glance/pike/contributor/minor-code-changes.html#database-migration-scripts","commit_id":"e7e72e9c2ab907b00f669e50fcafbee4c5fbbfaf"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"505662dc9017863d200abeb79240f97ba331a961","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from sqlalchemy import Column, MetaData, Table, and_, select"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from glance.db.sqlalchemy.migrate_repo.schema import ("},{"line_number":19,"context_line":"    Boolean, DateTime, Integer, String, Text, from_migration_import)  # noqa"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_67583688","line":16,"in_reply_to":"3fa7e38b_c1979a45","updated":"2020-01-10 14:56:01.000000000","message":"Should we just remove these now? Either way, we are going to have to touch these migration scripts if we want to get to a linter that is more current than the several years old ones we have right now.\n\nThis does not impact functionality in any way. The code isn\u0027t actually used anymore either, so I\u0027d actually be in favor of following up with a cleanup that just gets them out of the repo.","commit_id":"e7e72e9c2ab907b00f669e50fcafbee4c5fbbfaf"}],"tox.ini":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"b3bbd1c2d37009e48df655fefa77421881446cfe","unresolved":false,"context_lines":[{"line_number":132,"context_line":"exclude \u003d .venv,.git,.tox,dist,doc,etc,*glance/locale*,*lib/python*,*egg,build"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"[hacking]"},{"line_number":135,"context_line":"local-check-factory \u003d glance.hacking.checks.factory"},{"line_number":136,"context_line":"import_exceptions \u003d glance.i18n"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"[testenv:docs]"}],"source_content_type":"text/x-properties","patch_set":5,"id":"df33271e_fae36903","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":35},"updated":"2020-04-02 13:30:03.000000000","message":"this change disables local plugins, I\u0027ll fix it as followup.","commit_id":"595c1b17ffa0fbc7900f3f4c9c59534231bd173f"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"90015573b88028fb49a4424bedbc3db6d7f81890","unresolved":false,"context_lines":[{"line_number":132,"context_line":"exclude \u003d .venv,.git,.tox,dist,doc,etc,*glance/locale*,*lib/python*,*egg,build"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"[hacking]"},{"line_number":135,"context_line":"local-check-factory \u003d glance.hacking.checks.factory"},{"line_number":136,"context_line":"import_exceptions \u003d glance.i18n"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"[testenv:docs]"}],"source_content_type":"text/x-properties","patch_set":5,"id":"df33271e_1a41eda9","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":35},"in_reply_to":"df33271e_1ace0d62","updated":"2020-04-02 13:37:02.000000000","message":"\u003e Might also be worth raising hacking again to 3.0 while we\u0027re at it.\n\n\nYes, already combined in my local copy.","commit_id":"595c1b17ffa0fbc7900f3f4c9c59534231bd173f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"92b39308940cc37aa11c89ece7d8cf4ed5921cb9","unresolved":false,"context_lines":[{"line_number":132,"context_line":"exclude \u003d .venv,.git,.tox,dist,doc,etc,*glance/locale*,*lib/python*,*egg,build"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"[hacking]"},{"line_number":135,"context_line":"local-check-factory \u003d glance.hacking.checks.factory"},{"line_number":136,"context_line":"import_exceptions \u003d glance.i18n"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"[testenv:docs]"}],"source_content_type":"text/x-properties","patch_set":5,"id":"df33271e_1ace0d62","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":35},"in_reply_to":"df33271e_fae36903","updated":"2020-04-02 13:33:01.000000000","message":"Thanks, that was on my todo list, but haven\u0027t gotten there yet.\n\nMight also be worth raising hacking again to 3.0 while we\u0027re at it.","commit_id":"595c1b17ffa0fbc7900f3f4c9c59534231bd173f"}]}