)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"change_message_id":"8635f039efba1d3f7578bfe12e9beefcee5e3a09","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import api returns 500 if disk and container formats are not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run image-import api on any image which is in in queued"},{"line_number":10,"context_line":"state and container-format and disk-format are not set will return"},{"line_number":11,"context_line":"500 error as it raises \u0027ValueError: Properties disk_format,"},{"line_number":12,"context_line":"container_format must be set prior to saving data\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_46eec2b4","line":9,"range":{"start_line":9,"start_character":50,"end_line":9,"end_character":52},"updated":"2017-11-24 09:03:37.000000000","message":"nit: remove this extra in","commit_id":"b2bed7668dadb25f25deec052ae2da9e8e56e3f5"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"cfddf424ad37e1cd2c0d4764a8bf7ec55bfe3ec3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import api returns 500 if disk and container formats are not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run image-import api on any image which is in in queued"},{"line_number":10,"context_line":"state and container-format and disk-format are not set will return"},{"line_number":11,"context_line":"500 error as it raises \u0027ValueError: Properties disk_format,"},{"line_number":12,"context_line":"container_format must be set prior to saving data\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_464a42ac","line":9,"range":{"start_line":9,"start_character":50,"end_line":9,"end_character":52},"in_reply_to":"ff82abbf_46eec2b4","updated":"2017-11-24 09:06:04.000000000","message":"Done","commit_id":"b2bed7668dadb25f25deec052ae2da9e8e56e3f5"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"2a3c5e0b8115625946b41d64771b86f5b43f3baf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-24 09:04:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import api returns 500 if disk and container formats are not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run image-import api on any image which is in queued"},{"line_number":10,"context_line":"state and container-format and disk-format are not set will return"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_8ec6fc67","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":64},"updated":"2017-11-27 16:26:17.000000000","message":"Perhaps: \"Fix 500 on image-import if ...\"","commit_id":"224abb965655ce96a86b2798137f29363263763d"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"64484a25643930c58f6785a20a5212a6f1cf0d60","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-24 09:04:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Import api returns 500 if disk and container formats are not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run image-import api on any image which is in queued"},{"line_number":10,"context_line":"state and container-format and disk-format are not set will return"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_492a2e2c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":64},"in_reply_to":"ff82abbf_8ec6fc67","updated":"2017-11-27 16:54:54.000000000","message":"Done","commit_id":"224abb965655ce96a86b2798137f29363263763d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0e4b2f6bee7fdfbf76eb2d179722b15c6a6c88f4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-02 07:42:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix 500 on image-import if disk and container formats are not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run image-import api on any image which is in queued"},{"line_number":10,"context_line":"state and container-format and disk-format are not set will return"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df87a7cf_1a37d6e5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":65},"updated":"2017-12-05 23:01:57.000000000","message":"I suggest changing this to \"Fix 500 on ValueError during image-import\"","commit_id":"d80f761bdf8f59fe8d59c7bff271f09d4318c597"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"df7afe95be50378e987eeb350d5428dda0f8af58","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-02 07:42:30 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix 500 on image-import if disk and container formats are not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run image-import api on any image which is in queued"},{"line_number":10,"context_line":"state and container-format and disk-format are not set will return"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df87a7cf_bbd02b21","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":65},"in_reply_to":"df87a7cf_1a37d6e5","updated":"2017-12-06 03:50:59.000000000","message":"Done","commit_id":"d80f761bdf8f59fe8d59c7bff271f09d4318c597"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0e4b2f6bee7fdfbf76eb2d179722b15c6a6c88f4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix 500 on image-import if disk and container formats are not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run image-import api on any image which is in queued"},{"line_number":10,"context_line":"state and container-format and disk-format are not set will return"},{"line_number":11,"context_line":"500 error as it raises \u0027ValueError: Properties disk_format,"},{"line_number":12,"context_line":"container_format must be set prior to saving data\u0027."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df87a7cf_da5e4e11","line":10,"range":{"start_line":9,"start_character":28,"end_line":10,"end_character":54},"updated":"2017-12-05 23:01:57.000000000","message":"This may not be correct behavior, and if we change the behavior, this commit message will confuse future maintainers.  (This detail is something that would go into the bug report for how to produce the behavior.)\n\nThe key thing we want to convey here is: a ValueError is being raised during image-import, and it\u0027s not being caught, leading to a 500.  So this change catches the ValueError and raises a HTTPBadRequest.","commit_id":"d80f761bdf8f59fe8d59c7bff271f09d4318c597"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"df7afe95be50378e987eeb350d5428dda0f8af58","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix 500 on image-import if disk and container formats are not set"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If you run image-import api on any image which is in queued"},{"line_number":10,"context_line":"state and container-format and disk-format are not set will return"},{"line_number":11,"context_line":"500 error as it raises \u0027ValueError: Properties disk_format,"},{"line_number":12,"context_line":"container_format must be set prior to saving data\u0027."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"df87a7cf_dbcbaf6f","line":10,"range":{"start_line":9,"start_character":28,"end_line":10,"end_character":54},"in_reply_to":"df87a7cf_da5e4e11","updated":"2017-12-06 03:50:59.000000000","message":"Done","commit_id":"d80f761bdf8f59fe8d59c7bff271f09d4318c597"}]}