)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"411a57845d8316235bb558eca8815bb7f42f487e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-27 06:37:11 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Image data stays in store if image is deleted after staging call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Trying to delete image after staging call image gets deleted"},{"line_number":10,"context_line":"from the database, but image data remains in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_6b692af7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":64},"updated":"2017-11-27 16:16:39.000000000","message":"This is great bug topic, not so great commit topic line. If you look the commits as oneline this looks like the change is doing exactly opposite what it actually does.\n\nPerhaps: \"Delete data if image is deleted after staging call\"","commit_id":"ecd10d6c5bef492ab056812ed08e20901acec3f6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4cfb9e1e8e60877ac757c05475c3a925e057b0fa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Abhishek Kekane \u003cakekane@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-27 06:37:11 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Image data stays in store if image is deleted after staging call"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Trying to delete image after staging call image gets deleted"},{"line_number":10,"context_line":"from the database, but image data remains in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_b920dead","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":64},"in_reply_to":"ff82abbf_6b692af7","updated":"2017-11-28 03:56:17.000000000","message":"Done","commit_id":"ecd10d6c5bef492ab056812ed08e20901acec3f6"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"411a57845d8316235bb558eca8815bb7f42f487e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Trying to delete image after staging call image gets deleted"},{"line_number":10,"context_line":"from the database, but image data remains in the"},{"line_number":11,"context_line":"backend (\u0027/tmp/staging\u0027 directory)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Deleted image data from the backend (\u0027/tmp/staging\u0027 directory) if"},{"line_number":14,"context_line":"image_import is enabled and image is in uploading state while"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_ee3ea8b6","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":34},"updated":"2017-11-27 16:16:39.000000000","message":"perhaps: \"staging area\"\n\nthat path is not hardcoded and it is overloading \"backend\" and none of the staging config help refers to backend when talking about this.","commit_id":"ecd10d6c5bef492ab056812ed08e20901acec3f6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4cfb9e1e8e60877ac757c05475c3a925e057b0fa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Trying to delete image after staging call image gets deleted"},{"line_number":10,"context_line":"from the database, but image data remains in the"},{"line_number":11,"context_line":"backend (\u0027/tmp/staging\u0027 directory)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Deleted image data from the backend (\u0027/tmp/staging\u0027 directory) if"},{"line_number":14,"context_line":"image_import is enabled and image is in uploading state while"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_5911925c","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":34},"in_reply_to":"ff82abbf_ee3ea8b6","updated":"2017-11-28 03:56:17.000000000","message":"Done","commit_id":"ecd10d6c5bef492ab056812ed08e20901acec3f6"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"411a57845d8316235bb558eca8815bb7f42f487e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"from the database, but image data remains in the"},{"line_number":11,"context_line":"backend (\u0027/tmp/staging\u0027 directory)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Deleted image data from the backend (\u0027/tmp/staging\u0027 directory) if"},{"line_number":14,"context_line":"image_import is enabled and image is in uploading state while"},{"line_number":15,"context_line":"deleting."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_4e7794a1","line":13,"range":{"start_line":13,"start_character":28,"end_line":13,"end_character":62},"updated":"2017-11-27 16:16:39.000000000","message":"ditto","commit_id":"ecd10d6c5bef492ab056812ed08e20901acec3f6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4cfb9e1e8e60877ac757c05475c3a925e057b0fa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"from the database, but image data remains in the"},{"line_number":11,"context_line":"backend (\u0027/tmp/staging\u0027 directory)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Deleted image data from the backend (\u0027/tmp/staging\u0027 directory) if"},{"line_number":14,"context_line":"image_import is enabled and image is in uploading state while"},{"line_number":15,"context_line":"deleting."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_7916d657","line":13,"range":{"start_line":13,"start_character":28,"end_line":13,"end_character":62},"in_reply_to":"ff82abbf_4e7794a1","updated":"2017-11-28 03:56:17.000000000","message":"Done","commit_id":"ecd10d6c5bef492ab056812ed08e20901acec3f6"}],"glance/api/v2/images.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"411a57845d8316235bb558eca8815bb7f42f487e","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            # is uploading then delete image data from the staging area."},{"line_number":271,"context_line":"            if CONF.enable_image_import and image.status \u003d\u003d \u0027uploading\u0027:"},{"line_number":272,"context_line":"                file_path \u003d str(CONF.node_staging_uri + \u0027/\u0027 + image.image_id)"},{"line_number":273,"context_line":"                self.store_api.delete_from_backend(file_path)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            image.delete()"},{"line_number":276,"context_line":"            image_repo.remove(image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_ae166048","line":273,"range":{"start_line":273,"start_character":16,"end_line":273,"end_character":61},"updated":"2017-11-27 16:16:39.000000000","message":"We probably should except Forbidden and NotFound here as the delete_from_backend does not handle those.","commit_id":"ecd10d6c5bef492ab056812ed08e20901acec3f6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4cfb9e1e8e60877ac757c05475c3a925e057b0fa","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            # is uploading then delete image data from the staging area."},{"line_number":271,"context_line":"            if CONF.enable_image_import and image.status \u003d\u003d \u0027uploading\u0027:"},{"line_number":272,"context_line":"                file_path \u003d str(CONF.node_staging_uri + \u0027/\u0027 + image.image_id)"},{"line_number":273,"context_line":"                self.store_api.delete_from_backend(file_path)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            image.delete()"},{"line_number":276,"context_line":"            image_repo.remove(image)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_1961ca05","line":273,"range":{"start_line":273,"start_character":16,"end_line":273,"end_character":61},"in_reply_to":"ff82abbf_ae166048","updated":"2017-11-28 03:56:17.000000000","message":"Which will get caught at line #277 AND #280.\nShould I add separate try block for this?","commit_id":"ecd10d6c5bef492ab056812ed08e20901acec3f6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f1738d17204d25369dee74c36b4fb6b5f713e288","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            # NOTE(abhishekk): If \u0027image-import\u0027 is supported and image status"},{"line_number":270,"context_line":"            # is uploading then delete image data from the staging area."},{"line_number":271,"context_line":"            if CONF.enable_image_import and image.status \u003d\u003d \u0027uploading\u0027:"},{"line_number":272,"context_line":"                file_path \u003d str(CONF.node_staging_uri + \u0027/\u0027 + image.image_id)"},{"line_number":273,"context_line":"                self.store_api.delete_from_backend(file_path)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"            image.delete()"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_acc1c182","line":272,"range":{"start_line":272,"start_character":28,"end_line":272,"end_character":77},"updated":"2017-12-06 15:44:27.000000000","message":"This makes this extremely specific to the filesystem store (which is all we have now, but still ...)\n\nMy other concern, that I haven\u0027t looked into carefully, is what happens if the upload to the store is still happening when the delete is issued?\n\nI think let\u0027s hold off until Q-3 for this.","commit_id":"7eb2fcc865e56cc81f287beb71d6c320dc2f336d"}]}