)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b7f2a63787353e378d534e1b715982d2b28cbc9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix unreachable \u0027ImageSizeLimitExceeded\u0027 exception in image-upload"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ImageSizeLimitExceeded exception block [1] is unreachable in upload because"},{"line_number":10,"context_line":"it is caught at [1] and raised StorageQuotaFull exception from there. The"},{"line_number":11,"context_line":"problem here is that we have nested usage of the limiting reader."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To make it correct changed the limiting reader to accept"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_954b7baf","line":10,"range":{"start_line":10,"start_character":17,"end_line":10,"end_character":18},"updated":"2018-05-29 13:17:43.000000000","message":"I think you mean [2] here.","commit_id":"44fb8cc51cadde053f701a8bf59010abd815252b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2588d2171b05d84892b6a22e98db373bdd52f1a8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix unreachable \u0027ImageSizeLimitExceeded\u0027 exception in image-upload"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ImageSizeLimitExceeded exception block [1] is unreachable in upload because"},{"line_number":10,"context_line":"it is caught at [1] and raised StorageQuotaFull exception from there. The"},{"line_number":11,"context_line":"problem here is that we have nested usage of the limiting reader."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To make it correct changed the limiting reader to accept"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_c0ccc136","line":10,"range":{"start_line":10,"start_character":17,"end_line":10,"end_character":18},"in_reply_to":"5f7c97a3_954b7baf","updated":"2018-05-30 05:09:59.000000000","message":"yes","commit_id":"44fb8cc51cadde053f701a8bf59010abd815252b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b7f2a63787353e378d534e1b715982d2b28cbc9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"in case LimitingReader is used for quota check and ImageSizeExceeded exception"},{"line_number":16,"context_line":"if it is used for image size cap check."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L232"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1734832"},{"line_number":21,"context_line":"Change-Id: I5a419b763bee7f983c2a94c6f3a2245281e86743"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_355dc778","line":18,"updated":"2018-05-29 13:17:43.000000000","message":"use https://github.com/openstack/glance/blob/fd16fa4f258fd3f77c14900a019e97bb90bc5ac0/glance/api/v2/image_data.py#L230 instead to keep the line reference correct.","commit_id":"44fb8cc51cadde053f701a8bf59010abd815252b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2588d2171b05d84892b6a22e98db373bdd52f1a8","unresolved":false,"context_lines":[{"line_number":15,"context_line":"in case LimitingReader is used for quota check and ImageSizeExceeded exception"},{"line_number":16,"context_line":"if it is used for image size cap check."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L232"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1734832"},{"line_number":21,"context_line":"Change-Id: I5a419b763bee7f983c2a94c6f3a2245281e86743"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_60cdad2e","line":18,"in_reply_to":"5f7c97a3_355dc778","updated":"2018-05-30 05:09:59.000000000","message":"Done","commit_id":"44fb8cc51cadde053f701a8bf59010abd815252b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8b7f2a63787353e378d534e1b715982d2b28cbc9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"if it is used for image size cap check."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L232"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1734832"},{"line_number":21,"context_line":"Change-Id: I5a419b763bee7f983c2a94c6f3a2245281e86743"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_5595e3e2","line":19,"updated":"2018-05-29 13:17:43.000000000","message":"add:\n\n[2] https://github.com/openstack/glance/blob/fd16fa4f258fd3f77c14900a019e97bb90bc5ac0/glance/quota/__init__.py#L305","commit_id":"44fb8cc51cadde053f701a8bf59010abd815252b"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"2588d2171b05d84892b6a22e98db373bdd52f1a8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"if it is used for image size cap check."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1] https://github.com/openstack/glance/blob/master/glance/api/v2/image_data.py#L232"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1734832"},{"line_number":21,"context_line":"Change-Id: I5a419b763bee7f983c2a94c6f3a2245281e86743"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_80d249d0","line":19,"in_reply_to":"5f7c97a3_5595e3e2","updated":"2018-05-30 05:09:59.000000000","message":"Done","commit_id":"44fb8cc51cadde053f701a8bf59010abd815252b"}]}