)]}'
{"glance/async/flows/_internal_plugins/__init__.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4e28f2ef8dcca2b9f42b6ccff1b4c3c86a29cbfd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"CONF \u003d cfg.CONF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_import_plugin(**kwargs):"},{"line_number":24,"context_line":"    method_list \u003d CONF.enabled_import_methods"},{"line_number":25,"context_line":"    import_method \u003d kwargs.get(\u0027import_req\u0027)[\u0027method\u0027][\u0027name\u0027].replace(\"-\","},{"line_number":26,"context_line":"                                                                       \"_\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_3d72ab4a","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":32},"updated":"2018-01-16 05:56:55.000000000","message":"I think this should be moved to plugins directory or need to add code to load this pluginotherwise this plugin will never be loaded.\n\nRef:\nhttps://github.com/openstack/glance/blob/master/glance/async/flows/api_image_import.py#L26\nhttps://github.com/openstack/glance/blob/master/glance/async/flows/api_image_import.py#L373","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"c951e1e6b5e0590e8fec09a7ea203779f1e8c4ba","unresolved":false,"context_lines":[{"line_number":20,"context_line":"CONF \u003d cfg.CONF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_import_plugin(**kwargs):"},{"line_number":24,"context_line":"    method_list \u003d CONF.enabled_import_methods"},{"line_number":25,"context_line":"    import_method \u003d kwargs.get(\u0027import_req\u0027)[\u0027method\u0027][\u0027name\u0027].replace(\"-\","},{"line_number":26,"context_line":"                                                                       \"_\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_bc11d354","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":32},"in_reply_to":"7f96bb07_3d72ab4a","updated":"2018-01-16 11:34:48.000000000","message":"Look this change api_image_import.py lines 374-375","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"09616a00a303129bf41d5d195966aca2cff76ec7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"CONF \u003d cfg.CONF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_import_plugin(**kwargs):"},{"line_number":24,"context_line":"    method_list \u003d CONF.enabled_import_methods"},{"line_number":25,"context_line":"    import_method \u003d kwargs.get(\u0027import_req\u0027)[\u0027method\u0027][\u0027name\u0027].replace(\"-\","},{"line_number":26,"context_line":"                                                                       \"_\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_60b05c8b","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":32},"in_reply_to":"7f96bb07_56f18694","updated":"2018-01-17 07:59:01.000000000","message":"Overlooked what you were saying :)","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3150b6b2d2092229fe9e179affe349450f1e79bd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"CONF \u003d cfg.CONF"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def get_import_plugin(**kwargs):"},{"line_number":24,"context_line":"    method_list \u003d CONF.enabled_import_methods"},{"line_number":25,"context_line":"    import_method \u003d kwargs.get(\u0027import_req\u0027)[\u0027method\u0027][\u0027name\u0027].replace(\"-\","},{"line_number":26,"context_line":"                                                                       \"_\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_56f18694","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":32},"in_reply_to":"7f96bb07_bc11d354","updated":"2018-01-16 14:32:07.000000000","message":"If i am not wrong this will only import plugin from plugins packages and not this one as this is outside of plugins package.","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"}],"glance/async/flows/_internal_plugins/web_download.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0da84c461a65875c2aa0dbe57e0b01e51faf992f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_e5ba0fbf","line":1,"updated":"2018-01-18 09:53:00.000000000","message":"I think copyright statement is missing","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"42c5b482894295adf73f73b92a9c091cdc7d8022","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_83afdc28","line":1,"in_reply_to":"7f96bb07_e5ba0fbf","updated":"2018-01-24 13:02:59.000000000","message":"Done","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0da84c461a65875c2aa0dbe57e0b01e51faf992f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                     \"properly. Missing node_staging_uri: %(work_dir)s\") %"},{"line_number":45,"context_line":"                   {\u0027task_id\u0027: self.task_id,"},{"line_number":46,"context_line":"                    \u0027task_type\u0027: self.task_type,"},{"line_number":47,"context_line":"                    \u0027work_dir\u0027: CONF.node_staging_uri})"},{"line_number":48,"context_line":"            raise exception.BadTaskConfiguration(msg)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.store \u003d self._build_store()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_e530cfa1","line":47,"range":{"start_line":47,"start_character":32,"end_line":47,"end_character":52},"updated":"2018-01-18 09:53:00.000000000","message":"if it is None then it will print None here, will it be useful?\n\nI guess Missing node_staging_uri is sufficient here.","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"42c5b482894295adf73f73b92a9c091cdc7d8022","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                     \"properly. Missing node_staging_uri: %(work_dir)s\") %"},{"line_number":45,"context_line":"                   {\u0027task_id\u0027: self.task_id,"},{"line_number":46,"context_line":"                    \u0027task_type\u0027: self.task_type,"},{"line_number":47,"context_line":"                    \u0027work_dir\u0027: CONF.node_staging_uri})"},{"line_number":48,"context_line":"            raise exception.BadTaskConfiguration(msg)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self.store \u003d self._build_store()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_438c74d6","line":47,"range":{"start_line":47,"start_character":32,"end_line":47,"end_character":52},"in_reply_to":"7f96bb07_e530cfa1","updated":"2018-01-24 13:02:59.000000000","message":"\u003e if it is None then it will print None here, will it be useful?\n \u003e \n \u003e I guess Missing node_staging_uri is sufficient here.\n\nI\u0027d prefer to keep it there for consistency as we do print it from other tasks as well. It\u0027s very explicit and does not clutter the logs that badly (5 characters).","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0da84c461a65875c2aa0dbe57e0b01e51faf992f","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        # refer to the comment in the `_ImportToStore.execute` method."},{"line_number":94,"context_line":"        data \u003d script_utils.get_image_data_iter(self.uri)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        path \u003d self.store.add(self.image_id, data, 0, context\u003dNone)[0]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        return path"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_0595bb32","line":96,"range":{"start_line":96,"start_character":54,"end_line":96,"end_character":66},"updated":"2018-01-18 09:53:00.000000000","message":"No need to pass this","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"42c5b482894295adf73f73b92a9c091cdc7d8022","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        # refer to the comment in the `_ImportToStore.execute` method."},{"line_number":94,"context_line":"        data \u003d script_utils.get_image_data_iter(self.uri)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        path \u003d self.store.add(self.image_id, data, 0, context\u003dNone)[0]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        return path"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_c3b96479","line":96,"range":{"start_line":96,"start_character":54,"end_line":96,"end_character":66},"in_reply_to":"7f96bb07_0595bb32","updated":"2018-01-24 13:02:59.000000000","message":"Done","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0da84c461a65875c2aa0dbe57e0b01e51faf992f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                              \u0027%(image_id)s to the filesystem.\u0027),"},{"line_number":104,"context_line":"                          {\u0027task_id\u0027: self.task_id,"},{"line_number":105,"context_line":"                           \u0027image_id\u0027: self.image_id})"},{"line_number":106,"context_line":"            return"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def get_flow(**kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_c59a7360","line":106,"range":{"start_line":106,"start_character":12,"end_line":106,"end_character":18},"updated":"2018-01-18 09:53:00.000000000","message":"No required","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"42c5b482894295adf73f73b92a9c091cdc7d8022","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                              \u0027%(image_id)s to the filesystem.\u0027),"},{"line_number":104,"context_line":"                          {\u0027task_id\u0027: self.task_id,"},{"line_number":105,"context_line":"                           \u0027image_id\u0027: self.image_id})"},{"line_number":106,"context_line":"            return"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def get_flow(**kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_03c42cf4","line":106,"range":{"start_line":106,"start_character":12,"end_line":106,"end_character":18},"in_reply_to":"7f96bb07_c59a7360","updated":"2018-01-24 13:02:59.000000000","message":"Done","commit_id":"1d417a4a08fff12578becd4b9c95c33c600edd56"}]}