)]}'
{"glance/api/versions.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e72780c77f26a84fd6751ba87c7088b5763851d0","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        version_objs \u003d []"},{"line_number":75,"context_line":"        if CONF.enable_v2_api:"},{"line_number":76,"context_line":"            if CONF.enable_image_import:"},{"line_number":77,"context_line":"                version_objs.append("},{"line_number":78,"context_line":"                    build_version_object(2.6, \u0027v2\u0027, \u0027CURRENT\u0027))"},{"line_number":79,"context_line":"            version_objs.extend(["},{"line_number":80,"context_line":"                build_version_object(2.5, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":81,"context_line":"                build_version_object(2.4, \u0027v2\u0027, \u0027SUPPORTED\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_558695dd","line":78,"range":{"start_line":76,"start_character":12,"end_line":78,"end_character":63},"updated":"2018-01-15 05:11:01.000000000","message":"If default value is True then no need of this if condition, because of this 12 functional tests are failing. You can add it directly at after line #79.","commit_id":"c9f1ebb8ddb7405a8d23a24089af825e49f0e540"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"71a5f1349527a7c9c612472fcb7b9ed1821a4c12","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        version_objs \u003d []"},{"line_number":75,"context_line":"        if CONF.enable_v2_api:"},{"line_number":76,"context_line":"            if CONF.enable_image_import:"},{"line_number":77,"context_line":"                version_objs.append("},{"line_number":78,"context_line":"                    build_version_object(2.6, \u0027v2\u0027, \u0027CURRENT\u0027))"},{"line_number":79,"context_line":"            version_objs.extend(["},{"line_number":80,"context_line":"                build_version_object(2.5, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":81,"context_line":"                build_version_object(2.4, \u0027v2\u0027, \u0027SUPPORTED\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_c61b887e","line":78,"range":{"start_line":76,"start_character":12,"end_line":78,"end_character":63},"in_reply_to":"7f96bb07_3c91434f","updated":"2018-01-17 09:17:56.000000000","message":"Aha! Thanks, that makes some sense. Will fix it.","commit_id":"c9f1ebb8ddb7405a8d23a24089af825e49f0e540"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"d65c972c6de544c8a2064d46120620b0dcf07c2f","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        version_objs \u003d []"},{"line_number":75,"context_line":"        if CONF.enable_v2_api:"},{"line_number":76,"context_line":"            if CONF.enable_image_import:"},{"line_number":77,"context_line":"                version_objs.append("},{"line_number":78,"context_line":"                    build_version_object(2.6, \u0027v2\u0027, \u0027CURRENT\u0027))"},{"line_number":79,"context_line":"            version_objs.extend(["},{"line_number":80,"context_line":"                build_version_object(2.5, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":81,"context_line":"                build_version_object(2.4, \u0027v2\u0027, \u0027SUPPORTED\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_bcdb137a","line":78,"range":{"start_line":76,"start_character":12,"end_line":78,"end_character":63},"in_reply_to":"7f96bb07_558695dd","updated":"2018-01-16 11:39:17.000000000","message":"So why does this fail? It being true we should have the list built correctly (true, the condition is redundant, but it also should not break the tests). Also why does it break just the functional tests but not the unit tests?","commit_id":"c9f1ebb8ddb7405a8d23a24089af825e49f0e540"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"6a90b848c0bb2babb76318bf8d09ec5bd119c28b","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        version_objs \u003d []"},{"line_number":75,"context_line":"        if CONF.enable_v2_api:"},{"line_number":76,"context_line":"            if CONF.enable_image_import:"},{"line_number":77,"context_line":"                version_objs.append("},{"line_number":78,"context_line":"                    build_version_object(2.6, \u0027v2\u0027, \u0027CURRENT\u0027))"},{"line_number":79,"context_line":"            version_objs.extend(["},{"line_number":80,"context_line":"                build_version_object(2.5, \u0027v2\u0027, \u0027SUPPORTED\u0027),"},{"line_number":81,"context_line":"                build_version_object(2.4, \u0027v2\u0027, \u0027SUPPORTED\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_3c91434f","line":78,"range":{"start_line":76,"start_character":12,"end_line":78,"end_character":63},"in_reply_to":"7f96bb07_bcdb137a","updated":"2018-01-16 11:49:19.000000000","message":"This is because from test we need to set config option explicitly. As it is not set it that if condition fails and it does not include version 2.6 in the response and we get versions 2.5 and lower as support only.","commit_id":"c9f1ebb8ddb7405a8d23a24089af825e49f0e540"}],"glance/common/config.py":[{"author":{"_account_id":14676,"name":"Kairat Kushaev","email":"kkushaev@mirantis.com","username":"kairat_kushaev"},"change_message_id":"49679e70da20176cf318c6aa63bbc6f0ebc65eb6","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":"\"\"\")),"},{"line_number":706,"context_line":"    cfg.BoolOpt(\u0027enable_image_import\u0027,"},{"line_number":707,"context_line":"                default\u003dTrue,"},{"line_number":708,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":709,"context_line":"                deprecated_reason\u003d_(\"\"\""},{"line_number":710,"context_line":"This option is deprecated for removal in Rocky."}],"source_content_type":"text/x-python","patch_set":8,"id":"5f93b717_bee85a16","line":707,"range":{"start_line":707,"start_character":24,"end_line":707,"end_character":28},"updated":"2018-01-25 10:48:58.000000000","message":"Sorry, it seems i found some security issues in image import code, so we better not to merge this and enable it by default until we resolve these issues.","commit_id":"955b917b98710f11ef30cc299c61a39946147ece"}]}