)]}'
{"glance/common/wsgi.py":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"41dbd3e1169c1222a176905cdb796f0224f06ea8","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"        # and instead returns a \u0027repr\u0027. So we will return the Exception object"},{"line_number":1147,"context_line":"        # and jsonutils.dump_as_bytes() will work as expected."},{"line_number":1148,"context_line":"        if isinstance(obj, Exception):"},{"line_number":1149,"context_line":"            return obj"},{"line_number":1150,"context_line":"        return jsonutils.to_primitive(obj)"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    def to_json(self, data):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_91da7575","line":1149,"updated":"2018-01-18 07:39:23.000000000","message":"So I was digging into this more, but going to stop as 11:30PM my time.\n\nWhen this returns the obj, it actually causes a Circular reference detected exception to occur. And even without this change and the old oslo.serialization the same exception happens.\n\nSo far some reason a CircularReference exception works and returning a string representation of the HTTPNoContent fails the unit tests.\n\nWeird!","commit_id":"3e7326649ad4024f47e101f62b8da37c9029985e"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"856018f98a1822391bbc842ad30b4d99b26a48c4","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"        # and instead returns a \u0027repr\u0027. So we will return the Exception object"},{"line_number":1147,"context_line":"        # and jsonutils.dump_as_bytes() will work as expected."},{"line_number":1148,"context_line":"        if isinstance(obj, Exception):"},{"line_number":1149,"context_line":"            return obj"},{"line_number":1150,"context_line":"        return jsonutils.to_primitive(obj)"},{"line_number":1151,"context_line":""},{"line_number":1152,"context_line":"    def to_json(self, data):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_31c84172","line":1149,"in_reply_to":"7f96bb07_91da7575","updated":"2018-01-18 07:47:51.000000000","message":"So this might be the real reason for the strangeness, but not sure how to fix it.\n\nhttps://github.com/openstack/glance/blob/08e28cd921920cf8f5401c839376b65c19a97880/glance/common/wsgi.py#L1250-L1252","commit_id":"3e7326649ad4024f47e101f62b8da37c9029985e"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"c0a656862e59b065c0217e8d4a7efad3ae1c0c52","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"            response \u003d webob.exc.HTTPInternalServerError()"},{"line_number":1236,"context_line":"            return response"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"        # We cannot serialize an Exception, so return the action_result"},{"line_number":1239,"context_line":"        if isinstance(action_result, Exception):"},{"line_number":1240,"context_line":"            return action_result"},{"line_number":1241,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_22c2eaea","line":1238,"range":{"start_line":1238,"start_character":44,"end_line":1238,"end_character":71},"updated":"2018-01-21 05:27:26.000000000","message":"it could have sounded better to say :\n\n    \"so return the action_result preemptively\"","commit_id":"6e397345b1b4f5dc9e67cebde817155693f5cf51"}]}