)]}'
{"glance/cmd/manage.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"77ff74faf68124ebfd8d16edb0db42423ad0cbb8","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        else:"},{"line_number":178,"context_line":"            print(_(\u0027Database expansion is up to date. No expansion needed.\u0027))"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        curr_heads \u003d alembic_migrations.get_current_alembic_heads()"},{"line_number":181,"context_line":"        if expand_head not in curr_heads:"},{"line_number":182,"context_line":"            sys.exit(_(\u0027Database expansion failed. Database expansion should \u0027"},{"line_number":183,"context_line":"                       \u0027have brought the database version up to \"%(e_rev)s\" \u0027"},{"line_number":184,"context_line":"                       \u0027revision. But, current revisions are: %(curr_revs)s \u0027)"},{"line_number":185,"context_line":"                     % {\u0027e_rev\u0027: expand_head, \u0027curr_revs\u0027: curr_heads})"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def contract(self):"},{"line_number":188,"context_line":"        \"\"\"Run the contraction phase of a rolling upgrade procedure.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_18291689","line":185,"range":{"start_line":180,"start_character":8,"end_line":185,"end_character":71},"updated":"2018-02-08 06:12:30.000000000","message":"this should be moved after line #176","commit_id":"9bc12397e168d4562e10ff76e3196ce7bbbf7d71"},{"author":{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},"change_message_id":"2da8bf5f7feeb039a6bb3598a81d3be8f2ea06ef","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                           \u0027: %(curr_revs)s \u0027) % {\u0027e_rev\u0027: expand_head,"},{"line_number":217,"context_line":"                                                  \u0027curr_revs\u0027: curr_heads})"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            print(_(\u0027Database expansion is up to date. No expansion needed.\u0027))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def contract(self):"},{"line_number":222,"context_line":"        \"\"\"Run the contraction phase of a rolling upgrade procedure.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_cd13b25b","line":219,"range":{"start_line":219,"start_character":58,"end_line":219,"end_character":67},"updated":"2018-02-10 16:41:07.000000000","message":"Interestingly at line #205 they name it as migrations.. please check what would be more consistent usage across.","commit_id":"c6165aa61cf53c190116ac3f9bc9fe73a648cb00"},{"author":{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},"change_message_id":"2da8bf5f7feeb039a6bb3598a81d3be8f2ea06ef","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                           \u0027: %(curr_revs)s \u0027) % {\u0027e_rev\u0027: expand_head,"},{"line_number":217,"context_line":"                                                  \u0027curr_revs\u0027: curr_heads})"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            print(_(\u0027Database expansion is up to date. No expansion needed.\u0027))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def contract(self):"},{"line_number":222,"context_line":"        \"\"\"Run the contraction phase of a rolling upgrade procedure.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_ad2f4686","line":219,"range":{"start_line":219,"start_character":21,"end_line":219,"end_character":53},"updated":"2018-02-10 16:41:07.000000000","message":"Should be \"Database is up to date.\"","commit_id":"c6165aa61cf53c190116ac3f9bc9fe73a648cb00"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"7f0817b473724d2ae867046ee1ba65d4509792b4","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                           \u0027: %(curr_revs)s \u0027) % {\u0027e_rev\u0027: expand_head,"},{"line_number":217,"context_line":"                                                  \u0027curr_revs\u0027: curr_heads})"},{"line_number":218,"context_line":"        else:"},{"line_number":219,"context_line":"            print(_(\u0027Database expansion is up to date. No expansion needed.\u0027))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def contract(self):"},{"line_number":222,"context_line":"        \"\"\"Run the contraction phase of a rolling upgrade procedure.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_9f7a9eee","line":219,"range":{"start_line":219,"start_character":58,"end_line":219,"end_character":67},"in_reply_to":"3fa0c359_cd13b25b","updated":"2018-02-12 10:05:05.000000000","message":"Thanks Prateek for review.\n\n@205 correcting message as \u0027Database is up to date. No upgrades needed.\u0027\nAnd modifying same wherever applicable.","commit_id":"c6165aa61cf53c190116ac3f9bc9fe73a648cb00"},{"author":{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},"change_message_id":"2da8bf5f7feeb039a6bb3598a81d3be8f2ea06ef","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                       \u0027\"%(e_rev)s\" revision. But, current revisions are: \u0027"},{"line_number":257,"context_line":"                       \u0027%(curr_revs)s \u0027) % {\u0027e_rev\u0027: expand_head,"},{"line_number":258,"context_line":"                                            \u0027curr_revs\u0027: curr_heads})"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def migrate(self):"},{"line_number":261,"context_line":"        self._validate_engine(db_api.get_engine())"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_8d192a7b","line":259,"updated":"2018-02-10 16:41:07.000000000","message":"Do we want to add \"else\" statement similar to expand function to make it uniform across functions?","commit_id":"c6165aa61cf53c190116ac3f9bc9fe73a648cb00"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"7f0817b473724d2ae867046ee1ba65d4509792b4","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                       \u0027\"%(e_rev)s\" revision. But, current revisions are: \u0027"},{"line_number":257,"context_line":"                       \u0027%(curr_revs)s \u0027) % {\u0027e_rev\u0027: expand_head,"},{"line_number":258,"context_line":"                                            \u0027curr_revs\u0027: curr_heads})"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def migrate(self):"},{"line_number":261,"context_line":"        self._validate_engine(db_api.get_engine())"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_bfe3dad8","line":259,"in_reply_to":"3fa0c359_8d192a7b","updated":"2018-02-12 10:05:05.000000000","message":"Contract is executed or not its taken into account at @232\nSo according to me here else is not required.","commit_id":"c6165aa61cf53c190116ac3f9bc9fe73a648cb00"},{"author":{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},"change_message_id":"2da8bf5f7feeb039a6bb3598a81d3be8f2ea06ef","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            rows_migrated \u003d data_migrations.migrate(db_api.get_engine())"},{"line_number":280,"context_line":"            print(_(\u0027Migrated %s rows\u0027) % rows_migrated)"},{"line_number":281,"context_line":"        else:"},{"line_number":282,"context_line":"            print(_(\u0027Database migration is up to date. No migration needed.\u0027))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    @args(\u0027--path\u0027, metavar\u003d\u0027\u003cpath\u003e\u0027, help\u003d\u0027Path to the directory or file \u0027"},{"line_number":285,"context_line":"                                           \u0027where json metadata is stored\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_6d05be10","line":282,"range":{"start_line":282,"start_character":58,"end_line":282,"end_character":67},"updated":"2018-02-10 16:41:07.000000000","message":"Most of the places it is \"migrations\". Example line #268. We may want to keep it in sync.","commit_id":"c6165aa61cf53c190116ac3f9bc9fe73a648cb00"},{"author":{"_account_id":27248,"name":"Prateek Goel","email":"prateek.goel2@tatacommunications.com","username":"prateek.goel"},"change_message_id":"2da8bf5f7feeb039a6bb3598a81d3be8f2ea06ef","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            rows_migrated \u003d data_migrations.migrate(db_api.get_engine())"},{"line_number":280,"context_line":"            print(_(\u0027Migrated %s rows\u0027) % rows_migrated)"},{"line_number":281,"context_line":"        else:"},{"line_number":282,"context_line":"            print(_(\u0027Database migration is up to date. No migration needed.\u0027))"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    @args(\u0027--path\u0027, metavar\u003d\u0027\u003cpath\u003e\u0027, help\u003d\u0027Path to the directory or file \u0027"},{"line_number":285,"context_line":"                                           \u0027where json metadata is stored\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_4d4ec26f","line":282,"range":{"start_line":282,"start_character":21,"end_line":282,"end_character":54},"updated":"2018-02-10 16:41:07.000000000","message":"Should be \"Database is up to date.\"","commit_id":"c6165aa61cf53c190116ac3f9bc9fe73a648cb00"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"67120f28b32ee4362e274260b37e7893f35650d8","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            db_migration.CONTRACT_BRANCH)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        if (contract in curr_heads):"},{"line_number":156,"context_line":"            print(_(\u0027Database is up to date. No upgrades needed.\u0027))"},{"line_number":157,"context_line":"            sys.exit()"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_b9898475","line":156,"range":{"start_line":156,"start_character":48,"end_line":156,"end_character":56},"updated":"2018-02-13 22:41:04.000000000","message":"Why are we changing this?\n\nDitto on all of the cases below.","commit_id":"ac5bc76d1f6cd0ea437c7de29c59f40c594fe51a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"809040e652ba1c38e6dbdaee60afd58a3dae0545","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            db_migration.CONTRACT_BRANCH)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        if (contract in curr_heads):"},{"line_number":156,"context_line":"            print(_(\u0027Database is up to date. No upgrades needed.\u0027))"},{"line_number":157,"context_line":"            sys.exit()"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_ebf38872","line":156,"range":{"start_line":156,"start_character":48,"end_line":156,"end_character":56},"in_reply_to":"3fa0c359_9786acdb","updated":"2018-02-15 12:25:34.000000000","message":"No, my point is why to change the wording on this message. It was added by you not so long ago on commit f268df1cb, these were transformed to prints shortly after in 8682876a8 and now you want to touch every single one of these again. Not only I prefer the migrations wording here (upgrades makes it sound like in other cases some software upgrades like dependencies or glance version needs to be changed) but it is also very late on the cycle to change the strings that are supposed to be translated, which is not only us related change anymore but involves translations string freeze as well.","commit_id":"ac5bc76d1f6cd0ea437c7de29c59f40c594fe51a"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"2fb3471dfbb1532784664583e022be42a2b1b08a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            db_migration.CONTRACT_BRANCH)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        if (contract in curr_heads):"},{"line_number":156,"context_line":"            print(_(\u0027Database is up to date. No upgrades needed.\u0027))"},{"line_number":157,"context_line":"            sys.exit()"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_9786acdb","line":156,"range":{"start_line":156,"start_character":48,"end_line":156,"end_character":56},"in_reply_to":"3fa0c359_b9898475","updated":"2018-02-15 07:26:25.000000000","message":"To be more precise we are modifying.\nAnd for \u0027check feature\u0027 we had this message there, so to have consistency, followed the same.","commit_id":"ac5bc76d1f6cd0ea437c7de29c59f40c594fe51a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"67120f28b32ee4362e274260b37e7893f35650d8","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                           \u0027\"%(e_rev)s\" revision. But, current revisions are\u0027"},{"line_number":223,"context_line":"                           \u0027: %(curr_revs)s \u0027) % {\u0027e_rev\u0027: expand_head,"},{"line_number":224,"context_line":"                                                  \u0027curr_revs\u0027: curr_heads})"},{"line_number":225,"context_line":"        else:"},{"line_number":226,"context_line":"            print(_(\u0027Database expansion is up to date. No expansion needed.\u0027))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def contract(self):"},{"line_number":229,"context_line":"        \"\"\"Run the contraction phase of a rolling upgrade procedure.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_59f16000","line":226,"range":{"start_line":225,"start_character":8,"end_line":226,"end_character":78},"updated":"2018-02-13 22:41:04.000000000","message":"This should be never reached, I think.","commit_id":"ac5bc76d1f6cd0ea437c7de29c59f40c594fe51a"},{"author":{"_account_id":27302,"name":"Shilpa Devharakar","email":"shilpa.devharakar@nttdata.com","username":"shilpa.devharakar"},"change_message_id":"2fb3471dfbb1532784664583e022be42a2b1b08a","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                           \u0027\"%(e_rev)s\" revision. But, current revisions are\u0027"},{"line_number":223,"context_line":"                           \u0027: %(curr_revs)s \u0027) % {\u0027e_rev\u0027: expand_head,"},{"line_number":224,"context_line":"                                                  \u0027curr_revs\u0027: curr_heads})"},{"line_number":225,"context_line":"        else:"},{"line_number":226,"context_line":"            print(_(\u0027Database expansion is up to date. No expansion needed.\u0027))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def contract(self):"},{"line_number":229,"context_line":"        \"\"\"Run the contraction phase of a rolling upgrade procedure.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_d798b41c","line":226,"range":{"start_line":225,"start_character":8,"end_line":226,"end_character":78},"in_reply_to":"3fa0c359_59f16000","updated":"2018-02-15 07:26:25.000000000","message":"If someone tried expansion twice, its user friendly message to operator in that case.","commit_id":"ac5bc76d1f6cd0ea437c7de29c59f40c594fe51a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"576811b5ff7bb1adf3c1c8b325b400c18e0dde23","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                           \u0027\"%(e_rev)s\" revision. But, current revisions are\u0027"},{"line_number":223,"context_line":"                           \u0027: %(curr_revs)s \u0027) % {\u0027e_rev\u0027: expand_head,"},{"line_number":224,"context_line":"                                                  \u0027curr_revs\u0027: curr_heads})"},{"line_number":225,"context_line":"        else:"},{"line_number":226,"context_line":"            print(_(\u0027Database expansion is up to date. No expansion needed.\u0027))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def contract(self):"},{"line_number":229,"context_line":"        \"\"\"Run the contraction phase of a rolling upgrade procedure.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_0b583454","line":226,"range":{"start_line":225,"start_character":8,"end_line":226,"end_character":78},"in_reply_to":"3fa0c359_d798b41c","updated":"2018-02-15 12:27:24.000000000","message":"This was oversight on my behalf the check above I thought would prevent getting here was checking contract_head not expand_head on L211","commit_id":"ac5bc76d1f6cd0ea437c7de29c59f40c594fe51a"}],"glance/tests/functional/test_glance_manage.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"76d4ebe4b59cfc8446069c27a53fafe2baa04127","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        cmd \u003d (\u0027%s -m glance.cmd.manage --config-file %s db %s\u0027 %"},{"line_number":58,"context_line":"               (sys.executable, self.conf_filepath, db_method))"},{"line_number":59,"context_line":"        out \u003d execute(cmd, raise_error\u003dTrue)"},{"line_number":60,"context_line":"        return out"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _check_db(self, expected_exitcode):"},{"line_number":63,"context_line":"        with open(self.conf_filepath, \u0027w\u0027) as conf_file:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_c48724b5","line":60,"range":{"start_line":59,"start_character":8,"end_line":60,"end_character":18},"updated":"2018-02-12 04:34:27.000000000","message":"you can simply say\n\nreturn execute(cmd, raise_error\u003dTrue)","commit_id":"c6165aa61cf53c190116ac3f9bc9fe73a648cb00"}]}