)]}'
{"glance/async/flows/plugins/plugin_opts.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1c600f20cbe092c54f8a73c2ac7e0ba5f08481cb","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Note(jokke): This list contains tuples of config options for import plugins."},{"line_number":21,"context_line":"# When new plugin is introduced it\u0027s config options needs to be added to this"},{"line_number":22,"context_line":"# list so that they can be processed when config generator is used to generate"},{"line_number":23,"context_line":"# the glance-image-import.conf.sample. The module needs to be imported as the"},{"line_number":24,"context_line":"# Glance release packaged example(s) above and the first part of the tuple"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_1a46037e","line":21,"range":{"start_line":21,"start_character":32,"end_line":21,"end_character":36},"updated":"2018-02-07 15:15:44.000000000","message":"nit: s/it\u0027s/its/\nalso s/needs/need/","commit_id":"563f27e730fd741f448a07c846ad6633a590e365"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"cef77fb729a4c8d8e87f93ddf1d37d18c56f03a9","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Note(jokke): This list contains tuples of config options for import plugins."},{"line_number":21,"context_line":"# When new plugin is introduced it\u0027s config options needs to be added to this"},{"line_number":22,"context_line":"# list so that they can be processed when config generator is used to generate"},{"line_number":23,"context_line":"# the glance-image-import.conf.sample. The module needs to be imported as the"},{"line_number":24,"context_line":"# Glance release packaged example(s) above and the first part of the tuple"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_d5b14c91","line":21,"range":{"start_line":21,"start_character":32,"end_line":21,"end_character":36},"in_reply_to":"3fa0c359_1a46037e","updated":"2018-02-07 15:42:10.000000000","message":"Done","commit_id":"563f27e730fd741f448a07c846ad6633a590e365"}],"glance/opts.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"0f8cbe72a9d0b6c48c3d3dc8e0ff3b623624ec6d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"def list_image_import_opts():"},{"line_number":162,"context_line":"    \"\"\"Return a list of oslo_config options available for Image Import\"\"\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    opts \u003d _image_import_opts.append(plugin_opts.get_plugin_opts())"},{"line_number":165,"context_line":"    return [(g, copy.deepcopy(o)) for g, o in opts]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_f570f3de","line":164,"range":{"start_line":164,"start_character":30,"end_line":164,"end_character":36},"updated":"2018-02-08 05:59:55.000000000","message":"it should be extend IMO otherwise opts will look like;\n\n[(\u0027image_import_opts\u0027, glance.async.flows.api_image_import.api_import_opts), [(\u0027inject_metadata_properties\u0027, glance.async.flows.plugins.inject_image_metadata.inject_metadata_opts)]]\n\n(list within list) and what we expected is only tuples in list;\n\n[(\u0027image_import_opts\u0027, glance.async.flows.api_image_import.api_import_opts), (\u0027inject_metadata_properties\u0027, glance.async.flows.plugins.inject_image_metadata.inject_metadata_opts)]","commit_id":"e53fd8bbc73875ba444ab48e3ad038a112ce07b1"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"db6732d7e10a5809a0febe610e8623460716ab8a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"def list_image_import_opts():"},{"line_number":162,"context_line":"    \"\"\"Return a list of oslo_config options available for Image Import\"\"\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    opts \u003d _image_import_opts.append(plugin_opts.get_plugin_opts())"},{"line_number":165,"context_line":"    return [(g, copy.deepcopy(o)) for g, o in opts]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_44881770","line":164,"range":{"start_line":164,"start_character":30,"end_line":164,"end_character":36},"in_reply_to":"3fa0c359_f570f3de","updated":"2018-02-08 10:05:54.000000000","message":"you are correct, I did read that exactly wrong way around from the docs.","commit_id":"e53fd8bbc73875ba444ab48e3ad038a112ce07b1"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2a2a5a23f309ce46301f1ba6aaa99a22fdd2141a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"def list_image_import_opts():"},{"line_number":162,"context_line":"    \"\"\"Return a list of oslo_config options available for Image Import\"\"\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    opts \u003d _image_import_opts.extend(plugin_opts.get_plugin_opts())"},{"line_number":165,"context_line":"    return [(g, copy.deepcopy(o)) for g, o in opts]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_dd9b7c63","line":164,"range":{"start_line":164,"start_character":11,"end_line":164,"end_character":36},"updated":"2018-02-09 07:48:27.000000000","message":"extend returns None","commit_id":"824badc1890206695eb335582a804d9ecabb4d67"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"2a2a5a23f309ce46301f1ba6aaa99a22fdd2141a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    \"\"\"Return a list of oslo_config options available for Image Import\"\"\""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    opts \u003d _image_import_opts.extend(plugin_opts.get_plugin_opts())"},{"line_number":165,"context_line":"    return [(g, copy.deepcopy(o)) for g, o in opts]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_ddb4dcd3","line":165,"range":{"start_line":165,"start_character":46,"end_line":165,"end_character":50},"updated":"2018-02-09 07:48:27.000000000","message":"_image_import_opts","commit_id":"824badc1890206695eb335582a804d9ecabb4d67"}]}