)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"98c145d06d4c9ed2fca241327f981699113a4c38","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for PartialTask list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is to have the database to return a partial-task list on users"},{"line_number":10,"context_line":"invoking \u0027GET /v2/tasks\u0027. A partial-task includes all the values except"},{"line_number":11,"context_line":"the \u0027Text\u0027 columns(input, result \u0026 message). Returning list of partial tasks"},{"line_number":12,"context_line":"will help in reducing the response time when the user queries for the list of tasks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"AAAAUH%2F%2FplE%3D","line":9,"updated":"2014-01-10 04:06:05.000000000","message":"The explanation looks really good. However, can we please have this in bullet points and I believe sentence # 2 should come before sentence # 1. (Basically, you want to define partial task before explaining what it does right?)","commit_id":"612d96e01c1b0d7d17c0d86b66c6ac2cbf3d3de6"}],"glance/api/authorization.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"7d6748dd718e8f1fa9feab5ab532bbcf65c9f263","unresolved":false,"context_lines":[{"line_number":272,"context_line":"                      proxy_class\u003dTaskDetailProxy,"},{"line_number":273,"context_line":"                      proxy_kwargs\u003dkwargs)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def new_task_detail(self, context, task_id, task_input, message, result):"},{"line_number":276,"context_line":"        return super(TaskDetailFactoryProxy, self)\\"},{"line_number":277,"context_line":"            .new_task_detail(context, task_id, task_input, message, result)"},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F%2BjIM%3D","line":275,"updated":"2013-11-24 08:12:31.000000000","message":"If we only call super here directly, we don\u0027t need explicit override this method.","commit_id":"ca106acf9bd760a917f0b15199a54be38896054a"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"98c145d06d4c9ed2fca241327f981699113a4c38","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        super(TaskProxy, self).__init__(task)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"class TaskDetailProxy(glance.domain.proxy.TaskDetail):"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def __init__(self, task_detail):"},{"line_number":389,"context_line":"        self.task_detail \u003d task_detail"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUH%2F%2Fpkc%3D","line":386,"updated":"2014-01-10 04:06:05.000000000","message":"What does Mark have to say about \u0027TaskDetails\u0027 vs \u0027TaskDetail\u0027. Personally, I prefer \u0027TaskDetails\u0027.","commit_id":"612d96e01c1b0d7d17c0d86b66c6ac2cbf3d3de6"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"fb080824c4720535e155de642f331d2e7da24f37","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        super(TaskProxy, self).__init__(task)"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"class TaskDetailProxy(glance.domain.proxy.TaskDetail):"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def __init__(self, task_detail):"},{"line_number":389,"context_line":"        self.task_detail \u003d task_detail"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUH%2F%2FMdI%3D","line":386,"in_reply_to":"AAAAUH%2F%2Fpkc%3D","updated":"2014-01-16 15:23:43.000000000","message":"Hi Nikhil, TaskDetails is probably the right one. If you confirm me on this, I will go ahead and change it.","commit_id":"612d96e01c1b0d7d17c0d86b66c6ac2cbf3d3de6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"98c145d06d4c9ed2fca241327f981699113a4c38","unresolved":false,"context_lines":[{"line_number":420,"context_line":"    def __init__(self, task_detail_factory, context):"},{"line_number":421,"context_line":"        self.task_detail_factory \u003d task_detail_factory"},{"line_number":422,"context_line":"        self.context \u003d context"},{"line_number":423,"context_line":"        super(TaskDetailFactoryProxy, self) \\"},{"line_number":424,"context_line":"            .__init__(task_detail_factory,"},{"line_number":425,"context_line":"                      proxy_class\u003dTaskDetailProxy,"},{"line_number":426,"context_line":"                      proxy_kwargs\u003dNone)"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUH%2F%2Fpk4%3D","line":423,"updated":"2014-01-10 04:06:05.000000000","message":"If you bring \u0027self\u0027 here to the next line, you can avoid the backslash.\n\nI remember there was a plan to remove all the \u0027\\\u0027 from OS so, to help that momentum these can be our 2 cents.","commit_id":"612d96e01c1b0d7d17c0d86b66c6ac2cbf3d3de6"}],"glance/api/policy.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"7d6748dd718e8f1fa9feab5ab532bbcf65c9f263","unresolved":false,"context_lines":[{"line_number":420,"context_line":"                                               proxy_class\u003dTaskProxy,"},{"line_number":421,"context_line":"                                               proxy_kwargs\u003dproxy_kwargs)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def new_task(self, context, task_type, owner):"},{"line_number":424,"context_line":"        return super(TaskFactoryProxy, self).new_task(context,"},{"line_number":425,"context_line":"                                                      task_type,"},{"line_number":426,"context_line":"                                                      owner)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F%2BjH0%3D","line":423,"updated":"2013-11-24 08:12:31.000000000","message":"If we only call super here directly, we don\u0027t need explicit override this method.","commit_id":"ca106acf9bd760a917f0b15199a54be38896054a"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"7d6748dd718e8f1fa9feab5ab532bbcf65c9f263","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                      proxy_class\u003dTaskDetailProxy,"},{"line_number":439,"context_line":"                      proxy_kwargs\u003dproxy_kwargs)"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    def new_task_detail(self, context, task_id, task_input, message, result):"},{"line_number":442,"context_line":"        return super(TaskDetailFactoryProxy, self).new_task_detail(context,"},{"line_number":443,"context_line":"                                                                   task_id,"},{"line_number":444,"context_line":"                                                                   task_input,"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F%2BjHw%3D","line":441,"updated":"2013-11-24 08:12:31.000000000","message":"If we only call super here directly, we don\u0027t need explicit override this method.","commit_id":"ca106acf9bd760a917f0b15199a54be38896054a"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"98c145d06d4c9ed2fca241327f981699113a4c38","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        self.policy \u003d task_policy"},{"line_number":367,"context_line":"        self.task_repo \u003d task_repo"},{"line_number":368,"context_line":"        proxy_kwargs \u003d {\u0027context\u0027: self.context, \u0027policy\u0027: self.policy}"},{"line_number":369,"context_line":"        super(TaskRepoProxy, self) \\"},{"line_number":370,"context_line":"            .__init__(task_repo,"},{"line_number":371,"context_line":"                      task_proxy_class\u003dTaskProxy,"},{"line_number":372,"context_line":"                      task_proxy_kwargs\u003dproxy_kwargs,"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUH%2F%2FpkU%3D","line":369,"updated":"2014-01-10 04:06:05.000000000","message":"same as before, bringing self to the next line can avoid \u0027\\\u0027","commit_id":"612d96e01c1b0d7d17c0d86b66c6ac2cbf3d3de6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"98c145d06d4c9ed2fca241327f981699113a4c38","unresolved":false,"context_lines":[{"line_number":411,"context_line":"        self.context \u003d context"},{"line_number":412,"context_line":"        self.policy \u003d policy"},{"line_number":413,"context_line":"        proxy_kwargs \u003d {\u0027context\u0027: self.context, \u0027policy\u0027: self.policy}"},{"line_number":414,"context_line":"        super(TaskDetailFactoryProxy, self) \\"},{"line_number":415,"context_line":"            .__init__(task_detail_factory,"},{"line_number":416,"context_line":"                      proxy_class\u003dTaskDetailProxy,"},{"line_number":417,"context_line":"                      proxy_kwargs\u003dproxy_kwargs)"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUH%2F%2FpkQ%3D","line":414,"updated":"2014-01-10 04:06:05.000000000","message":"ditto","commit_id":"612d96e01c1b0d7d17c0d86b66c6ac2cbf3d3de6"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3565d7a4d5d7e0bee799b26ac441cc67b3e4d0fc","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        self.task_repo \u003d task_repo"},{"line_number":366,"context_line":"        proxy_kwargs \u003d {\u0027context\u0027: self.context, \u0027policy\u0027: self.policy}"},{"line_number":367,"context_line":"        super(TaskRepoProxy,"},{"line_number":368,"context_line":"              self)  .__init__(task_repo,"},{"line_number":369,"context_line":"                               task_proxy_class\u003dTaskProxy,"},{"line_number":370,"context_line":"                               task_proxy_kwargs\u003dproxy_kwargs,"},{"line_number":371,"context_line":"                               task_details_proxy_class\u003dTaskDetailsProxy,"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Fouo%3D","line":368,"updated":"2014-02-11 22:08:14.000000000","message":"that whitespace after \"self)\" could be an issue","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"621a6d47fab60c850e06f5e53bb9f4436cf7bfae","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        self.task_repo \u003d task_repo"},{"line_number":366,"context_line":"        proxy_kwargs \u003d {\u0027context\u0027: self.context, \u0027policy\u0027: self.policy}"},{"line_number":367,"context_line":"        super(TaskRepoProxy,"},{"line_number":368,"context_line":"              self)  .__init__(task_repo,"},{"line_number":369,"context_line":"                               task_proxy_class\u003dTaskProxy,"},{"line_number":370,"context_line":"                               task_proxy_kwargs\u003dproxy_kwargs,"},{"line_number":371,"context_line":"                               task_details_proxy_class\u003dTaskDetailsProxy,"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FnOo%3D","line":368,"in_reply_to":"AAAAUX%2F%2Fouo%3D","updated":"2014-02-12 00:46:25.000000000","message":"Ah good eye.","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"4ed098b6a2dbd2133ad5c8c6f7c381ef8f5f3664","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        self.task_repo \u003d task_repo"},{"line_number":366,"context_line":"        proxy_kwargs \u003d {\u0027context\u0027: self.context, \u0027policy\u0027: self.policy}"},{"line_number":367,"context_line":"        super(TaskRepoProxy,"},{"line_number":368,"context_line":"              self)  .__init__(task_repo,"},{"line_number":369,"context_line":"                               task_proxy_class\u003dTaskProxy,"},{"line_number":370,"context_line":"                               task_proxy_kwargs\u003dproxy_kwargs,"},{"line_number":371,"context_line":"                               task_details_proxy_class\u003dTaskDetailsProxy,"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FlG8%3D","line":368,"in_reply_to":"AAAAUX%2F%2Fouo%3D","updated":"2014-02-12 11:43:20.000000000","message":"sorry about this. i don\u0027t know how I missed the extra space. thanks for pointing me out.","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"}],"glance/api/v2/tasks.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"98c145d06d4c9ed2fca241327f981699113a4c38","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        params.pop(\u0027marker\u0027, None)"},{"line_number":263,"context_line":"        query \u003d urllib.urlencode(params)"},{"line_number":264,"context_line":"        body \u003d {"},{"line_number":265,"context_line":"            \u0027tasks\u0027: [self._format_task(self.partial_task_schema, i)"},{"line_number":266,"context_line":"                      for i in result[\u0027tasks\u0027]],"},{"line_number":267,"context_line":"            \u0027first\u0027: \u0027/v2/tasks\u0027,"},{"line_number":268,"context_line":"            \u0027schema\u0027: \u0027/v2/schemas/tasks\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUH%2F%2Fpj8%3D","line":265,"updated":"2014-01-10 04:06:05.000000000","message":"can we please rename this \u0027i\u0027 variable to \u0027task\u0027 instead?","commit_id":"612d96e01c1b0d7d17c0d86b66c6ac2cbf3d3de6"}],"glance/db/__init__.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"7d6748dd718e8f1fa9feab5ab532bbcf65c9f263","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            msg \u003d _(\u0027Could not find task %s\u0027) % task.task_id"},{"line_number":389,"context_line":"            raise exception.NotFound(msg)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        return self._format_task_from_db(updated_values), self.\\"},{"line_number":392,"context_line":"            _format_task_detail_from_db(updated_values)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def add(self, task, task_detail\u003dNone):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F%2BjHE%3D","line":391,"updated":"2013-11-24 08:12:31.000000000","message":"Under current discussion decision, we don\u0027t need return value for \u0027save\u0027, \u0027add\u0027 and \u0027remove\u0027.\n\nhttps://review.openstack.org/#/c/54198/19/glance/db/__init__.py","commit_id":"ca106acf9bd760a917f0b15199a54be38896054a"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"98c145d06d4c9ed2fca241327f981699113a4c38","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        except (exception.NotFound, exception.Forbidden):"},{"line_number":333,"context_line":"            msg \u003d _(\u0027Could not find task %s\u0027) % task_id"},{"line_number":334,"context_line":"            raise exception.NotFound(msg)"},{"line_number":335,"context_line":"        return self._format_task_from_db(db_api_task), self.\\"},{"line_number":336,"context_line":"            _format_task_detail_from_db(db_api_task)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def list_tasks(self,"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUH%2F%2Fpj0%3D","line":335,"updated":"2014-01-10 04:06:05.000000000","message":"no need of the \u0027\\\u0027","commit_id":"612d96e01c1b0d7d17c0d86b66c6ac2cbf3d3de6"}],"glance/domain/__init__.py":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"a2ed427365cf27e4db7098099743dda8dd3423ae","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"class TaskDetails(object):"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    def __init__(self, task_id, task_input, message, result):"},{"line_number":384,"context_line":"        if task_id is None:"},{"line_number":385,"context_line":"            raise exception.TaskException(_(\u0027task_id is required to create \u0027"},{"line_number":386,"context_line":"                                            \u0027a new TaskDetails object\u0027))"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAUH%2F9soQ%3D","line":383,"updated":"2014-02-04 21:53:39.000000000","message":"should we have task_input,message,result to have default value None since they are optional? But it is not necessary I guess.","commit_id":"5108cb4b580c046a76eb21ce03fe5a26776182e3"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"db95dfa89901f26fe1174cf06a99a55912d58276","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"class TaskDetails(object):"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    def __init__(self, task_id, task_input, message, result):"},{"line_number":384,"context_line":"        if task_id is None:"},{"line_number":385,"context_line":"            raise exception.TaskException(_(\u0027task_id is required to create \u0027"},{"line_number":386,"context_line":"                                            \u0027a new TaskDetails object\u0027))"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAUH%2F9oxo%3D","line":383,"in_reply_to":"AAAAUH%2F9soQ%3D","updated":"2014-02-05 13:29:23.000000000","message":"Yes, in here we may not need it as generally we create a new instance of TaskDetails using TaskFactory.","commit_id":"5108cb4b580c046a76eb21ce03fe5a26776182e3"}],"glance/gateway.py":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"a2ed427365cf27e4db7098099743dda8dd3423ae","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            notifier_task_factory, context)"},{"line_number":99,"context_line":"        return authorized_task_factory"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get_task_details_factory(self, context):"},{"line_number":102,"context_line":"        td_factory \u003d glance.domain.TaskDetailsFactory()"},{"line_number":103,"context_line":"        policy_td_factory \u003d policy.TaskDetailsFactoryProxy("},{"line_number":104,"context_line":"            td_factory, context, self.policy)"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAUH%2F9spE%3D","line":101,"updated":"2014-02-04 21:53:39.000000000","message":"do we need a separate fn for this? can we pass an arg in get_task_factory fn and do an if stmt to assign task_factory to details or just task factory?","commit_id":"5108cb4b580c046a76eb21ce03fe5a26776182e3"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"db95dfa89901f26fe1174cf06a99a55912d58276","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            notifier_task_factory, context)"},{"line_number":99,"context_line":"        return authorized_task_factory"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get_task_details_factory(self, context):"},{"line_number":102,"context_line":"        td_factory \u003d glance.domain.TaskDetailsFactory()"},{"line_number":103,"context_line":"        policy_td_factory \u003d policy.TaskDetailsFactoryProxy("},{"line_number":104,"context_line":"            td_factory, context, self.policy)"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAUH%2F9ouA%3D","line":101,"in_reply_to":"AAAAUH%2F9spE%3D","updated":"2014-02-05 13:29:23.000000000","message":"Thanks Iccha for suggesting me this point.\n\nMade the following changes and pushed a new patchset(24):\n- removed TaskDetailsFactory implementation from domain module.\n- removed TaskDetailsFactoryProxy implementation from all proxies module.\n- instead made necessary changes to be able to create new instance of TaskDetails from TaskFactory itself instead of using a separate factory(TaskDetailsFactory).\n- updated the tests to remove any reference to TaskDetailsFactory and instead use TaskFactory for creating new instance of TaskDetails.\n\nThought this would be a better approach as there was not much logic around creating a new instance of TaskDetails at domain and proxies level. This also helped me to reduce some reasonable amount of code.\n\nPlease do let me know your thoughts.","commit_id":"5108cb4b580c046a76eb21ce03fe5a26776182e3"}],"glance/notifier.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3565d7a4d5d7e0bee799b26ac441cc67b3e4d0fc","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        payload[\u0027deleted\u0027] \u003d True"},{"line_number":295,"context_line":"        payload[\u0027deleted_at\u0027] \u003d timeutils.isotime()"},{"line_number":296,"context_line":"        self.notifier.info(\u0027task.delete\u0027, payload)"},{"line_number":297,"context_line":"        return super(TaskRepoProxy, self).add(task)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"class TaskFactoryProxy(glance.domain.proxy.TaskFactory):"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FomU%3D","side":"PARENT","line":297,"updated":"2014-02-11 22:08:14.000000000","message":"wow!! good catch","commit_id":"22408ff5bcc3914fea07e1929bb240a8e979e610"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"4ed098b6a2dbd2133ad5c8c6f7c381ef8f5f3664","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        payload[\u0027deleted\u0027] \u003d True"},{"line_number":295,"context_line":"        payload[\u0027deleted_at\u0027] \u003d timeutils.isotime()"},{"line_number":296,"context_line":"        self.notifier.info(\u0027task.delete\u0027, payload)"},{"line_number":297,"context_line":"        return super(TaskRepoProxy, self).add(task)"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"class TaskFactoryProxy(glance.domain.proxy.TaskFactory):"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FlGw%3D","side":"PARENT","line":297,"in_reply_to":"AAAAUX%2F%2FomU%3D","updated":"2014-02-12 11:43:20.000000000","message":"thanks nikhil. :)","commit_id":"22408ff5bcc3914fea07e1929bb240a8e979e610"}],"glance/tests/unit/test_auth.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"1396854d50112e54e136e931aeb1207fb1e7b2f8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import datetime"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import stubout"},{"line_number":23,"context_line":"import webob"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FoOU%3D","line":20,"updated":"2013-10-31 07:56:19.000000000","message":"order issue","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"f60bfa5f93c39eea75e75af241fe94141b756dee","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import json"},{"line_number":20,"context_line":"import datetime"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import stubout"},{"line_number":23,"context_line":"import webob"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Fn7Q%3D","line":20,"in_reply_to":"AAAATn%2F%2FoOU%3D","updated":"2013-10-31 09:36:00.000000000","message":"thanks zhi. fixed it.","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"174277d774babc8ab537a98b52d554293507b900","unresolved":false,"context_lines":[{"line_number":970,"context_line":""},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"def _new_sparse_task(task_id):"},{"line_number":973,"context_line":"    now \u003d datetime.datetime.now()"},{"line_number":974,"context_line":"    return glance.domain.SparseTask(task_id,"},{"line_number":975,"context_line":"                                    \u0027import\u0027,"},{"line_number":976,"context_line":"                                    \u0027pending\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FriY%3D","line":973,"updated":"2013-10-30 14:15:01.000000000","message":"utcnow()","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"f60bfa5f93c39eea75e75af241fe94141b756dee","unresolved":false,"context_lines":[{"line_number":970,"context_line":""},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"def _new_sparse_task(task_id):"},{"line_number":973,"context_line":"    now \u003d datetime.datetime.now()"},{"line_number":974,"context_line":"    return glance.domain.SparseTask(task_id,"},{"line_number":975,"context_line":"                                    \u0027import\u0027,"},{"line_number":976,"context_line":"                                    \u0027pending\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Fn7E%3D","line":973,"in_reply_to":"AAAATn%2F%2FriY%3D","updated":"2013-10-31 09:36:00.000000000","message":"thanks nikhil. changed to utcnow()","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"}],"glance/tests/unit/test_db.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"174277d774babc8ab537a98b52d554293507b900","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        request \u003d unit_test_utils.get_fake_request(USER1, TENANT1)"},{"line_number":595,"context_line":"        task_values \u003d {\u0027type\u0027: \u0027import\u0027, \u0027input\u0027: self.fake_task_input}"},{"line_number":596,"context_line":"        task \u003d self.task_factory.new_task(request.context,"},{"line_number":597,"context_line":"                                          task_values)"},{"line_number":598,"context_line":"        self.assertEqual(task.updated_at, task.created_at)"},{"line_number":599,"context_line":"        self.task_repo.add(task)"},{"line_number":600,"context_line":"        retrieved_task \u003d self.task_repo.get(task.task_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FriM%3D","line":597,"updated":"2013-10-30 14:15:01.000000000","message":"formatting not necessary, same in the gateway file","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"f60bfa5f93c39eea75e75af241fe94141b756dee","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        request \u003d unit_test_utils.get_fake_request(USER1, TENANT1)"},{"line_number":595,"context_line":"        task_values \u003d {\u0027type\u0027: \u0027import\u0027, \u0027input\u0027: self.fake_task_input}"},{"line_number":596,"context_line":"        task \u003d self.task_factory.new_task(request.context,"},{"line_number":597,"context_line":"                                          task_values)"},{"line_number":598,"context_line":"        self.assertEqual(task.updated_at, task.created_at)"},{"line_number":599,"context_line":"        self.task_repo.add(task)"},{"line_number":600,"context_line":"        retrieved_task \u003d self.task_repo.get(task.task_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Fn6s%3D","line":597,"in_reply_to":"AAAATn%2F%2FriM%3D","updated":"2013-10-31 09:36:00.000000000","message":"got it fixed.","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"174277d774babc8ab537a98b52d554293507b900","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        request \u003d unit_test_utils.get_fake_request(USER1, TENANT1)"},{"line_number":605,"context_line":"        task_values \u003d {"},{"line_number":606,"context_line":"            \u0027type\u0027: \u0027fake\u0027,"},{"line_number":607,"context_line":"            \u0027status\u0027: \u0027pending\u0027,"},{"line_number":608,"context_line":"            \u0027input\u0027: self.fake_task_input"},{"line_number":609,"context_line":"        }"},{"line_number":610,"context_line":"        self.assertRaises(exception.InvalidTaskType,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FriE%3D","line":607,"updated":"2013-10-30 14:15:01.000000000","message":"same as above","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"f60bfa5f93c39eea75e75af241fe94141b756dee","unresolved":false,"context_lines":[{"line_number":604,"context_line":"        request \u003d unit_test_utils.get_fake_request(USER1, TENANT1)"},{"line_number":605,"context_line":"        task_values \u003d {"},{"line_number":606,"context_line":"            \u0027type\u0027: \u0027fake\u0027,"},{"line_number":607,"context_line":"            \u0027status\u0027: \u0027pending\u0027,"},{"line_number":608,"context_line":"            \u0027input\u0027: self.fake_task_input"},{"line_number":609,"context_line":"        }"},{"line_number":610,"context_line":"        self.assertRaises(exception.InvalidTaskType,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Fn60%3D","line":607,"in_reply_to":"AAAATn%2F%2FriE%3D","updated":"2013-10-31 09:36:00.000000000","message":"got it fixed.","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"9779129a54a3a39c6aa474b8afcdc15e04ce6ed0","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    def test_add_task_with_wrong_type(self):"},{"line_number":603,"context_line":"        request \u003d unit_test_utils.get_fake_request(USER1, TENANT1)"},{"line_number":604,"context_line":"        task_values \u003d {\u0027type\u0027: \u0027fake\u0027, \u0027status\u0027: \u0027pending\u0027,"},{"line_number":605,"context_line":"                       \u0027input\u0027: self.fake_task_input }"},{"line_number":606,"context_line":"        self.assertRaises(exception.InvalidTaskType,"},{"line_number":607,"context_line":"                          self.task_factory.new_task,"},{"line_number":608,"context_line":"                          request.context,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2Fn68%3D","line":605,"updated":"2013-10-31 09:30:31.000000000","message":"nit: an useless space","commit_id":"7027a958a98389a82ab542c866831502fcf2d867"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"e91ac722105acb7d43f596c8a3a9fe15e2df5479","unresolved":false,"context_lines":[{"line_number":602,"context_line":"    def test_add_task_with_wrong_type(self):"},{"line_number":603,"context_line":"        request \u003d unit_test_utils.get_fake_request(USER1, TENANT1)"},{"line_number":604,"context_line":"        task_values \u003d {\u0027type\u0027: \u0027fake\u0027, \u0027status\u0027: \u0027pending\u0027,"},{"line_number":605,"context_line":"                       \u0027input\u0027: self.fake_task_input }"},{"line_number":606,"context_line":"        self.assertRaises(exception.InvalidTaskType,"},{"line_number":607,"context_line":"                          self.task_factory.new_task,"},{"line_number":608,"context_line":"                          request.context,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F%2Fn5k%3D","line":605,"in_reply_to":"AAAATn%2F%2Fn68%3D","updated":"2013-10-31 09:37:11.000000000","message":"zhi, will fix this change in my next check-in","commit_id":"7027a958a98389a82ab542c866831502fcf2d867"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3565d7a4d5d7e0bee799b26ac441cc67b3e4d0fc","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        self.assertEqual(task.task_id, UUID1)"},{"line_number":567,"context_line":"        self.assertEqual(task.type, \u0027import\u0027)"},{"line_number":568,"context_line":"        self.assertEqual(task.status, \u0027pending\u0027)"},{"line_number":569,"context_line":"        self.assertEqual(task.task_id, task.task_id)"},{"line_number":570,"context_line":"        self.assertEqual(task_details.input, self.fake_task_input)"},{"line_number":571,"context_line":"        self.assertEqual(task_details.result, \u0027\u0027)"},{"line_number":572,"context_line":"        self.assertEqual(task.owner, TENANT1)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FolA%3D","line":569,"updated":"2014-02-11 22:08:14.000000000","message":"what is this testing and the line 566 should cover it, no?","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"4ed098b6a2dbd2133ad5c8c6f7c381ef8f5f3664","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        self.assertEqual(task.task_id, UUID1)"},{"line_number":567,"context_line":"        self.assertEqual(task.type, \u0027import\u0027)"},{"line_number":568,"context_line":"        self.assertEqual(task.status, \u0027pending\u0027)"},{"line_number":569,"context_line":"        self.assertEqual(task.task_id, task.task_id)"},{"line_number":570,"context_line":"        self.assertEqual(task_details.input, self.fake_task_input)"},{"line_number":571,"context_line":"        self.assertEqual(task_details.result, \u0027\u0027)"},{"line_number":572,"context_line":"        self.assertEqual(task.owner, TENANT1)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FlGA%3D","line":569,"in_reply_to":"AAAAUX%2F%2FolA%3D","updated":"2014-02-12 11:43:20.000000000","message":"it is supposed be \u0027self.assertEqual(task.task_id, task_details.task_id)\u0027 while refactoring the code for task_details miss spelled it as \u0027task\u0027. Thanks for points me this.","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"}],"glance/tests/unit/test_domain.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"174277d774babc8ab537a98b52d554293507b900","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from glance.common import exception"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Frh4%3D","line":15,"updated":"2013-10-30 14:15:01.000000000","message":"needs a blank line before import","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"f60bfa5f93c39eea75e75af241fe94141b756dee","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"import datetime"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from glance.common import exception"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Fn6U%3D","line":15,"in_reply_to":"AAAATn%2F%2Frh4%3D","updated":"2013-10-31 09:36:00.000000000","message":"removed this line. not required as i am utcnow().","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"174277d774babc8ab537a98b52d554293507b900","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def setUp(self):"},{"line_number":334,"context_line":"        super(TestSparseTask, self).setUp()"},{"line_number":335,"context_line":"        now \u003d datetime.datetime.now()"},{"line_number":336,"context_line":"        self.base_values \u003d [None, now, now]"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def test_sparse_task_init(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Frh0%3D","line":335,"updated":"2013-10-30 14:15:01.000000000","message":"utcnow()","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"}],"glance/tests/unit/test_policy.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"174277d774babc8ab537a98b52d554293507b900","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    def setUp(self):"},{"line_number":457,"context_line":"        super(TestSparseTaskPolicy, self).setUp()"},{"line_number":458,"context_line":"        self.task_repo_stub \u003d self.TaskRepoStub()"},{"line_number":459,"context_line":"        self.policy \u003d unit_test_utils.FakePolicyEnforcer()"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def test_get_tasks_allowed(self):"},{"line_number":462,"context_line":"        rules \u003d {\"get_task\": True}"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Frho%3D","line":459,"updated":"2013-10-30 14:15:01.000000000","message":"we should use a mock here. please see https://review.openstack.org/#/c/53451/1/glance/tests/unit/test_policy.py for ref","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"f60bfa5f93c39eea75e75af241fe94141b756dee","unresolved":false,"context_lines":[{"line_number":456,"context_line":"    def setUp(self):"},{"line_number":457,"context_line":"        super(TestSparseTaskPolicy, self).setUp()"},{"line_number":458,"context_line":"        self.task_repo_stub \u003d self.TaskRepoStub()"},{"line_number":459,"context_line":"        self.policy \u003d unit_test_utils.FakePolicyEnforcer()"},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"    def test_get_tasks_allowed(self):"},{"line_number":462,"context_line":"        rules \u003d {\"get_task\": True}"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Fn6I%3D","line":459,"in_reply_to":"AAAATn%2F%2Frho%3D","updated":"2013-10-31 09:36:00.000000000","message":"thanks for the reference nikhil. Changed the code to use mock.","commit_id":"66e42d6e892f36a49d7a0b8b0e06ed56a9ed95d2"}],"glance/tests/unit/v2/test_tasks_resource.py":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3565d7a4d5d7e0bee799b26ac441cc67b3e4d0fc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    return obj"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def _domain_fixture(id, **kwargs):"},{"line_number":65,"context_line":"    default_datetime \u003d timeutils.utcnow()"},{"line_number":66,"context_line":"    task_properties \u003d {"},{"line_number":67,"context_line":"        \u0027task_id\u0027: id,"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FoLU%3D","line":64,"updated":"2014-02-11 22:08:14.000000000","message":"should we get rid of this built-in var \u0027id\u0027 here and start using task_id or something?","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"4ed098b6a2dbd2133ad5c8c6f7c381ef8f5f3664","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    return obj"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def _domain_fixture(id, **kwargs):"},{"line_number":65,"context_line":"    default_datetime \u003d timeutils.utcnow()"},{"line_number":66,"context_line":"    task_properties \u003d {"},{"line_number":67,"context_line":"        \u0027task_id\u0027: id,"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Fk3o%3D","line":64,"in_reply_to":"AAAAUX%2F%2FoLU%3D","updated":"2014-02-12 11:43:20.000000000","message":"sure, will changed it to task_id. thanks nikhil.","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3565d7a4d5d7e0bee799b26ac441cc67b3e4d0fc","unresolved":false,"context_lines":[{"line_number":64,"context_line":"def _domain_fixture(id, **kwargs):"},{"line_number":65,"context_line":"    default_datetime \u003d timeutils.utcnow()"},{"line_number":66,"context_line":"    task_properties \u003d {"},{"line_number":67,"context_line":"        \u0027task_id\u0027: id,"},{"line_number":68,"context_line":"        \u0027status\u0027: kwargs.get(\u0027status\u0027, \u0027pending\u0027),"},{"line_number":69,"context_line":"        \u0027task_type\u0027: kwargs.get(\u0027type\u0027, \u0027import\u0027),"},{"line_number":70,"context_line":"        \u0027owner\u0027: kwargs.get(\u0027owner\u0027, None),"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FoG0%3D","line":67,"updated":"2014-02-11 22:08:14.000000000","message":"can we please get rid of this built-in var \u0027id\u0027 and use \u0027task_id\u0027 instead?","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"4ed098b6a2dbd2133ad5c8c6f7c381ef8f5f3664","unresolved":false,"context_lines":[{"line_number":64,"context_line":"def _domain_fixture(id, **kwargs):"},{"line_number":65,"context_line":"    default_datetime \u003d timeutils.utcnow()"},{"line_number":66,"context_line":"    task_properties \u003d {"},{"line_number":67,"context_line":"        \u0027task_id\u0027: id,"},{"line_number":68,"context_line":"        \u0027status\u0027: kwargs.get(\u0027status\u0027, \u0027pending\u0027),"},{"line_number":69,"context_line":"        \u0027task_type\u0027: kwargs.get(\u0027type\u0027, \u0027import\u0027),"},{"line_number":70,"context_line":"        \u0027owner\u0027: kwargs.get(\u0027owner\u0027, None),"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Fk3w%3D","line":67,"in_reply_to":"AAAAUX%2F%2FoG0%3D","updated":"2014-02-12 11:43:20.000000000","message":"sure, will changed it to task_id. thanks nikhil.","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3565d7a4d5d7e0bee799b26ac441cc67b3e4d0fc","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        response \u003d webob.Response()"},{"line_number":646,"context_line":"        self.serializer.create(response, self.fixtures[3])"},{"line_number":647,"context_line":"        self.assertEqual(response.status_int, 201)"},{"line_number":648,"context_line":"        self.assertEqual(self.fixtures[3][\u0027task\u0027].task_id,"},{"line_number":649,"context_line":"                         jsonutils.loads(response.body)[\u0027id\u0027])"},{"line_number":650,"context_line":"        self.assertTrue(\u0027expires_at\u0027 in jsonutils.loads(response.body))"},{"line_number":651,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FoHk%3D","line":648,"updated":"2014-02-11 22:08:14.000000000","message":"Feel like we should also check the [\u0027task_details\u0027].task_id part too.","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"4ed098b6a2dbd2133ad5c8c6f7c381ef8f5f3664","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        response \u003d webob.Response()"},{"line_number":646,"context_line":"        self.serializer.create(response, self.fixtures[3])"},{"line_number":647,"context_line":"        self.assertEqual(response.status_int, 201)"},{"line_number":648,"context_line":"        self.assertEqual(self.fixtures[3][\u0027task\u0027].task_id,"},{"line_number":649,"context_line":"                         jsonutils.loads(response.body)[\u0027id\u0027])"},{"line_number":650,"context_line":"        self.assertTrue(\u0027expires_at\u0027 in jsonutils.loads(response.body))"},{"line_number":651,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Fk5A%3D","line":648,"in_reply_to":"AAAAUX%2F%2FoHk%3D","updated":"2014-02-12 11:43:20.000000000","message":"thanks nikhil, will add assertions for task_details.task_id and task_details.input","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3565d7a4d5d7e0bee799b26ac441cc67b3e4d0fc","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        response \u003d webob.Response()"},{"line_number":655,"context_line":"        self.serializer.create(response, self.fixtures[0])"},{"line_number":656,"context_line":"        self.assertEqual(response.status_int, 201)"},{"line_number":657,"context_line":"        self.assertEqual(self.fixtures[0][\u0027task\u0027].task_id,"},{"line_number":658,"context_line":"                         jsonutils.loads(response.body)[\u0027id\u0027])"},{"line_number":659,"context_line":"        self.assertFalse(\u0027expires_at\u0027 in jsonutils.loads(response.body))"},{"line_number":660,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FoHc%3D","line":657,"updated":"2014-02-11 22:08:14.000000000","message":"ditto (line 648)","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"4ed098b6a2dbd2133ad5c8c6f7c381ef8f5f3664","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        response \u003d webob.Response()"},{"line_number":655,"context_line":"        self.serializer.create(response, self.fixtures[0])"},{"line_number":656,"context_line":"        self.assertEqual(response.status_int, 201)"},{"line_number":657,"context_line":"        self.assertEqual(self.fixtures[0][\u0027task\u0027].task_id,"},{"line_number":658,"context_line":"                         jsonutils.loads(response.body)[\u0027id\u0027])"},{"line_number":659,"context_line":"        self.assertFalse(\u0027expires_at\u0027 in jsonutils.loads(response.body))"},{"line_number":660,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Fk4Y%3D","line":657,"in_reply_to":"AAAAUX%2F%2FoHc%3D","updated":"2014-02-12 11:43:20.000000000","message":"same as replied at (line 648)","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"3565d7a4d5d7e0bee799b26ac441cc67b3e4d0fc","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        response \u003d webob.Response()"},{"line_number":663,"context_line":"        self.serializer.create(response, self.fixtures[1])"},{"line_number":664,"context_line":"        self.assertEqual(response.status_int, 201)"},{"line_number":665,"context_line":"        self.assertEqual(self.fixtures[1][\u0027task\u0027].task_id,"},{"line_number":666,"context_line":"                         jsonutils.loads(response.body)[\u0027id\u0027])"},{"line_number":667,"context_line":"        self.assertFalse(\u0027expires_at\u0027 in jsonutils.loads(response.body))"},{"line_number":668,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2FoHU%3D","line":665,"updated":"2014-02-11 22:08:14.000000000","message":"ditto (line 648)","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"},{"author":{"_account_id":7703,"name":"Venkatesh Sampath","email":"venkatesh.sampath@outlook.com","username":"venkateshsampath"},"change_message_id":"4ed098b6a2dbd2133ad5c8c6f7c381ef8f5f3664","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        response \u003d webob.Response()"},{"line_number":663,"context_line":"        self.serializer.create(response, self.fixtures[1])"},{"line_number":664,"context_line":"        self.assertEqual(response.status_int, 201)"},{"line_number":665,"context_line":"        self.assertEqual(self.fixtures[1][\u0027task\u0027].task_id,"},{"line_number":666,"context_line":"                         jsonutils.loads(response.body)[\u0027id\u0027])"},{"line_number":667,"context_line":"        self.assertFalse(\u0027expires_at\u0027 in jsonutils.loads(response.body))"},{"line_number":668,"context_line":"        self.assertEqual(\u0027application/json\u0027, response.content_type)"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAUX%2F%2Fk4I%3D","line":665,"in_reply_to":"AAAAUX%2F%2FoHU%3D","updated":"2014-02-12 11:43:20.000000000","message":"same as replied at (line 648)","commit_id":"03ca742f3b06a3cc54c8e0beaf34ecc00d5e4262"}]}