)]}'
{"glance/api/v2/images.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"36ffcc8abf8d1c6f14587596b221f3a91a3d9f0b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                                task_input\u003dtask_input)"},{"line_number":104,"context_line":"            task_repo.add(import_task)"},{"line_number":105,"context_line":"            task_executor \u003d executor_factory.new_task_executor(req.context)"},{"line_number":106,"context_line":"            #pool \u003d common.get_thread_pool(\"tasks_eventlet_pool\")"},{"line_number":107,"context_line":"            #pool.spawn_n(import_task.run, task_executor)"},{"line_number":108,"context_line":"            import_task.run(task_executor)"},{"line_number":109,"context_line":"        except exception.Forbidden as e:"},{"line_number":110,"context_line":"            LOG.debug(\"User not permitted to create image import task.\")"},{"line_number":111,"context_line":"            raise webob.exc.HTTPForbidden(explanation\u003de.msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_09c3838a","line":108,"range":{"start_line":106,"start_character":12,"end_line":108,"end_character":42},"updated":"2018-02-14 08:18:11.000000000","message":"This change is not required, I have made this change just to run taskflow with uwsgi","commit_id":"f3d773d7419d92f35748138c2a5b09b634936687"}],"glance/async/flows/_internal_plugins/web_download.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0bd3115eb45adc365dc72e0b9a52da798ebfcbfc","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        path \u003d self.store.add(self.image_id, data, 0)[0]"},{"line_number":100,"context_line":"        image \u003d self.image_repo.get(self.image_id)"},{"line_number":101,"context_line":"        image.status \u003d \u0027uploading\u0027"},{"line_number":102,"context_line":"        self.image_repo.save(image, from_state\u003d\u0027queued\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        return path"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_10a39b01","line":101,"updated":"2018-02-14 14:07:09.000000000","message":"Abhishek is wondering whether the image status change should be done *before* the store.add ?  I think maybe it\u0027s good as is, if the store.add fails, the image would stay in queued?  Not sure.","commit_id":"2659156c849a4783f2956c0f0ba7d530dcafed47"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"57fbf6b272411ba11e003f7a7acd1304d9c57dd3","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        path \u003d self.store.add(self.image_id, data, 0)[0]"},{"line_number":100,"context_line":"        image \u003d self.image_repo.get(self.image_id)"},{"line_number":101,"context_line":"        image.status \u003d \u0027uploading\u0027"},{"line_number":102,"context_line":"        self.image_repo.save(image, from_state\u003d\u0027queued\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        return path"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_46788d8e","line":101,"in_reply_to":"3fa0c359_10a39b01","updated":"2018-02-14 15:27:29.000000000","message":"So what happens if the image is big, user just might issue another import call as it seems that nothing happened. Or what happens if stage call is issued while this call is running? I think we need to do the transition to \u0027importing\u0027 from queued already in the api_image_import.py get_flow to indicate that the processing has started and prevent any other user actions while the taskflow is running.","commit_id":"2659156c849a4783f2956c0f0ba7d530dcafed47"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6092d8fd3609b6afb3b0f2f9b12ee389c7f30167","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        path \u003d self.store.add(self.image_id, data, 0)[0]"},{"line_number":100,"context_line":"        image \u003d self.image_repo.get(self.image_id)"},{"line_number":101,"context_line":"        image.status \u003d \u0027uploading\u0027"},{"line_number":102,"context_line":"        self.image_repo.save(image, from_state\u003d\u0027queued\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        return path"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_86e2159f","line":101,"in_reply_to":"3fa0c359_46788d8e","updated":"2018-02-14 15:34:36.000000000","message":"That makes sense to me.","commit_id":"2659156c849a4783f2956c0f0ba7d530dcafed47"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"effe1d87f8f1bc208203e8b717d184680ec9bf75","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        path \u003d self.store.add(self.image_id, data, 0)[0]"},{"line_number":100,"context_line":"        image \u003d self.image_repo.get(self.image_id)"},{"line_number":101,"context_line":"        image.status \u003d \u0027uploading\u0027"},{"line_number":102,"context_line":"        self.image_repo.save(image, from_state\u003d\u0027queued\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        return path"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_a2485a5c","line":101,"in_reply_to":"3fa0c359_86e2159f","updated":"2018-02-14 16:13:46.000000000","message":"OK, Erno is going to move the transition in another patch: https://review.openstack.org/544511","commit_id":"2659156c849a4783f2956c0f0ba7d530dcafed47"}],"glance/async/flows/api_image_import.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"57fbf6b272411ba11e003f7a7acd1304d9c57dd3","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    if uri.startswith(\"http\") and import_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":375,"context_line":"        downloadToStaging \u003d internal_plugins.get_import_plugin(**kwargs)"},{"line_number":376,"context_line":"        flow.add(downloadToStaging)"},{"line_number":377,"context_line":"        if not CONF.node_staging_uri.endswith(\u0027/\u0027):"},{"line_number":378,"context_line":"            separator \u003d \u0027/\u0027"},{"line_number":379,"context_line":"        file_uri \u003d separator.join((CONF.node_staging_uri, str(image_id)))"},{"line_number":380,"context_line":"    else:"},{"line_number":381,"context_line":"        file_uri \u003d uri"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_86c77564","line":379,"range":{"start_line":377,"start_character":1,"end_line":379,"end_character":73},"updated":"2018-02-14 15:27:29.000000000","message":"This shouldn\u0027t be needded. The downloadToStaging provides the file_uri for the rest of the flow based on the location it actually saves the image in staging.","commit_id":"2659156c849a4783f2956c0f0ba7d530dcafed47"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6092d8fd3609b6afb3b0f2f9b12ee389c7f30167","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    if uri.startswith(\"http\") and import_method \u003d\u003d \u0027web-download\u0027:"},{"line_number":375,"context_line":"        downloadToStaging \u003d internal_plugins.get_import_plugin(**kwargs)"},{"line_number":376,"context_line":"        flow.add(downloadToStaging)"},{"line_number":377,"context_line":"        if not CONF.node_staging_uri.endswith(\u0027/\u0027):"},{"line_number":378,"context_line":"            separator \u003d \u0027/\u0027"},{"line_number":379,"context_line":"        file_uri \u003d separator.join((CONF.node_staging_uri, str(image_id)))"},{"line_number":380,"context_line":"    else:"},{"line_number":381,"context_line":"        file_uri \u003d uri"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_265d4178","line":379,"range":{"start_line":377,"start_character":1,"end_line":379,"end_character":73},"in_reply_to":"3fa0c359_86c77564","updated":"2018-02-14 15:34:36.000000000","message":"Without this, I was getting \"UnboundLocalError: local variable \u0027file_uri\u0027 referenced before assignment\" in the flow.add() call at line 383.","commit_id":"2659156c849a4783f2956c0f0ba7d530dcafed47"}]}
