)]}'
{"glance/common/config.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"0ce4820c9969529618b3ae9759def7f6ccfd3589","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    if CONF.log_config_append:"},{"line_number":121,"context_line":"        # Use a logging configuration file for all settings..."},{"line_number":122,"context_line":"        if os.path.exists(CONF.log_config_append):"},{"line_number":123,"context_line":"            logging.config.fileConfig(CONF.log_config_append)"},{"line_number":124,"context_line":"            return"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            raise RuntimeError(\"Unable to locate specified logging \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FmQs%3D","line":123,"updated":"2013-10-31 16:59:28.000000000","message":"By default, fileConfig has \"disable_existing_loggers\u003dTrue\".  \n\nSince the logging_config_append setting is meant to append to the existing log settings, not destroy them, I don\u0027t think this makes sense.\n\nHow about calling the setup_logging() method within oslo-inclubator instead and getting rid of all this custom code?","commit_id":"13040f364c059094a9e21d7292a24d5d189dcd78"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"4f79fdf9f2ac60f397a7e7ba56029ad7f5f64064","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    if CONF.log_config_append:"},{"line_number":121,"context_line":"        # Use a logging configuration file for all settings..."},{"line_number":122,"context_line":"        if os.path.exists(CONF.log_config_append):"},{"line_number":123,"context_line":"            logging.config.fileConfig(CONF.log_config_append)"},{"line_number":124,"context_line":"            return"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            raise RuntimeError(\"Unable to locate specified logging \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fh2U%3D","line":123,"in_reply_to":"AAAATn%2F%2FjOs%3D","updated":"2013-11-02 03:18:53.000000000","message":"post a patch to remove this unused mehtod  https://review.openstack.org/#/c/55008/","commit_id":"13040f364c059094a9e21d7292a24d5d189dcd78"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"df0c0d9980ea8c8f2e1d0ff5649bf64ba6f6c536","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    if CONF.log_config_append:"},{"line_number":121,"context_line":"        # Use a logging configuration file for all settings..."},{"line_number":122,"context_line":"        if os.path.exists(CONF.log_config_append):"},{"line_number":123,"context_line":"            logging.config.fileConfig(CONF.log_config_append)"},{"line_number":124,"context_line":"            return"},{"line_number":125,"context_line":"        else:"},{"line_number":126,"context_line":"            raise RuntimeError(\"Unable to locate specified logging \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FjOs%3D","line":123,"in_reply_to":"AAAATn%2F%2FmQs%3D","updated":"2013-11-01 14:44:56.000000000","message":"I search the this method  in Glance projects , It is not used anywhere ,  log.setup(\u0027glance\u0027)  are used somewhere . I think we can remove this method in other patch ,  or remove this method  before syncing from oslo  ?","commit_id":"13040f364c059094a9e21d7292a24d5d189dcd78"}]}
