)]}'
{"glance/tests/unit/test_s3_store.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"5e959f30fb4275c000a72e7b62322527f69d4d5c","unresolved":false,"context_lines":[{"line_number":350,"context_line":"        \"\"\""},{"line_number":351,"context_line":"        def _h(l):"},{"line_number":352,"context_line":"            sep \u003d \u0027-\u0027 if l else l"},{"line_number":353,"context_line":"            return \u0027s3\u0027 + sep + l + \u0027.amazonaws.com\u0027"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        self._do_test_get_s3_location(_h(\u0027\u0027), \u0027\u0027)"},{"line_number":356,"context_line":"        self._do_test_get_s3_location(_h(\u0027eu-west-1\u0027), \u0027EU\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAE3%2F%2F7uE%3D","line":353,"updated":"2012-03-21 15:19:22.000000000","message":"Took me a little bit to figure out what precisely you were doing here :) Might be a bit more readable to just do a loop like:\n\n good_locations \u003d [(\u0027s3.amazonaws.com\u0027, \u0027\u0027),\n     (\u0027eu-west-1\u0027, \u0027EU\u0027),\n     ...\n ]\n for (url, expected) in good_locations:\n     self._do_test_s3_location(url, expected)\n\n Also, would be good to put a couple negative/fringe tests in here.","commit_id":"7ea0a4a4967091f4d101fae3ac740d794eb20ea8"}]}