)]}'
{"glance/tests/functional/ft_utils.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"c53452d53734d2cd0071aa89eb5bb4de023f7bf8","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def wait_for_status(request_path, request_headers, status\u003d\u0027active\u0027,"},{"line_number":24,"context_line":"                    max_sec\u003d10, interval_sec\u003d0.2, start_delay_sec\u003dNone):"},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":"    Performs a time-bounded wait for the entity at the request_path to"},{"line_number":27,"context_line":"    reach the requested status."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_ebf38272","line":24,"range":{"start_line":24,"start_character":32,"end_line":24,"end_character":48},"updated":"2018-04-27 11:55:39.000000000","message":"this looks quite harsh default for bombarding http requests.","commit_id":"c2e9ae67b533fd015b5c0b6e6db51e9fdeca2005"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"72256641fb3740b2b4a04e45262386658d063a38","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def wait_for_status(request_path, request_headers, status\u003d\u0027active\u0027,"},{"line_number":24,"context_line":"                    max_sec\u003d10, interval_sec\u003d0.2, start_delay_sec\u003dNone):"},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":"    Performs a time-bounded wait for the entity at the request_path to"},{"line_number":27,"context_line":"    reach the requested status."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_12d07df7","line":24,"range":{"start_line":24,"start_character":32,"end_line":24,"end_character":48},"in_reply_to":"9f6a8fd7_9c5b2553","updated":"2018-05-03 14:39:34.000000000","message":"Hmm-m ... true, should we call this \u0027delay_sec\u0027 instead then as it\u0027s not interval? I know it\u0027s nitpicking at this point. Just would not want to be confused about it again when this conversation is forgotten ;)","commit_id":"c2e9ae67b533fd015b5c0b6e6db51e9fdeca2005"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7343fb1f604be3376574ea299759644cbf4e2b50","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def wait_for_status(request_path, request_headers, status\u003d\u0027active\u0027,"},{"line_number":24,"context_line":"                    max_sec\u003d10, interval_sec\u003d0.2, start_delay_sec\u003dNone):"},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":"    Performs a time-bounded wait for the entity at the request_path to"},{"line_number":27,"context_line":"    reach the requested status."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_9c5b2553","line":24,"range":{"start_line":24,"start_character":32,"end_line":24,"end_character":48},"in_reply_to":"9f6a8fd7_bcfe2969","updated":"2018-04-27 17:12:55.000000000","message":"Sean makes a good point, all the times here are kind of sloppy.  We\u0027re not looking at a request being made every 0.2 sec, we\u0027re looking at a request being made at least 0.2 sec after a response has been received.  So while an interval_sec of 0.2 does look kind of harsh, it\u0027s really not that bad.","commit_id":"c2e9ae67b533fd015b5c0b6e6db51e9fdeca2005"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"a807056d30a8a23334ee9153e4b4213eb6b661d7","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def wait_for_status(request_path, request_headers, status\u003d\u0027active\u0027,"},{"line_number":24,"context_line":"                    max_sec\u003d10, interval_sec\u003d0.2, start_delay_sec\u003dNone):"},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":"    Performs a time-bounded wait for the entity at the request_path to"},{"line_number":27,"context_line":"    reach the requested status."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_bcfe2969","line":24,"range":{"start_line":24,"start_character":32,"end_line":24,"end_character":48},"in_reply_to":"9f6a8fd7_ebf38272","updated":"2018-04-27 16:58:12.000000000","message":"I think this may be OK. With the extra time overhead from actually performing the http request and parsing the response, I think the server would get hit less than 5 times a second in most cases.\n\nIf we make it a larger interval we run the risk of missing out and exiting the retry loop too soon. By this, I mean if we have a 2 second timeout and set this to a 1 second or .5 second interval, then we may one try one time before the interval and operation overhead put us past the timeout.\n\nSo while I do think this would be a tight loop to do for local code, knowing the network overhead that comes into play here, I think this is probably an acceptable value.\n\nAnyway, my 2 cents.","commit_id":"c2e9ae67b533fd015b5c0b6e6db51e9fdeca2005"}],"glance/tests/functional/v2/test_images.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4eb059e7ca818df7141fc3fdf33cc3bf409512f9","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                   request_headers\u003dself._headers(),"},{"line_number":253,"context_line":"                                   status\u003d\u0027active\u0027,"},{"line_number":254,"context_line":"                                   max_sec\u003d2,"},{"line_number":255,"context_line":"                                   interval_sec\u003d0.2)"},{"line_number":256,"context_line":"        _verify_image_checksum_and_status("},{"line_number":257,"context_line":"            checksum\u003d\u00278f113e38d28a79a5a451b16048cc2b72\u0027,"},{"line_number":258,"context_line":"            status\u003d\u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_0428e031","line":255,"range":{"start_line":255,"start_character":36,"end_line":255,"end_character":51},"updated":"2018-05-02 06:43:21.000000000","message":"no need to pass interval_sec as default is 0.2 only","commit_id":"c2e9ae67b533fd015b5c0b6e6db51e9fdeca2005"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ca2c155bae9e47292cda41a08f05ca1e8beba3b2","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                   request_headers\u003dself._headers(),"},{"line_number":253,"context_line":"                                   status\u003d\u0027active\u0027,"},{"line_number":254,"context_line":"                                   max_sec\u003d2,"},{"line_number":255,"context_line":"                                   interval_sec\u003d0.2)"},{"line_number":256,"context_line":"        _verify_image_checksum_and_status("},{"line_number":257,"context_line":"            checksum\u003d\u00278f113e38d28a79a5a451b16048cc2b72\u0027,"},{"line_number":258,"context_line":"            status\u003d\u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_4e2eeafa","line":255,"range":{"start_line":255,"start_character":36,"end_line":255,"end_character":51},"in_reply_to":"9f6a8fd7_0428e031","updated":"2018-05-02 15:20:45.000000000","message":"I figured I\u0027d pass the interval_sec to make it obvious here, but also in case anyone had suggestions for using a different value in this context (the glance-direct should happen pretty quickly, so maybe a smaller value would work here, whereas we\u0027d want a larger value below for the web-download test).\n\nI\u0027m not averse to removing it, though, if that would be better.  Another option would be to make the default None and have the wait function raise an exception if the caller doesn\u0027t set a value.  What do you think?","commit_id":"c2e9ae67b533fd015b5c0b6e6db51e9fdeca2005"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"72256641fb3740b2b4a04e45262386658d063a38","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                   request_headers\u003dself._headers(),"},{"line_number":253,"context_line":"                                   status\u003d\u0027active\u0027,"},{"line_number":254,"context_line":"                                   max_sec\u003d2,"},{"line_number":255,"context_line":"                                   interval_sec\u003d0.2)"},{"line_number":256,"context_line":"        _verify_image_checksum_and_status("},{"line_number":257,"context_line":"            checksum\u003d\u00278f113e38d28a79a5a451b16048cc2b72\u0027,"},{"line_number":258,"context_line":"            status\u003d\u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_52983569","line":255,"range":{"start_line":255,"start_character":36,"end_line":255,"end_character":51},"in_reply_to":"9f6a8fd7_4e2eeafa","updated":"2018-05-03 14:39:34.000000000","message":"I do prefer explisit calls where ever it improves readability and this is definitely one of those cases. It\u0027s our tests and troubleshooting these test few months down the line makes it so much easier when we do have these values called out.\n\nIf we have assumed that the .2 sec is reasonable delay, then we should keep the default value there. Makes it suck way less to write next test using this func.","commit_id":"c2e9ae67b533fd015b5c0b6e6db51e9fdeca2005"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"4eb059e7ca818df7141fc3fdf33cc3bf409512f9","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                                   request_headers\u003dself._headers(),"},{"line_number":391,"context_line":"                                   status\u003d\u0027active\u0027,"},{"line_number":392,"context_line":"                                   max_sec\u003d20,"},{"line_number":393,"context_line":"                                   interval_sec\u003d0.2,"},{"line_number":394,"context_line":"                                   start_delay_sec\u003d1)"},{"line_number":395,"context_line":"        _verify_image_checksum_and_status("},{"line_number":396,"context_line":"            checksum\u003d\u0027bcd65f8922f61a9e6a20572ad7aa2bdd\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_242ba430","line":393,"range":{"start_line":393,"start_character":35,"end_line":393,"end_character":51},"updated":"2018-05-02 06:43:21.000000000","message":"ditto","commit_id":"c2e9ae67b533fd015b5c0b6e6db51e9fdeca2005"}]}