)]}'
{"glance/api/v2/image_data.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a6c032ddfcf4b37bb0b53f1cc60dc356b484b9a7","unresolved":false,"context_lines":[{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def stage(self, request):"},{"line_number":385,"context_line":"        if \"glance-direct\" not in CONF.enabled_import_methods:"},{"line_number":386,"context_line":"            msg \u003d _(\"Direct image import is not supported at this site.\")"},{"line_number":387,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":388,"context_line":"        try:"},{"line_number":389,"context_line":"            request.get_content_type((\u0027application/octet-stream\u0027,))"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d07418d3","line":386,"updated":"2018-06-05 21:10:54.000000000","message":"I think it would be more clear to mention the name of the method:  \"The \u0027glance-direct\u0027 image import method is not supported at this site.\"","commit_id":"f248070a866c5b9df2bfa1e42f9e3738df9b3b20"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"421c0a6745a4ac2aea34f39f22efbfc7f2a03bab","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    def stage(self, request):"},{"line_number":385,"context_line":"        if \"glance-direct\" not in CONF.enabled_import_methods:"},{"line_number":386,"context_line":"            msg \u003d _(\"\u0027glance-direct\u0027 method is not available at this site.\")"},{"line_number":387,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":388,"context_line":"        try:"},{"line_number":389,"context_line":"            request.get_content_type((\u0027application/octet-stream\u0027,))"},{"line_number":390,"context_line":"        except exception.InvalidContentType as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a6711d7a","line":387,"updated":"2018-06-06 02:16:18.000000000","message":"Should this be NotFound or BadRequest?","commit_id":"6bc12fd48bca9cf78b88505ad83583ed297ad7f7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6a379e1f1d53b8af5e5d4b2dcc27b921ad92e759","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    def stage(self, request):"},{"line_number":385,"context_line":"        if \"glance-direct\" not in CONF.enabled_import_methods:"},{"line_number":386,"context_line":"            msg \u003d _(\"\u0027glance-direct\u0027 method is not available at this site.\")"},{"line_number":387,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":388,"context_line":"        try:"},{"line_number":389,"context_line":"            request.get_content_type((\u0027application/octet-stream\u0027,))"},{"line_number":390,"context_line":"        except exception.InvalidContentType as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f2b6e63e","line":387,"in_reply_to":"5f7c97a3_1167e4b9","updated":"2018-06-06 14:22:25.000000000","message":"I can live with 404.  If if glance-direct is not allowed at a site, the \u0027stage\u0027 resource does not exist on any image, and hence 404 is appropriate.  Plus there is the \"no indication given of whether the condition is temporary or permanent\" aspect, which makes sense as the operator could enable it at some point.","commit_id":"6bc12fd48bca9cf78b88505ad83583ed297ad7f7"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5575d81f8f834f5e668f3316ea6d39d5db4d1c2d","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    def stage(self, request):"},{"line_number":385,"context_line":"        if \"glance-direct\" not in CONF.enabled_import_methods:"},{"line_number":386,"context_line":"            msg \u003d _(\"\u0027glance-direct\u0027 method is not available at this site.\")"},{"line_number":387,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":388,"context_line":"        try:"},{"line_number":389,"context_line":"            request.get_content_type((\u0027application/octet-stream\u0027,))"},{"line_number":390,"context_line":"        except exception.InvalidContentType as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_1167e4b9","line":387,"in_reply_to":"5f7c97a3_a425950c","updated":"2018-06-06 12:20:37.000000000","message":"I\u0027m bit opinionated on this and I know we do it a lot because of policies. Imho if we do not expose API endpoint due to config decision we should just return 404. It might be perfectly valid request, just not something the cloud is providing.\n\nFrom rfc2616:\n10.4.1 400 Bad Request\n\nThe request could not be understood by the server due to malformed syntax.\n\n10.4.4 403 Forbidden\n\nThe server understood the request, but is refusing to fulfill it.\n\n10.4.5 404 Not Found\n\nThe server has not found anything matching the Request-URI. No indication is given of whether the condition is temporary or permanent.\n\nSo my take is that Bad Request is really the worst case scenario claiming that it was user\u0027s fault and we really should use either Forbidden or Not Found.","commit_id":"6bc12fd48bca9cf78b88505ad83583ed297ad7f7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"47a9c5698a1fa6dc4c51c5e86ce54d3f76ab6285","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    def stage(self, request):"},{"line_number":385,"context_line":"        if \"glance-direct\" not in CONF.enabled_import_methods:"},{"line_number":386,"context_line":"            msg \u003d _(\"\u0027glance-direct\u0027 method is not available at this site.\")"},{"line_number":387,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":388,"context_line":"        try:"},{"line_number":389,"context_line":"            request.get_content_type((\u0027application/octet-stream\u0027,))"},{"line_number":390,"context_line":"        except exception.InvalidContentType as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a425950c","line":387,"in_reply_to":"5f7c97a3_a6711d7a","updated":"2018-06-06 06:00:59.000000000","message":"IMO, BadRequest sounds perfect here.","commit_id":"6bc12fd48bca9cf78b88505ad83583ed297ad7f7"}],"glance/api/v2/images.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a6c032ddfcf4b37bb0b53f1cc60dc356b484b9a7","unresolved":false,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def import_image(self, request):"},{"line_number":823,"context_line":"        body \u003d self._get_request_body(request)"},{"line_number":824,"context_line":"        self._validate_import_body(body)"},{"line_number":825,"context_line":"        return {\u0027body\u0027: body}"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3b99adcf","line":824,"updated":"2018-06-05 21:10:54.000000000","message":"Verified that if CONF.enabled_import_methods is empty, this function will raise an exception (HTTPBadRequest).  Message will be \"Unknown import method name \u0027%s\u0027\", which is a bit misleading.  Maybe it should be changed in a follow-up patch to something like: \"Import method \u0027%s\u0027 is not supported at this site.\"","commit_id":"f248070a866c5b9df2bfa1e42f9e3738df9b3b20"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5575d81f8f834f5e668f3316ea6d39d5db4d1c2d","unresolved":false,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"    def import_image(self, request):"},{"line_number":823,"context_line":"        body \u003d self._get_request_body(request)"},{"line_number":824,"context_line":"        self._validate_import_body(body)"},{"line_number":825,"context_line":"        return {\u0027body\u0027: body}"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_61ec5429","line":824,"in_reply_to":"5f7c97a3_3b99adcf","updated":"2018-06-06 12:20:37.000000000","message":"Yeah, we probably should do something about that case.","commit_id":"f248070a866c5b9df2bfa1e42f9e3738df9b3b20"}],"glance/tests/unit/v2/test_discovery_image_import.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a6c032ddfcf4b37bb0b53f1cc60dc356b484b9a7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(TestInfoControllers, self).setUp()"},{"line_number":27,"context_line":"        self.controller \u003d glance.api.v2.discovery.InfoController()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_get_import_info_when_import_not_enabled(self):"},{"line_number":30,"context_line":"        \"\"\"When import not enabled, should return 404 just like v2.5\"\"\""},{"line_number":31,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":32,"context_line":"        req \u003d unit_test_utils.get_fake_request()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_db9d1958","side":"PARENT","line":29,"updated":"2018-06-05 21:10:54.000000000","message":"I think we should keep a variation of this test, something like \u0027test_get_import_info_no_enabled_methods\u0027 to make sure that we do in fact get a HTTPOK response when self.config(enable_image_import\u003d[])","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b013146b629a1853d08e7c52c070367a5812f1ea","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(TestInfoControllers, self).setUp()"},{"line_number":27,"context_line":"        self.controller \u003d glance.api.v2.discovery.InfoController()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_get_import_info_when_import_not_enabled(self):"},{"line_number":30,"context_line":"        \"\"\"When import not enabled, should return 404 just like v2.5\"\"\""},{"line_number":31,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":32,"context_line":"        req \u003d unit_test_utils.get_fake_request()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_3223fec0","side":"PARENT","line":29,"in_reply_to":"5f7c97a3_12fcc2b3","updated":"2018-06-06 14:33:22.000000000","message":"My bad,the discovery should indeed work regardless","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5575d81f8f834f5e668f3316ea6d39d5db4d1c2d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(TestInfoControllers, self).setUp()"},{"line_number":27,"context_line":"        self.controller \u003d glance.api.v2.discovery.InfoController()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_get_import_info_when_import_not_enabled(self):"},{"line_number":30,"context_line":"        \"\"\"When import not enabled, should return 404 just like v2.5\"\"\""},{"line_number":31,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":32,"context_line":"        req \u003d unit_test_utils.get_fake_request()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e1d7044f","side":"PARENT","line":29,"in_reply_to":"5f7c97a3_db9d1958","updated":"2018-06-06 12:20:37.000000000","message":"Lets try to address that when we address that import call error. I\u0027m not too keen to verify that unsupported configuration is not ever misbehaving.","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6a379e1f1d53b8af5e5d4b2dcc27b921ad92e759","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        super(TestInfoControllers, self).setUp()"},{"line_number":27,"context_line":"        self.controller \u003d glance.api.v2.discovery.InfoController()"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_get_import_info_when_import_not_enabled(self):"},{"line_number":30,"context_line":"        \"\"\"When import not enabled, should return 404 just like v2.5\"\"\""},{"line_number":31,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":32,"context_line":"        req \u003d unit_test_utils.get_fake_request()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_12fcc2b3","side":"PARENT","line":29,"in_reply_to":"5f7c97a3_e1d7044f","updated":"2018-06-06 14:22:25.000000000","message":"I disagree.  The API contract is that the discovery call should return a response, although the import methods might be empty.  We need the test because of the asymmetry with the response header for the image-create call -- it is against the standard to have an empty header, so i can easily see someone refactoring the code at some point and deciding that this call should return a 404.  This test is the way to document the correct behavior and avoid regressions.","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"}],"glance/tests/unit/v2/test_image_data_resource.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a6c032ddfcf4b37bb0b53f1cc60dc356b484b9a7","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        data \u003d output.pop(\u0027data\u0027)"},{"line_number":681,"context_line":"        self.assertEqual(b\u0027YYYY\u0027, data.read())"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    def test_stage_if_image_import_is_disabled(self):"},{"line_number":684,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":685,"context_line":"        req \u003d unit_test_utils.get_fake_request()"},{"line_number":686,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_7bbde500","side":"PARENT","line":683,"updated":"2018-06-05 21:10:54.000000000","message":"I think we should include a test like this, call it \u0027test_stage_if_glance_direct_is_disabled\u0027.  The test would set self.config(enabled_import_methods \u003d [\u0027web-download\u0027] and the assertRaises will look for HTTPBadRequest","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5575d81f8f834f5e668f3316ea6d39d5db4d1c2d","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        data \u003d output.pop(\u0027data\u0027)"},{"line_number":681,"context_line":"        self.assertEqual(b\u0027YYYY\u0027, data.read())"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    def test_stage_if_image_import_is_disabled(self):"},{"line_number":684,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":685,"context_line":"        req \u003d unit_test_utils.get_fake_request()"},{"line_number":686,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a14fcc32","side":"PARENT","line":683,"in_reply_to":"5f7c97a3_7bbde500","updated":"2018-06-06 12:20:37.000000000","message":"Actually good point, well apart from it\u0027s not raising bad request but not found. I just keep this test but chnage the name and the trigger.","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6a379e1f1d53b8af5e5d4b2dcc27b921ad92e759","unresolved":false,"context_lines":[{"line_number":680,"context_line":"        data \u003d output.pop(\u0027data\u0027)"},{"line_number":681,"context_line":"        self.assertEqual(b\u0027YYYY\u0027, data.read())"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    def test_stage_if_image_import_is_disabled(self):"},{"line_number":684,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":685,"context_line":"        req \u003d unit_test_utils.get_fake_request()"},{"line_number":686,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_72b416f3","side":"PARENT","line":683,"in_reply_to":"5f7c97a3_a14fcc32","updated":"2018-06-06 14:22:25.000000000","message":"You are correct about the NotFound, we had that discussion on the image data controller.","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"}],"glance/tests/unit/v2/test_images_resource.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a6c032ddfcf4b37bb0b53f1cc60dc356b484b9a7","unresolved":false,"context_lines":[{"line_number":3179,"context_line":"        expected \u003d {\"body\": import_body}"},{"line_number":3180,"context_line":"        self.assertEqual(expected, output)"},{"line_number":3181,"context_line":""},{"line_number":3182,"context_line":"    def test_import_image_disabled(self):"},{"line_number":3183,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":3184,"context_line":"        request \u003d unit_test_utils.get_fake_request()"},{"line_number":3185,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1b12b10a","side":"PARENT","line":3182,"updated":"2018-06-05 21:10:54.000000000","message":"Maybe replace this with \u0027test_import_image_no_methods_enabled\u0027, set self.config(enabled_import_methods \u003d []) and assertRaises HTTPBadRequest","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5a12eec95a566acfc0b5eb47999755ce9f64aa5f","unresolved":false,"context_lines":[{"line_number":3179,"context_line":"        expected \u003d {\"body\": import_body}"},{"line_number":3180,"context_line":"        self.assertEqual(expected, output)"},{"line_number":3181,"context_line":""},{"line_number":3182,"context_line":"    def test_import_image_disabled(self):"},{"line_number":3183,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":3184,"context_line":"        request \u003d unit_test_utils.get_fake_request()"},{"line_number":3185,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_1a47f4be","side":"PARENT","line":3182,"in_reply_to":"5f7c97a3_12012207","updated":"2018-06-06 17:09:18.000000000","message":"I\u0027m not going to insist because the code in question is exercised by the invalid-body-test, but I think an empty list is an edge case that\u0027s always worth testing because you never know what might break.","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5575d81f8f834f5e668f3316ea6d39d5db4d1c2d","unresolved":false,"context_lines":[{"line_number":3179,"context_line":"        expected \u003d {\"body\": import_body}"},{"line_number":3180,"context_line":"        self.assertEqual(expected, output)"},{"line_number":3181,"context_line":""},{"line_number":3182,"context_line":"    def test_import_image_disabled(self):"},{"line_number":3183,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":3184,"context_line":"        request \u003d unit_test_utils.get_fake_request()"},{"line_number":3185,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a1a7cca7","side":"PARENT","line":3182,"in_reply_to":"5f7c97a3_1b12b10a","updated":"2018-06-06 12:20:37.000000000","message":"Ditto","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b013146b629a1853d08e7c52c070367a5812f1ea","unresolved":false,"context_lines":[{"line_number":3179,"context_line":"        expected \u003d {\"body\": import_body}"},{"line_number":3180,"context_line":"        self.assertEqual(expected, output)"},{"line_number":3181,"context_line":""},{"line_number":3182,"context_line":"    def test_import_image_disabled(self):"},{"line_number":3183,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":3184,"context_line":"        request \u003d unit_test_utils.get_fake_request()"},{"line_number":3185,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_12012207","side":"PARENT","line":3182,"in_reply_to":"5f7c97a3_32a1be96","updated":"2018-06-06 14:33:22.000000000","message":"This was towards the empty list","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6a379e1f1d53b8af5e5d4b2dcc27b921ad92e759","unresolved":false,"context_lines":[{"line_number":3179,"context_line":"        expected \u003d {\"body\": import_body}"},{"line_number":3180,"context_line":"        self.assertEqual(expected, output)"},{"line_number":3181,"context_line":""},{"line_number":3182,"context_line":"    def test_import_image_disabled(self):"},{"line_number":3183,"context_line":"        self.config(enable_image_import\u003dFalse)"},{"line_number":3184,"context_line":"        request \u003d unit_test_utils.get_fake_request()"},{"line_number":3185,"context_line":"        self.assertRaises(webob.exc.HTTPNotFound,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_32a1be96","side":"PARENT","line":3182,"in_reply_to":"5f7c97a3_a1a7cca7","updated":"2018-06-06 14:22:25.000000000","message":"Not sure whether the ditto is to \"no, do not want to test empty list of import methods\" or \"ditto, makes sense to test this\"!","commit_id":"2a1ce3a4982d2be32f218f83fb6d6c36eae8c35f"}],"releasenotes/notes/remove_enable_image_import_option-ec4a859ac9a7ea7b.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a6c032ddfcf4b37bb0b53f1cc60dc356b484b9a7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    As Image Import will be always enabled, care needs to be taken that it is"},{"line_number":8,"context_line":"    configured accordingly from this release. Any deployments relying to turn"},{"line_number":9,"context_line":"    it off via config option will not have that possibility anymore."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_50c56809","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":44},"updated":"2018-06-05 21:10:54.000000000","message":"maybe \"properly from this release forward\"","commit_id":"f248070a866c5b9df2bfa1e42f9e3738df9b3b20"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a6c032ddfcf4b37bb0b53f1cc60dc356b484b9a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_10b6108c","line":10,"updated":"2018-06-05 21:10:54.000000000","message":"How about replacing the second sentence with: \"The enable_image_import option is silently ignored and cannot be used to turn off the import functionality.\"","commit_id":"f248070a866c5b9df2bfa1e42f9e3738df9b3b20"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"5575d81f8f834f5e668f3316ea6d39d5db4d1c2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_4104b87e","line":10,"in_reply_to":"5f7c97a3_10b6108c","updated":"2018-06-06 12:20:37.000000000","message":"That will be literally repetition of the start of the paragraph. Will leave the last part off.","commit_id":"f248070a866c5b9df2bfa1e42f9e3738df9b3b20"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6a379e1f1d53b8af5e5d4b2dcc27b921ad92e759","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_d215ea9c","line":10,"in_reply_to":"5f7c97a3_4104b87e","updated":"2018-06-06 14:22:25.000000000","message":"Up to you, but we know that people don\u0027t read these notes very carefully.  Doug\u0027s advice in the releasenote template is that each section is independent and may require repeating info from another section.  I think that makes sense here, especially since in the Queens release we changed the default value from False to True, so someone might have the impression that\u0027s what we\u0027re referring to here.","commit_id":"f248070a866c5b9df2bfa1e42f9e3738df9b3b20"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5a12eec95a566acfc0b5eb47999755ce9f64aa5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_fa079880","line":10,"in_reply_to":"5f7c97a3_52ab1a1d","updated":"2018-06-06 17:09:18.000000000","message":"Well, it\u0027s possible to misunderstand \"will always be enabled\" as \"will be shipped with import enabled\".  I think it\u0027s worth taking the risk of being repetitive to emphasize that the config option no longer does anything.  (I think that was your intuition when you first wrote the paragraph, and I think it\u0027s worth paying attention to.)  But I don\u0027t insist.","commit_id":"f248070a866c5b9df2bfa1e42f9e3738df9b3b20"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"b013146b629a1853d08e7c52c070367a5812f1ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f7c97a3_52ab1a1d","line":10,"in_reply_to":"5f7c97a3_d215ea9c","updated":"2018-06-06 14:33:22.000000000","message":"I don\u0027t mean that it would have been repetition of the prelude, that we do know to repeat in each section. My point was that it would have been repetition of the start of the previous sentence on the very same paragraph \"As Image Import will be always enabled\" ... \"cannot be used to turn off the import\" without actual context why it\u0027s significant.","commit_id":"f248070a866c5b9df2bfa1e42f9e3738df9b3b20"}]}