)]}'
{"glance/api/v2/images.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5ada7e084b627159aaa2ac24ec47238185ecd276","unresolved":false,"context_lines":[{"line_number":983,"context_line":"        },"},{"line_number":984,"context_line":"        \u0027hidden\u0027: {"},{"line_number":985,"context_line":"            \u0027type\u0027: \u0027boolean\u0027,"},{"line_number":986,"context_line":"            \u0027description\u0027: _(\u0027If true, image will not be listed.\u0027),"},{"line_number":987,"context_line":"        },"},{"line_number":988,"context_line":"        \u0027checksum\u0027: {"},{"line_number":989,"context_line":"            \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_c071bdad","line":986,"range":{"start_line":986,"start_character":39,"end_line":986,"end_character":63},"updated":"2018-06-28 13:12:37.000000000","message":"maybe: image will not appear in the default image list response","commit_id":"bb170ab7c8168ee92db58f67906c3f1d5d7c4af6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"09368f8ac1d1df5c88953b8dd12c6f1080cf625d","unresolved":false,"context_lines":[{"line_number":983,"context_line":"        },"},{"line_number":984,"context_line":"        \u0027hidden\u0027: {"},{"line_number":985,"context_line":"            \u0027type\u0027: \u0027boolean\u0027,"},{"line_number":986,"context_line":"            \u0027description\u0027: _(\u0027If true, image will not be listed.\u0027),"},{"line_number":987,"context_line":"        },"},{"line_number":988,"context_line":"        \u0027checksum\u0027: {"},{"line_number":989,"context_line":"            \u0027type\u0027: [\u0027null\u0027, \u0027string\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_e04cf99e","line":986,"range":{"start_line":986,"start_character":39,"end_line":986,"end_character":63},"in_reply_to":"5f7c97a3_c071bdad","updated":"2018-06-28 13:27:14.000000000","message":"will change in new PS","commit_id":"bb170ab7c8168ee92db58f67906c3f1d5d7c4af6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"266841c49e69008e8854907947b97fdc848ccd03","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        filters[\u0027deleted\u0027] \u003d False"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        hidden \u003d filters.get(\u0027hidden\u0027, \u0027false\u0027)"},{"line_number":146,"context_line":"        if hidden is not None:"},{"line_number":147,"context_line":"            if hidden not in [\u0027true\u0027, \u0027false\u0027]:"},{"line_number":148,"context_line":"                message \u003d _(\"Invalid value \u0027%s\u0027 for \u0027hidden\u0027 filter.\""},{"line_number":149,"context_line":"                            \" Valid values are \u0027true\u0027 or \u0027false\u0027.\") % hidden"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_f25026d8","line":146,"range":{"start_line":146,"start_character":18,"end_line":146,"end_character":29},"updated":"2018-06-29 22:39:36.000000000","message":"Can hidden actually be None here? The only way would be if filters contained the key but the value was somehow set to None.","commit_id":"8c83228342376dc061e8fb3949dac9567ec57cdb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8737f20225c5a0bb623450438ce30e6f27538a30","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        filters[\u0027deleted\u0027] \u003d False"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        hidden \u003d filters.get(\u0027hidden\u0027, \u0027false\u0027)"},{"line_number":146,"context_line":"        if hidden is not None:"},{"line_number":147,"context_line":"            if hidden not in [\u0027true\u0027, \u0027false\u0027]:"},{"line_number":148,"context_line":"                message \u003d _(\"Invalid value \u0027%s\u0027 for \u0027hidden\u0027 filter.\""},{"line_number":149,"context_line":"                            \" Valid values are \u0027true\u0027 or \u0027false\u0027.\") % hidden"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_914be684","line":146,"range":{"start_line":146,"start_character":18,"end_line":146,"end_character":29},"in_reply_to":"5f7c97a3_f25026d8","updated":"2018-07-02 05:46:29.000000000","message":"Done","commit_id":"8c83228342376dc061e8fb3949dac9567ec57cdb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"266841c49e69008e8854907947b97fdc848ccd03","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                # Only active image should be allowed to"},{"line_number":209,"context_line":"                # update with hidden"},{"line_number":210,"context_line":"                if image.status !\u003d \u0027active\u0027 and \u0027hidden\u0027 in change[\u0027path\u0027]:"},{"line_number":211,"context_line":"                    msg \u003d (\"Not permitted to hide image %s \""},{"line_number":212,"context_line":"                           \"as it is in %s state\" % (image_id,"},{"line_number":213,"context_line":"                                                     image.status))"},{"line_number":214,"context_line":"                    LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_725656d1","line":211,"range":{"start_line":211,"start_character":26,"end_line":211,"end_character":27},"updated":"2018-06-29 22:39:36.000000000","message":"Needs _()","commit_id":"8c83228342376dc061e8fb3949dac9567ec57cdb"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"8737f20225c5a0bb623450438ce30e6f27538a30","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                # Only active image should be allowed to"},{"line_number":209,"context_line":"                # update with hidden"},{"line_number":210,"context_line":"                if image.status !\u003d \u0027active\u0027 and \u0027hidden\u0027 in change[\u0027path\u0027]:"},{"line_number":211,"context_line":"                    msg \u003d (\"Not permitted to hide image %s \""},{"line_number":212,"context_line":"                           \"as it is in %s state\" % (image_id,"},{"line_number":213,"context_line":"                                                     image.status))"},{"line_number":214,"context_line":"                    LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_74e5d83d","line":211,"range":{"start_line":211,"start_character":26,"end_line":211,"end_character":27},"in_reply_to":"5f7c97a3_725656d1","updated":"2018-07-02 05:46:29.000000000","message":"Done","commit_id":"8c83228342376dc061e8fb3949dac9567ec57cdb"}],"glance/db/__init__.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"44c1f78fb74e4bf5c9af126034acf914a504f0af","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            virtual_size\u003ddb_image[\u0027virtual_size\u0027],"},{"line_number":138,"context_line":"            extra_properties\u003dproperties,"},{"line_number":139,"context_line":"            tags\u003ddb_tags,"},{"line_number":140,"context_line":"            hidden\u003ddb_image[\u0027hidden\u0027],"},{"line_number":141,"context_line":"        )"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _format_image_to_db(self, image):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_0d44dc19","line":140,"range":{"start_line":140,"start_character":12,"end_line":140,"end_character":18},"updated":"2018-07-23 09:02:41.000000000","message":"Would it make the logic easier to follow if this was os_hidden","commit_id":"7371360241663b1dd1c5f78d7773ebba40e79f1a"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"44c1f78fb74e4bf5c9af126034acf914a504f0af","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            \u0027virtual_size\u0027: image.virtual_size,"},{"line_number":170,"context_line":"            \u0027visibility\u0027: image.visibility,"},{"line_number":171,"context_line":"            \u0027properties\u0027: dict(image.extra_properties),"},{"line_number":172,"context_line":"            \u0027hidden\u0027: image.hidden"},{"line_number":173,"context_line":"        }"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def add(self, image):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_2d419809","line":172,"range":{"start_line":172,"start_character":28,"end_line":172,"end_character":34},"updated":"2018-07-23 09:02:41.000000000","message":"ditto","commit_id":"7371360241663b1dd1c5f78d7773ebba40e79f1a"}],"glance/db/simple/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3c3f4e140d5603cefc7c1a9db1b5329e2abf6032","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            if not image_is_public \u003d\u003d is_public:"},{"line_number":303,"context_line":"                continue"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if os_hidden:"},{"line_number":306,"context_line":"            if image_is_hidden:"},{"line_number":307,"context_line":"                continue"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        to_add \u003d True"},{"line_number":310,"context_line":"        for k, value in six.iteritems(filters):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_8308582e","line":307,"range":{"start_line":305,"start_character":0,"end_line":307,"end_character":24},"updated":"2018-07-26 17:55:04.000000000","message":"This block is saying: if the request is GET /v2/images?os_hidden\u003dTrue AND the image_is_hidden, then do NOT include it in the response set.  I don\u0027t think that\u0027s what we want.\n\nThe conditions we want are:\n\n    filter value     image value   include?\n    True                True         yes\n    True                False        no\n    False (or missing)  True         no\n    False (or missing)  False        yes\n\nSo I think the condition should be:\n\n    if os_hidden !\u003d image_is_hidden:\n        continue","commit_id":"a308c444065307e99f18b521ed8d95714be24da7"}],"glance/domain/__init__.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5ada7e084b627159aaa2ac24ec47238185ecd276","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            self.virtual_size \u003d None"},{"line_number":171,"context_line":"        self._status \u003d status"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @property"},{"line_number":174,"context_line":"    def hidden(self):"},{"line_number":175,"context_line":"        return self._hidden"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @hidden.setter"},{"line_number":178,"context_line":"    def hidden(self, hidden):"},{"line_number":179,"context_line":"        self._hidden \u003d hidden"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @property"},{"line_number":182,"context_line":"    def visibility(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_20c2f154","line":179,"range":{"start_line":173,"start_character":0,"end_line":179,"end_character":29},"updated":"2018-06-28 13:12:37.000000000","message":"I was wondering whether we should enforce a boolean value here, so I looked for how we handle \u0027protected\u0027, and it\u0027s just a regular object property.  Do we need this for \u0027hidden\u0027?  (I\u0027m not saying don\u0027t do it, I\u0027m trying to think of the implications.)","commit_id":"bb170ab7c8168ee92db58f67906c3f1d5d7c4af6"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"09368f8ac1d1df5c88953b8dd12c6f1080cf625d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            self.virtual_size \u003d None"},{"line_number":171,"context_line":"        self._status \u003d status"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    @property"},{"line_number":174,"context_line":"    def hidden(self):"},{"line_number":175,"context_line":"        return self._hidden"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    @hidden.setter"},{"line_number":178,"context_line":"    def hidden(self, hidden):"},{"line_number":179,"context_line":"        self._hidden \u003d hidden"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    @property"},{"line_number":182,"context_line":"    def visibility(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_80418566","line":179,"range":{"start_line":173,"start_character":0,"end_line":179,"end_character":29},"in_reply_to":"5f7c97a3_20c2f154","updated":"2018-06-28 13:27:14.000000000","message":"I will check this, thank you for pointing it.","commit_id":"bb170ab7c8168ee92db58f67906c3f1d5d7c4af6"}]}