)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"0565217484dd26923d75b51430b3c6256a6c359b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use common db migrations module from Oslo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes due to use common migration module instead of Glance"},{"line_number":10,"context_line":"implenemtation."},{"line_number":11,"context_line":"Removed glance.db.sqlalchemy.migration module and related code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"blueprint db-use-oslo-common-code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"AAAAUH%2F%2FtlY%3D","line":10,"updated":"2014-01-09 10:37:36.000000000","message":"nit: implementation","commit_id":"936795a4fcf0c1a5aa45bb4f453c0f07c9eab7b0"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"a4e5fcbc8213d050c25997e87054c62d72cf1bc6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use common db migrations module from Oslo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes due to use common migration module instead of Glance"},{"line_number":10,"context_line":"implenemtation."},{"line_number":11,"context_line":"Removed glance.db.sqlalchemy.migration module and related code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"blueprint db-use-oslo-common-code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"AAAAUH%2F%2FtF8%3D","line":10,"in_reply_to":"AAAAUH%2F%2FtlY%3D","updated":"2014-01-09 13:22:51.000000000","message":"Done","commit_id":"936795a4fcf0c1a5aa45bb4f453c0f07c9eab7b0"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"42521200585b148fd31f8578687d01a7700663e9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use common db migrations module from Oslo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes due to use common migration module instead of Glance"},{"line_number":10,"context_line":"implenentation."},{"line_number":11,"context_line":"Removed glance.db.sqlalchemy.migration module and related code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"AAAAUH%2F%2FoUE%3D","line":10,"updated":"2014-01-10 10:34:03.000000000","message":"implementation :)","commit_id":"31c7486a376b1e6f308511dbe8b1403865617de4"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"1924ba73124ac5119f9e8202d41beb5f88ec2704","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use common db migrations module from Oslo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes due to use common migration module instead of Glance"},{"line_number":10,"context_line":"implenentation."},{"line_number":11,"context_line":"Removed glance.db.sqlalchemy.migration module and related code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"AAAAUH%2F%2FoJ0%3D","line":10,"in_reply_to":"AAAAUH%2F%2FoUE%3D","updated":"2014-01-10 11:33:07.000000000","message":"Done","commit_id":"31c7486a376b1e6f308511dbe8b1403865617de4"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"42521200585b148fd31f8578687d01a7700663e9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Removed glance.db.sqlalchemy.migration module and related code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"sync() method from DbCommands class takes no current_version argument anymore"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"blueprint db-use-oslo-common-code"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"AAAAUH%2F%2FoSY%3D","line":14,"updated":"2014-01-10 10:34:03.000000000","message":"So this is an interesting one. This should not be a problem, because --current_version has been ignored so far due to https://bugs.launchpad.net/glance/+bug/1261348 . Though, I think, we could warn users about this anyway.\n\nHow about something like this? (as DocImpact is mostly useful for users, rather than for developers)\n\n\"glance-manage db sync\" no longer accepts --current-version optional argument. To be able to apply migration scripts users must first put the DB schema under version control using \"glance-manage db version_control --version NUM\".","commit_id":"31c7486a376b1e6f308511dbe8b1403865617de4"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"1924ba73124ac5119f9e8202d41beb5f88ec2704","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Removed glance.db.sqlalchemy.migration module and related code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"sync() method from DbCommands class takes no current_version argument anymore"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"blueprint db-use-oslo-common-code"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"AAAAUH%2F%2FoJA%3D","line":14,"in_reply_to":"AAAAUH%2F%2FoSY%3D","updated":"2014-01-10 11:33:07.000000000","message":"ok, let it be","commit_id":"31c7486a376b1e6f308511dbe8b1403865617de4"}],"glance/cmd/manage.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"0565217484dd26923d75b51430b3c6256a6c359b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        migration.version_control(version)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":87,"context_line":"    @args(\u0027--current_version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027,"},{"line_number":88,"context_line":"          help\u003d\u0027Current Database version\u0027)"},{"line_number":89,"context_line":"    def sync(self, version\u003dNone, current_version\u003dNone):"},{"line_number":90,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2Ftcs%3D","side":"PARENT","line":87,"updated":"2014-01-09 10:37:36.000000000","message":"I\u0027m ok with removing this, but this should be documented somewhere (i.e. that users must put the DB schema under version control first, and only then call db_sync(), if they happen to have tables in the schema that is not under version control).","commit_id":"61a715e17e8d6e6dbe60d35447c70fba990bd2e9"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"a4e5fcbc8213d050c25997e87054c62d72cf1bc6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        migration.version_control(version)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":87,"context_line":"    @args(\u0027--current_version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027,"},{"line_number":88,"context_line":"          help\u003d\u0027Current Database version\u0027)"},{"line_number":89,"context_line":"    def sync(self, version\u003dNone, current_version\u003dNone):"},{"line_number":90,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2FtBM%3D","side":"PARENT","line":87,"in_reply_to":"AAAAUH%2F%2Ftcs%3D","updated":"2014-01-09 13:22:51.000000000","message":"Done","commit_id":"61a715e17e8d6e6dbe60d35447c70fba990bd2e9"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"0565217484dd26923d75b51430b3c6256a6c359b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"CONF.import_group(\"database\", \"glance.openstack.common.db.sqlalchemy.session\")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"MIGRATE_REPO_PATH \u003d os.path.join("},{"line_number":54,"context_line":"    os.path.abspath(os.path.dirname(__file__)),"},{"line_number":55,"context_line":"    os.pardir,"},{"line_number":56,"context_line":"    \u0027db\u0027,"},{"line_number":57,"context_line":"    \u0027sqlalchemy\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2FtjU%3D","line":54,"updated":"2014-01-09 10:37:36.000000000","message":"I\u0027d rather we do:\n\n  MIGRATE_REPO_PATH \u003d os.path.abspath(os.path.dirname(glance.db.sqlalchemy.migrate_repo.__file__))\n\ninstead","commit_id":"936795a4fcf0c1a5aa45bb4f453c0f07c9eab7b0"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"a4e5fcbc8213d050c25997e87054c62d72cf1bc6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"CONF.import_group(\"database\", \"glance.openstack.common.db.sqlalchemy.session\")"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"MIGRATE_REPO_PATH \u003d os.path.join("},{"line_number":54,"context_line":"    os.path.abspath(os.path.dirname(__file__)),"},{"line_number":55,"context_line":"    os.pardir,"},{"line_number":56,"context_line":"    \u0027db\u0027,"},{"line_number":57,"context_line":"    \u0027sqlalchemy\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2FtE0%3D","line":54,"in_reply_to":"AAAAUH%2F%2FtjU%3D","updated":"2014-01-09 13:22:51.000000000","message":"Done","commit_id":"936795a4fcf0c1a5aa45bb4f453c0f07c9eab7b0"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"42521200585b148fd31f8578687d01a7700663e9","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":84,"context_line":"    def version_control(self, version\u003dNone):"},{"line_number":85,"context_line":"        \"\"\"Place a database under migration control\"\"\""},{"line_number":86,"context_line":"        migration.db_sync(db_migration.MIGRATE_REPO_PATH, version)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":89,"context_line":"    def sync(self, version\u003dNone, current_version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2FoQA%3D","line":86,"updated":"2014-01-10 10:34:03.000000000","message":"hmm, why not this function https://github.com/openstack/oslo-incubator/blob/master/openstack/common/db/sqlalchemy/migration.py#L227  is called here?","commit_id":"31c7486a376b1e6f308511dbe8b1403865617de4"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"1924ba73124ac5119f9e8202d41beb5f88ec2704","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":84,"context_line":"    def version_control(self, version\u003dNone):"},{"line_number":85,"context_line":"        \"\"\"Place a database under migration control\"\"\""},{"line_number":86,"context_line":"        migration.db_sync(db_migration.MIGRATE_REPO_PATH, version)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":89,"context_line":"    def sync(self, version\u003dNone, current_version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2FoI4%3D","line":86,"in_reply_to":"AAAAUH%2F%2FoQA%3D","updated":"2014-01-10 11:33:07.000000000","message":"lol, thanks","commit_id":"31c7486a376b1e6f308511dbe8b1403865617de4"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"517c0eb1bb23d325c37dfdeda7c89c0fd36076fd","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        migration.version_control(version)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":87,"context_line":"    @args(\u0027--current_version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027,"},{"line_number":88,"context_line":"          help\u003d\u0027Current Database version\u0027)"},{"line_number":89,"context_line":"    def sync(self, version\u003dNone, current_version\u003dNone):"},{"line_number":90,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2FOto%3D","side":"PARENT","line":87,"updated":"2014-01-16 06:03:08.000000000","message":"I think I\u0027d prefer we continue to support this argument.","commit_id":"8efd443e0dd92b3e008f65f12fe1ae423853b6c4"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"ca1a8703ee3ee23377219687a9cefab67eb0bb6a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        migration.version_control(version)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":87,"context_line":"    @args(\u0027--current_version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027,"},{"line_number":88,"context_line":"          help\u003d\u0027Current Database version\u0027)"},{"line_number":89,"context_line":"    def sync(self, version\u003dNone, current_version\u003dNone):"},{"line_number":90,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2FNjo%3D","side":"PARENT","line":87,"in_reply_to":"AAAAUH%2F%2FOto%3D","updated":"2014-01-16 11:37:36.000000000","message":"Done","commit_id":"8efd443e0dd92b3e008f65f12fe1ae423853b6c4"},{"author":{"_account_id":616,"name":"Mark Washenberger","email":"mark.washenberger@markwash.net","username":"markwash"},"change_message_id":"517c0eb1bb23d325c37dfdeda7c89c0fd36076fd","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        Place a database under migration control and upgrade,"},{"line_number":92,"context_line":"        creating first if necessary."},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        migration.db_sync(db_migration.MIGRATE_REPO_PATH, version)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2FOtI%3D","line":93,"updated":"2014-01-16 06:03:08.000000000","message":"For backwards compatibility, couldn\u0027t we do \n\n  if current_version is not None:\n      migration.db_version_control(db_migration.MIGRATE_REPO_PATH, current_version)","commit_id":"75d351c4930b0ceb834ef55499a9be916ab96730"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"ca1a8703ee3ee23377219687a9cefab67eb0bb6a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        Place a database under migration control and upgrade,"},{"line_number":92,"context_line":"        creating first if necessary."},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        migration.db_sync(db_migration.MIGRATE_REPO_PATH, version)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2FNjs%3D","line":93,"in_reply_to":"AAAAUH%2F%2FOtI%3D","updated":"2014-01-16 11:37:36.000000000","message":"Done","commit_id":"75d351c4930b0ceb834ef55499a9be916ab96730"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"912b2e760d657a012ce164927b2535044746b461","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        \"\"\""},{"line_number":91,"context_line":"        Place a database under migration control and upgrade,"},{"line_number":92,"context_line":"        creating first if necessary."},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":"        migration.db_sync(db_migration.MIGRATE_REPO_PATH, version)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2FNlY%3D","line":93,"in_reply_to":"AAAAUH%2F%2FOtI%3D","updated":"2014-01-16 10:22:18.000000000","message":"Hmm, we actually can.\n\nThough this shouldn\u0027t be an issue anyway, as current_version argument seems to have been ignored before due to the bug which is fixed by https://review.openstack.org/#/c/62329/","commit_id":"75d351c4930b0ceb834ef55499a9be916ab96730"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"2f4ac07cfbee1d5b87e5201b24d4f38d4fea73c1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":78,"context_line":"    def downgrade(self, version\u003dNone):"},{"line_number":79,"context_line":"        \"\"\"Downgrade the database\u0027s migration level\"\"\""},{"line_number":80,"context_line":"        migration.downgrade(version)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":83,"context_line":"    def version_control(self, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F%2FHiA%3D","line":80,"updated":"2014-01-17 09:15:09.000000000","message":"this should be migration.db_sync(db_migration.MIGRATE_REPO_PATH, version)","commit_id":"f65dac65a42157c27f02b13292c7d09ef82d277c"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"26b83d9c92db13294fed3bf2b0b062a99b61fd18","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":78,"context_line":"    def downgrade(self, version\u003dNone):"},{"line_number":79,"context_line":"        \"\"\"Downgrade the database\u0027s migration level\"\"\""},{"line_number":80,"context_line":"        migration.downgrade(version)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @args(\u0027--version\u0027, metavar\u003d\u0027\u003cversion\u003e\u0027, help\u003d\u0027Database version\u0027)"},{"line_number":83,"context_line":"    def version_control(self, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F%2FHcs%3D","line":80,"in_reply_to":"AAAAUH%2F%2FHiA%3D","updated":"2014-01-17 09:33:57.000000000","message":"Thanks!","commit_id":"f65dac65a42157c27f02b13292c7d09ef82d277c"}],"glance/db/migration.py":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"82435ea02be5497c275cb630f8c075d4e7b5c0d3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"IMPL \u003d utils.LazyPluggable("},{"line_number":28,"context_line":"    \u0027backend\u0027,"},{"line_number":29,"context_line":"    config_group\u003d\u0027database\u0027,"},{"line_number":30,"context_line":"    sqlalchemy\u003d\u0027glance.openstack.common.db.sqlalchemy.migration\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"INIT_VERSION \u003d 000"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F%2FI0k%3D","line":29,"updated":"2014-01-17 03:33:26.000000000","message":"Just a asking for confirmation: can this work well with current glance-api.conf, right [1]? since current glance-api.conf template is still using deprecated database group. Thanks.\n\n[1] https://github.com/openstack/oslo-incubator/blob/master/openstack/common/db/api.py#L37","commit_id":"f65dac65a42157c27f02b13292c7d09ef82d277c"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"26b83d9c92db13294fed3bf2b0b062a99b61fd18","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"IMPL \u003d utils.LazyPluggable("},{"line_number":28,"context_line":"    \u0027backend\u0027,"},{"line_number":29,"context_line":"    config_group\u003d\u0027database\u0027,"},{"line_number":30,"context_line":"    sqlalchemy\u003d\u0027glance.openstack.common.db.sqlalchemy.migration\u0027)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"INIT_VERSION \u003d 000"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAUH%2F%2FHc0%3D","line":29,"in_reply_to":"AAAAUH%2F%2FI0k%3D","updated":"2014-01-17 09:33:57.000000000","message":"I confirm, that this code work well with current glance-api.conf","commit_id":"f65dac65a42157c27f02b13292c7d09ef82d277c"}],"glance/tests/integration/legacy_functional/base.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"42521200585b148fd31f8578687d01a7700663e9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import glance.common.client"},{"line_number":22,"context_line":"from glance.common import config"},{"line_number":23,"context_line":"import glance.db.sqlalchemy.api"},{"line_number":24,"context_line":"from glance.openstack.common.db.sqlalchemy import migration"},{"line_number":25,"context_line":"import glance.registry.client.v1.client"},{"line_number":26,"context_line":"import glance.store"},{"line_number":27,"context_line":"from glance import tests as glance_tests"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2FoOM%3D","line":24,"updated":"2014-01-10 10:34:03.000000000","message":"maybe it\u0027s worth to just use glance.db.migration here instead?","commit_id":"31c7486a376b1e6f308511dbe8b1403865617de4"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"1924ba73124ac5119f9e8202d41beb5f88ec2704","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import glance.common.client"},{"line_number":22,"context_line":"from glance.common import config"},{"line_number":23,"context_line":"import glance.db.sqlalchemy.api"},{"line_number":24,"context_line":"from glance.openstack.common.db.sqlalchemy import migration"},{"line_number":25,"context_line":"import glance.registry.client.v1.client"},{"line_number":26,"context_line":"import glance.store"},{"line_number":27,"context_line":"from glance import tests as glance_tests"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAAUH%2F%2FoHc%3D","line":24,"in_reply_to":"AAAAUH%2F%2FoOM%3D","updated":"2014-01-10 11:33:07.000000000","message":"Done","commit_id":"31c7486a376b1e6f308511dbe8b1403865617de4"}],"glance/tests/integration/v2/base.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"0565217484dd26923d75b51430b3c6256a6c359b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            test_utils.execute(\u0027cp %s %s/tests.sqlite\u0027"},{"line_number":169,"context_line":"                               % (db_location, self.test_dir))"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            migration.db_sync()"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"            # copy the clean db to a temp location so that it"},{"line_number":174,"context_line":"            # can be reused for future tests"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2Ftfk%3D","line":171,"updated":"2014-01-09 10:37:36.000000000","message":"This must be never called in tests as migration.db_sync() has one required argument https://github.com/openstack/glance/blob/master/glance/openstack/common/db/sqlalchemy/migration.py#L203","commit_id":"936795a4fcf0c1a5aa45bb4f453c0f07c9eab7b0"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"a4e5fcbc8213d050c25997e87054c62d72cf1bc6","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            test_utils.execute(\u0027cp %s %s/tests.sqlite\u0027"},{"line_number":169,"context_line":"                               % (db_location, self.test_dir))"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            migration.db_sync()"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"            # copy the clean db to a temp location so that it"},{"line_number":174,"context_line":"            # can be reused for future tests"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2FtDE%3D","line":171,"in_reply_to":"AAAAUH%2F%2Ftfk%3D","updated":"2014-01-09 13:22:51.000000000","message":"Done","commit_id":"936795a4fcf0c1a5aa45bb4f453c0f07c9eab7b0"}],"glance/tests/unit/test_migrations.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"0565217484dd26923d75b51430b3c6256a6c359b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"import glance.db.migration as migration"},{"line_number":45,"context_line":"import glance.db.sqlalchemy.migrate_repo"},{"line_number":46,"context_line":"from glance.db.sqlalchemy import models"},{"line_number":47,"context_line":"from glance.openstack.common.db.sqlalchemy.migration import versioning_api"},{"line_number":48,"context_line":"from glance.openstack.common import jsonutils"},{"line_number":49,"context_line":"from glance.openstack.common import log as logging"},{"line_number":50,"context_line":"from glance.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2Fte8%3D","line":47,"updated":"2014-01-09 10:37:36.000000000","message":"can we just import it as \u0027migration_api\u0027, so renaming won\u0027t be needed?","commit_id":"936795a4fcf0c1a5aa45bb4f453c0f07c9eab7b0"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"a4e5fcbc8213d050c25997e87054c62d72cf1bc6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"import glance.db.migration as migration"},{"line_number":45,"context_line":"import glance.db.sqlalchemy.migrate_repo"},{"line_number":46,"context_line":"from glance.db.sqlalchemy import models"},{"line_number":47,"context_line":"from glance.openstack.common.db.sqlalchemy.migration import versioning_api"},{"line_number":48,"context_line":"from glance.openstack.common import jsonutils"},{"line_number":49,"context_line":"from glance.openstack.common import log as logging"},{"line_number":50,"context_line":"from glance.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2FtDM%3D","line":47,"in_reply_to":"AAAAUH%2F%2Fte8%3D","updated":"2014-01-09 13:22:51.000000000","message":"Done","commit_id":"936795a4fcf0c1a5aa45bb4f453c0f07c9eab7b0"}]}