)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update glance documentation for trait support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Required traits on the image allow specifying a server to be"},{"line_number":10,"context_line":"build only on compute nodes which expresses those traits. The"},{"line_number":11,"context_line":"FilterScheduler has been updated to look at the image trait"},{"line_number":12,"context_line":"properties when selecting compute nodes."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_cce6c6e8","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":5},"updated":"2018-07-12 12:32:39.000000000","message":"built","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update glance documentation for trait support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Required traits on the image allow specifying a server to be"},{"line_number":10,"context_line":"build only on compute nodes which expresses those traits. The"},{"line_number":11,"context_line":"FilterScheduler has been updated to look at the image trait"},{"line_number":12,"context_line":"properties when selecting compute nodes."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_4cd2b6ff","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":43},"updated":"2018-07-12 12:32:39.000000000","message":"express","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Required traits on the image allow specifying a server to be"},{"line_number":10,"context_line":"build only on compute nodes which expresses those traits. The"},{"line_number":11,"context_line":"FilterScheduler has been updated to look at the image trait"},{"line_number":12,"context_line":"properties when selecting compute nodes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Updating the documentation for glance to explain the same."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_0c06fe86","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":15},"updated":"2018-07-12 12:32:39.000000000","message":"nova scheduler","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"}],"doc/source/admin/useful-image-properties.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":233,"context_line":"   * - All"},{"line_number":234,"context_line":"     - ``trait:\u003ctrait_name\u003e``"},{"line_number":235,"context_line":"     - Added in the Rocky release. Functionality is similar to traits specified"},{"line_number":236,"context_line":"       in flavor extra specs."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"       traits allow specifying a server to build on a compute node with the set"},{"line_number":239,"context_line":"       of traits specified in the image. The traits are associated with the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_ac2fcaf3","line":236,"range":{"start_line":236,"start_character":10,"end_line":236,"end_character":29},"updated":"2018-07-12 12:32:39.000000000","message":"You could link to this:\n\n`flavor extra specs`_\n\n.. _flavor extra specs: https://docs.openstack.org/nova/latest/user/flavors.html#extra-specs","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":233,"context_line":"   * - All"},{"line_number":234,"context_line":"     - ``trait:\u003ctrait_name\u003e``"},{"line_number":235,"context_line":"     - Added in the Rocky release. Functionality is similar to traits specified"},{"line_number":236,"context_line":"       in flavor extra specs."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"       traits allow specifying a server to build on a compute node with the set"},{"line_number":239,"context_line":"       of traits specified in the image. The traits are associated with the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_9b42413b","line":236,"range":{"start_line":236,"start_character":10,"end_line":236,"end_character":29},"in_reply_to":"5f7c97a3_ac2fcaf3","updated":"2018-07-12 15:47:46.000000000","message":"yup...the link is a good idea. I added it in the commit message but its better to add for user reference.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":28171,"name":"karim","email":"karimullah.mohammed@intel.com","username":"karimull"},"change_message_id":"17346889b862309167875ea8d629e56815825339","unresolved":false,"context_lines":[{"line_number":235,"context_line":"     - Added in the Rocky release. Functionality is similar to traits specified"},{"line_number":236,"context_line":"       in flavor extra specs."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"       traits allow specifying a server to build on a compute node with the set"},{"line_number":239,"context_line":"       of traits specified in the image. The traits are associated with the"},{"line_number":240,"context_line":"       resource provider that represents the compute node in the Placement API."},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_bc56295e","line":238,"range":{"start_line":238,"start_character":7,"end_line":238,"end_character":13},"updated":"2018-07-12 01:23:42.000000000","message":"Traits(?)","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":235,"context_line":"     - Added in the Rocky release. Functionality is similar to traits specified"},{"line_number":236,"context_line":"       in flavor extra specs."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"       traits allow specifying a server to build on a compute node with the set"},{"line_number":239,"context_line":"       of traits specified in the image. The traits are associated with the"},{"line_number":240,"context_line":"       resource provider that represents the compute node in the Placement API."},{"line_number":241,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_3b71adac","line":238,"range":{"start_line":238,"start_character":7,"end_line":238,"end_character":13},"in_reply_to":"5f7c97a3_bc56295e","updated":"2018-07-12 15:47:46.000000000","message":"Done","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":28171,"name":"karim","email":"karimullah.mohammed@intel.com","username":"karimull"},"change_message_id":"17346889b862309167875ea8d629e56815825339","unresolved":false,"context_lines":[{"line_number":236,"context_line":"       in flavor extra specs."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"       traits allow specifying a server to build on a compute node with the set"},{"line_number":239,"context_line":"       of traits specified in the image. The traits are associated with the"},{"line_number":240,"context_line":"       resource provider that represents the compute node in the Placement API."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"       The syntax of specifying traits is trait:\u003ctrait_name\u003e\u003dvalue"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_fc258117","line":240,"range":{"start_line":239,"start_character":41,"end_line":240,"end_character":78},"updated":"2018-07-12 01:23:42.000000000","message":"The traits are associated with the resource provider that represents either the compute node or a shared resource provider of that node.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":236,"context_line":"       in flavor extra specs."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"       traits allow specifying a server to build on a compute node with the set"},{"line_number":239,"context_line":"       of traits specified in the image. The traits are associated with the"},{"line_number":240,"context_line":"       resource provider that represents the compute node in the Placement API."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"       The syntax of specifying traits is trait:\u003ctrait_name\u003e\u003dvalue"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_fb9fb5b0","line":240,"range":{"start_line":239,"start_character":41,"end_line":240,"end_character":78},"in_reply_to":"5f7c97a3_accb4a1b","updated":"2018-07-12 15:47:46.000000000","message":"Yup, its a copy from the flavor description.\n\nI agree...its lots of detail for a table of properties already :)","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":236,"context_line":"       in flavor extra specs."},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"       traits allow specifying a server to build on a compute node with the set"},{"line_number":239,"context_line":"       of traits specified in the image. The traits are associated with the"},{"line_number":240,"context_line":"       resource provider that represents the compute node in the Placement API."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"       The syntax of specifying traits is trait:\u003ctrait_name\u003e\u003dvalue"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_accb4a1b","line":240,"range":{"start_line":239,"start_character":41,"end_line":240,"end_character":78},"in_reply_to":"5f7c97a3_fc258117","updated":"2018-07-12 12:32:39.000000000","message":"Well, if we want to get specific, it could also be children providers in the same tree, etc. This is copying from the flavor extra specs description:\n\nhttps://docs.openstack.org/nova/latest/user/flavors.html#extra-specs\n\nWhich predates shared provider or nested support, but the point is it\u0027s all linked back to the compute node provider as the root provider so whether the trait is on a shared aggregate provider or a child provider in the same tree, it\u0027s the same - I\u0027m not sure we want to get into that level of detail here otherwise it might confuse people.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":239,"context_line":"       of traits specified in the image. The traits are associated with the"},{"line_number":240,"context_line":"       resource provider that represents the compute node in the Placement API."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"       The syntax of specifying traits is trait:\u003ctrait_name\u003e\u003dvalue"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"       For example:"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_2cdf3ad8","line":242,"range":{"start_line":242,"start_character":61,"end_line":242,"end_character":66},"updated":"2018-07-12 12:32:39.000000000","message":"It\u0027s specifically \"required\" here right?\n\nhttps://github.com/openstack/nova/blob/39b05ee9e34ae7e7c1854439f887588ec157bc69/nova/objects/image_meta.py#L568\n\nAlso, put \"trait:\u003ctrait_name\u003e\u003dvalue\" in bold:\n\n**trait:\u003ctrait_name\u003e\u003dvalue**","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":239,"context_line":"       of traits specified in the image. The traits are associated with the"},{"line_number":240,"context_line":"       resource provider that represents the compute node in the Placement API."},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"       The syntax of specifying traits is trait:\u003ctrait_name\u003e\u003dvalue"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"       For example:"},{"line_number":245,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_7b8c0580","line":242,"range":{"start_line":242,"start_character":61,"end_line":242,"end_character":66},"in_reply_to":"5f7c97a3_2cdf3ad8","updated":"2018-07-12 15:47:46.000000000","message":"yes. Only required is supported. i put this in the Expected Value column....wanted to leave it generic in the description. \n\nMade it bold","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":28171,"name":"karim","email":"karimullah.mohammed@intel.com","username":"karimull"},"change_message_id":"17346889b862309167875ea8d629e56815825339","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        trait:HW_CPU_X86_AVX2\u003drequired"},{"line_number":247,"context_line":"        trait:STORAGE_DISK_SSD\u003drequired"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       The scheduler will pass required traits to the Placement API to include"},{"line_number":250,"context_line":"       only resource providers that can satisfy the required traits."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"       Image traits are used by the scheduler even in cases of volume backed"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_3c1c59c1","line":249,"range":{"start_line":249,"start_character":40,"end_line":249,"end_character":46},"updated":"2018-07-12 01:23:42.000000000","message":"image traits ( to be specific)","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        trait:HW_CPU_X86_AVX2\u003drequired"},{"line_number":247,"context_line":"        trait:STORAGE_DISK_SSD\u003drequired"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       The scheduler will pass required traits to the Placement API to include"},{"line_number":250,"context_line":"       only resource providers that can satisfy the required traits."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"       Image traits are used by the scheduler even in cases of volume backed"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_db42f90d","line":249,"range":{"start_line":249,"start_character":40,"end_line":249,"end_character":46},"in_reply_to":"5f7c97a3_3c1c59c1","updated":"2018-07-12 15:47:46.000000000","message":"Reworded to\n\n\"required traits specified on the image\"","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":28171,"name":"karim","email":"karimullah.mohammed@intel.com","username":"karimull"},"change_message_id":"17346889b862309167875ea8d629e56815825339","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        trait:STORAGE_DISK_SSD\u003drequired"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       The scheduler will pass required traits to the Placement API to include"},{"line_number":250,"context_line":"       only resource providers that can satisfy the required traits."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"       Image traits are used by the scheduler even in cases of volume backed"},{"line_number":253,"context_line":"       instances, if the volume source is an image with traits."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_5c1915cf","line":250,"range":{"start_line":250,"start_character":52,"end_line":250,"end_character":60},"updated":"2018-07-12 01:23:42.000000000","message":"given(?)","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        trait:STORAGE_DISK_SSD\u003drequired"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       The scheduler will pass required traits to the Placement API to include"},{"line_number":250,"context_line":"       only resource providers that can satisfy the required traits."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"       Image traits are used by the scheduler even in cases of volume backed"},{"line_number":253,"context_line":"       instances, if the volume source is an image with traits."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_fb5495c8","line":250,"range":{"start_line":250,"start_character":52,"end_line":250,"end_character":60},"in_reply_to":"5f7c97a3_5c1915cf","updated":"2018-07-12 15:47:46.000000000","message":"want to use the same terminology...i think having it say required traits is fine.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       The scheduler will pass required traits to the Placement API to include"},{"line_number":250,"context_line":"       only resource providers that can satisfy the required traits."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"       Image traits are used by the scheduler even in cases of volume backed"},{"line_number":253,"context_line":"       instances, if the volume source is an image with traits."},{"line_number":254,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_cc9ec605","line":251,"updated":"2018-07-12 12:32:39.000000000","message":"The flavor extra specs doc mentions:\n\n\"In 18.0.0 forbidden is added (see below). Any other value will be considered invalid.\"\n\nBut we didn\u0027t add support for forbidden traits in image metadata. I\u0027m not sure if it\u0027s worth mentioning that forbidden traits are not supported and if that functionality is needed, use flavor extra specs. That might also be overly descriptive and thus a source of confusion to the reader.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       The scheduler will pass required traits to the Placement API to include"},{"line_number":250,"context_line":"       only resource providers that can satisfy the required traits."},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"       Image traits are used by the scheduler even in cases of volume backed"},{"line_number":253,"context_line":"       instances, if the volume source is an image with traits."},{"line_number":254,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_1b287131","line":251,"in_reply_to":"5f7c97a3_cc9ec605","updated":"2018-07-12 15:47:46.000000000","message":"i think it would cause confusion as well. If needed(and when support is added) we can add that in the \"expected value\" column. \n\nWe have already specified that required is the only valid value and provided link to the extra specs which should be fine IMO.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":252,"context_line":"       Image traits are used by the scheduler even in cases of volume backed"},{"line_number":253,"context_line":"       instances, if the volume source is an image with traits."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"       The FilterScheduler is currently the only scheduler driver that supports"},{"line_number":256,"context_line":"       this feature."},{"line_number":257,"context_line":"     - Only valid value is required, any other value is invalid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_ccb7a685","line":256,"range":{"start_line":255,"start_character":6,"end_line":256,"end_character":20},"updated":"2018-07-12 12:32:39.000000000","message":"I think you can omit this - this is glance specific docs and the FilterScheduler is a nova-specific thing.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":252,"context_line":"       Image traits are used by the scheduler even in cases of volume backed"},{"line_number":253,"context_line":"       instances, if the volume source is an image with traits."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"       The FilterScheduler is currently the only scheduler driver that supports"},{"line_number":256,"context_line":"       this feature."},{"line_number":257,"context_line":"     - Only valid value is required, any other value is invalid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_bbca9d6c","line":256,"range":{"start_line":255,"start_character":6,"end_line":256,"end_character":20},"in_reply_to":"5f7c97a3_ccb7a685","updated":"2018-07-12 15:47:46.000000000","message":"documentation on line 40 does mention schedulers and filters already so wanted to provide the same level of context here...let me know if you feel strongly about this and i will remove.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"       The FilterScheduler is currently the only scheduler driver that supports"},{"line_number":256,"context_line":"       this feature."},{"line_number":257,"context_line":"     - Only valid value is required, any other value is invalid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"},{"line_number":260,"context_line":"         represents the compute node on which the image is launched."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_6cac5236","line":257,"range":{"start_line":257,"start_character":27,"end_line":257,"end_character":35},"updated":"2018-07-12 12:32:39.000000000","message":"``required``","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"       The FilterScheduler is currently the only scheduler driver that supports"},{"line_number":256,"context_line":"       this feature."},{"line_number":257,"context_line":"     - Only valid value is required, any other value is invalid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"},{"line_number":260,"context_line":"         represents the compute node on which the image is launched."}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_db8c393b","line":257,"range":{"start_line":257,"start_character":27,"end_line":257,"end_character":35},"in_reply_to":"5f7c97a3_6cac5236","updated":"2018-07-12 15:47:46.000000000","message":"Done","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":256,"context_line":"       this feature."},{"line_number":257,"context_line":"     - Only valid value is required, any other value is invalid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"},{"line_number":260,"context_line":"         represents the compute node on which the image is launched."},{"line_number":261,"context_line":"   * - All"},{"line_number":262,"context_line":"     - ``vm_mode``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_ac67ca24","line":259,"range":{"start_line":259,"start_character":49,"end_line":259,"end_character":74},"updated":"2018-07-12 12:32:39.000000000","message":"nit: this might be a good opportunity to mention that traits can be managed using the osc-placement plugin:\n\nhttps://docs.openstack.org/osc-placement/latest/index.html\n\nI\u0027ll push a change to the flavor extra spec docs for that as well.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":256,"context_line":"       this feature."},{"line_number":257,"context_line":"     - Only valid value is required, any other value is invalid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"},{"line_number":260,"context_line":"         represents the compute node on which the image is launched."},{"line_number":261,"context_line":"   * - All"},{"line_number":262,"context_line":"     - ``vm_mode``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_fbe1f5d0","line":259,"range":{"start_line":259,"start_character":49,"end_line":259,"end_character":74},"in_reply_to":"5f7c97a3_ac67ca24","updated":"2018-07-12 15:47:46.000000000","message":"i can add this link in the description column since its common to all values.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":28171,"name":"karim","email":"karimullah.mohammed@intel.com","username":"karimull"},"change_message_id":"17346889b862309167875ea8d629e56815825339","unresolved":false,"context_lines":[{"line_number":257,"context_line":"     - Only valid value is required, any other value is invalid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"},{"line_number":260,"context_line":"         represents the compute node on which the image is launched."},{"line_number":261,"context_line":"   * - All"},{"line_number":262,"context_line":"     - ``vm_mode``"},{"line_number":263,"context_line":"     - The virtual machine mode. This represents the host/guest ABI"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_5c6ef52c","line":260,"range":{"start_line":260,"start_character":24,"end_line":260,"end_character":36},"updated":"2018-07-12 01:23:42.000000000","message":"or to any other shared resource provider to that compute node","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b76dbc55f67557c3355c413ad6482af26b61cad6","unresolved":false,"context_lines":[{"line_number":257,"context_line":"     - Only valid value is required, any other value is invalid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"},{"line_number":260,"context_line":"         represents the compute node on which the image is launched."},{"line_number":261,"context_line":"   * - All"},{"line_number":262,"context_line":"     - ``vm_mode``"},{"line_number":263,"context_line":"     - The virtual machine mode. This represents the host/guest ABI"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_ec5dc254","line":260,"range":{"start_line":260,"start_character":24,"end_line":260,"end_character":36},"in_reply_to":"5f7c97a3_5c6ef52c","updated":"2018-07-12 12:32:39.000000000","message":"Same reply as above - I don\u0027t think we want to get into that level of detail here.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"968e93d74ff47a32b4a4021babeaccfb32ea2979","unresolved":false,"context_lines":[{"line_number":257,"context_line":"     - Only valid value is required, any other value is invalid."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"},{"line_number":260,"context_line":"         represents the compute node on which the image is launched."},{"line_number":261,"context_line":"   * - All"},{"line_number":262,"context_line":"     - ``vm_mode``"},{"line_number":263,"context_line":"     - The virtual machine mode. This represents the host/guest ABI"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5f7c97a3_5b8a691a","line":260,"range":{"start_line":260,"start_character":24,"end_line":260,"end_character":36},"in_reply_to":"5f7c97a3_ec5dc254","updated":"2018-07-12 15:47:46.000000000","message":"see above..not changing this.","commit_id":"5483a6ad421f0134d82718f24724abbdf1541c90"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42e01a5e1c3304ee9a85080cb4d77ef4c222b8f8","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"       For example:"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        trait:HW_CPU_X86_AVX2\u003drequired"},{"line_number":247,"context_line":"        trait:STORAGE_DISK_SSD\u003drequired"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       The scheduler will pass required traits specified on the image to the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_7f7ffa16","line":246,"range":{"start_line":246,"start_character":7,"end_line":246,"end_character":8},"updated":"2018-07-13 12:50:16.000000000","message":"This formats a bit weird, so either align with \"For example\" or use a bullet list like in the flavor extra specs docs.","commit_id":"17106981f19e7c7f62816d0c0013190412d11b88"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"d7c4872f39b4458dfedf2f69e96ef027937425fa","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"       For example:"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        trait:HW_CPU_X86_AVX2\u003drequired"},{"line_number":247,"context_line":"        trait:STORAGE_DISK_SSD\u003drequired"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       The scheduler will pass required traits specified on the image to the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_cb320cc1","line":246,"range":{"start_line":246,"start_character":7,"end_line":246,"end_character":8},"in_reply_to":"5f7c97a3_7f7ffa16","updated":"2018-07-13 15:30:03.000000000","message":"Done","commit_id":"17106981f19e7c7f62816d0c0013190412d11b88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42e01a5e1c3304ee9a85080cb4d77ef4c222b8f8","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        trait:HW_CPU_X86_AVX2\u003drequired"},{"line_number":247,"context_line":"        trait:STORAGE_DISK_SSD\u003drequired"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       The scheduler will pass required traits specified on the image to the"},{"line_number":250,"context_line":"       Placement API to include only resource providers that can satisfy the"},{"line_number":251,"context_line":"       required traits. Traits for the resource providers can be managed using"},{"line_number":252,"context_line":"       the `osc-placement plugin. \u003chttps://docs.openstack.org/osc-placement/latest/index.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_7fa61ac3","line":249,"range":{"start_line":249,"start_character":11,"end_line":249,"end_character":20},"updated":"2018-07-13 12:50:16.000000000","message":"nova scheduler","commit_id":"17106981f19e7c7f62816d0c0013190412d11b88"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"d7c4872f39b4458dfedf2f69e96ef027937425fa","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        trait:HW_CPU_X86_AVX2\u003drequired"},{"line_number":247,"context_line":"        trait:STORAGE_DISK_SSD\u003drequired"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       The scheduler will pass required traits specified on the image to the"},{"line_number":250,"context_line":"       Placement API to include only resource providers that can satisfy the"},{"line_number":251,"context_line":"       required traits. Traits for the resource providers can be managed using"},{"line_number":252,"context_line":"       the `osc-placement plugin. \u003chttps://docs.openstack.org/osc-placement/latest/index.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_6b6ad882","line":249,"range":{"start_line":249,"start_character":11,"end_line":249,"end_character":20},"in_reply_to":"5f7c97a3_7fa61ac3","updated":"2018-07-13 15:30:03.000000000","message":"Done","commit_id":"17106981f19e7c7f62816d0c0013190412d11b88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"42e01a5e1c3304ee9a85080cb4d77ef4c222b8f8","unresolved":false,"context_lines":[{"line_number":254,"context_line":"       Image traits are used by the scheduler even in cases of volume backed"},{"line_number":255,"context_line":"       instances, if the volume source is an image with traits."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"       The FilterScheduler is currently the only scheduler driver that supports"},{"line_number":258,"context_line":"       this feature."},{"line_number":259,"context_line":"     - Only valid value is ``required``, any other value is invalid."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_df9f2e62","line":258,"range":{"start_line":257,"start_character":7,"end_line":258,"end_character":20},"updated":"2018-07-13 12:50:16.000000000","message":"I would still remove this since it\u0027s too nova-specific.","commit_id":"17106981f19e7c7f62816d0c0013190412d11b88"},{"author":{"_account_id":17190,"name":"Arvind Nadendla","email":"arvindn05@gmail.com","username":"arvindn05"},"change_message_id":"d7c4872f39b4458dfedf2f69e96ef027937425fa","unresolved":false,"context_lines":[{"line_number":254,"context_line":"       Image traits are used by the scheduler even in cases of volume backed"},{"line_number":255,"context_line":"       instances, if the volume source is an image with traits."},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"       The FilterScheduler is currently the only scheduler driver that supports"},{"line_number":258,"context_line":"       this feature."},{"line_number":259,"context_line":"     - Only valid value is ``required``, any other value is invalid."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"       * ``required`` - \u003ctrait_name\u003e is required on the resource provider that"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5f7c97a3_0b69e48a","line":258,"range":{"start_line":257,"start_character":7,"end_line":258,"end_character":20},"in_reply_to":"5f7c97a3_df9f2e62","updated":"2018-07-13 15:30:03.000000000","message":"Done","commit_id":"17106981f19e7c7f62816d0c0013190412d11b88"}]}