)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"9ecb897a76bc614ecca729531d2638b88f5b912b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bump hacking to 0.8 and get python 3.x compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to Bump hacking dependency is not the 0.8, some compatibility checks with python 3.x are not being done on gate and it is bringing code issues."},{"line_number":10,"context_line":"This change contains all the fixes for all the rules that failed when changed to hacking 0.8"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic878fe2e1bd3f65f7f95a9b5c7a192dac81b749d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F94uo%3D","line":9,"updated":"2013-12-04 21:20:08.000000000","message":"The commit message needs to be limited by 72 chars per line.","commit_id":"67538de38ee95f253464331c7df463d2e35a8d1f"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"89f6383a7118e0f0bc5af1a2e8d505c4a067c7a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bump hacking to 0.8 and get python 3.x compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Due to Bump hacking dependency is not the 0.8, some compatibility checks with python 3.x are not being done on gate and it is bringing code issues."},{"line_number":10,"context_line":"This change contains all the fixes for all the rules that failed when changed to hacking 0.8"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic878fe2e1bd3f65f7f95a9b5c7a192dac81b749d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F90%2Bk%3D","line":9,"in_reply_to":"AAAATn%2F94uo%3D","updated":"2013-12-05 14:27:23.000000000","message":"Done","commit_id":"67538de38ee95f253464331c7df463d2e35a8d1f"}],"glance/cmd/cache_manage.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"unresolved":false,"context_lines":[{"line_number":448,"context_line":"        command \u003d commands[command_name]"},{"line_number":449,"context_line":"    except KeyError:"},{"line_number":450,"context_line":"        parser.print_usage()"},{"line_number":451,"context_line":"        sys.exit(\"Unknown command: %s\" % {\u0027command_name\u0027: command_name})"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    return command"},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9RHQ%3D","line":451,"updated":"2013-12-13 10:08:14.000000000","message":"You don\u0027t need to use a keyword formatting here, unless you use %(command_name)s instead.\n\n   \u003e\u003e\u003e command_name \u003d \"test\"\n   \u003e\u003e\u003e \"Unknown command: %s\" % {\u0027command_name\u0027: command_name}\n   \"Unknown command: {\u0027command_name\u0027: \u0027test\u0027}\"","commit_id":"72a9c5716234f0a0c9323c2f24eba0bee93bc037"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"21c1d11a45681f393f6fd452689b6cf7e2ba4e81","unresolved":false,"context_lines":[{"line_number":448,"context_line":"        command \u003d commands[command_name]"},{"line_number":449,"context_line":"    except KeyError:"},{"line_number":450,"context_line":"        parser.print_usage()"},{"line_number":451,"context_line":"        sys.exit(\"Unknown command: %s\" % {\u0027command_name\u0027: command_name})"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"    return command"},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9QTo%3D","line":451,"in_reply_to":"AAAATn%2F9RHQ%3D","updated":"2013-12-13 13:12:48.000000000","message":"Done","commit_id":"72a9c5716234f0a0c9323c2f24eba0bee93bc037"},{"author":{"_account_id":9412,"name":"Andres Buraschi","email":"andres.buraschi@intel.com","username":"aburaschi"},"change_message_id":"e5d78133b607618d560ebe635023afe432c3c54a","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return FAILURE"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    if (not options.force and"},{"line_number":158,"context_line":"        not user_confirm(\"Queue image %s for caching?\" %"},{"line_number":159,"context_line":"                         {\u0027image_id\u0027: image_id}, default\u003dFalse)):"},{"line_number":160,"context_line":"        return SUCCESS"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Fcpc%3D","line":158,"updated":"2014-01-13 19:53:45.000000000","message":"String should be:\nQueue image %(image_id)s for caching?","commit_id":"31a2d5d5a4444c6e4b5b5b4a8345aaac9f740ff3"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"f48f9d8003131a67e14c6dad076b0bdb1eb521b1","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        return FAILURE"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    if (not options.force and"},{"line_number":158,"context_line":"        not user_confirm(\"Queue image %s for caching?\" %"},{"line_number":159,"context_line":"                         {\u0027image_id\u0027: image_id}, default\u003dFalse)):"},{"line_number":160,"context_line":"        return SUCCESS"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2FcgE%3D","line":158,"in_reply_to":"AAAAUH%2F%2Fcpc%3D","updated":"2014-01-13 20:07:55.000000000","message":"Done","commit_id":"31a2d5d5a4444c6e4b5b5b4a8345aaac9f740ff3"}],"glance/db/sqlalchemy/migrate_repo/versions/015_quote_swift_credentials.py":[{"author":{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},"change_message_id":"54ad749f6908a16a8cab0905377d9f1721ec507d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        if to_quote:"},{"line_number":121,"context_line":"            if len(cred_parts) \u003d\u003d 1:"},{"line_number":122,"context_line":"                reason \u003d (_(\"Badly formed credentials \u0027%(creds)s\u0027 in Swift \""},{"line_number":123,"context_line":"                            \"URI\") % creds)"},{"line_number":124,"context_line":"                LOG.error(reason)"},{"line_number":125,"context_line":"                raise exception.BadStoreUri()"},{"line_number":126,"context_line":"            elif len(cred_parts) \u003d\u003d 3:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F94nI%3D","line":123,"updated":"2013-12-04 21:55:48.000000000","message":"I don\u0027t think this will work now. The formatting is going to look for a something called \u0027creds\u0027 inside the creds variable. For this to work you need to drop the \u0027creds\u0027 in the format specifier. e.g. just use \u0027%s\u0027","commit_id":"67538de38ee95f253464331c7df463d2e35a8d1f"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"89f6383a7118e0f0bc5af1a2e8d505c4a067c7a2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        if to_quote:"},{"line_number":121,"context_line":"            if len(cred_parts) \u003d\u003d 1:"},{"line_number":122,"context_line":"                reason \u003d (_(\"Badly formed credentials \u0027%(creds)s\u0027 in Swift \""},{"line_number":123,"context_line":"                            \"URI\") % creds)"},{"line_number":124,"context_line":"                LOG.error(reason)"},{"line_number":125,"context_line":"                raise exception.BadStoreUri()"},{"line_number":126,"context_line":"            elif len(cred_parts) \u003d\u003d 3:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F90%2Bw%3D","line":123,"in_reply_to":"AAAATn%2F94nI%3D","updated":"2013-12-05 14:27:23.000000000","message":"Done","commit_id":"67538de38ee95f253464331c7df463d2e35a8d1f"}],"glance/tests/functional/__init__.py":[{"author":{"_account_id":5347,"name":"Eddie Sheffield","email":"eddie.sheffield@rackspace.com","username":"eddie-sheffield"},"change_message_id":"5c1a2e0b0249d7a653cb168d9a55991103d7c434","unresolved":false,"context_lines":[{"line_number":650,"context_line":"                if auth_pieces[1].strip():"},{"line_number":651,"context_line":"                    password \u003d \"-p%s\" % auth_pieces[1]"},{"line_number":652,"context_line":"            sql \u003d (\"drop database if exists %(database)s; \""},{"line_number":653,"context_line":"                   \"create database %(database)s;\") % database"},{"line_number":654,"context_line":"            cmd \u003d (\"mysql -u%(user)s %(password)s -h%(host)s \""},{"line_number":655,"context_line":"                   \"-e\\\"%(sql)s\\\"\") % {\u0027user\u0027: user, \u0027password\u0027: password,"},{"line_number":656,"context_line":"                                       \u0027host\u0027: host, \u0027sql\u0027: sql}"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F90B8%3D","line":653,"updated":"2013-12-05 16:52:18.000000000","message":"Needs a dictionary here.","commit_id":"0ca9ba8e00aa24262fc5d634ac3c0959551d3fa4"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"21c1d11a45681f393f6fd452689b6cf7e2ba4e81","unresolved":false,"context_lines":[{"line_number":650,"context_line":"                if auth_pieces[1].strip():"},{"line_number":651,"context_line":"                    password \u003d \"-p%s\" % auth_pieces[1]"},{"line_number":652,"context_line":"            sql \u003d (\"drop database if exists %(database)s; \""},{"line_number":653,"context_line":"                   \"create database %(database)s;\") % database"},{"line_number":654,"context_line":"            cmd \u003d (\"mysql -u%(user)s %(password)s -h%(host)s \""},{"line_number":655,"context_line":"                   \"-e\\\"%(sql)s\\\"\") % {\u0027user\u0027: user, \u0027password\u0027: password,"},{"line_number":656,"context_line":"                                       \u0027host\u0027: host, \u0027sql\u0027: sql}"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9z8I%3D","line":653,"in_reply_to":"AAAATn%2F90B8%3D","updated":"2013-12-05 17:04:52.000000000","message":"Done","commit_id":"0ca9ba8e00aa24262fc5d634ac3c0959551d3fa4"}],"glance/tests/unit/common/test_wsgi.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"unresolved":false,"context_lines":[{"line_number":293,"context_line":"                   \u0027properties\u0027: {\u0027distro\u0027: \u0027Ubuntu 10.04 LTS\u0027}}"},{"line_number":294,"context_line":"        headers \u003d utils.image_meta_to_http_headers(fixture)"},{"line_number":295,"context_line":"        for k, v in headers.iteritems():"},{"line_number":296,"context_line":"            self.assertTrue(isinstance(v, unicode), \"%s is not unicode\" % v)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_data_passed_properly_through_headers(self):"},{"line_number":299,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9RFs%3D","line":296,"updated":"2013-12-13 10:08:14.000000000","message":"Does hacking complains about this? It looks like un-related to this patch. Also, there\u0027s another patch already fixing this: Ie67c4c84eb74d7ed27b3c6c253239aaa1aff4862","commit_id":"72a9c5716234f0a0c9323c2f24eba0bee93bc037"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"21c1d11a45681f393f6fd452689b6cf7e2ba4e81","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                   \u0027properties\u0027: {\u0027distro\u0027: \u0027Ubuntu 10.04 LTS\u0027}}"},{"line_number":294,"context_line":"        headers \u003d utils.image_meta_to_http_headers(fixture)"},{"line_number":295,"context_line":"        for k, v in headers.iteritems():"},{"line_number":296,"context_line":"            self.assertTrue(isinstance(v, unicode), \"%s is not unicode\" % v)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_data_passed_properly_through_headers(self):"},{"line_number":299,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9Qbo%3D","line":296,"in_reply_to":"AAAATn%2F9RFs%3D","updated":"2013-12-13 13:12:48.000000000","message":"Good, I did a rebase so I have this fix.","commit_id":"72a9c5716234f0a0c9323c2f24eba0bee93bc037"}],"glance/tests/unit/test_migrations.py":[{"author":{"_account_id":9412,"name":"Andres Buraschi","email":"andres.buraschi@intel.com","username":"aburaschi"},"change_message_id":"e5d78133b607618d560ebe635023afe432c3c54a","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                sql \u003d (\"drop database if exists %(database)s; create \""},{"line_number":204,"context_line":"                       \"database %(database)s;\") % {\u0027database\u0027: database}"},{"line_number":205,"context_line":"                cmd \u003d (\"mysql -u \\\"%(user)s\\\" %(password)s -h %(host)s \""},{"line_number":206,"context_line":"                       \"-e \\\"%(sql)s\\\"\") % {\u0027user\u0027: user, \u0027host\u0027: host,"},{"line_number":207,"context_line":"                                            \u0027password\u0027: password,"},{"line_number":208,"context_line":"                                            \u0027sql\u0027: sql}"},{"line_number":209,"context_line":"                execute_cmd(cmd)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2FcnM%3D","line":206,"updated":"2014-01-13 19:53:45.000000000","message":"Just cosmetic, parameters are not in the same order. Even though it does no harm, you can update it if you need to upload another patch.","commit_id":"31a2d5d5a4444c6e4b5b5b4a8345aaac9f740ff3"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"f48f9d8003131a67e14c6dad076b0bdb1eb521b1","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                sql \u003d (\"drop database if exists %(database)s; create \""},{"line_number":204,"context_line":"                       \"database %(database)s;\") % {\u0027database\u0027: database}"},{"line_number":205,"context_line":"                cmd \u003d (\"mysql -u \\\"%(user)s\\\" %(password)s -h %(host)s \""},{"line_number":206,"context_line":"                       \"-e \\\"%(sql)s\\\"\") % {\u0027user\u0027: user, \u0027host\u0027: host,"},{"line_number":207,"context_line":"                                            \u0027password\u0027: password,"},{"line_number":208,"context_line":"                                            \u0027sql\u0027: sql}"},{"line_number":209,"context_line":"                execute_cmd(cmd)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Fcfo%3D","line":206,"in_reply_to":"AAAAUH%2F%2FcnM%3D","updated":"2014-01-13 20:07:55.000000000","message":"Done","commit_id":"31a2d5d5a4444c6e4b5b5b4a8345aaac9f740ff3"}],"glance/tests/unit/v2/test_images_resource.py":[{"author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"change_message_id":"252e821eaeb88158bc50469922a169a9d8fcc959","unresolved":false,"context_lines":[{"line_number":2125,"context_line":"    def test_index_with_many_filter(self):"},{"line_number":2126,"context_line":"        name \u003d \u0027My Little Image\u0027"},{"line_number":2127,"context_line":"        instance_id \u003d uuidutils.generate_uuid()"},{"line_number":2128,"context_line":"        path \u003d \u0027/images?name\u003d%(name)s\u0026id\u003d%(instance_id)s\u0027 % \\"},{"line_number":2129,"context_line":"               {\u0027name\u0027: name, \u0027instance_id\u0027: instance_id}"},{"line_number":2130,"context_line":"        request \u003d unit_test_utils.get_fake_request(path)"},{"line_number":2131,"context_line":"        output \u003d self.deserializer.index(request)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8ob8%3D","line":2128,"updated":"2013-12-24 01:07:23.000000000","message":"Could you use () instead of \\\n(\u0027/images?name\u003d%(name)s\u0026id\u003d%(instance_id)s\u0027 % {\u0027name\u0027: name, \u0027instance_id\u0027: instance_id})","commit_id":"8cb6fb98a2e28dba4b78839815ef92d193fac0fb"},{"author":{"_account_id":9214,"name":"Sergio Cazzolato","email":"sergiocazzolato@gmail.com","username":"sjcazzol"},"change_message_id":"567ec093d780b0c52245a29a96a62a1368fc4bad","unresolved":false,"context_lines":[{"line_number":2125,"context_line":"    def test_index_with_many_filter(self):"},{"line_number":2126,"context_line":"        name \u003d \u0027My Little Image\u0027"},{"line_number":2127,"context_line":"        instance_id \u003d uuidutils.generate_uuid()"},{"line_number":2128,"context_line":"        path \u003d \u0027/images?name\u003d%(name)s\u0026id\u003d%(instance_id)s\u0027 % \\"},{"line_number":2129,"context_line":"               {\u0027name\u0027: name, \u0027instance_id\u0027: instance_id}"},{"line_number":2130,"context_line":"        request \u003d unit_test_utils.get_fake_request(path)"},{"line_number":2131,"context_line":"        output \u003d self.deserializer.index(request)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2Fc1Q%3D","line":2128,"in_reply_to":"AAAATn%2F8ob8%3D","updated":"2014-01-13 18:54:24.000000000","message":"Done","commit_id":"8cb6fb98a2e28dba4b78839815ef92d193fac0fb"}]}