)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2caf5f555c5ce75c38a3a28fa8de07ba0cd665b0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     shreeduth-awasthi \u003cshreeduth.awasthi@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-04 23:46:53 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added error logging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"http store logs an error message when the remote location fails to return the image"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F95Y8%3D","line":7,"updated":"2013-12-04 18:49:52.000000000","message":"Can you please add more explicit title? This does not seem to indicate anything related to the HTTP store or 400.","commit_id":"dda3ef698829c2aafc7a2dcc0f748cd8456b08ec"},{"author":{"_account_id":2537,"name":"Nikhil Komawar","email":"nik.komawar@gmail.com","username":"nikhil-komawar"},"change_message_id":"2caf5f555c5ce75c38a3a28fa8de07ba0cd665b0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added error logging"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"http store logs an error message when the remote location fails to return the image"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I43c74395bc4632a97761ae4c11474bfeb823c85a"},{"line_number":12,"context_line":"Closes-Bug: #1257234"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F95aI%3D","line":9,"updated":"2013-12-04 18:49:52.000000000","message":"commit message cannot have more than 72 chars per line","commit_id":"dda3ef698829c2aafc7a2dcc0f748cd8456b08ec"}],"glance/store/http.py":[{"author":{"_account_id":6493,"name":"John Bresnahan","email":"john@bresnahan.me","username":"jbresnah"},"change_message_id":"5e1458a0796efd09a95c2522d719ccac621c6bed","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _query(self, location, verb, depth\u003d0):"},{"line_number":154,"context_line":"        if depth \u003e MAX_REDIRECTS:"},{"line_number":155,"context_line":"            raise exception.MaxRedirectsExceeded(redirects\u003dMAX_REDIRECTS)"},{"line_number":156,"context_line":"        loc \u003d location.store_location"},{"line_number":157,"context_line":"        conn_class \u003d self._get_conn_class(loc)"},{"line_number":158,"context_line":"        conn \u003d conn_class(loc.netloc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F90Nk%3D","line":155,"updated":"2013-12-05 16:18:18.000000000","message":"Should we log here as well for completion?","commit_id":"a651190d95a5dea295817e63dba3a6d0848ad24f"},{"author":{"_account_id":9565,"name":"Shree Duth Awasthi","email":"shreeduth.awasthi@tcs.com","username":"shreeduth-awasthi"},"change_message_id":"02a272690282e8b625bdaf784acacebf28e3aec6","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _query(self, location, verb, depth\u003d0):"},{"line_number":154,"context_line":"        if depth \u003e MAX_REDIRECTS:"},{"line_number":155,"context_line":"            raise exception.MaxRedirectsExceeded(redirects\u003dMAX_REDIRECTS)"},{"line_number":156,"context_line":"        loc \u003d location.store_location"},{"line_number":157,"context_line":"        conn_class \u003d self._get_conn_class(loc)"},{"line_number":158,"context_line":"        conn \u003d conn_class(loc.netloc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F90D4%3D","line":155,"in_reply_to":"AAAATn%2F90Nk%3D","updated":"2013-12-05 16:58:43.000000000","message":"Yes, it completes for http store. We shall do that.\n\nThanks for your time for the review.","commit_id":"a651190d95a5dea295817e63dba3a6d0848ad24f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"d3e9c69387e1151409cefafefbe8d779d892b98b","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            if resp.status not in (301, 302):"},{"line_number":171,"context_line":"                reason \u003d _(\"The HTTP URL attempted to redirect with an \""},{"line_number":172,"context_line":"                           \"invalid status code.\")"},{"line_number":173,"context_line":"                raise exception.BadStoreUri(loc.path, reason)"},{"line_number":174,"context_line":"            location_class \u003d glance.store.location.Location"},{"line_number":175,"context_line":"            new_loc \u003d location_class(location.store_name,"},{"line_number":176,"context_line":"                                     location.store_location.__class__,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F93jM%3D","line":173,"updated":"2013-12-05 02:23:35.000000000","message":"I prefer write a log at here also.","commit_id":"a651190d95a5dea295817e63dba3a6d0848ad24f"},{"author":{"_account_id":9565,"name":"Shree Duth Awasthi","email":"shreeduth.awasthi@tcs.com","username":"shreeduth-awasthi"},"change_message_id":"02a272690282e8b625bdaf784acacebf28e3aec6","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            if resp.status not in (301, 302):"},{"line_number":171,"context_line":"                reason \u003d _(\"The HTTP URL attempted to redirect with an \""},{"line_number":172,"context_line":"                           \"invalid status code.\")"},{"line_number":173,"context_line":"                raise exception.BadStoreUri(loc.path, reason)"},{"line_number":174,"context_line":"            location_class \u003d glance.store.location.Location"},{"line_number":175,"context_line":"            new_loc \u003d location_class(location.store_name,"},{"line_number":176,"context_line":"                                     location.store_location.__class__,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F90Ig%3D","line":173,"in_reply_to":"AAAATn%2F93jM%3D","updated":"2013-12-05 16:58:43.000000000","message":"Agree. Incorporated.\n\nThanks for your time for the review.","commit_id":"a651190d95a5dea295817e63dba3a6d0848ad24f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"0210d10cb19c5810f50b3e17d1d49f29c53de95e","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _query(self, location, verb, depth\u003d0):"},{"line_number":154,"context_line":"        if depth \u003e MAX_REDIRECTS:"},{"line_number":155,"context_line":"            reason \u003d _(\"The HTTP URL exceeded maximum redirects.\")"},{"line_number":156,"context_line":"            LOG.debug(reason)"},{"line_number":157,"context_line":"            raise exception.MaxRedirectsExceeded(redirects\u003dMAX_REDIRECTS)"},{"line_number":158,"context_line":"        loc \u003d location.store_location"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9z5M%3D","line":155,"updated":"2013-12-05 17:07:38.000000000","message":"humm..do you think it will be better if we put MAX_REDIRECTS value into log also?","commit_id":"7a212041a760999dae093cab850c9cae55587eb0"},{"author":{"_account_id":9565,"name":"Shree Duth Awasthi","email":"shreeduth.awasthi@tcs.com","username":"shreeduth-awasthi"},"change_message_id":"5e94a6d9952c34a8b30ca60eac7dfc2410c62c7c","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _query(self, location, verb, depth\u003d0):"},{"line_number":154,"context_line":"        if depth \u003e MAX_REDIRECTS:"},{"line_number":155,"context_line":"            reason \u003d _(\"The HTTP URL exceeded maximum redirects.\")"},{"line_number":156,"context_line":"            LOG.debug(reason)"},{"line_number":157,"context_line":"            raise exception.MaxRedirectsExceeded(redirects\u003dMAX_REDIRECTS)"},{"line_number":158,"context_line":"        loc \u003d location.store_location"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9zgI%3D","line":155,"in_reply_to":"AAAATn%2F9z5M%3D","updated":"2013-12-05 18:08:30.000000000","message":"Yes, sure.","commit_id":"7a212041a760999dae093cab850c9cae55587eb0"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"0210d10cb19c5810f50b3e17d1d49f29c53de95e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        location_header \u003d resp.getheader(\"location\")"},{"line_number":171,"context_line":"        if location_header:"},{"line_number":172,"context_line":"            if resp.status not in (301, 302):"},{"line_number":173,"context_line":"                reason \u003d _(\"The HTTP URL attempted to redirect with an \""},{"line_number":174,"context_line":"                           \"invalid status code.\")"},{"line_number":175,"context_line":"                LOG.debug(reason)"},{"line_number":176,"context_line":"                raise exception.BadStoreUri(loc.path, reason)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9z4c%3D","line":173,"updated":"2013-12-05 17:07:38.000000000","message":"ditto, resp.status","commit_id":"7a212041a760999dae093cab850c9cae55587eb0"}]}
