)]}'
{"glance/cmd/api.py":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"3577959eba321cf3dd318c49582914d9794dd4bd","unresolved":false,"context_lines":[{"line_number":30,"context_line":"eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue, time\u003dTrue,"},{"line_number":31,"context_line":"                              select\u003dTrue, thread\u003dTrue)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# If ../glance/__init__.py exists, add ../ to Python search path, so that"},{"line_number":34,"context_line":"# it will override what happens to be installed in /usr/(local/)lib/python..."},{"line_number":35,"context_line":"possible_topdir \u003d os.path.normpath(os.path.join(os.path.abspath(sys.argv[0]),"},{"line_number":36,"context_line":"                                   os.pardir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F86Z8%3D","side":"PARENT","line":33,"updated":"2013-12-18 22:17:07.000000000","message":"I am about 95% certain this code no longer needs to exist at all for the scripts in glance/cmd since they have been converted to entry points. Documenting my thoughts below.\n\nThis was missed in glance commit 039f3d8a59c62d3ad14288ed1b6a97aab539731e. However, these lines in nova scripts were removed when those were converted to entry points in nova commit 799a925c1f4a388c30a7f0d9e1ffe1b82e8ced9d.\n\nThese scripts should not be run directly and instead imported as modules. This snipped originally came to existence in nova commit f2a3f9a622613ec1575e70ac9fe9655b485d9a6d. My guess is that it was needed because unit tests ran the scripts directly and we needed to make sure that current code in the repo was being imported and used instead of an installed version.","commit_id":"5229f820a38df670e4548701dbd9368d6a498771"},{"author":{"_account_id":8641,"name":"DennyZhang","email":"filebat.mark@gmail.com","username":"dennyzhang"},"change_message_id":"c517a76608c43fe916f3015e8632eb7535ad051f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"eventlet.patcher.monkey_patch(all\u003dFalse, socket\u003dTrue, time\u003dTrue,"},{"line_number":31,"context_line":"                              select\u003dTrue, thread\u003dTrue)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# If ../glance/__init__.py exists, add ../ to Python search path, so that"},{"line_number":34,"context_line":"# it will override what happens to be installed in /usr/(local/)lib/python..."},{"line_number":35,"context_line":"possible_topdir \u003d os.path.normpath(os.path.join(os.path.abspath(sys.argv[0]),"},{"line_number":36,"context_line":"                                   os.pardir,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F81xc%3D","side":"PARENT","line":33,"in_reply_to":"AAAATn%2F86Z8%3D","updated":"2013-12-19 17:12:26.000000000","message":"Alex, are you suggesting to remove the code block from related files, then watch for a while to see whether we have some regression issues?\n\nOr do the code refactor first, then remove the common function, if we are 100% certain the common function is not required.","commit_id":"5229f820a38df670e4548701dbd9368d6a498771"}]}