)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"57656e210bd0a3d91b68a16566d9965c661bd755","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current policy.json file is missing the copy_from policy in order"},{"line_number":10,"context_line":"to be exhaustive."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ibc0d1fa7626629c28c514514a985a6b89db2ac69"},{"line_number":13,"context_line":"Closes-bug: #1258999"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9RBE%3D","line":11,"updated":"2013-12-13 10:17:57.000000000","message":"This change should be tagged with DocImpact.","commit_id":"20d16542ea5aefcf63ea8d111f75af978d0d095f"}],"doc/source/policies.rst":[{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"04efa70f4493e7f8bfdbecd60bbf7c59778633cc","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* ``copy_from`` - Copy binary image data from URL"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  * ``POST /v1/images``"},{"line_number":62,"context_line":"  * ``PUT /v1/images/\u003cIMAGE_ID\u003e``"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* ``add_image`` - Create an image entity"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F9qeE%3D","line":62,"updated":"2013-12-09 04:42:02.000000000","message":"In code I can see glance check \u0027copy_from\u0027 for create only, https://github.com/openstack/glance/blob/master/glance/api/v1/images.py#L747 , so can you tell me where we do the checking for PUT request? thanks.","commit_id":"20d16542ea5aefcf63ea8d111f75af978d0d095f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"813bdeef61862ca0bc55f59a4a38153d8fd0c1fb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* ``copy_from`` - Copy binary image data from URL"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  * ``POST /v1/images``"},{"line_number":62,"context_line":"  * ``PUT /v1/images/\u003cIMAGE_ID\u003e``"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* ``add_image`` - Create an image entity"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F9kxo%3D","line":62,"in_reply_to":"AAAATn%2F9nCc%3D","updated":"2013-12-10 02:56:58.000000000","message":"OK","commit_id":"20d16542ea5aefcf63ea8d111f75af978d0d095f"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"91c4e3aa3bad6774f4a7a1434a0452997d30813e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* ``copy_from`` - Copy binary image data from URL"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  * ``POST /v1/images``"},{"line_number":62,"context_line":"  * ``PUT /v1/images/\u003cIMAGE_ID\u003e``"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* ``add_image`` - Create an image entity"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F9nCc%3D","line":62,"in_reply_to":"AAAATn%2F9okw%3D","updated":"2013-12-09 17:27:45.000000000","message":"For the copy_from policy enforcement here is the patch https://review.openstack.org/#/c/60886/. So let\u0027s wait for the mentionned patch to be merged, before merging this review.","commit_id":"20d16542ea5aefcf63ea8d111f75af978d0d095f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"d01798ca9f4a99b53261b3c823ab5dfaaf8310ae","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* ``copy_from`` - Copy binary image data from URL"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  * ``POST /v1/images``"},{"line_number":62,"context_line":"  * ``PUT /v1/images/\u003cIMAGE_ID\u003e``"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* ``add_image`` - Create an image entity"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F9okw%3D","line":62,"in_reply_to":"AAAATn%2F9opk%3D","updated":"2013-12-09 14:01:37.000000000","message":"Agree. And I think it\u0027s a dedicated defect/change, and if you like you can fix that first then merge this.\n\nOf cause you can remove this line temporarily and add the copy_from policy enforcer, then add this doc line back again.","commit_id":"20d16542ea5aefcf63ea8d111f75af978d0d095f"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"c367fec78a73b3119e29655112501ffddb9ee2de","unresolved":false,"context_lines":[{"line_number":59,"context_line":"* ``copy_from`` - Copy binary image data from URL"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  * ``POST /v1/images``"},{"line_number":62,"context_line":"  * ``PUT /v1/images/\u003cIMAGE_ID\u003e``"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"* ``add_image`` - Create an image entity"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"AAAATn%2F9opk%3D","line":62,"in_reply_to":"AAAATn%2F9qeE%3D","updated":"2013-12-09 13:52:49.000000000","message":"You\u0027re highlighting a good point here. When doing an update one can use --copy_from option and it will be considered in _handle_source  https://github.com/openstack/glance/blob/master/glance/api/v1/images.py#L876. So actually I think the copy_from check on update is missing. Do you agree ?","commit_id":"20d16542ea5aefcf63ea8d111f75af978d0d095f"}]}