)]}'
{"doc/source/cli/glancestatus.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06d816dc8eb8d54f41db847d57d517b4eb3c9784","unresolved":false,"context_lines":[{"line_number":27,"context_line":"``upgrade``"},{"line_number":28,"context_line":"      This is the prefix for checking the glance deployment for any upgrade"},{"line_number":29,"context_line":"      issues that might prevent glance from upgrading."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"OPTIONS"},{"line_number":32,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3f79a3b5_dcb2ac05","line":30,"updated":"2018-11-05 17:10:28.000000000","message":"Should have the return code and history stuff in here, like this:\n\nhttps://docs.openstack.org/keystone/latest/cli/keystone-status.html#categories-and-commands","commit_id":"9bebb8c22e7f5c0845012726f06d766b6fe02b17"}],"glance/cmd/status.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"ae5cea5ca6a80cfad566ebbaee4b14f0f4850156","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Checks(upgradecheck.UpgradeCommands):"},{"line_number":22,"context_line":"    \"\"\"Programmable upgrade checks.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_82997f6c","line":22,"updated":"2018-10-18 15:12:30.000000000","message":"Here is Cinder upgrade check: https://review.openstack.org/#/c/610581/\n\nI think you may define _upgrade_checks, and add check check function which return SUCCESS.","commit_id":"9bebb8c22e7f5c0845012726f06d766b6fe02b17"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6a927f58e6119da1791fab12156595fde204c5e4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Checks(upgradecheck.UpgradeCommands):"},{"line_number":22,"context_line":"    \"\"\"Programmable upgrade checks.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5cf77cd2","line":22,"in_reply_to":"3f79a3b5_82997f6c","updated":"2018-11-05 17:07:58.000000000","message":"Lance is copying what he did in Keystone. Technically the oslo.upgradecheck tooling will handle _upgrade_checks being empty and will just result in an empty table.\n\nHaving said that, most other projects are getting a placeholder check in the base framework patch to see how checks are added.","commit_id":"9bebb8c22e7f5c0845012726f06d766b6fe02b17"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f6f6c3a4ed261c80886f030d9dcd898a283f7f7d","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def main():"},{"line_number":28,"context_line":"    return upgradecheck.main(CONF, \u0027glance\u0027, Checks())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_332a9077","line":28,"updated":"2018-10-15 17:00:37.000000000","message":"Running this is throwing the following error [0]. AFAICT this is the same exact implementation that keystone is using, which doesn\u0027t throw an error. The only difference is keystone is using keystone.conf as a configuration object, which does some extra stuff around oslo_config.cfg.Config.\n\nCould the fact that glance doesn\u0027t do that be causing issues? Or am I using CONF wrong here?\n\n[0] http://paste.openstack.org/raw/732162/","commit_id":"9bebb8c22e7f5c0845012726f06d766b6fe02b17"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb2514723a8ec9795e98b4221caf77e1016b7312","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class Checks(upgradecheck.UpgradeCommands):"},{"line_number":22,"context_line":"    \"\"\"Programmable upgrade checks.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_dc586c8a","line":24,"updated":"2018-11-05 17:20:41.000000000","message":"As previously noted, this works and results in an empty table:\n\nvenv runtests: commands[0] | glance-status upgrade check\n/home/osboxes/git/glance/.tox/venv/lib/python3.5/site.py:165: DeprecationWarning: \u0027U\u0027 mode is deprecated\n  f \u003d open(fullname, \"rU\")\n+-----------------------+\n| Upgrade Check Results |\n+-----------------------+\n__________________________________________________________________________________ summary __________________________________________________________________________________\n  venv: commands succeeded\n  congratulations :)\nosboxes@osboxes:~/git/glance$ \n\n\nIt would be nice to have a placeholder in here as an example for developers, but it could be done in a follow up, or just add a real check as the first one.","commit_id":"5cd2eb76554e97cfa1c0ea681b65359a87693fb6"}],"setup.cfg":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6a927f58e6119da1791fab12156595fde204c5e4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    glance-cache-cleaner \u003d glance.cmd.cache_cleaner:main"},{"line_number":41,"context_line":"    glance-control \u003d glance.cmd.control:main"},{"line_number":42,"context_line":"    glance-manage \u003d glance.cmd.manage:main"},{"line_number":43,"context_line":"    glance-status \u003d glance.cmd.status:main"},{"line_number":44,"context_line":"    glance-registry \u003d glance.cmd.registry:main"},{"line_number":45,"context_line":"    glance-replicator \u003d glance.cmd.replicator:main"},{"line_number":46,"context_line":"    glance-scrubber \u003d glance.cmd.scrubber:main"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3f79a3b5_1c2b4432","line":43,"updated":"2018-11-05 17:07:58.000000000","message":"Looks like these should be sorted.","commit_id":"9bebb8c22e7f5c0845012726f06d766b6fe02b17"}]}