)]}'
{"doc/source/admin/multistores.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2042c82d7e6aa22d5983e4e88fa40e3fe826399c","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"The reserved stores are not intended to be exposed to end users.  Thus"},{"line_number":137,"context_line":"they will not appear in the response to the store discovery call, GET"},{"line_number":138,"context_line":"/v2/info/stores."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"You do not get to select the name of a reserved store; these are defined"},{"line_number":141,"context_line":"by Glance and begin with the prefix ``os_glance_``.  In the Train release,"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7faddb67_8e15544b","line":138,"range":{"start_line":138,"start_character":15,"end_line":138,"end_character":16},"updated":"2019-07-19 12:24:48.000000000","message":"s/./, or as values in the ``OpenStack-image-store-ids`` response header of the image-create call./","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3c290984fe09f76e98ae8c15caea8a11f2a2aa94","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"The reserved stores are not intended to be exposed to end users.  Thus"},{"line_number":137,"context_line":"they will not appear in the response to the store discovery call, GET"},{"line_number":138,"context_line":"/v2/info/stores."},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"You do not get to select the name of a reserved store; these are defined"},{"line_number":141,"context_line":"by Glance and begin with the prefix ``os_glance_``.  In the Train release,"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7faddb67_3a2569ac","line":138,"range":{"start_line":138,"start_character":15,"end_line":138,"end_character":16},"in_reply_to":"7faddb67_8e15544b","updated":"2019-07-22 06:09:25.000000000","message":"Done","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2042c82d7e6aa22d5983e4e88fa40e3fe826399c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  and ``os_glance_staging_store``, must **not** be included in the"},{"line_number":188,"context_line":"  ``enabled_backends`` list."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* The reserved stores will **not** appear in the store discovery response."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"* The reserved stores will **not** be accepted as the ``store`` option"},{"line_number":193,"context_line":"  in image-create calls."}],"source_content_type":"text/x-rst","patch_set":14,"id":"7faddb67_8e3c74e1","line":190,"range":{"start_line":190,"start_character":73,"end_line":190,"end_character":74},"updated":"2019-07-19 12:24:48.000000000","message":"or as values in the ``OpenStack-image-store-ids`` response header of the image-create call.","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3c290984fe09f76e98ae8c15caea8a11f2a2aa94","unresolved":false,"context_lines":[{"line_number":187,"context_line":"  and ``os_glance_staging_store``, must **not** be included in the"},{"line_number":188,"context_line":"  ``enabled_backends`` list."},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* The reserved stores will **not** appear in the store discovery response."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"* The reserved stores will **not** be accepted as the ``store`` option"},{"line_number":193,"context_line":"  in image-create calls."}],"source_content_type":"text/x-rst","patch_set":14,"id":"7faddb67_da39b5d8","line":190,"range":{"start_line":190,"start_character":73,"end_line":190,"end_character":74},"in_reply_to":"7faddb67_8e3c74e1","updated":"2019-07-22 06:09:25.000000000","message":"Done","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2042c82d7e6aa22d5983e4e88fa40e3fe826399c","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* The reserved stores will **not** appear in the store discovery response."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"* The reserved stores will **not** be accepted as the ``store`` option"},{"line_number":193,"context_line":"  in image-create calls."}],"source_content_type":"text/x-rst","patch_set":14,"id":"7faddb67_2e62200b","line":193,"range":{"start_line":192,"start_character":50,"end_line":193,"end_character":24},"updated":"2019-07-19 12:24:48.000000000","message":"I think this should be \"the value of the ``X-Image-Meta-Store`` header on the image-data-upload call or the image-import call.","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3c290984fe09f76e98ae8c15caea8a11f2a2aa94","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"* The reserved stores will **not** appear in the store discovery response."},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"* The reserved stores will **not** be accepted as the ``store`` option"},{"line_number":193,"context_line":"  in image-create calls."}],"source_content_type":"text/x-rst","patch_set":14,"id":"7faddb67_fa36f1e7","line":193,"range":{"start_line":192,"start_character":50,"end_line":193,"end_character":24},"in_reply_to":"7faddb67_2e62200b","updated":"2019-07-22 06:09:25.000000000","message":"Done","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"a3900c06e3746542376516db99c8c5c0c52f62eb","unresolved":false,"context_lines":[{"line_number":181,"context_line":"* The path for ``filesystem_store_datadir`` used for the reserved"},{"line_number":182,"context_line":"  stores should be **different** from the path you are using for"},{"line_number":183,"context_line":"  any filesystem store you have listed in ``enabled_backends``."},{"line_number":184,"context_line":"  In fact, we do **not** recommend using the same data directory"},{"line_number":185,"context_line":"  for different stores."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* The identifiers for reserved stores, that is, ``os_glance_tasks_store``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7faddb67_42d59ab6","line":184,"range":{"start_line":184,"start_character":25,"end_line":184,"end_character":34},"updated":"2019-07-25 11:55:13.000000000","message":"I think we should change this to something stronger. Specially with the store id autodetection patch that is proposed utilizing same paths will cause massive confusion as I think that list we iterate does contain these reserved stores even they don\u0027t show up in discovery.","commit_id":"65e94f7a8eebf70d0385d29219019a2cdad688c8"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"d4c729bd0d2c24c83d724d8c8983a0db16428f5b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"* The path for ``filesystem_store_datadir`` used for the reserved"},{"line_number":182,"context_line":"  stores should be **different** from the path you are using for"},{"line_number":183,"context_line":"  any filesystem store you have listed in ``enabled_backends``."},{"line_number":184,"context_line":"  In fact, we do **not** recommend using the same data directory"},{"line_number":185,"context_line":"  for different stores."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* The identifiers for reserved stores, that is, ``os_glance_tasks_store``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7faddb67_9d2a17e5","line":184,"range":{"start_line":184,"start_character":25,"end_line":184,"end_character":34},"in_reply_to":"7faddb67_42d59ab6","updated":"2019-07-25 12:45:45.000000000","message":"I will need help here, not much into perfect wordings.\nrosmaita, erno please help :D","commit_id":"65e94f7a8eebf70d0385d29219019a2cdad688c8"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"d45c6451c625aac498baed9046026da086c510d6","unresolved":false,"context_lines":[{"line_number":181,"context_line":"* The path for ``filesystem_store_datadir`` used for the reserved"},{"line_number":182,"context_line":"  stores should be **different** from the path you are using for"},{"line_number":183,"context_line":"  any filesystem store you have listed in ``enabled_backends``."},{"line_number":184,"context_line":"  In fact, we do **not** recommend using the same data directory"},{"line_number":185,"context_line":"  for different stores."},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"* The identifiers for reserved stores, that is, ``os_glance_tasks_store``"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7faddb67_c82a0b7d","line":184,"range":{"start_line":184,"start_character":25,"end_line":184,"end_character":34},"in_reply_to":"7faddb67_9d2a17e5","updated":"2019-07-25 13:11:04.000000000","message":"Lets brainstorm that in the weekly meeting shortly.","commit_id":"65e94f7a8eebf70d0385d29219019a2cdad688c8"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4894eae78450f91e7daf2c7ddb26b1e74ed56de3","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. note::"},{"line_number":142,"context_line":"   Currently, only the filesystem store type is supported as a Glance"},{"line_number":143,"context_line":"   reserved store.  Our goal is to allow any store type to be used in"},{"line_number":144,"context_line":"   a future release."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"The reserved stores are not intended to be exposed to end users.  Thus"},{"line_number":147,"context_line":"they will not appear in the response to the store discovery call, GET"}],"source_content_type":"text/x-rst","patch_set":21,"id":"3fa7e38b_3bcedd59","line":144,"range":{"start_line":143,"start_character":20,"end_line":144,"end_character":20},"updated":"2019-09-30 16:04:24.000000000","message":"NIT: I don\u0027t want to hold this because of this doc sentence, but no we are never gonna support any stores for these purposes. We are looking to expand the list to stores that makes sense. \u0027http\u0027 due to it\u0027s read only nature we just can\u0027t and I\u0027m not fully convinced we can use anything else than file for tasks work dir. We need to be careful setting the expectations and looking what would actually make sense process flow wise.","commit_id":"dc2144d42b3f861b90fa8fe32bb0063dc81b46b0"}],"glance/api/v2/discovery.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"52ae8b7b83c9580cc418815e62915bcd3a8a2e2d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        # \u0027stores\u0027 and \u0027default_store\u0027 are removed."},{"line_number":42,"context_line":"        enabled_backends \u003d CONF.enabled_backends"},{"line_number":43,"context_line":"        if not enabled_backends:"},{"line_number":44,"context_line":"            msg \u003d _(\"Multi backend is not supported at this site.\")"},{"line_number":45,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        backends \u003d []"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_f6d86c53","line":44,"range":{"start_line":44,"start_character":21,"end_line":44,"end_character":64},"updated":"2019-07-18 23:17:48.000000000","message":"This may already be handled by another patch, just want to make sure we don\u0027t miss this.  Should say \"multiple stores\".","commit_id":"ef7ac138bc30ab9ca3c6fc8dfe197f2f5558deab"}],"glance/async_/flows/_internal_plugins/web_download.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"4894eae78450f91e7daf2c7ddb26b1e74ed56de3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            name\u003d\u0027%s-WebDownload-%s\u0027 % (task_type, task_id))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        # NOTE(abhishekk): Use reserved \u0027os_glance_staging_store\u0027 for"},{"line_number":48,"context_line":"        # staging the data, the else part will be removed once multiple"},{"line_number":49,"context_line":"        # backend feature is declared as stable."},{"line_number":50,"context_line":"        if CONF.enabled_backends:"},{"line_number":51,"context_line":"            self.store \u003d store_api.get_store_from_store_identifier("},{"line_number":52,"context_line":"                \u0027os_glance_staging_store\u0027)"}],"source_content_type":"text/x-python","patch_set":21,"id":"3fa7e38b_dbe229a0","line":49,"range":{"start_line":48,"start_character":28,"end_line":49,"end_character":47},"updated":"2019-09-30 16:04:24.000000000","message":"NIT: not holding the patch back for this either, but this is considered stable, we can get rid of the clause there after we are done with deprecation of the old way of configuring these.","commit_id":"dc2144d42b3f861b90fa8fe32bb0063dc81b46b0"}],"glance/async_/flows/api_image_import.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"52ae8b7b83c9580cc418815e62915bcd3a8a2e2d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                LOG.warning(_(\"After upload to backend, deletion of staged \""},{"line_number":109,"context_line":"                              \"image data has failed because \""},{"line_number":110,"context_line":"                              \"it cannot be found at %(fn)s\"), {"},{"line_number":111,"context_line":"                    \u0027fn\u0027: file_path})"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class _VerifyStaging(task.Task):"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_f1ccf635","line":111,"updated":"2019-07-18 23:17:48.000000000","message":"This looks really weird, but I guess pep8 is OK with it.","commit_id":"ef7ac138bc30ab9ca3c6fc8dfe197f2f5558deab"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"52ae8b7b83c9580cc418815e62915bcd3a8a2e2d","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        downloadToStaging \u003d internal_plugins.get_import_plugin(**kwargs)"},{"line_number":359,"context_line":"        flow.add(downloadToStaging)"},{"line_number":360,"context_line":"        if CONF.enabled_backends:"},{"line_number":361,"context_line":"            staging_dir \u003d \"file://%s\" % getattr("},{"line_number":362,"context_line":"                CONF, \u0027os_glance_staging_store\u0027).filesystem_store_datadir"},{"line_number":363,"context_line":"            if not staging_dir.endswith(\u0027/\u0027):"},{"line_number":364,"context_line":"                separator \u003d \u0027/\u0027"},{"line_number":365,"context_line":"            file_uri \u003d separator.join((staging_dir, str(image_id)))"},{"line_number":366,"context_line":"        else:"},{"line_number":367,"context_line":"            file_uri \u003d separator.join((CONF.node_staging_uri, str(image_id)))"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_717486cf","line":364,"range":{"start_line":361,"start_character":0,"end_line":364,"end_character":31},"updated":"2019-07-18 23:17:48.000000000","message":"This duplicates lines 347-350 ... maybe factor it out to after lines 341-343, that way we\u0027re taking care of the separator all in one place.","commit_id":"ef7ac138bc30ab9ca3c6fc8dfe197f2f5558deab"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2042c82d7e6aa22d5983e4e88fa40e3fe826399c","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        downloadToStaging \u003d internal_plugins.get_import_plugin(**kwargs)"},{"line_number":359,"context_line":"        flow.add(downloadToStaging)"},{"line_number":360,"context_line":"        if CONF.enabled_backends:"},{"line_number":361,"context_line":"            staging_dir \u003d \"file://%s\" % getattr("},{"line_number":362,"context_line":"                CONF, \u0027os_glance_staging_store\u0027).filesystem_store_datadir"},{"line_number":363,"context_line":"            if not staging_dir.endswith(\u0027/\u0027):"},{"line_number":364,"context_line":"                separator \u003d \u0027/\u0027"},{"line_number":365,"context_line":"            file_uri \u003d separator.join((staging_dir, str(image_id)))"},{"line_number":366,"context_line":"        else:"},{"line_number":367,"context_line":"            file_uri \u003d separator.join((CONF.node_staging_uri, str(image_id)))"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_50813ac2","line":364,"range":{"start_line":361,"start_character":0,"end_line":364,"end_character":31},"updated":"2019-07-19 12:24:48.000000000","message":"This duplicates lines 347-350 ... maybe factor it out to after lines 341-343, that way we\u0027re taking care of the separator all in one place.","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3c290984fe09f76e98ae8c15caea8a11f2a2aa94","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        downloadToStaging \u003d internal_plugins.get_import_plugin(**kwargs)"},{"line_number":359,"context_line":"        flow.add(downloadToStaging)"},{"line_number":360,"context_line":"        if CONF.enabled_backends:"},{"line_number":361,"context_line":"            staging_dir \u003d \"file://%s\" % getattr("},{"line_number":362,"context_line":"                CONF, \u0027os_glance_staging_store\u0027).filesystem_store_datadir"},{"line_number":363,"context_line":"            if not staging_dir.endswith(\u0027/\u0027):"},{"line_number":364,"context_line":"                separator \u003d \u0027/\u0027"},{"line_number":365,"context_line":"            file_uri \u003d separator.join((staging_dir, str(image_id)))"},{"line_number":366,"context_line":"        else:"},{"line_number":367,"context_line":"            file_uri \u003d separator.join((CONF.node_staging_uri, str(image_id)))"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_7a50c10b","line":364,"range":{"start_line":361,"start_character":0,"end_line":364,"end_character":31},"in_reply_to":"7faddb67_50813ac2","updated":"2019-07-22 06:09:25.000000000","message":"Done","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"91b77c7a1537810e8401041bfdb2f18ec84157a8","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        CONF, \u0027os_glance_staging_store\u0027).filesystem_store_datadir"},{"line_number":404,"context_line":"    if not staging_dir.endswith(\u0027/\u0027):"},{"line_number":405,"context_line":"        separator \u003d \u0027/\u0027"},{"line_number":406,"context_line":"    return separator, staging_dir"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_ba4f0b91","line":406,"range":{"start_line":406,"start_character":11,"end_line":406,"end_character":20},"updated":"2019-07-22 20:44:59.000000000","message":"I think it\u0027s possible this could raise an UnboundLocalError -- I think you need to initialize separator to the empty string at the beginning of the function.","commit_id":"e1fd1026b8935b9dbf38ecd78245eac73644d8aa"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"c105a86fa1debe874cd69c81c90c28cf8920532b","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        CONF, \u0027os_glance_staging_store\u0027).filesystem_store_datadir"},{"line_number":404,"context_line":"    if not staging_dir.endswith(\u0027/\u0027):"},{"line_number":405,"context_line":"        separator \u003d \u0027/\u0027"},{"line_number":406,"context_line":"    return separator, staging_dir"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_096857b8","line":406,"range":{"start_line":406,"start_character":11,"end_line":406,"end_character":20},"in_reply_to":"7faddb67_ba4f0b91","updated":"2019-07-23 05:06:38.000000000","message":"Done","commit_id":"e1fd1026b8935b9dbf38ecd78245eac73644d8aa"}],"glance/common/config.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2dd69274e2859e41f17f6940f2fe90ad9dbdfa78","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    cfg.StrOpt(\u0027work_dir\u0027,"},{"line_number":130,"context_line":"               sample_default\u003d\u0027/work_dir\u0027,"},{"line_number":131,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":132,"context_line":"               deprecated_since\u003d\u0027Stein\u0027,"},{"line_number":133,"context_line":"               deprecated_reason\u003d_(\"\"\""},{"line_number":134,"context_line":"This option is deprecated as glance will now reserve"},{"line_number":135,"context_line":"a filesystem store named \u0027os_glance_tasks_store\u0027 to use instead of"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_fe85005b","line":132,"range":{"start_line":132,"start_character":33,"end_line":132,"end_character":38},"updated":"2019-09-12 14:44:55.000000000","message":"Can\u0027t really backdate deprecations. That said, we can still handle the deprecation and then removal appropriately, so this would just be a slightly misleading documentation issue. It at least states below that it would be removed in Ussuri, so I\u0027m not really too concerned about this.","commit_id":"1c45567ef0279247502ac7ab8136149c2b1e5a88"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"358d850f0d49a4c675a61377b15a879bb5815544","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    cfg.StrOpt(\u0027work_dir\u0027,"},{"line_number":130,"context_line":"               sample_default\u003d\u0027/work_dir\u0027,"},{"line_number":131,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":132,"context_line":"               deprecated_since\u003d\u0027Stein\u0027,"},{"line_number":133,"context_line":"               deprecated_reason\u003d_(\"\"\""},{"line_number":134,"context_line":"This option is deprecated as glance will now reserve"},{"line_number":135,"context_line":"a filesystem store named \u0027os_glance_tasks_store\u0027 to use instead of"}],"source_content_type":"text/x-python","patch_set":19,"id":"5faad753_bd3a21c9","line":132,"range":{"start_line":132,"start_character":33,"end_line":132,"end_character":38},"in_reply_to":"5faad753_fe85005b","updated":"2019-09-13 02:42:15.000000000","message":"Good catch, Sean.  I think this file is going to have a merge conflict with commit 4265e61bc84, which already deprecated these options (for Train).  See https://review.opendev.org/#/c/674697/4/glance/common/config.py\n\nWe should probably just drop this file from the patch set.","commit_id":"1c45567ef0279247502ac7ab8136149c2b1e5a88"}],"glance/common/wsgi.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"52ae8b7b83c9580cc418815e62915bcd3a8a2e2d","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":3,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":4,"context_line":"# Copyright 2010 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":12,"id":"7faddb67_a94ff268","line":1,"updated":"2019-07-18 23:17:48.000000000","message":"Nit: I don\u0027t think we want this blank line here.","commit_id":"ef7ac138bc30ab9ca3c6fc8dfe197f2f5558deab"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2042c82d7e6aa22d5983e4e88fa40e3fe826399c","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":3,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":4,"context_line":"# Copyright 2010 OpenStack Foundation"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_10ce6262","line":1,"updated":"2019-07-19 12:24:48.000000000","message":"Please remove this blank line.","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"}],"releasenotes/notes/rethinking-filesystem-access-120bc46064b3d40a.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"52ae8b7b83c9580cc418815e62915bcd3a8a2e2d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    This release adds support to reserve filesystem stores for staging"},{"line_number":4,"context_line":"    and tasks operations."},{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - |"},{"line_number":7,"context_line":"    Configuration option ``work_dir`` used for tasks and ``node_staging_uri``"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7faddb67_a9d4d248","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":25},"updated":"2019-07-18 23:17:48.000000000","message":"I think you should remove the prelude, the PTL will write one for the entire release.","commit_id":"ef7ac138bc30ab9ca3c6fc8dfe197f2f5558deab"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2042c82d7e6aa22d5983e4e88fa40e3fe826399c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    note the following:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    * In this release, the use of stores (instead of local directories) is"},{"line_number":12,"context_line":"      optional, but it will become mandatory for the \u0027U\u0027 release.  "},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    * In this release, the stores used *must* be the filesystem store type."},{"line_number":15,"context_line":"      Our goal is that in a future release, operators will be able to"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7faddb67_ee05e814","line":12,"range":{"start_line":12,"start_character":65,"end_line":12,"end_character":67},"updated":"2019-07-19 12:24:48.000000000","message":"Nit: whitespace to remove.","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"3c290984fe09f76e98ae8c15caea8a11f2a2aa94","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    note the following:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    * In this release, the use of stores (instead of local directories) is"},{"line_number":12,"context_line":"      optional, but it will become mandatory for the \u0027U\u0027 release.  "},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    * In this release, the stores used *must* be the filesystem store type."},{"line_number":15,"context_line":"      Our goal is that in a future release, operators will be able to"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7faddb67_1a550dfb","line":12,"range":{"start_line":12,"start_character":65,"end_line":12,"end_character":67},"in_reply_to":"7faddb67_ee05e814","updated":"2019-07-22 06:09:25.000000000","message":"Done","commit_id":"cb8aad5e70f8941768577fda6f0ff5cb032fc025"}]}