)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"433810c349e9adf19504aa5313dd917c2fdb9b34","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michael Moore \u003copenstack@mdmoore.me\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-26 22:10:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updates glance config to honor documented default paste_deploy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updates glance config to use the documented default value \u0027keystone\u0027 for paste_deploy"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_035f5f74","line":7,"range":{"start_line":7,"start_character":31,"end_line":7,"end_character":41},"updated":"2018-11-05 21:09:04.000000000","message":"This isn\u0027t quite accurate because the default documented in the glance-api-paste.ini is no auth or caching","commit_id":"98c866baf8497a321affec4cccfffa9138181f95"}],"glance/common/config.py":[{"author":{"_account_id":23561,"name":"iain MacDonnell","email":"iain.macdonnell@oracle.com","username":"imacdonn"},"change_message_id":"1be160a0304146df0475d01460edb9d58ed4c149","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"paste_deploy_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027flavor\u0027,"},{"line_number":33,"context_line":"               sample_default\u003d\u0027keystone\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\"\"\""},{"line_number":36,"context_line":"Deployment flavor to use in the server application pipeline."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_05cf0bb3","line":33,"range":{"start_line":33,"start_character":15,"end_line":33,"end_character":41},"updated":"2018-10-26 21:19:28.000000000","message":"I think sample_default becomes redundant with this change, and probably should be removed.","commit_id":"03c937ad194483d474e56913af4e2fac4833d9df"},{"author":{"_account_id":29380,"name":"Michael Moore","email":"openstack@mdmoore.me","username":"mdmoore"},"change_message_id":"662787e390f90b00e5a08b37c5c7edad788453bf","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"paste_deploy_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027flavor\u0027,"},{"line_number":33,"context_line":"               sample_default\u003d\u0027keystone\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\"\"\""},{"line_number":36,"context_line":"Deployment flavor to use in the server application pipeline."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a5f097db","line":33,"range":{"start_line":33,"start_character":15,"end_line":33,"end_character":41},"in_reply_to":"3f79a3b5_05cf0bb3","updated":"2018-10-26 21:28:31.000000000","message":"My reading of https://docs.openstack.org/oslo.config/queens/reference/opts.html\n\ndefault¶\nthe default value of the option\n\nsample_default¶\na sample default value string to include in sample config files\n\nmakes me think that sample_default is only for sample configuration files.\n\nI don\u0027t see anything that indicates that default will set a value for sample_default","commit_id":"03c937ad194483d474e56913af4e2fac4833d9df"},{"author":{"_account_id":29380,"name":"Michael Moore","email":"openstack@mdmoore.me","username":"mdmoore"},"change_message_id":"53a368ad1768c038f3e068326130bdfbab2a9d2d","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"paste_deploy_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027flavor\u0027,"},{"line_number":33,"context_line":"               sample_default\u003d\u0027keystone\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\"\"\""},{"line_number":36,"context_line":"Deployment flavor to use in the server application pipeline."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_85731be8","line":33,"range":{"start_line":33,"start_character":15,"end_line":33,"end_character":41},"in_reply_to":"3f79a3b5_85855bb0","updated":"2018-10-26 22:06:03.000000000","message":"OK that makes sense, and the hashing_algorithm setting and sample config values line up. Making that edit.","commit_id":"03c937ad194483d474e56913af4e2fac4833d9df"},{"author":{"_account_id":23561,"name":"iain MacDonnell","email":"iain.macdonnell@oracle.com","username":"imacdonn"},"change_message_id":"350e907f7ccd238b981d824512bc41f0ea72701f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"paste_deploy_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027flavor\u0027,"},{"line_number":33,"context_line":"               sample_default\u003d\u0027keystone\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":35,"context_line":"               help\u003d_(\"\"\""},{"line_number":36,"context_line":"Deployment flavor to use in the server application pipeline."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_85855bb0","line":33,"range":{"start_line":33,"start_character":15,"end_line":33,"end_character":41},"in_reply_to":"3f79a3b5_a5f097db","updated":"2018-10-26 22:00:26.000000000","message":"I was looking at https://docs.openstack.org/oslo.config/latest/cli/generator.html , and my interpretation is that sample_default is used to provide a meaningful example value for documentation when the actual value is not applicable (e.g. it\u0027s actually determined dynamically at runtime). Look at hashing_algorithm (same file) for an example of \"default\", which does appear at https://docs.openstack.org/glance/latest/configuration/sample-configuration.html","commit_id":"03c937ad194483d474e56913af4e2fac4833d9df"},{"author":{"_account_id":23561,"name":"iain MacDonnell","email":"iain.macdonnell@oracle.com","username":"imacdonn"},"change_message_id":"7c675ef8653c4fe42ca6d8cba9310245efe60eaa","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from glance.version import version_info as version"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"paste_deploy_opts \u003d ["},{"line_number":32,"context_line":"    cfg.StrOpt(\u0027flavor\u0027,               "},{"line_number":33,"context_line":"               default\u003d\u0027keystone\u0027,"},{"line_number":34,"context_line":"               help\u003d_(\"\"\""},{"line_number":35,"context_line":"Deployment flavor to use in the server application pipeline."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_052e2baa","line":32,"range":{"start_line":32,"start_character":24,"end_line":32,"end_character":39},"updated":"2018-10-26 22:08:40.000000000","message":"spurious whitespace","commit_id":"79a42dc32d5a564551704a912d41843c8e0b8deb"}]}