)]}'
{"glance/async_/flows/_internal_plugins/web_download.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"827083bd27515affbc0492dc1116dae709a67632","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # While using any path should be \"technically\" fine, it\u0027s not what"},{"line_number":101,"context_line":"        # we recommend as the best solution. For more details on this, please"},{"line_number":102,"context_line":"        # refer to the comment in the `_ImportToStore.execute` method."},{"line_number":103,"context_line":"        data \u003d script_utils.get_image_data_iter(self.uri)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        path \u003d self.store.add(self.image_id, data, 0)[0]"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a0f525cb","line":103,"updated":"2018-11-22 13:57:53.000000000","message":"We probably should add exception handling here so we won\u0027t be logging stack trace when such errors happens (also consider to change the LOG. call below for same reason)?","commit_id":"0f590ba1688abbbca1729c5bc1fe53172674e274"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b09ad7a42d09bd309b9fe4f29dd69c56ca7879ac","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            data \u003d script_utils.get_image_data_iter(self.uri)"},{"line_number":107,"context_line":"        except Exception as e:"},{"line_number":108,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":109,"context_line":"                LOG.error(\"Task %(task_id)s failed with exception %(error)s\" %"},{"line_number":110,"context_line":"                          {\"error\": encodeutils.exception_to_unicode(e),"},{"line_number":111,"context_line":"                           \"task_id\": self.task_id})"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_2e377400","line":109,"range":{"start_line":109,"start_character":77,"end_line":109,"end_character":78},"updated":"2019-03-01 14:46:14.000000000","message":"nit: Should be a comma to pass the formatting values into the LOG call as args rather than doing the string formatting up front. That said, error level logging is likely always going to be enabled, so just a very minor performance concern.","commit_id":"27bbcd5b193cf73abbd772a79708a9808892f9b1"}],"glance/tests/unit/async_/flows/test_web_download.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b09ad7a42d09bd309b9fe4f29dd69c56ca7879ac","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                               \"get_image_data_iter\") as mock_iter:"},{"line_number":96,"context_line":"            mock_iter.side_effect \u003d glance.common.exception.NotFound"},{"line_number":97,"context_line":"            self.assertRaises(glance.common.exception.NotFound,"},{"line_number":98,"context_line":"                              web_download_task.execute)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_2e10d458","line":98,"updated":"2019-03-01 14:46:14.000000000","message":"Should we also have an assert that validate the resulting state?","commit_id":"27bbcd5b193cf73abbd772a79708a9808892f9b1"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a30451ee17236ffa34200b9193ac467dfb7aa115","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                               \"get_image_data_iter\") as mock_iter:"},{"line_number":96,"context_line":"            mock_iter.side_effect \u003d glance.common.exception.NotFound"},{"line_number":97,"context_line":"            self.assertRaises(glance.common.exception.NotFound,"},{"line_number":98,"context_line":"                              web_download_task.execute)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_649b4617","line":98,"in_reply_to":"9fdfeff1_2e10d458","updated":"2019-03-04 05:02:39.000000000","message":"I am afraid to say this class is written just to test the WebDownload task and image_id is mocked here and it does not have any image object associated with it.","commit_id":"27bbcd5b193cf73abbd772a79708a9808892f9b1"}]}