)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7884,"name":"Noboru Arai","email":"arai@mxa.nes.nec.co.jp","username":"NoboruArai"},"change_message_id":"68aa4ae7c14b73304816f2ecb0a282f387af724f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"module."},{"line_number":14,"context_line":"Unit test test_cache_pruner_main_runtime_exception_handling added to"},{"line_number":15,"context_line":"cover exception handling for main() method of cache_cleaner.py"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7d7b182260a407aed1288a5d136e03cbe029523f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2Fu7Y%3D","line":16,"updated":"2014-01-09 03:06:21.000000000","message":"In my understand, \"cache_cleaner.py\" is \"cache_pruner.py\".\nIf I\u0027m wrong, let me know.","commit_id":"f7777843cbb419908d706e843fa809f305246aea"},{"author":{"_account_id":8689,"name":"Vitaliy Kolosov","email":"vkolosov@yahoo-inc.com","username":"VKolosov"},"change_message_id":"ecb4c65f3aa914ecfc6ea32ac7cf9ead69d25915","unresolved":false,"context_lines":[{"line_number":13,"context_line":"module."},{"line_number":14,"context_line":"Unit test test_cache_pruner_main_runtime_exception_handling added to"},{"line_number":15,"context_line":"cover exception handling for main() method of cache_cleaner.py"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7d7b182260a407aed1288a5d136e03cbe029523f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2B1aM%3D","line":16,"in_reply_to":"AAAAUH%2F%2FGkQ%3D","updated":"2014-01-21 16:25:57.000000000","message":"Done","commit_id":"f7777843cbb419908d706e843fa809f305246aea"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0556c433edc01e226df8544ae6851f2dcdca9246","unresolved":false,"context_lines":[{"line_number":13,"context_line":"module."},{"line_number":14,"context_line":"Unit test test_cache_pruner_main_runtime_exception_handling added to"},{"line_number":15,"context_line":"cover exception handling for main() method of cache_cleaner.py"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7d7b182260a407aed1288a5d136e03cbe029523f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FGkQ%3D","line":16,"in_reply_to":"AAAAUH%2F%2Fu7Y%3D","updated":"2014-01-17 12:30:35.000000000","message":"+1, seems like a copy-paste issue.","commit_id":"f7777843cbb419908d706e843fa809f305246aea"}],"glance/tests/unit/api/test_cmd.py":[{"author":{"_account_id":7884,"name":"Noboru Arai","email":"arai@mxa.nes.nec.co.jp","username":"NoboruArai"},"change_message_id":"68aa4ae7c14b73304816f2ecb0a282f387af724f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import glance.common.config"},{"line_number":21,"context_line":"from glance.common import exception as exc"},{"line_number":22,"context_line":"import glance.common.wsgi"},{"line_number":23,"context_line":"import glance.image_cache.cleaner"},{"line_number":24,"context_line":"from glance.tests import utils as test_utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Fu78%3D","line":23,"updated":"2014-01-09 03:06:21.000000000","message":"In Stubs.Set of line 127,  \"glance.image_cache.pruner.Pruner\" is used.\n\nIs unnecessary \" import glance.image_cache.pruner\" ?\n\nIn Stub.Set of line 98 ,\" glance.image_cache.cleaner.Cleaner\" is used and \" glance.image_cache.cleaner\" is imported.","commit_id":"f7777843cbb419908d706e843fa809f305246aea"},{"author":{"_account_id":8689,"name":"Vitaliy Kolosov","email":"vkolosov@yahoo-inc.com","username":"VKolosov"},"change_message_id":"ecb4c65f3aa914ecfc6ea32ac7cf9ead69d25915","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import glance.common.config"},{"line_number":21,"context_line":"from glance.common import exception as exc"},{"line_number":22,"context_line":"import glance.common.wsgi"},{"line_number":23,"context_line":"import glance.image_cache.cleaner"},{"line_number":24,"context_line":"from glance.tests import utils as test_utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B1Rc%3D","line":23,"in_reply_to":"AAAAUH%2F%2B5Io%3D","updated":"2014-01-21 16:25:57.000000000","message":"Thank you for your notice. It seems, there is some hidden import of *glance.image_cache.pruner* before the test, based on it, so the test passes. I\u0027ll add the import into this file like for image_cache.cleaner.","commit_id":"f7777843cbb419908d706e843fa809f305246aea"},{"author":{"_account_id":7884,"name":"Noboru Arai","email":"arai@mxa.nes.nec.co.jp","username":"NoboruArai"},"change_message_id":"9cec7acfaf24471ab00ee51eedccc6f04e9ff6c7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import glance.common.config"},{"line_number":21,"context_line":"from glance.common import exception as exc"},{"line_number":22,"context_line":"import glance.common.wsgi"},{"line_number":23,"context_line":"import glance.image_cache.cleaner"},{"line_number":24,"context_line":"from glance.tests import utils as test_utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B5Io%3D","line":23,"in_reply_to":"AAAAUH%2F%2FGig%3D","updated":"2014-01-21 01:43:07.000000000","message":"@Fei\n\nThanks.\n\n \"glance.image_cache.cleaner\" is used in Line 98.\n -self.stubs.Set(glance.image_cache.cleaner.Cleaner, \u0027run\u0027,self._raise(RuntimeError))\n\nAnd  \"import glance.image_cache.cleaner\"  exists in line 23.\n\nIn comparison to above,\n\"glance.image_cache.pruner.\" is used in Line 127.\n-self.stubs.Set(glance.image_cache.pruner.Pruner,\u0027run\u0027,self._raise(RuntimeError)).\n\nbut \"import glance.image_cache.pruner\"  does\u0027nt exist.\n\n\n---------------------------------------------------------------------\nvagrant@arai-controller:~$ python\nPython 2.7.3 (default, Sep 26 2013, 20:03:06)\n[GCC 4.6.3] on linux2\n\u003e\u003e\u003e import stubout\n\u003e\u003e\u003e stubs\u003dstubout.StubOutForTesting()\n\u003e\u003e\u003e stubs.Set(time,\"time\",lambda:100)\nTraceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\nNameError: name \u0027time\u0027 is not defined\n\u003e\u003e\u003e import time\n\u003e\u003e\u003e time.time()\n1390300482.143033\n\u003e\u003e\u003e stubs.Set(time,\"time\",lambda:100)\n\u003e\u003e\u003e time.time()\n100\n\u003e\u003e\u003e","commit_id":"f7777843cbb419908d706e843fa809f305246aea"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"0556c433edc01e226df8544ae6851f2dcdca9246","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import glance.common.config"},{"line_number":21,"context_line":"from glance.common import exception as exc"},{"line_number":22,"context_line":"import glance.common.wsgi"},{"line_number":23,"context_line":"import glance.image_cache.cleaner"},{"line_number":24,"context_line":"from glance.tests import utils as test_utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FGig%3D","line":23,"in_reply_to":"AAAAUH%2F%2Fu78%3D","updated":"2014-01-17 12:30:35.000000000","message":"@Noboru, I didn\u0027t see \u0027import glance.image_cache.pruner\u0027, am I missing anything?","commit_id":"f7777843cbb419908d706e843fa809f305246aea"}]}