)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fc3dbef004784a0f74327ba71c2cf5b0c4332c60","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change default visibility to \u0027private\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change changes the defaults of all layers (domain and database)"},{"line_number":10,"context_line":"to \u0027private\u0027 visibility and adresses the test cases to either testing"},{"line_number":11,"context_line":"that the default is \u0027private\u0027 or if test does touch membership, the"},{"line_number":12,"context_line":"image is explicitly created vith \u0027visibility\u0027\u003d\u0027shared\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"New alembic migration scripts are added for changing the default"},{"line_number":15,"context_line":"visibility on database server level as well for consistency."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfdaf3ff_f07d631c","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":55},"updated":"2019-01-16 01:13:42.000000000","message":"What was an actual problem on the existing \u0027shared\u0027 visibility? Is that security issue?\nHappy to see some bug report if we have.","commit_id":"d247f4c4a35f5064c4016f493d59a3325e465a19"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0c088dc72cdc3aa2ee81a96b12982728e72bd463","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change default visibility to \u0027private\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change changes the defaults of all layers (domain and database)"},{"line_number":10,"context_line":"to \u0027private\u0027 visibility and adresses the test cases to either testing"},{"line_number":11,"context_line":"that the default is \u0027private\u0027 or if test does touch membership, the"},{"line_number":12,"context_line":"image is explicitly created vith \u0027visibility\u0027\u003d\u0027shared\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"New alembic migration scripts are added for changing the default"},{"line_number":15,"context_line":"visibility on database server level as well for consistency."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfdaf3ff_0d9d6d58","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":55},"in_reply_to":"bfdaf3ff_f07d631c","updated":"2019-01-16 09:54:59.000000000","message":"Reasoning for this change is rather user experience than directly security. The problem with the \"shared\" default visibility is that for new user it indeed looks like a security vulnerability. When new image is created currently the image details shows it as \"shared\" which spooks users. While the image is not in fact shared with anyone before there is members added to it. This creates very crappy user experience.","commit_id":"d247f4c4a35f5064c4016f493d59a3325e465a19"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fc3dbef004784a0f74327ba71c2cf5b0c4332c60","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to \u0027private\u0027 visibility and adresses the test cases to either testing"},{"line_number":11,"context_line":"that the default is \u0027private\u0027 or if test does touch membership, the"},{"line_number":12,"context_line":"image is explicitly created vith \u0027visibility\u0027\u003d\u0027shared\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"New alembic migration scripts are added for changing the default"},{"line_number":15,"context_line":"visibility on database server level as well for consistency."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfdaf3ff_3099ab6d","line":13,"updated":"2019-01-16 01:13:42.000000000","message":"My concern is the default value could be changed like a swinging pendulum in the future if we don\u0027t have a concrete evidence. And that could hurt users and operators.\n\nBTW isn\u0027t it possible to implement this as a config option which option\u0027s default value is \u0027shared\u0027 to avoid hurting them for soft changing?","commit_id":"d247f4c4a35f5064c4016f493d59a3325e465a19"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0c088dc72cdc3aa2ee81a96b12982728e72bd463","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to \u0027private\u0027 visibility and adresses the test cases to either testing"},{"line_number":11,"context_line":"that the default is \u0027private\u0027 or if test does touch membership, the"},{"line_number":12,"context_line":"image is explicitly created vith \u0027visibility\u0027\u003d\u0027shared\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"New alembic migration scripts are added for changing the default"},{"line_number":15,"context_line":"visibility on database server level as well for consistency."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfdaf3ff_ed5ca97f","line":13,"in_reply_to":"bfdaf3ff_3099ab6d","updated":"2019-01-16 09:54:59.000000000","message":"Config option is technically possible to implement, yet it won\u0027t happen for two reasons. Our config file is already way north of 3k lines of all kind of crap. Adding pointless config option there will not make operator life any easier. The other problem having this as configurable is inconsistency among deployments. Default values are supposed to be reasonable defaults and making this configurable _and_ leaving the default of that config option to something that has been identified as user experience problem is again not going to help anyone. It also will cause confusion amongs users when they cannot depend on behaviour from the cloud.\n\nYou\u0027re worried that the default value could be changed by the community and yet you propose a solution for that being easily changeable by the deployer, so please what are you actually concerned about?","commit_id":"d247f4c4a35f5064c4016f493d59a3325e465a19"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"82fd0eeff4a1e951eb725d1834635b749a7aaf13","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to \u0027private\u0027 visibility and adresses the test cases to either testing"},{"line_number":11,"context_line":"that the default is \u0027private\u0027 or if test does touch membership, the"},{"line_number":12,"context_line":"image is explicitly created vith \u0027visibility\u0027\u003d\u0027shared\u0027."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"New alembic migration scripts are added for changing the default"},{"line_number":15,"context_line":"visibility on database server level as well for consistency."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bfdaf3ff_fcbe8b63","line":13,"in_reply_to":"bfdaf3ff_ed5ca97f","updated":"2019-01-16 22:10:54.000000000","message":"Maybe my main concern is it is difficult to see any actual feedback(voice) from operators/users, because I cannot find any bug reports/survey which mention such feedback.\n\nI just wanted to be confident to see \"We never change the default value again\". Please help me to be confident.","commit_id":"d247f4c4a35f5064c4016f493d59a3325e465a19"}],"glance/db/sqlalchemy/alembic_migrations/versions/stein_contract01_empty.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"07395dcdc66ed01dd5cb60c7fa460528cf79abaf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2019 RedHat Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fdfeff1_fbf9837f","line":1,"updated":"2019-02-13 05:33:30.000000000","message":"this file needs to rename as stein_contract01_change_default_visibility.py\n\nIn addition we need to add empty migration script under alembic_migrations/data_migrations/stein_migrate01_empty.py","commit_id":"d247f4c4a35f5064c4016f493d59a3325e465a19"}],"glance/tests/functional/db/migrations/test_stein_contract01.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"95a35c5127fcedb8eb2f709cf2b0b1433fb5d6a9","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _pre_upgrade_stein_contract01(self, engine):"},{"line_number":27,"context_line":"        images \u003d db_utils.get_table(engine, \u0027images\u0027)"},{"line_number":28,"context_line":"        self.assertIsNone(images.c.visibility.server_default)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _check_stein_contract01(self, engine, data):"},{"line_number":31,"context_line":"        images \u003d db_utils.get_table(engine, \u0027images\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_b2ecde29","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":25},"updated":"2019-01-09 11:45:38.000000000","message":"This needs to be changed to assertIsNotNone, as by default it applies \u0027DefaultClause(\u003csqlalchemy.sql.elements.TextClause object at 0x7f7bbe95e5f8\u003e, for_update\u003dFalse)\u0027 to the column\n\nThis will fix the only failing functional test","commit_id":"8d6c84ea7074bf1895024bffdb4aadd3ef43703e"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"95a35c5127fcedb8eb2f709cf2b0b1433fb5d6a9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.assertEqual(\u0027private\u0027, images.c.visibility.server_default)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class TestRockyExpand02MySQL(TestSteinContract01Mixin,"},{"line_number":36,"context_line":"                             test_base.MySQLOpportunisticTestCase):"},{"line_number":37,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfd5e7cf_7281964a","line":35,"range":{"start_line":35,"start_character":6,"end_line":35,"end_character":27},"updated":"2019-01-09 11:45:38.000000000","message":"This needs to be TestSteinExpand01MySQL","commit_id":"8d6c84ea7074bf1895024bffdb4aadd3ef43703e"}],"releasenotes/notes/default_vis_private-58e4114a9f93ae28.yaml":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fc3dbef004784a0f74327ba71c2cf5b0c4332c60","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Default image visibility has been changed to \u0027private\u0027."},{"line_number":5,"context_line":"    While default image visibility was previously set to"},{"line_number":6,"context_line":"    \u0027shared\u0027 to be compatible with Images API v1 (where only"},{"line_number":7,"context_line":"    options were just public or not). Based on the user \u0026"},{"line_number":8,"context_line":"    operator survey at December 2018 all responses were in"},{"line_number":9,"context_line":"    favour of changing the default visibility to \u0027private\u0027. This"},{"line_number":10,"context_line":"    makes it less confusing for end user who creates an image and"},{"line_number":11,"context_line":"    should not expect it being shared with anyone. While the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfdaf3ff_d0993f79","line":8,"range":{"start_line":7,"start_character":38,"end_line":8,"end_character":36},"updated":"2019-01-16 01:13:42.000000000","message":"Could you put actual link to the survey as an evidence?","commit_id":"d247f4c4a35f5064c4016f493d59a3325e465a19"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0c088dc72cdc3aa2ee81a96b12982728e72bd463","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Default image visibility has been changed to \u0027private\u0027."},{"line_number":5,"context_line":"    While default image visibility was previously set to"},{"line_number":6,"context_line":"    \u0027shared\u0027 to be compatible with Images API v1 (where only"},{"line_number":7,"context_line":"    options were just public or not). Based on the user \u0026"},{"line_number":8,"context_line":"    operator survey at December 2018 all responses were in"},{"line_number":9,"context_line":"    favour of changing the default visibility to \u0027private\u0027. This"},{"line_number":10,"context_line":"    makes it less confusing for end user who creates an image and"},{"line_number":11,"context_line":"    should not expect it being shared with anyone. While the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfdaf3ff_edea6973","line":8,"range":{"start_line":7,"start_character":38,"end_line":8,"end_character":36},"in_reply_to":"bfdaf3ff_d0993f79","updated":"2019-01-16 09:54:59.000000000","message":"http://lists.openstack.org/pipermail/openstack-discuss/2018-November/000362.html due to google forms and dataprotection reasons I cannot make the responses public, I obviously could export the results sanitized from the survey but I doubt that would make it any more evident for you.","commit_id":"d247f4c4a35f5064c4016f493d59a3325e465a19"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c42be4e4b5ab48eac2eaa4b48d731b813a6ddbf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fdfeff1_39b1d890","line":15,"updated":"2019-01-21 18:06:11.000000000","message":"I think we need to add an \u0027upgrade\u0027 section.  Because of https://review.openstack.org/#/c/628430/5/glance/domain/__init__.py@72 (default viz is set in code, not relying on the DB default), you need to restart the api before you see the effect of the change.  If someone\u0027s doing rolling upgrades, the \"old\" nodes will still create images with default viz \u0027shared\u0027 until they\u0027re pulled out of circulation.","commit_id":"d247f4c4a35f5064c4016f493d59a3325e465a19"}]}