)]}'
{"id":"openstack%2Fglance~62897","triplet_id":"openstack%2Fglance~master~I82f08a8f522c81541e4f77597c2ba0aeb68556ce","project":"openstack/glance","branch":"master","hashtags":[],"change_id":"I82f08a8f522c81541e4f77597c2ba0aeb68556ce","subject":"Filter out deleted images from storage usage","status":"MERGED","created":"2013-12-18 14:29:29.000000000","updated":"2014-01-08 03:02:23.000000000","submitted":"2013-12-20 17:01:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e2b9f9644ec2abea6206735650925a369a0f50bb","_number":62897,"virtual_id_number":62897,"owner":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"value":0,"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},{"value":2,"date":"2013-12-20 17:01:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9363,"name":"Konstantin Permyakov","email":"kpermyakov@griddynamics.com","username":"kpermyakov"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"all":[{"value":0,"date":"2013-12-20 12:40:22.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":2,"date":"2013-12-20 16:03:45.000000000","_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"value":1,"date":"2013-12-20 16:02:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9363,"name":"Konstantin Permyakov","email":"kpermyakov@griddynamics.com","username":"kpermyakov"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"all":[{"value":0,"date":"2013-12-20 12:40:22.000000000","_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":1,"date":"2013-12-20 16:04:24.000000000","_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"value":0,"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9363,"name":"Konstantin Permyakov","email":"kpermyakov@griddynamics.com","username":"kpermyakov"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"value":0,"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"value":0,"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"value":0,"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9363,"name":"Konstantin Permyakov","email":"kpermyakov@griddynamics.com","username":"kpermyakov"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},{"_account_id":9363,"name":"Konstantin Permyakov","email":"kpermyakov@griddynamics.com","username":"kpermyakov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-19 14:29:11.000000000","updated_by":{"_account_id":9363,"name":"Konstantin Permyakov","email":"kpermyakov@griddynamics.com","username":"kpermyakov"},"reviewer":{"_account_id":9363,"name":"Konstantin Permyakov","email":"kpermyakov@griddynamics.com","username":"kpermyakov"},"state":"REVIEWER"},{"updated":"2013-12-19 20:59:44.000000000","updated_by":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"reviewer":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"state":"REVIEWER"},{"updated":"2013-12-20 16:02:59.000000000","updated_by":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"reviewer":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"state":"REVIEWER"},{"updated":"2013-12-20 16:04:24.000000000","updated_by":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"reviewer":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"state":"REVIEWER"},{"updated":"2013-12-20 17:01:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d2fc190d704b73661dbb8cfce0f1493da5d0ff2c","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2013-12-18 14:41:21.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nI think the root cause is there are some \u0027deleted\u0027 locations instead of deleted images.","accounts_in_message":[],"_revision_number":1},{"id":"0070b25cde06c35efbc823f23f34e8e8117d2aca","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-18 14:51:37.000000000","message":"Patch Set 1:\n\nI disagree. There\u0027s no reason to iterate over deleted images. I\u0027d say we should add a filter for killed images as well and deleted locations.","accounts_in_message":[],"_revision_number":1},{"id":"16c05cc81527b2dd02df4e1f6700cb75b403fa9f","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-18 14:53:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d4e8651cae7ba975b6758b2cbac87194f71bb083","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2013-12-18 15:00:48.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\nDo we need some test cases for simpleDB?","accounts_in_message":[],"_revision_number":2},{"id":"8e1d711280156ef619daa3b61995dbf031aa3258","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-18 15:47:09.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-glance-pep8 http://logs.openstack.org/97/62897/2/check/gate-glance-pep8/9df693f : SUCCESS in 2m 30s\n- gate-glance-docs http://docs-draft.openstack.org/97/62897/2/check/gate-glance-docs/0262507/doc/build/html/ : SUCCESS in 2m 08s\n- gate-glance-python26 http://logs.openstack.org/97/62897/2/check/gate-glance-python26/5730074 : SUCCESS in 13m 32s\n- gate-glance-python27 http://logs.openstack.org/97/62897/2/check/gate-glance-python27/f9b6fb3 : SUCCESS in 10m 46s\n- check-tempest-dsvm-full http://logs.openstack.org/97/62897/2/check/check-tempest-dsvm-full/646c818 : SUCCESS in 52m 12s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/62897/2/check/check-tempest-dsvm-postgres-full/92e5c18 : SUCCESS in 47m 43s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/62897/2/check/check-tempest-dsvm-neutron/da64691 : SUCCESS in 34m 32s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/62897/2/check/gate-tempest-dsvm-large-ops/3bc1c34 : SUCCESS in 14m 49s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/62897/2/check/gate-tempest-dsvm-neutron-large-ops/c98aa26 : SUCCESS in 20m 39s\n- check-grenade-dsvm http://logs.openstack.org/97/62897/2/check/check-grenade-dsvm/551e90b : SUCCESS in 38m 47s\n","accounts_in_message":[],"_revision_number":2},{"id":"d16cfec5148f2f04bd712b68b27cb4db08a7977e","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-18 16:43:57.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cff53388a5be8b9b0fe4a5ba0688190e7fa4355b","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-18 16:50:22.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"fec47abb1a58cd1fd0cd48db97478058c6a76212","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-12-18 16:50:30.000000000","message":"Patch Set 4:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":4},{"id":"ec99d561018f62843dfe5b7e490eddb45876ea2f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-18 17:34:20.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-glance-pep8 http://logs.openstack.org/97/62897/4/check/gate-glance-pep8/c4255fc : FAILURE in 1m 55s\n- gate-glance-docs http://docs-draft.openstack.org/97/62897/4/check/gate-glance-docs/f3131a1/doc/build/html/ : SUCCESS in 2m 02s\n- gate-glance-python26 http://logs.openstack.org/97/62897/4/check/gate-glance-python26/f910a04 : FAILURE in 11m 02s\n- gate-glance-python27 http://logs.openstack.org/97/62897/4/check/gate-glance-python27/67eefd4 : FAILURE in 12m 08s\n- check-tempest-dsvm-full http://logs.openstack.org/97/62897/4/check/check-tempest-dsvm-full/db02af5 : SUCCESS in 41m 14s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/62897/4/check/check-tempest-dsvm-postgres-full/46af160 : SUCCESS in 40m 52s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/62897/4/check/check-tempest-dsvm-neutron/afab3af : SUCCESS in 39m 29s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/62897/4/check/gate-tempest-dsvm-large-ops/5d17132 : SUCCESS in 16m 16s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/62897/4/check/gate-tempest-dsvm-neutron-large-ops/602fc27 : SUCCESS in 15m 38s\n- check-grenade-dsvm http://logs.openstack.org/97/62897/4/check/check-grenade-dsvm/1276eba : SUCCESS in 36m 13s\n","accounts_in_message":[],"_revision_number":4},{"id":"fd3f93e5eeb2a785c4721eb39dd7b9bebf2a844c","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2013-12-19 03:11:31.000000000","message":"Patch Set 4: (2 inline comments)\n\nSorry for the -1 :)","accounts_in_message":[],"_revision_number":4},{"id":"06981f115a1779108fd9c60728da914aa57b3537","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2013-12-19 03:11:42.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\n","accounts_in_message":[],"_revision_number":4},{"id":"e2a9560d2f365a7c22ae34daeb17126d49ae7a84","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-19 09:01:29.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"0d9827dafdf31091dc6a5b7bebafdcfc1e63c3fc","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-19 09:01:49.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"ebbe4093c3ccf3011d7b4b7218850cfb3b21f374","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-19 09:08:01.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"08d0e75dead9160f133c88926ce91ae3828a1126","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-19 09:52:03.000000000","message":"Patch Set 6: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-glance-pep8 http://logs.openstack.org/97/62897/6/check/gate-glance-pep8/260fd50 : FAILURE in 1m 41s\n- gate-glance-docs http://docs-draft.openstack.org/97/62897/6/check/gate-glance-docs/ef0c579/doc/build/html/ : SUCCESS in 2m 13s\n- gate-glance-python26 http://logs.openstack.org/97/62897/6/check/gate-glance-python26/ce22f41 : FAILURE in 14m 21s\n- gate-glance-python27 http://logs.openstack.org/97/62897/6/check/gate-glance-python27/7651885 : FAILURE in 14m 17s\n- check-tempest-dsvm-full http://logs.openstack.org/97/62897/6/check/check-tempest-dsvm-full/f1c2d5e : SUCCESS in 43m 48s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/62897/6/check/check-tempest-dsvm-postgres-full/672ec91 : SUCCESS in 42m 32s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/62897/6/check/check-tempest-dsvm-neutron/5aad8aa : SUCCESS in 36m 26s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/62897/6/check/gate-tempest-dsvm-large-ops/4a22acd : SUCCESS in 17m 40s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/62897/6/check/gate-tempest-dsvm-neutron-large-ops/ffb54bc : SUCCESS in 20m 52s\n- check-grenade-dsvm http://logs.openstack.org/97/62897/6/check/check-grenade-dsvm/d196c46 : SUCCESS in 42m 41s\n","accounts_in_message":[],"_revision_number":6},{"id":"f4b24d6aec5dd75ae2cdb75a85ec7288451b433a","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-19 11:29:15.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"3ef690dc2811d422c9b24449b3947a91ae1da3cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-19 12:13:00.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- gate-glance-pep8 http://logs.openstack.org/97/62897/7/check/gate-glance-pep8/1a58a91 : SUCCESS in 1m 58s\n- gate-glance-docs http://docs-draft.openstack.org/97/62897/7/check/gate-glance-docs/58f8ed7/doc/build/html/ : SUCCESS in 2m 17s\n- gate-glance-python26 http://logs.openstack.org/97/62897/7/check/gate-glance-python26/4875d4d : SUCCESS in 9m 47s\n- gate-glance-python27 http://logs.openstack.org/97/62897/7/check/gate-glance-python27/7fef53d : SUCCESS in 12m 59s\n- check-tempest-dsvm-full http://logs.openstack.org/97/62897/7/check/check-tempest-dsvm-full/ca41ebc : SUCCESS in 39m 03s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/62897/7/check/check-tempest-dsvm-postgres-full/7eddab8 : SUCCESS in 36m 16s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/62897/7/check/check-tempest-dsvm-neutron/da3e9d1 : SUCCESS in 36m 21s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/62897/7/check/gate-tempest-dsvm-large-ops/00ac5a8 : SUCCESS in 14m 37s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/62897/7/check/gate-tempest-dsvm-neutron-large-ops/9c2d488 : SUCCESS in 19m 02s\n- check-grenade-dsvm http://logs.openstack.org/97/62897/7/check/check-grenade-dsvm/ec36df9 : SUCCESS in 36m 08s\n","accounts_in_message":[],"_revision_number":7},{"id":"d14ba543f7029c5afe2d027a465f14f89b453137","author":{"_account_id":9363,"name":"Konstantin Permyakov","email":"kpermyakov@griddynamics.com","username":"kpermyakov"},"date":"2013-12-19 14:31:54.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"f3e6032abb0542a3a4ed72fe6d7561317b4318cd","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-19 15:14:47.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"45869ad40335299f73aa2cb260edf5600042b7a1","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-19 16:07:11.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"65b16e5f2f449ea5dd5176788ba495ea759c6b27","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-12-19 16:07:18.000000000","message":"Patch Set 8:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":8},{"id":"986bcdf41a3e3a3f41975f0ae4c218eb2ba3cda9","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2013-12-19 16:24:46.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"f1524555c4c6603d6275d470906c2cca10c3ecb8","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-19 16:39:57.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"566e6527551c22f18923c7b74e235025e6c1c008","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-12-19 16:40:05.000000000","message":"Patch Set 9:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":9},{"id":"3dbd2be0dedf32284caf5fdb609ac1f9b2d7ed1b","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2013-12-19 17:02:55.000000000","message":"Patch Set 8: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"2c83c9b4435b22b5b2d6434624746b25009dc138","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2013-12-19 17:03:03.000000000","message":"Patch Set 9: I would prefer that you didn\u0027t merge this\n\n","accounts_in_message":[],"_revision_number":9},{"id":"ee6d8f9edb7f5eac5532c5c1d2024a5e902434f0","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2013-12-19 17:08:40.000000000","message":"Patch Set 9: I would prefer that you didn\u0027t merge this\n\nEchoing ZhiYan\u0027s comments, it\u0027s a good point. Let\u0027s find a reasonable way for that.","accounts_in_message":[],"_revision_number":9},{"id":"611e473f1401ad8c9510f2b1f315e286b843c7ab","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-19 17:22:54.000000000","message":"Patch Set 9: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-glance-pep8 http://logs.openstack.org/97/62897/9/check/gate-glance-pep8/0d4bb69 : SUCCESS in 2m 09s\n- gate-glance-docs http://docs-draft.openstack.org/97/62897/9/check/gate-glance-docs/2f658d0/doc/build/html/ : SUCCESS in 1m 48s\n- gate-glance-python26 http://logs.openstack.org/97/62897/9/check/gate-glance-python26/95b1f21 : SUCCESS in 11m 44s\n- gate-glance-python27 http://logs.openstack.org/97/62897/9/check/gate-glance-python27/486650f : SUCCESS in 15m 15s\n- check-tempest-dsvm-full http://logs.openstack.org/97/62897/9/check/check-tempest-dsvm-full/8c57c85 : SUCCESS in 37m 25s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/62897/9/check/check-tempest-dsvm-postgres-full/2bc9e9e : SUCCESS in 37m 55s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/62897/9/check/check-tempest-dsvm-neutron/6720eb3 : SUCCESS in 32m 51s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/62897/9/check/gate-tempest-dsvm-large-ops/9ecd146 : SUCCESS in 15m 45s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/62897/9/check/gate-tempest-dsvm-neutron-large-ops/443449f : FAILURE in 10m 52s\n- check-grenade-dsvm http://logs.openstack.org/97/62897/9/check/check-grenade-dsvm/ea295ff : SUCCESS in 32m 45s\n","accounts_in_message":[],"_revision_number":9},{"id":"2bb31d3caab0306264fc805bc9d947c902930486","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-19 17:29:14.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"c3196702133337ea7d422b3cd5bd89e2917f291d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-19 18:17:03.000000000","message":"Patch Set 10: Works for me\n\nBuild succeeded.\n\n- gate-glance-pep8 http://logs.openstack.org/97/62897/10/check/gate-glance-pep8/d9f604d : SUCCESS in 1m 42s\n- gate-glance-docs http://docs-draft.openstack.org/97/62897/10/check/gate-glance-docs/54710e6/doc/build/html/ : SUCCESS in 1m 54s\n- gate-glance-python26 http://logs.openstack.org/97/62897/10/check/gate-glance-python26/943d1ef : SUCCESS in 13m 41s\n- gate-glance-python27 http://logs.openstack.org/97/62897/10/check/gate-glance-python27/ca5bbb1 : SUCCESS in 12m 08s\n- check-tempest-dsvm-full http://logs.openstack.org/97/62897/10/check/check-tempest-dsvm-full/1edb236 : SUCCESS in 41m 37s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/62897/10/check/check-tempest-dsvm-postgres-full/2fa414e : SUCCESS in 37m 20s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/62897/10/check/check-tempest-dsvm-neutron/a830244 : SUCCESS in 37m 25s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/62897/10/check/gate-tempest-dsvm-large-ops/6e09911 : SUCCESS in 15m 09s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/62897/10/check/gate-tempest-dsvm-neutron-large-ops/fd67f75 : SUCCESS in 15m 08s\n- check-grenade-dsvm http://logs.openstack.org/97/62897/10/check/check-grenade-dsvm/12e0375 : SUCCESS in 34m 30s\n","accounts_in_message":[],"_revision_number":10},{"id":"c0be744d9d9c92b61b833a0a0f5956f610c94f19","author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"date":"2013-12-19 20:59:44.000000000","message":"Patch Set 10: Looks good to me (core reviewer)\n\nThanks for the excellent job.","accounts_in_message":[],"_revision_number":10},{"id":"99a5c93f94510521facf8df87077370da67eb995","author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"date":"2013-12-19 23:33:40.000000000","message":"Patch Set 10: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":10},{"id":"347d1172445830480717fceb40b8687ee3cbdc4a","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2013-12-20 04:19:38.000000000","message":"Patch Set 10: Looks good to me (core reviewer)\n\n@flaper87, I have one little question:\n\nwhere we can tell end user, the images which under pending-deleted status will not be limited by quota, i think it will be better to tell user this situation/design in the official document since from end user\u0027s POV the image storage space usage can exceed they configured quota value temporarily, IMO  it\u0027s confuse if we not explain that.\n\ndo you think adding docImpact tag to commit message is a good choice?","accounts_in_message":[],"_revision_number":10},{"id":"9193af5c9c04767b6ef2391ec72fd3b1e8d2a00e","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-20 09:35:50.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"197d1878343a8c073268bc585291bc8808806110","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-12-20 09:35:58.000000000","message":"Patch Set 11:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":11},{"id":"6821c8e8d7ee03de7af043bbc8f2309191e1581e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 10:32:04.000000000","message":"Patch Set 11: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-glance-pep8 http://logs.openstack.org/97/62897/11/check/gate-glance-pep8/4429619 : SUCCESS in 2m 01s\n- gate-glance-docs http://docs-draft.openstack.org/97/62897/11/check/gate-glance-docs/9a21342/doc/build/html/ : SUCCESS in 2m 12s\n- gate-glance-python26 http://logs.openstack.org/97/62897/11/check/gate-glance-python26/3cbaf26 : SUCCESS in 11m 49s\n- gate-glance-python27 http://logs.openstack.org/97/62897/11/check/gate-glance-python27/97322d4 : SUCCESS in 14m 52s\n- check-tempest-dsvm-full http://logs.openstack.org/97/62897/11/check/check-tempest-dsvm-full/0af86ef : SUCCESS in 39m 53s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/62897/11/check/check-tempest-dsvm-postgres-full/33e08da : SUCCESS in 55m 58s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/62897/11/check/check-tempest-dsvm-neutron/a6b8172 : FAILURE in 39m 23s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/62897/11/check/gate-tempest-dsvm-large-ops/2d1b656 : SUCCESS in 14m 14s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/62897/11/check/gate-tempest-dsvm-neutron-large-ops/2605598 : FAILURE in 10m 33s\n- check-grenade-dsvm http://logs.openstack.org/97/62897/11/check/check-grenade-dsvm/9d716b9 : SUCCESS in 31m 59s\n","accounts_in_message":[],"_revision_number":11},{"id":"f9853b708e3da559ac640a288c0ef3b0a92c68a5","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-12-20 10:32:21.000000000","message":"Patch Set 11:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1262906\n- https://bugs.launchpad.net/bugs/1253896\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1262906\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1262906","accounts_in_message":[],"_revision_number":11},{"id":"3ac5d64e4f4530c0476dd54f3b59cc89a0183ac7","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-20 12:40:22.000000000","message":"Patch Set 11:\n\nrecheck bug 1262906","accounts_in_message":[],"_revision_number":11},{"id":"72f84928ae50fa95c7cec07f31e7c78ce47291f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 13:23:03.000000000","message":"Patch Set 11:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-glance-pep8 http://logs.openstack.org/97/62897/11/check/gate-glance-pep8/7c1ae4f : SUCCESS in 1m 53s\n- gate-glance-docs http://docs-draft.openstack.org/97/62897/11/check/gate-glance-docs/8b5f226/doc/build/html/ : SUCCESS in 2m 22s\n- gate-glance-python26 http://logs.openstack.org/97/62897/11/check/gate-glance-python26/461ef20 : SUCCESS in 19m 18s\n- gate-glance-python27 http://logs.openstack.org/97/62897/11/check/gate-glance-python27/9021ff5 : SUCCESS in 11m 43s\n- check-tempest-dsvm-full http://logs.openstack.org/97/62897/11/check/check-tempest-dsvm-full/c01e6a1 : SUCCESS in 38m 33s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/62897/11/check/check-tempest-dsvm-postgres-full/20bc9ea : SUCCESS in 37m 13s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/62897/11/check/check-tempest-dsvm-neutron/505556b : FAILURE in 42m 31s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/62897/11/check/gate-tempest-dsvm-large-ops/d75bd40 : SUCCESS in 13m 58s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/62897/11/check/gate-tempest-dsvm-neutron-large-ops/ab465d3 : FAILURE in 11m 26s\n- check-grenade-dsvm http://logs.openstack.org/97/62897/11/check/check-grenade-dsvm/0176054 : SUCCESS in 32m 10s\n","accounts_in_message":[],"_revision_number":11},{"id":"87be73b79567ae18110ad6b96b29421dcec27a73","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-12-20 13:23:24.000000000","message":"Patch Set 11:\n\nI noticed tempest failed, I think you hit bug(s):\n\n- https://bugs.launchpad.net/bugs/1262906\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1262906\n\nFor a code review which has been approved but failed to merge,\nyou can reverify by leaving a comment like this:\n\n    reverify bug 1262906","accounts_in_message":[],"_revision_number":11},{"id":"ae1486632775d99fe1df2bb5e2925fe1e2ce3c2c","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2013-12-20 14:50:38.000000000","message":"Patch Set 11:\n\nrecheck bug 1262906","accounts_in_message":[],"_revision_number":11},{"id":"f14f9f13a331c07e2ba05b4fa81b7e273897d53e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 15:28:19.000000000","message":"Patch Set 11: Works for me\n\nBuild succeeded.\n\n- gate-glance-pep8 http://logs.openstack.org/97/62897/11/check/gate-glance-pep8/92634a8 : SUCCESS in 1m 56s\n- gate-glance-docs http://docs-draft.openstack.org/97/62897/11/check/gate-glance-docs/93781ef/doc/build/html/ : SUCCESS in 1m 51s\n- gate-glance-python26 http://logs.openstack.org/97/62897/11/check/gate-glance-python26/996c1b9 : SUCCESS in 11m 59s\n- gate-glance-python27 http://logs.openstack.org/97/62897/11/check/gate-glance-python27/b62be1d : SUCCESS in 11m 35s\n- check-tempest-dsvm-full http://logs.openstack.org/97/62897/11/check/check-tempest-dsvm-full/349b409 : SUCCESS in 36m 46s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/97/62897/11/check/check-tempest-dsvm-postgres-full/5eba796 : SUCCESS in 37m 31s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/62897/11/check/check-tempest-dsvm-neutron/a6735f5 : SUCCESS in 33m 16s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/62897/11/check/gate-tempest-dsvm-large-ops/154685d : SUCCESS in 14m 28s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/62897/11/check/gate-tempest-dsvm-neutron-large-ops/ca2f552 : SUCCESS in 14m 58s\n- check-grenade-dsvm http://logs.openstack.org/97/62897/11/check/check-grenade-dsvm/b1f5b3d : SUCCESS in 36m 48s\n","accounts_in_message":[],"_revision_number":11},{"id":"58645646df5f4d7e36993b8f9b60f15f2e69c96b","author":{"_account_id":8759,"name":"Arnaud Legendre","email":"arnaudleg@gmail.com","username":"arnaud"},"date":"2013-12-20 16:02:59.000000000","message":"Patch Set 11: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":11},{"id":"669c925963759bb5623716c42e4c681016b01cbb","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2013-12-20 16:03:45.000000000","message":"Patch Set 11: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":11},{"id":"62efe922bf8b3a4e0c8eeff9cb118d9e43885e19","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2013-12-20 16:04:24.000000000","message":"Patch Set 11: Approved\n\n","accounts_in_message":[],"_revision_number":11},{"id":"923c085970a39fba9520638ff0ee594d11b50e23","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 16:04:25.000000000","message":"Patch Set 11: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":11},{"id":"8ef946086276b15e267b8b09d97e145358d3a83f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 17:01:46.000000000","message":"Patch Set 11: Verified\n\nBuild succeeded.\n\n- gate-glance-docs http://docs-draft.openstack.org/97/62897/11/gate/gate-glance-docs/0351950/doc/build/html/ : SUCCESS in 2m 00s\n- gate-glance-pep8 http://logs.openstack.org/97/62897/11/gate/gate-glance-pep8/ef383b9 : SUCCESS in 1m 53s\n- gate-glance-python26 http://logs.openstack.org/97/62897/11/gate/gate-glance-python26/93984db : SUCCESS in 14m 04s\n- gate-glance-python27 http://logs.openstack.org/97/62897/11/gate/gate-glance-python27/9f54a6a : SUCCESS in 12m 21s\n- gate-tempest-dsvm-full http://logs.openstack.org/97/62897/11/gate/gate-tempest-dsvm-full/13d14e2 : SUCCESS in 42m 31s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/97/62897/11/gate/gate-tempest-dsvm-postgres-full/894844e : SUCCESS in 38m 30s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/97/62897/11/gate/gate-tempest-dsvm-neutron/44b8c1c : SUCCESS in 42m 59s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/97/62897/11/gate/gate-tempest-dsvm-large-ops/80f2c62 : SUCCESS in 13m 17s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/97/62897/11/gate/gate-tempest-dsvm-neutron-large-ops/0d3a4d5 : SUCCESS in 15m 07s\n- gate-grenade-dsvm http://logs.openstack.org/97/62897/11/gate/gate-grenade-dsvm/e94f461 : SUCCESS in 26m 54s\n","accounts_in_message":[],"_revision_number":11},{"id":"3f8565443ddc0e56660d51790a601d9a73304dc8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-20 17:01:47.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":11},{"id":"e2b9f9644ec2abea6206735650925a369a0f50bb","author":{"_account_id":9209,"name":"Lin Cai","email":"reachlin@gmail.com","username":"reachlin"},"date":"2014-01-08 03:02:23.000000000","message":"Patch Set 11: (1 inline comment)\n\nHaving a question","accounts_in_message":[],"_revision_number":11}],"current_revision_number":11,"current_revision":"b35728019e0eb89c213eed7bc35a1f062c99dcca","revisions":{"e44f56a21fba2b3efa236d9e54c8e81528cc523c":{"kind":"REWORK","_number":1,"created":"2013-12-18 14:29:29.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/1"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted images from the\ndatabase if we\u0027re actually not considering them as valid images.\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/e44f56a21fba2b3efa236d9e54c8e81528cc523c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/e44f56a21fba2b3efa236d9e54c8e81528cc523c"}]},"branch":"refs/heads/master"},"99ea51bf8d2acf7ddafc9b31c727d495e9d1d8d3":{"kind":"REWORK","_number":2,"created":"2013-12-18 14:53:58.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/2"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:53:48.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted images from the\ndatabase if we\u0027re actually not considering them as valid images.\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/99ea51bf8d2acf7ddafc9b31c727d495e9d1d8d3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/99ea51bf8d2acf7ddafc9b31c727d495e9d1d8d3"}]},"branch":"refs/heads/master"},"5b79aa92aa32aab53ae197876c611e0af021e817":{"kind":"REWORK","_number":3,"created":"2013-12-18 16:43:57.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/3"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 16:43:47.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted images from the\ndatabase if we\u0027re actually not considering them as valid images.\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/5b79aa92aa32aab53ae197876c611e0af021e817"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/5b79aa92aa32aab53ae197876c611e0af021e817"}]},"branch":"refs/heads/master"},"d2fd4862d111872992230968b80684f6838b80ff":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2013-12-18 16:50:22.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/4"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 16:49:21.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted / killed /\npending-deleted images from the database if we\u0027re actually not\nconsidering them as valid images.\n\nThe patch also filters out deleted locations.\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/d2fd4862d111872992230968b80684f6838b80ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/d2fd4862d111872992230968b80684f6838b80ff"}]},"branch":"refs/heads/master"},"2ec354e4d710ec8f393c1c19e2e74e9ae6508f50":{"kind":"REWORK","_number":5,"created":"2013-12-19 09:01:29.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/5"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-19 09:01:10.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted / killed /\npending-deleted images from the database if we\u0027re actually not\nconsidering them as valid images.\n\nThe patch also filters out deleted locations.\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2ec354e4d710ec8f393c1c19e2e74e9ae6508f50"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/2ec354e4d710ec8f393c1c19e2e74e9ae6508f50"}]},"branch":"refs/heads/master"},"9f5a33c907e2f4adb0f0ae4bcefe975f36d627e3":{"kind":"REWORK","_number":6,"created":"2013-12-19 09:08:01.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/6"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-19 09:07:51.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted / killed /\npending-deleted images from the database if we\u0027re actually not\nconsidering them as valid images.\n\nThe patch also filters out deleted locations.\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9f5a33c907e2f4adb0f0ae4bcefe975f36d627e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9f5a33c907e2f4adb0f0ae4bcefe975f36d627e3"}]},"branch":"refs/heads/master"},"947a657d0b5226ce293cc3e32135ab909559a843":{"kind":"REWORK","_number":7,"created":"2013-12-19 11:29:15.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/7"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-19 11:29:04.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted / killed /\npending-deleted images from the database if we\u0027re actually not\nconsidering them as valid images.\n\nThe patch also filters out deleted locations.\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/947a657d0b5226ce293cc3e32135ab909559a843"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/947a657d0b5226ce293cc3e32135ab909559a843"}]},"branch":"refs/heads/master"},"aad79f78719edaf4624d16108024808f9a0d82a4":{"kind":"NO_CODE_CHANGE","_number":8,"created":"2013-12-19 16:07:11.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/8"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-19 15:48:17.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted / killed /\npending-deleted images from the database if we\u0027re actually not\nconsidering them as valid images.\n\nThe patch also filters out deleted locations.\n\nNOTE: In the case of locations, it was not possible to add a test for\nthe deleted locations because it requires some changes that are not\nworth in this patch. In order to mark a location as deleted, it\u0027s\nnecessary to go through the API and use a PATCH operation. Since this is\na database test, it doesn\u0027t make much sense to add API calls to it.\nCalling the image_destroy function with an empty location list will\nremove all the locations which won\u0027t help testing that specific case.\n\nI\u0027ll work on a better solution for that in a follow-up patch.\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/aad79f78719edaf4624d16108024808f9a0d82a4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/aad79f78719edaf4624d16108024808f9a0d82a4"}]},"branch":"refs/heads/master"},"9f23c262a50e7d3524fba96c8a7f14b46a7a46a2":{"kind":"NO_CODE_CHANGE","_number":9,"created":"2013-12-19 16:39:57.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/9"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-19 16:39:31.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted / killed / images\nfrom the database if we\u0027re actually not considering them as valid\nimages.\n\nThe patch also filters out deleted locations.\n\nNOTE: In the case of locations, it was not possible to add a test for\nthe deleted locations because it requires some changes that are not\nworth in this patch. In order to mark a location as deleted, it\u0027s\nnecessary to go through the API and use a PATCH operation. Since this is\na database test, it doesn\u0027t make much sense to add API calls to it.\nCalling the image_destroy function with an empty location list will\nremove all the locations which won\u0027t help testing that specific case.\n\nI\u0027ll work on a better solution for that in a follow-up patch.\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9f23c262a50e7d3524fba96c8a7f14b46a7a46a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9f23c262a50e7d3524fba96c8a7f14b46a7a46a2"}]},"branch":"refs/heads/master"},"fe377e60dd47ad4cf395427fc3db30ff7628c17f":{"kind":"REWORK","_number":10,"created":"2013-12-19 17:29:14.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/10"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-19 17:28:37.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted / killed /\npending_delete images from the database if we\u0027re actually not\nconsidering them as valid images.\n\nThe patch also filters out deleted locations.\n\nNOTE: In the case of locations, it was not possible to add a test for\nthe deleted locations because it requires some changes that are not\nworth in this patch. In order to mark a location as deleted, it\u0027s\nnecessary to go through the API and use a PATCH operation. Since this is\na database test, it doesn\u0027t make much sense to add API calls to it.\nCalling the image_destroy function with an empty location list will\nremove all the locations which won\u0027t help testing that specific case.\n\nI\u0027ll work on a better solution for that in a follow-up patch.\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/fe377e60dd47ad4cf395427fc3db30ff7628c17f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/fe377e60dd47ad4cf395427fc3db30ff7628c17f"}]},"branch":"refs/heads/master"},"b35728019e0eb89c213eed7bc35a1f062c99dcca":{"kind":"NO_CODE_CHANGE","_number":11,"created":"2013-12-20 09:35:50.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/97/62897/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/glance","ref":"refs/changes/97/62897/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/glance refs/changes/97/62897/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/glance refs/changes/97/62897/11"}}},"commit":{"parents":[{"commit":"9ff915a262c1eb80a2b938ee20b3d72b51f80365","subject":"Merge \"Return 204 when image data does not exist\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/9ff915a262c1eb80a2b938ee20b3d72b51f80365"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-18 14:18:17.000000000","tz":60},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2013-12-20 09:35:24.000000000","tz":60},"subject":"Filter out deleted images from storage usage","message":"Filter out deleted images from storage usage\n\nAll database API\u0027s currently include deleted images in the calc of\nstorage usage. This is not an issue when deleted images don\u0027t have\nlocations. However, there are cases where a deleted image has deleted\nlocations as well and that causes the current algorithm to count those\nlocations as if they were allocating space.\n\nBesides this bug, it makes sense to not load deleted / killed /\npending_delete images from the database if we\u0027re actually not\nconsidering them as valid images.\n\nThe patch also filters out deleted locations.\n\nNOTE: In the case of locations, it was not possible to add a test for\nthe deleted locations because it requires some changes that are not\nworth in this patch. In order to mark a location as deleted, it\u0027s\nnecessary to go through the API and use a PATCH operation. Since this is\na database test, it doesn\u0027t make much sense to add API calls to it.\nCalling the image_destroy function with an empty location list will\nremove all the locations which won\u0027t help testing that specific case.\n\nI\u0027ll work on a better solution for that in a follow-up patch.\n\nDocImpact\n\nChange-Id: I82f08a8f522c81541e4f77597c2ba0aeb68556ce\nCloses-Bug: #1261738\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b35728019e0eb89c213eed7bc35a1f062c99dcca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/glance/commit/b35728019e0eb89c213eed7bc35a1f062c99dcca"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}