)]}'
{"glance/tests/__init__.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"92275a21b2f964432cbbf429ac820e7950467adc","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":"# NOTE(jokke): As per the eventlet commit"},{"line_number":19,"context_line":"# b756447bab51046dfc6f1e0e299cc997ab343701 there\u0027s circular import happening"},{"line_number":20,"context_line":"# which can be solved making sure the hubs are properly and fully imported"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_dc35d047","line":17,"updated":"2019-03-12 17:01:28.000000000","message":"NIT: We really should follow the Imports guidelines from https://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"968a0b7949d041983ec01bffc9c9a45ed80d01c5"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"2d38ba230eb1b31e99fd2b6d8d3391cb8f36cb7a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":"# NOTE(jokke): As per the eventlet commit"},{"line_number":19,"context_line":"# b756447bab51046dfc6f1e0e299cc997ab343701 there\u0027s circular import happening"},{"line_number":20,"context_line":"# which can be solved making sure the hubs are properly and fully imported"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_7e1fc2b6","line":17,"in_reply_to":"5fc1f717_dc35d047","updated":"2019-03-13 12:19:02.000000000","message":"Right, the os module is builtin so it should be separate. Thanks for pointing it out, I missed that.\n\nThere used to be a flake8 check for that.","commit_id":"968a0b7949d041983ec01bffc9c9a45ed80d01c5"}]}